SRL Archive - SRL Bugs

I'm not entirely sure how this happened or how it could be reproduced.

I was running a SMART based script when I saw it type my username and password into main chat. As far as I can tell, it was trying to log into the game for some reason. The script report suggests something similar.

Script runtime: 0h 34min
Welcome to Runescape.
(my username was here)
One minute has passed…
NextPlayer

Part of this may have been my fault. I did mess with the SMART window a bit, and I may have thrown something off. I'm not sure what would cause such an issue though.

I think the check for logging in should be more robust to avoid potential disasters like this. If I didn't spot this, I may well have lost a high level account to a bank of people.

actually the same exact thing happened to me the other day. :( i was using a script i made in Simba though. maybe the detection of the logged in char should be updated? i wonder if others have faced this issue.

Hmm yeah, minimizing/unminimzing of the SMART screen makes runescpae flash black/white for a second or something, and may have resulted in a false positive of the login screen.

Hmm, SRL has:

{*******************************************************************************
function RSReady: Boolean;
By: ZephyrsFury
Description: Returns true if we are ready to auto (on loginscreen or logged in).
  Useful for waiting until RS has fully loaded.
*******************************************************************************}

function RSReady: Boolean;
begin
  Result := (LoggedIn) or (GetColor(749, 492) = 65536); //settings thingy button
end;

The function list at the top however has:

// * function AtLobbyScreen: Boolean;                                       // * by Dgby714

But the function doesn't appear anywhere in Login.Scar
What's going on there?

Meh, so it seems LoggedIn is not entirely reliable if you can't always count on the RS screen being available.

I think the login routines should have more robust checking for the login form before they go entering passwords. In usual script logic, it's not the end of the world if a script thinks you logged out when you didn't. The only exception seems to be with regard to logging in.

Btw, what's the proper usage of SMART, then? Is it safe to minimize? Obscure behind another window? Move out of the screen?

From: ForgotMyName
Meh, so it seems LoggedIn is not entirely reliable if you can't always count on the RS screen being available.

I think the login routines should have more robust checking for the login form before they go entering passwords. In usual script logic, it's not the end of the world if a script thinks you logged out when you didn't. The only exception seems to be with regard to logging in.

Btw, what's the proper usage of SMART, then? Is it safe to minimize? Obscure behind another window? Move out of the screen?

You can do whatever the hell you want with it as long as the button on the bottom left is enabled :p

All LoggedIn checks for is a white pixel, clWhite… it's a pretty common color. Seems to be all over the place actually… a blank white screen would make LoggedIn result true. It's a pretty old function tbh. I started using a custom LoggedIn2 in my scripts because I used to have a lot of trouble with smart, but after I uninstalled Desktop Earth my smart screen stopped going white.

If you ever have any problems with SMART, then you shouldn't try and multitask when using it. Leave it open and idle from your computer.

In the small chance that this is some sort of bug that is susceptible from other SRL code in loginplayer or something, I'll look into but I highly doubt it as LoginPlayer would not of come up in the script unless something else went wrong.

It could have been that when the username, password screen was there and SRL was about to type, you disabled it and logged on yourself. When you enabled SMART SRL continued where it left off- typing the username and password.

Also this is not really a disaster. You can't say your password in-game ;) It comes as ****** or you get message telling 'you typed your password bla bla bla'….Can't remember…

This is the same error I've been having. I've reinstalled the whole SCAR directory, the whole SRL open-dev, and moved plugins afresh, and still getting the same problem.

I'm sitting in an airplane terminal about leave to go nearly half way around the world for the next week. If everything goes well ill have internet in about a day from now.

I wouldn't be too surprised if there was a bug with srl because of the interface, maybe someone could go in and find/fix the problem?

From: FEAR
Also this is not really a disaster. You can't say your password in-game ;) It comes as ****** or you get message telling 'you typed your password bla bla bla'….Can't remember…

Did they really implement that feature? I seem to remember this claim being a common scam a few years back.

From: ForgotMyName
Did they really implement that feature? I seem to remember this claim being a common scam a few years back.

Yea they did, one of the more amusing things they've done.

I've now realized that in addition to the bug discussed here, SRL is also unable to log out for me.

It will click the logout tab, but will not click the logout button.

There is no failsafe for verifying that the logout process succeeded, so my scripts will continue on running as if they had changed players and logged back in.

FYI, this bug is due to the signed and unsigned clients having different buttons and screens during login and logout.

This bug makes it so that if you login on an unsigned client, it hangs for 1 minute to wait for the lobby screen to appear, but the unsigned client has no lobby screen. Then once logged in it is unable to logout, because the logout button has different text on an unsigned client and isn't detected.

This bug has been around for over a month now and needs to be fixed. It's a major bug for any script that uses an unsigned client.

Also, the login/logout from 1+ month old revisions still work for the unsigned client, so the old code just needs to be incorporated into the new login/logout procedures.