SRL Archive - RS3 Outdated / Broken Scripts

• 1. Stand at Draynor Bank, Face North.
• 2. Have plenty raw materials visible at Upper Bank.
• 3. Make sure you enable WithDraw 14 (Choose Option and manually type 14 BEFORE runnin g this script.
• Fill in the Constants at LIne 144 (See Below)

const
    TheHerb         = 'irit'; // guam / harralander / ranarr / avantoe / kwuarm / irit
    CleanTheHerb    = True;
    MakeTheUnf      = True;
    MakeThePot      = True;
    DecantAllPots   = True;

-= TheHerb =-
Choose between: 'guam','harralander','ranarr','avantoe','kwuarm','irit'

-= CleanTheHerb =-
Choose Between True: Cleans Grimies.
False: Uses Clean Herbs and does not clean Grimies.

-= MakeTheUnf =-
Choose Between True: Makes Unfinished Potions.
False: Does not Make unfinished Potions.

-= MakeThePot =-
Choose Between True: Makes (3) Potions.
False: Does not Make Makes (3) Potions.

-= DecantAllPots =-
Choose Between True: Makes (4) Potions from (3) Potions.
False: Does not Make Makes (4) Potions from (3) Potions.




1. CLEAN GRIMY GUAM HERBS

TheHerb = 'guam';
CleanTheHerb = True;
MakeTheUnf = False;
MakeThePot = False;
DecantAllPots = False;

2. CLEAN GRIMY HARRALANDER HERBS AND MAKE HARRALANDER UNFS

TheHerb = 'harralander';
CleanTheHerb = True;
MakeTheUnf = True;
MakeThePot = False;
DecantAllPots = False;

3. USE CLEAN RANARR HERBS AND MAKE RANARR UNFS

TheHerb = 'ranarr';
CleanTheHerb = False;
MakeTheUnf = True;
MakeThePot = False;
DecantAllPots = False;

4. CLEAN GRIMY AVANTOE HERBS AND MAKE SUPER ENERGY(3)POTS

TheHerb = 'avantoe';
CleanTheHerb = True;
MakeTheUnf = True;
MakeThePot = True;
DecantAllPots = False;

5. USE CLEAN KWUARM HERBS AND MAKE SUPER STRENGTH(4)POTS

TheHerb = 'kwuarm';
CleanTheHerb = False;
MakeTheUnf = True;
MakeThePot = True;
DecantAllPots = True;

6. CLEAN GRIMY RANARR HERBS AND MAKE PRAYER(4)POTS

TheHerb = 'ranarr';
CleanTheHerb = True;
MakeTheUnf = True;
MakeThePot = True;
DecantAllPots = True;

7. DECANT SUPER ATTACK(3)POTS TO SUPER ATTACK(4)POTS

TheHerb = 'irit';
CleanTheHerb = False;
MakeTheUnf = False;
MakeThePot = False;
DecantAllPots = True;



HERR Blore tries to perform humanlike. So it wont bank in between making potions by withdrawing 14 instead of 28. It banks usually flawless. Needs to bank flawless too, since you bank approx 80 times per hour. You can start with the Bank open for your convienience. I did that because it was convienent for me…with all the different types of herbs, ingredients and potions.

The mainloop is far from ideal nor intelligent…I know. It was the only way I could fit in all these different combinations in one mainloop..erm. If anyone can do better…please do!

This script leans totally on bitmaps. If our beloved company desides to change its bitmaps…so should I (you).

You can use this script to boost your Herblore form level-1 upwards to leve-70 with a minimum loss. Profit can go up to 800k Per hour making unf pots…Buy and sell wisely!

Feel free to use, adjust, simplify, or elaborate my code. Do not forget to credit me properly :)

Released to the public at 06032010

Credits: The SRL Team!

Win.


I'm going to try and get some proggys. I'm excited. Does this run on SIMBA?

are you going to update it with more herbs/ pots? :D

like up to super restores or something..

im deffidently going to be using this once the prices for herb supplies goes down :)

var
    GrimyH, CleanH, UnfPot, SecondIngredient, The3Pot,
    GrimyGuam, CleanGuam, GrimyHarra, CleanHarra, GrimyIrit, CleanIrit,
    GrimyAvantoe, CleanAvantoe,  GrimyKwuarm, CleanKwuarm, GrimyRanarr, CleanRanarr,
    UnfGuam, UnfHarra, UnfAvantoe, UnfKwuarm, UnfIrit, UnfRanarr,
    EyeofNewt, ChocoDust, SnapeGrass, MortMyreFungus, LimpwurtRoot,
    VialMask, VialOfWater,  LeafMask, Runs,
    Attack3, Prayer3, Energy3, SuperAttack3, SuperEnergy3, SuperStrength3 : Integer;
    CleanXP, PotXP, TotalCleanXP, TotalPotXP: Extended;

How about using a Type Record for this, like the Player record? ;)

Also, for the mainloop, you could just have

if CleanTheHerb then
  Grimy2Clean(GrimyH, True);

if MakeTheUnf then
  Clean2Unf(CleanH, True);

if MakeThePot then
  MakePotion(UnfPot, SecondIngredient, True);

if DecantAllPots then
  Decant;

It'll do it step by step, and you can get rid of the functions that cover more than one step…. unless is makes it less efficient (dunno).

~RM

Haha I know about that. Too lazy to implement. This kinda evolves around a simple idea and then grows. But you are right I guess. Sloppy me :)

And there is logic behind the mainloop: For instance: if you just want to clean herbs you need to withdraw 28, but unfs you need to withdraw 14. And there are more problems underway. I thought it wise to solve it in a manner I understand.

Manually stopped it.

<============== - Progress Report ===============>
Time Running 1 Hours, 44 Minutes and 50 Seconds
121 Runs.
Cleaned 1694 ranarrs
Clean XP 12705
Pot XP 0
Total XP 12705
Unfinished 1694 Potions
Made 0 Potions
Decanted 0 Potions
Óut of Suplies

From: Awkwardsaw
are you going to update it with more herbs/ pots? :D

like up to super restores or something..

im deffidently going to be using this once the prices for herb supplies goes down :)

Sure. That is Snapdragon and Spider Eggs? No problem.

Arghh just ran out of members, I would love to try this.

Psst, Instead of doing 'ChooseOption('Withdraw-14'); (or whatever you are doing) do

if not ChooseOption('14') then
begin
  ChooseOption('X');
  SendKeys('14');
end;

<============== - Progress Report ===============>
Time Running 18 Minutes and 26 Seconds
20 Runs.
Cleaned 280 harralanders
Clean XP 1764
Pot XP 0
Total XP 1764
Unfinished 280 Potions
Made 0 Potions
Decanted 0 Potions
bitmap o NOT found
bitmap o found
UseQuickly returded True
Out of Vials
Successfully executed

It had cleaned herbs in the inventory with vials of water. So maybe the BMP failed?

Nice handling of the 4 variables and the combinations, reminds me of my kyab LSD (Lumby Swamp Dinosaur) :p
Will (ab)use after 94 mage, ~2 days from now

nice, I'll test this when I get a chance, all herbs are dropping right now except guam, so it's a good time to stock up, most will probably buy for min.

Going to look for which I can make the most profit with then buy a bunch to test out your script :) expect an edit by hopefully tomorrow with a proggy.

Boost your Herblore form level-1 to level-70 with profit!

Sounds great :D, definitely gonna use this.

Its on my things to do list.

Nice. Will use. :3

Will use on the bonus XP weekend! :) I've been gathering herbs from GD and Chaos druids, going to make ~400 pots.

Just made me 165k Herblore XP in 4 hours making Prayer(4) Pots from grimy ranarrs leftover in two runs. Cost me 27.4 Mil, made me 27.8 Mil. Far into Herb Level 60's now with a couple of Players.



<============== - Progress Report ===============>
Time Running 1 Hours, 43 Minutes and 17 Seconds
121 Runs.
Cleaned 1694 ranarrs
Clean XP 12705
Pot XP 0
Total XP 12705
Unfinished 1694 Potions
Made 0 Potions
Decanted 0 Potions
Successfully executed



<============== - Progress Report ===============>
Time Running 2 Hours, 2 Minutes and 10 Seconds
128 Runs.
Cleaned 0 ranarrs
Clean XP 0
Pot XP 153300
Total XP 153300
Unfinished 0 Potions
Made 1778 Potions
Decanted 1143 Potions
Out of Vials
Successfully executed

Wow WT-Fakawi that's some very fast herb experience ! I really would use this to but I was to late with the preparations. So I spent the 10 hours on some different skills :(

From: Matsetst
Wow WT-Fakawi that's some very fast herb experience ! I really would use this to but I was to late with the preparations. So I spent the 10 hours on some different skills :(

erm… that's done without the Bonus XP :)

Hi Fakawi, running the script in SD etc, it starts well and opens the bank but the the curser moves over to my inventory and just hovers there, its doesnt attempt to withdraw ( im cleaning herbs), just wondering if im doing something wrong on my end.
Using Scar 3.22 Thanks!

No,… all you need to do is make sure you enable withdraw 14 once, before running the script. So manually do Withdraw-X and type 14. Now 14 is enabled.

I know, I know….. I could have done this more intelligent, just wanted to release something that works…erm…. flawless :)

Yeah i did that but still…. it hovers where the INV tab would be next to skills tab etc maybe the colour of the tab is confusing it?

hmmmm, you sure you setup the right vars and the right names?

From: GREEN GIANT
Hi Fakawi, running the script in SD etc, it starts well and opens the bank but the the curser moves over to my inventory and just hovers there, its doesnt attempt to withdraw ( im cleaning herbs), just wondering if im doing something wrong on my end.
Using Scar 3.22 Thanks!

Use scar 3.23 (you'll need to download it from it's svn) as scar 3.22 does not detect Uptext properly.

~RM

From: WT-Fakawi
hmmmm, you sure you setup the right vars and the right names?

Well the default already had irit put in so i left it, all i did was edit the true/false statements.

I tried dowloading Scar 3.23 but now i get parameter problems, something to do with sandwhich lady?

So with 3.22 it ran but didnt do as it was meant to, with 3.23 it didnt work atall and i got allsorts of perimeter exceptions etc

I downloaded the includes and srl files so i cant see whats wrong?

Thanks

From: GREEN GIANT
Well the default alreasy had irit put in so i left it, all i did was edit the true/false statements.

I tried dowloading Scar 3.23 but now i get parameter problems, something to do with sandwhich lady?

thanks for your help

Update your SRL to the Open Dev revision and move your plugins.

http://villavu.com/forum/showthread.php?t=47714

From: NCDS
Update your SRL to the Open Dev revision and move your plugins.

http://villavu.com/forum/showthread.php?t=47714

Hello again, did as above and it works!! well…..for the cleaning atleast :( When i try to make it do the unfinished potions i get the following:

[Runtime Error] : Exception: Can't allocate the DIB handle in line 540 in script C:\Users\Administrator\Desktop\scarprerelease\includes\SRL\SRL\Core\Text.scar

I tried updating the SRL again just incase but that didnt work..

Thanks again x

Ahhhhh its ok i think it was a problem on my behalf because after i reopened the script it worked fine, mut of changed some script by accident.
Thanks again guys you'v been a great help! :)

Hmmm another problem im afraid, when making potions the script fails to bank the finished potion and withdraws the herbs again, as there is no room to withdraw the vials it assumes there is none and stops the script as if it has finished.
Anyone else had that happen?

Edit: It works if decant is true, but doesnt work if decant is false.

Where can i download scar 3.23?

From: NCDS
Update your SRL to the Open Dev revision and move your plugins.

http://villavu.com/forum/showthread.php?t=47714

Follow that link if you want the latest Scar, and the instuctions on how to properly install it :)

Hi again, been using the script to much success, it works great :)
I want to start making Lantadme potions now though, can any one point me in the right direction on how to edit the script to do this?

GREEN GIANT asked me how to expand Herr Blore.

Before we go: Two thing you must understand is: One. this script is entirely build around bitmaps. It was for me the easiest way to get it done. Two. My scripts are not known for their beauty. In fact I am a lazy coder. Once I set off, I seldomly enhance my code. But my scripts have something special: I observe them. For weeks I test and test and test, til I get it right. Usually once I release a script, it is worth it's value.

This is how it works:

1. I make screenshots and extract (crop) the bitmaps in Photoshop.



In Scar I make bitmaps using Picture To String… and name them. I do the same thing with Vials, second ingredients, Potions and unfinished potions. If you want to study their boundaries you can reverse engineer them in scar. Copy the bitmap part between the "" quotes and perform String To Picture…


2. I declare a lot of global variables, one for each bitmap I added to SetIngredients. Lazy, I know, should have been coded with a Type.

3. In my functions I do a lot of bitmap finding and counting. If you know a little bit of coding, you should be able to wade yourself through the logic. The functions are that poorly coded…it's fawki-style :)

4. My main loop is…and I must admit…the most horrible one I ever written. I have never been more goal oriented.

So how to adjust Herr Blore yourself.

1. Make bitmaps for

1. grimy and clean Lantadyme, (reverse engineer my bitmaps for grimy… and clean… and copy them)
2. the second ingredient
3. the unf pot
4. the finished potion(3).
5. the finished potion(4).

2. Declare them as globals.

4. Add to the function SetIngredients your own Case:

    'lantadyme':                                 // Attack Pots
        begin
            GrimyH  := yourGrimyLanta;
            CleanH  := yourCleanLanta;
            CleanXP := 2.5;
            PotXP   := 25;
            UnfPot  := yourUnfLanta;
            SecondIngredient := yourSecondIngredient;
            The3Pot := yourPot3;
        end;                                // Energy Pots

4. Done.

Thanks dude your a legend, ill have a good go at this and let you know how i get on :)

Works well. Herb prices seem to be dropping :/ and idk if i want to invest all my money in herbs only to find by the time i sell the potions i end up losing money.
<============== - Progress Report ===============>
Time Running 44 Minutes and 37 Seconds
54 Runs.
Cleaned 756 irits
Clean XP 13305.6
Pot XP 0
Total XP 13305.6
Unfinished 0 Potions
Made 0 Potions
Decanted 0 Potions
Óut of Suplies

GGGRRRR the annoyance….did as explained cropped lil images of both clean, grimy and unfpot and inputted them into script, but qhen i run the script it just says "out of supplies" is there a trick to getting a perfect lil picture?

EDIT :: SORTED!! Turns out my bitmaps had a little tiny piece of backround in them thus rendering them different :)
Thanks again FAKAWI!

From: nikos
Works well. Herb prices seem to be dropping :/ and idk if i want to invest all my money in herbs only to find by the time i sell the potions i end up losing money.
<============== - Progress Report ===============>
Time Running 44 Minutes and 37 Seconds
54 Runs.
Cleaned 756 irits
Clean XP 13305.6
Pot XP 0
Total XP 13305.6
Unfinished 0 Potions
Made 0 Potions
Decanted 0 Potions
Óut of Suplies

They are being dumped atm (merchanting clans are selling out, expect them to go down more)

Fakawi, the script does not deposit prayer potions(3) and continues to withdraw grimmy ranarr. (when CleanHerbs: true, MakeUnfs: true, MakePots: true, Decant: false )
I made MakePots: false and it ran fine but MakePots needs to deposit or check to see if it deposited.
EDIT: I believe it works if you decant the potions but idk why you would do that its not like you make more money. correct me if im wrong..

From: GREEN GIANT
Yeah i did that but still…. it hovers where the INV tab would be next to skills tab etc maybe the colour of the tab is confusing it?

Have the same problem when I trie to test it with Grimy Avantoes.

Difference to the quote is that I think I have the answer where the problem lies. I'm running Windows 7 64-bit.

As the noob that I am, is there a way to make scar run as 32-bit? I will look for it in google and edit this out if I find the answer.

I also ran into the issue of prayer potions not being deposited. It will continue to withdraw and clean ranarrs.

Well, I made an temporary fix for this.
Change line 942 to

Grimy2Unf(GrimyH, CleanH, True);

Is it intentional that it misses cleaning some herbs and goes back for them?

Are there any plans for supporting multiple seconds? (Harralander/Red spider eggs -> Restore potion is actually pretty decent exp.)

Hi sorry to bother you again :)
I made my own bitmaps for lantadymes that worked perfectly, so i decided to make my own for cadantine, but for some reason when im cleaning cadantines it will clean them then try to clean them a second time instead of just cleaning the ones it missed out :/
Its not because my bitmaps for clean and grimy are similar because iv chnaged both but still it will not work :(
Would it be possible for someone to maybe try it out an get back to me with your results?
Thanks

EDIT : If anyone is interested i fixed this problem by changing the tolerance of both grimy and clean cadantines to 15, works like a dream now :)

Yet another post by me :)
Newest problem is that the script constantly logs me out thinking i have ran out of supplies, when i have plenty in the bank. This is annoying as i like to leave the script to clean a few thousand herbs whilst i do other things, but somtimes return to find out it has cleaned 1 inv then logged me out.

Any chance someone can alter the script to take away the logging out procedure for running out of supplies?

Thanks

This script is awesome btw cleaned over 200k herbs so far :)

From: Cazabacca
Have the same problem when I trie to test it with Grimy Avantoes.

Difference to the quote is that I think I have the answer where the problem lies. I'm running Windows 7 64-bit.

As the noob that I am, is there a way to make scar run as 32-bit? I will look for it in google and edit this out if I find the answer.

BTW this problem only came out with grimy avantoes. Kwuarms etc work perfectly. The 64-bit was no problem at all.

@GREEN GIANT: Don't double post, just edit your last post instead. As for your problem, I have not had any problems with cleaning herbs.

Time Running 31 Minutes and 56 Seconds
35 Runs.
Cleaned 490 irits
Clean XP 4312
Pot XP 0
Total XP 4312
Unfinished 490 Potions
Made 0 Potions
Decanted 0 Potions
happy birthday!!!???

<============== - Progress Report ===============>
Time Running 2 Hours, 58 Minutes and 19 Seconds
138 Runs.
Cleaned 1932 harralanders
Clean XP 24343.2
Pot XP 0
Total XP 24343.2
Unfinished 0 Potions
Made 0 Potions
Decanted 0 Potions
Óut of Suplies
Successfully executed
———————————————–

Epic :D. Except it did 4000 harralanders, not 1932. Just noticed o.O.

EDIT: Another thing I noticed is when making the harralanders unf. pots, it always logged me out at 20 minutes (a few different times), saying it couldn't find any herbs. But there were herbs in my inventory and bank tab for it to use. Not sure exactly what it means but still kudos :)

EDIT:

Time Running 1 Hours, 17 Minutes and 42 Seconds
63 Runs.
Cleaned 882 avantoes
Clean XP 8820
Pot XP 0
Total XP 8820
Unfinished 882 Potions
Made 0 Potions
Decanted 0 Potions

Failed when compiling
Line 270: [Error] (15530:1): Invalid number of parameters in script C:\Users\tommo\Desktop\scarprerelease\includes\SRL\SRL\Core\AntiRandoms\Sandwich.scar


I get that, tried everything , can't get it to work.

tommo, you need to move your plugins.

I have. copied all files from place inside plugins folder, except the simba folder, to the plugins folder.

Well you're doing something wrong. :p

You need scar 3.23

^ ++.

Fakawi still plugging away ! Good to see :)

From: MylesMadness
You need scar 2.23

3.23*

tommo9999: Check Coh3n's tutorial on downloading scar :)

i tried changing the bitmaps for vial of water, clean ranarr, and unf ranarr, to make unf ranarrs w/ clean herbs but to no avail. also what is vialmask and leafmask? idk but maybe that is the problem.

From: blackelvis
i tried changing the bitmaps for vial of water, clean ranarr, and unf ranarr, to make unf ranarrs w/ clean herbs but to no avail. also what is vialmask and leafmask? idk but maybe that is the problem.

The masks are a set of black/white bitmaps that specify which pixels in an icon are considered important (i.e. used in comparisons) and which aren't. Since the icons themselves have changed shapes and not just color makeup, you'd need to update the masks too. In particular, I suspect you're now catching bits of the inventory background and missing bits of the herb/vial in question.

Have they changed the bitmaps already? Sure? Are you running safe mode and 32-bits color scheme?

yeah i know the vials are all changed and i am almost certain the herbs are, too. a lot of mats got changed in this update like logs etc. I'd be more than happy to get all the bitmaps or w/e you need, i just dont know how to put it all together it myself.

From: blackelvis
yeah i know the vials are all changed and i am almost certain the herbs are, too. a lot of mats got changed in this update like logs etc. I'd be more than happy to get all the bitmaps or w/e you need, i just dont know how to put it all together it myself.

Hmmm, last time they did that was loooong ago. Anyway; halfway down the first page of this thread I wrote a small tut how to make your own bitmaps. Shouldnt be to hard. Just make sure you dont take any outline (shadow) in the bitmap.

so i updated the bitmaps and it works, insofar as it can withdraw everything but when it tries to use a clean w/ a vial of water it chooses to use the vial instead of using the herb with the vial

From: blackelvis
so i updated the bitmaps and it works, insofar as it can withdraw everything but when it tries to use a clean w/ a vial of water it chooses to use the vial instead of using the herb with the vial

Read my post above about bitmap masks. You'll have to change all the inputs to the functions and not just some. Specifically, I think you need to replace the masks for leaves and vials. I think the core logic should still work fine, though.

i dont think i explained it correctly. The script can select the herb and then try to use it with the vial. But, recently, there's been added an option, which allows you to right click with an item selected for use, and instead of using your already selected item, select the second item for use on something entirely different. E.G. if i have a Clean Ranarr selected for use and right click a Vial of Water, I will be presented with the option to use the herb with the vial or to just 'use' the vial.

Oh sorry. I misunderstood at first.
You want it to select:
Use clean avantoe -> Vial of water
rather than
Use vial of water

First, I'm rather surprised it right clicks the second when it should do just as well left clicking it.

Right, so currently, around line 730, we have

If WeHave(CleanHerb, 'inv', x, y) then
begin
Mouse(x, y, 8, 8, False);
if not ChooseOption('Use') then
begin
end
end
else
Quit('Out of CleanHerb');

If WeHave(VialOfWater, 'inv', x, y) then
begin
Mouse(x, y, 8, 8, False);
if not ChooseOption('Use') then
begin
end
end
else
Quit('Out of Vials');

The first one is still fine. There's only one use option when you first select the herb. The second one is ambiguous. We ask it to click "Use" but don't specify which one.

My idea would be to make it go for the herb name, since that's unambiguously present in only one part of the menu. That will require a bit of work on your part to get it to change the name depending on which herb you're using.

Also, beware, you probably need to make this change for the other modes as well.

EDIT:

I did suggest you could apply a rough fix by making it left click the second item. I'm not entirely sure there aren't other consequences from that though. If Fawki made his script do right clicks, there may be a reason I didn't notice.

If WeHave(CleanHerb, 'inv', x, y) then
begin
Mouse(x, y, 8, 8, False);
if not ChooseOption('Use') then
begin
end
end
else
Quit('Out of CleanHerb');

If WeHave(VialOfWater, 'inv', x, y) then
begin
Mouse(x, y, 8, 8, False);
if not ChooseOption('anarr') then   <-------------
begin
end
end
else
Quit('Out of Vials'); 

thanks for the advice! this worked for making unf pots with clean ranarrs. same lines around 730 or w/e

The rightclicks are neccesary because many times left clicks fail. not because SRL fails, but because runescape does :)


I will take a look at it once I have a member at my disposal