SRL Archive - RS3 Outdated / Broken Scripts

SCRIPT STATUS: OUTDATED
LAST UPDATE: 2/21/10 3:55 P.M. (East Coast of U.S.)
VERSION: 0.15

Reqs: Latest SRL, and SCAR versions

I am releasing my newest script, and first one in a while (besides my g/e form). It makes unfinished potions.

I haven't tested it yet besides the DTM's and the right clicking on the potion in the chat box to make all, but it should in theory work, I just haven't tested it yet, so it's definitely not ready to just leave on overnight. I would watch it closely, make sure it doesn't do anything bot-like.

It has antirandoms/antiban, it withdraws any herb, so make sure the one you want it to use in the one in the most upper-left hand spot in bank, and same with vials of water, it might detect empty vials cause I made the tolerance 255 for unfinished potions, then realized I didn't need to detect them, I could just deposit all. Next release won't detect empty vials if it currently does, but just keep the herbs and vials of water you want to use in a tab without other herbs/vials or have them close to the top left before others. It switches players/takes breaks if one player is active.

You can set the constant Load if you want all players to do the same amount of loads, or you can set it individually in the declare players, it's Integers[0].

Set the world you want to auto in, which player to start with, which bank (arguments shown in script), how long to auto for taking a break (if only one player is active) with GameTimer, how long to sleep for with SleepTimer (also for one player).

It should tell you how many unfinished pots it's made, how many loads each player did, the total loads, exp gained, exp p/h, and how many randoms it's encountered.

If you want it to login to a random world each time set World to 0, otherwise set it to the world you want to auto in.

If you would like to use SMART take out the // on line 17.

If you find any bugs or have any suggestions please tell me so I can improve this script. Again, this is only the BETA version since I've never really tested it. Please post progress reports and tell me where/how it messed up. I can't really think of anything else, so I guess that's all, thanks.


EDIT:

***If it doesn't find your herb post which herb it is so I can test it or make a new one.***

You should put in a failsafe that if WithDrawDTM returns false it switches players.

Otherwise it looks great. :)

EDIT:

Ok a lot of errors. The DTM (for vials) returns the point of the bottom of the vial:

mouse(x, y -25, 3, 3, false);

And there should be a wait after the right-click to find the text.

There's no need for OptionsExist and there shouldn't be a space after 'Draw'

 WAIT(1000+ random(1000));
        if not WaitOptionMulti(['Withdraw-14', 'draw-14'], 300) then

The DTM does not work for Herbs so I switched to bitmaps…

And you forgot to load the DTMS

 SetUpSRL;
  DeclarePlayers;
  DeclareDTMS;

For making the unfs procedure… you don't really need anymore failsafes since you already withdrew it as the item already…. So instead of using FindDTM just use ItemCoords.

thanks for the feedback, I wrote this out pretty quick and didn't test or review it too much, thanks for reading over it so much. :)

the withdraw function came straight from SRL, I just took fixbanktab; out.

and yea, the spot on the vials was a bit too low, I meant to pick a little bit low incase numbers covered the spot on the vial, and to make sure it was the water color, but then I just made it 255 tolerance anyway, I could move it up. And the dtm for herbs worked on marrentill and some other herb for me, I figured it'd work on all, I can try to make a new one, see if it works, was your herb grimy or clean by the way?

and it was originally a function because I had it if it returned false on a "clean" herb to search for a "grimy" one, and the herb dtm was an array of ints, then I just made one herb dtm for both grimy and clean, and it found both for me, but I forgot to turn withdrawdtm back into a procedure, but that's a good idea to make it switch players if it returns false, I'm going to do that, thanks.

optionsexist is a failsafe to make sure it's clicking an herb, I think that's why I originally did that. And at:

"mouse(x, y -25, 3, 3, false);

And there should be a wait after the right-click to find the text. " (Sorry, to lazy to use quote tags :p)

what line is that?

You should never switch players in the middle of a function like you do here:

  if(not(BankScreen) and not(PinScreen)) then
  begin
    OpenBank(WhichBank, true, true);
    wait(200 + random(100));
    if(not(BankScreen) and not(PinScreen)) then
    begin
      writeln('could not open bank, switching players');
      SwitchPlayers(False);
    end;
  end;
  DepositAll;
  wait(200 + random(100));
  WithdrawDtm(Herb, 'draw')
  WithdrawDtm(vial, 'ial');
  wait(100 + random(100));
  CloseWindow;
  AntiBan(False);
end;

Because when the next player logs in, he'll attempt to 'DepositAll' and so on, thinking he was the previous player.

You should log him out, and then do
if not LoggedIn then exit

and finally, you should only switch them in the mainloop.

~RM

:duh: can't believe I did that and didn't notice. Thanks RM, I changed my bank procedure to a boolean function, if it was going to switches players, it now sets result to false and exit's the function.

When I run it it logs in, checks the herblore level, opens the bank but doesnt withdraw anything, closes the bank, checks the heblore level again then logs out.

I don't know why it might be doing that, maybe I need to make new herb and vial dtm's. I'll try buying some herbs and vials to see if I can find what's going wrong.

From: Baked0420
I don't know why it might be doing that, maybe I need to make new herb and vial dtm's. I'll try buying some herbs and vials to see if I can find what's going wrong.

I used Avantoe herbs and it did the same thing as the guy above me. Also had problems finding Banker, and when it did, it clicked collect xD

what bank are you at? Did you change the constant to be the bank where you are? and it works for my marrentills, I edited a few things and now it does a few loads. Still messing with it, I think I need to add DTM's for all the herbs if it's not working for you guys. Still a few failsafes that need to be put in also. The DTM's haven't been updated yet but they worked for me, but if they don't work for you, if you update them for your herbs you can use this script, I'll post what I edited in the first post. It was a tweak with the bank and sleeping, and I don't think much else was touched.

From: Baked0420
what bank are you at? Did you change the constant to be the bank where you are? and it works for my marrentills, I edited a few things and now it does a few loads. Still messing with it, I think I need to add DTM's for all the herbs if it's not working for you guys. Still a few failsafes that need to be put in also. The DTM's haven't been updated yet but they worked for me, but if they don't work for you, if you update them for your herbs you can use this script, I'll post what I edited in the first post. It was a tweak with the bank and sleeping, and I don't think much else was touched.

Tried lb, fwb and vwb.

were you at those banks when you put that for the constant?

EDIT:

From: bi a op
I used Avantoe herbs and it did the same thing as the guy above me. Also had problems finding Banker, and when it did, it clicked collect xD

were you using grimy avantoe? I tested both clean and grimy and I think it should've found grimy first by the way it searches (DTM Editor) but it found the clean one in dtm editor. I think it works for clean only for some reason.

From: Baked0420
were you at those banks when you put that for the constant?

Yes. right in front of bankbooth.

oh, I don't know why it's not working for you.. and I tested the two avantoes as separate pictures and it found both, I don't know why it's not finding herbs for you. Is your SRL up to date? You have the dev rev?

From: Baked0420
oh, I don't know why it's not working for you.. and I tested the two avantoes as separate pictures and it found both, I don't know why it's not finding herbs for you. Is your SRL up to date? You have the dev rev?

Yes I have everything up to date.
What slots do you have the herbs and vials in? And bank tabs. My herbs are clean.

it shouldn't matter what tab they're in, just as long as that was the last tab open so when it opens the bank scar can see them. I have had my herb and vial near the bottom right corner of the bank screen and top left and both times scar found them. I don't know what could be wrong for you.

From: Baked0420
it shouldn't matter what tab they're in, just as long as that was the last tab open so when it opens the bank scar can see them. I have had my herb and vial near the bottom right corner of the bank screen and top left and both times scar found them. I don't know what could be wrong for you.

Ok, but when was last time something about Scar and SRL was updated, I might be out dated then :-P

do you use the svn? For me TortoiseSVN said the last update was February 17, 2010. That's the open dev last update. Then the scar pre-release says the last update was December 27, 2009.


EDIT: Just try updating from the svn if you are up-to-date it won't hurt, so I'd just try updating and if it still doesn't work then I'd have to see if I could figure out why.

From: Baked0420
do you use the svn? For me TortoiseSVN said the last update was February 17, 2010. That's the open dev last update. Then the scar pre-release says the last update was December 27, 2009.


EDIT: Just try updating from the svn if you are up-to-date it won't hurt, so I'd just try updating and if it still doesn't work then I'd have to see if I could figure out why.

It could possibly be because the DTM you made used the top left corner of the item when it was in the inventory so it returns true there but not inside the bank where the item count shows so a point becomes obscured.

try this for an herb dtm, it works for me:

  Herb:= DTMFromString('78DA6374636060106740010279260CFF81342' +
       '310FF0702C600204394010D30814946288FD11248881050130832' +
       '9C801A907B64F1AB0100189D0793');

if that's the same that's already in there, then it should work, this one works for me so if you guys have a different one you can try using the script with this DTM or wait till a new update that should have a working herb finder.

Thanks, but it still doesn't work. I have my vial at first bank slot and avantoe in second. And random potions and herbs in other slots.
I'm at 'lb' and the script just opens and closes the bank. I also tried the new DTM you posted. And I tried to update SVN and it's up-to-date.

that's really weird, because I've tested my DTM for avantoes and it worked for both clean and grimy avantoe. I'll release a new version ASAP that doesn't use DTM's. Hopefully by the end of today I'll have it released.

EDIT: I had it do like 16 loads, it did over 200 pots but then it accidently clicked x on the vial of water in the bank then closed the bank, and I didn't give it a chance to see if itd bank the herbs and retry i just ended the script to buy more herbs, this script isn't just how I'd like it yet. I want to do a few more things before releasing this version, I want it to try to make it more reliable.

So I'm trying to make harralander Unf pots, but it won't work in vwb/veb/lb. The varrock banks both just sit there, then log out, and lumbridge it tried to, but an error came up and said that 'lb' wasn't in OpenBankQuiet. And Finally in Falador West Bank, It started to make the pots but then I got

[Runtime Error] : Exception: Could not convert variant of type (String) into type (Double) in line 253 in script *:\Program*\ScapeRelease\includes\SRL\SRL\Core\AntiBan.scar

        Mouse(247, 417, 7, 7, False);

^That's my line 413

changed from what I think was

 Mouse(247, 417, 335-195, 420-390, False);

Yours before hand had too much variance and would misclick 3 out of 4 times. I'm not sure if the 7 is random enough but this is what I used. Also I was wondering why at the beginning of the script it sit around for about 15 seconds (just the mouse moves around the edges of the screen) before it starts going. I'm not sure if that's intentional or not.

Oh, I also removed all the AntiBan (Maybe that's causing the waste at the beginning?), because of the same error I got above.

EDIT: After about 700 pots made, the script got into a loop where it continually checked the tabs. It was fixed by making it withdraw herbs (first slot) and then went back to normal.

Also I noticed it kept jumping bankers, whether or not this is a SRL thing or not, it was interesting.

You may also want to consider having it pick the "14th" herb to use on the vial (aka the one next to the vial). Using the first herb in inventory is more bot like to me, though that could be personal preference.

And I'd post my proggy, but it never printed what I had done (Had to force termination, ran out of herbs). Otherwise nice script :D. Seems to have best productivity when camera view is on the horizon facing outside of VEB bank. Sorry if there's a lot of stuff here, more debugging done today hopefully

Good posts both but I'm afraid you did this for nothing:

a) This scipt might be outdated (not 100% sure)

b) Don't doublepost, edit your last post. :)

c) There is an updated herb cleaner/unf potion maker/decanter called HERR Blore! By WT-Fakawi.

From: chaoyd
Also I noticed it kept jumping bankers, whether or not this is a SRL thing or not, it was interesting.

This happens every once in a while, it should click the banker closest to you, but this doesn't always happen. Nothing to really worry about.

From: Cazabacca
Good posts both but I'm afraid you did this for nothing:

a) This scipt might be outdated (not 100% sure)

b) Don't doublepost, edit your last post. :)

c) There is an updated herb cleaner/unf potion maker/decanter called HERR Blore! By WT-Fakawi.



This happens every once in a while, it should click the banker closest to you, but this doesn't always happen. Nothing to really worry about.

Well I couldn't find The one you just linked to (though could be because of spelling? just searched herblore). But thanks :D. Didn't know bout the double post thing my bad

EDIT: Oh and Caza do you know why it sometimes jumps bankers? Or where I can go to find out? Just curious

this still works? I thought it'd be too outdated by now, I switched status to outdated just because you said it's a little buggy. It hasn't been updated in a while and I been a bit inactive and forgot to change it to outdated and to ever check on it. If I get some extra time I'll try to get the bugs out, thanks for running it and posting feedback.