jimthesoundman
2010-01-20 04:34:48
Made this simple smelter today, ran it for four hours and it seemed to do okay but it didn't encounter any randoms.
Any comments/suggestions are welcomed.
Feel free to take it and expand it to handle other ores.
Edit 1/21/10: I updated a few small things with the mouse clicks and rewrote the includes and functions as suggested. All comments welcomed.
Edit 1/22/10: Added a DeclarePlayers function as it was causing part of AntiRandoms.scar to crash without it.
Jim
swisspking
2010-01-20 07:15:09
Why is this tagged as Runecrafting and why do you include runecrafting.scar in a smithing script? Other than that I'd suggest you to add DeclarePlayers.
Script looks good at first look although I don't like the "blindclick for furnace", how about running to the tree there or something?
~Swiss
Bad Boy JH
2010-01-20 07:31:26
You have many issues…
A: You included runecrafting.scar in a smelting script
B: You created a find furnace function, when there already is one in smithing.scar
C: Co-Ordinate Clicking
D: Poor organisation, Whist standards are great…your organisation of functions/procedures are poor, personally i prefer a seperate functions for walking…
You also want basic things like…Login functions, checkout login.scar, its located in includes/SRL/Base/login.scar (Don't include its already included)
right… now how to improve the errors you made…
A: Fairly simple…delete that line… don't include uncessesary files
B: always look at skill relevant, Skill includes… the are at {scarfolder}/includes/SRL/skill/
C: DTMs to find the co-ordinates, many guides to help you…and it makes it much easier to get all the bar types and reduces detectability
D:Like I said, one function at a time, Walk to furnace, Smelt, Walk to bank, Bank, 4 basic sections and progress reports…
These basic things can help you improve…just remember we all start somewhere,
Sabzi
2010-01-20 07:34:13
@B: The one in smithing.scar is not really working so modifying that/making your own is a better option.
jimthesoundman
2010-01-20 08:32:05
My bad, I was also working on a ZMI script and after all that going back and forth I guess my brain has just turned to mush. I copied part of the ZMI script over to start this one and when I posted it I still was being braindead and tagged it as Runecrafting instead of Smithing. So, how do I change that RC icon at the top to Smithing?
JIM
jimthesoundman
2010-01-20 08:37:58
From: swisspking
Script looks good at first look although I don't like the "blindclick for furnace", how about running to the tree there or something?
The bank and the furnace are so close together, that on the rare occasion when the FindSymbol function might fail, it's not a stretch to use a blindclick as a backup. Doesn't seem like there is any way the blindclick could fail, unless the user rotated the camera or something like that. I ran it for four hours and it was always able to find the furnace.
JMHO,
JIM
Sabzi
2010-01-20 09:06:15
1st: use the edit button, pls don't double post
2nd: just report the thread using the little red cross near the blue rep+/- tick and say that you want to change the icon from rc to smithing and a staff member will do that
Bad Boy JH
2010-01-20 10:19:04
Oh, didn't realise the findfurnace didn't work, assumed it would…never did anything involving smelting…