SRL Archive - Commits

Wizzup why'd you revert the changes of 336?

I indeed spotted some unnecessary optimizations, but they never did any harm..


Besides Nava, in a for loop the start parameter will only be called once, so it's not necessary to save the start parameter in a different var..
That's why I used downto loops.
eg: for x := w*h downto 0 => w*h is only calculated once

I think he was just frustrated with what Nava did. Here's the chat log from the time:

<Wizzup> …
<Wizzup> ffs
<Widget`> eh?
<Wizzup> - for i := (h*w-1) downto 0 do
<Wizzup> + HH := w*h-1;
<Wizzup> + for i := HH downto 0 do
<Wizzup> nava just made a tol on changes like that
<Wizzup> ton*
<Wizzup> ……

Yeah, but there's not reason to revert it like this.. He could have at least explained why he reverted it.

I do know the reason though; we've said not to optimize our code for a while. It's easier to read and debug when it's not optimized.

From: mastaraymond
Yeah, but there's not reason to revert it like this.. He could have at least explained why he reverted it.

I do know the reason though; we've said not to optimize our code for a while. It's easier to read and debug when it's not optimized.

I discussed it with Nava in person. Some of the optimisations were totally unnecessary, and others were just overdoing it. I think for now the code is more than fine, and those changes will hardly affect the speed of the code. And yeah, I've stated a couple of times we weren't going to focus optimisations. Besides, optimisations like these are for the compiler to make, and not ours, IMO.

From: Wizzup?
I discussed it with Nava in person. Some of the optimisations were totally unnecessary, and others were just overdoing it. I think for now the code is more than fine, and those changes will hardly affect the speed of the code. And yeah, I've stated a couple of times we weren't going to focus optimisations. Besides, optimisations like these are for the compiler to make, and not ours, IMO.

Yeah, I just thought you made this revert purely out of rage.. D/w

From: mastaraymond
Yeah, I just thought you made this revert purely out of rage.. D/w

* Wizzup never rages.

He explained it… I did get to say Happy Holidays though !

Wizzup does rage! Lies!