SRL Archive - RS3 Outdated / Broken Scripts

This is my Christmas gift to SRL :). Please post all progress reports but much more importantly, ERRORS. If the script fails, please take a screenshot of where your character is and copy and paste the last few lines of the debug box then post that here along with any other necessary description of the error.

I intend to keep this updated and progressively make it better and better.

Please Note: I've noticed that the script runs best at off-peak hours because during peak hours, symbol and DTM finding is occasionally stopped by crowding from the white dots of players.

Bbri06"s Catherby Yew Cutter
Time running: 3 Hours, 3 Minutes and 49 Seconds
Logs banked: 540

Bbri06"s Catherby Yew Cutter
Time running: 2 Hours, 27 Minutes and 10 Seconds
Logs banked: 459

what is the point of SwitchWorldsProc

Oh, did I leave that in there? Oops. It was a feature I was working on but decided to save for later and I guess I left it in there lol. When I get it working it will switch worlds while breaking.

  if(High(CheckPoints)) >= 15 then
  begin
    result := true;
  end else
    result := false;

// Fixed:
  result := High(CheckPoints) >= 15;

  if(FindSymbol(x, y, 'rare trees'))then
  begin
    for i := 0 to 10 do
    begin
    if(FindDtmRotated(TreesDTM, x, y, MMX1, MMY1, MMX2, MMY2, Radians(-35), Radians(35), 0.02, ReturnAngle))then
    begin
      writeln('Found trees via symbol and DTM');
      mouse(x - 15 - random(5), y + 7 + random(5), 2, 0, true)
      FFlag(0);
      result := true;
      Exit;
    end;
    end
  end;

This part in your CheckForTrees function is useless, because it will never be called. You already check "if FindSymbol(x, y, 'rare trees') then" earlier, and if the symbol is found you click it and exit. If the symbol is not found earlier, it will look for it again in this part of the function, which is unnecessary.

What comes to AdjustableRadialWalk, I suggest you take a look into LinearWalk in file /core/MapWalk.scar.

Procedure ToTrees;
begin
  If(not(Loggedin))then
    Exit;
  Writeln('Walking to trees');
  Randoms;
  if(FindStore)then
  begin
    if(not(AdjustableRadialWalk(FindWaterColor, 260, 280, 60, 4, 4, 40, true)))then
    begin
      writeln('failed to walk to trees');
      Players[CurrentPlayer].Active := False;
      LogOut; // You log out here, but you don't exit the procedure
    end else
      FFlag(0);
    repeat // ...and you will start this loop while logged out!
    if(CheckForTrees)then // <- CheckForTrees never returns True if you're logged out
      break;
    if(not(AdjustableRadialWalk(FindWaterColor, 255, 359, 60, 4, 4, 20, true)))then
    begin // Again, you log out while you can already be logged out earlier!
      writeln('failed to walk to trees');
      Players[CurrentPlayer].Active := False;
      LogOut;
    end else
      FFlag(10);
    until(false) // this causes an infinite loop if the first AdjustableRadialWalk after the first FindStore fails! 
  end else
  begin
    writeln('Failed to walk to store icon');
    Players[CurrentPlayer].Active := False;
    LogOut;
  end;
end;

Same problems that are in ToTrees are also found in ToBank! You should Exit the procedures after logging out.

——————————-
Nice to see new scripters, and there's always a great need for Yew cutters! :) You have great potential! Be more careful when you write and check all your loops after finishing them, if they're possibly endless. Also in some functions you Exit before you free your dtms!

Fix these things and you'll be a SRL Member in no time!

So, if I simply exit the procedures after logouts, then all the commented problems in ToBank; and ToTrees; are fixed. Correct?

Edit: I uploaded an edited version with your changes, Marpis. If you could check it out again I would appreciate that a lot.

Edit2: More accurate banking added!

Glad you made it to members :)

Going to try soon. Thank you for your gift ^^

Thanks and you're welcome :)

The script has had some significant updating!

-The Script now uses Animation.scar (Thanks marpis :)) to check if your character is currently cutting a tree.

-A failsafe for part of the ToTrees; procedure has been added.

-Tree colors are now retrieved with an autocolor function.

-Uptext is now used rather than OptionsExist;

*Between tomorrow and the 2nd, I will be rewriting the whole banking procedure and most likely some of the ToBank; Procedure. Right now it's functionality is rather sub-par.

Also, if anyone has a screenshot of a bird's nest on the ground that's a .bmp, I would love to have it.

Hehe, nice to see you find Animation.scar useful! :)

Hey, I decided to give this a whirl…..

Checks to often and repeats selecting option to chop tree to often….

Repetitious pattern searching for tree while re-spawning…

Sorry, had to stop testing, as these changes need to be made before continuing to use…

However, very good start :)

Checks to often and repeats selecting option to chop tree to often….

I've noticed it does do that. I'm going to play with different animating time and pixel change options to see if I can eliminate that problem.

edit: Hmm, what axe are you using?

Repetitious pattern searching for tree while re-spawning…

Hmm… Never really thought of changing that. I think I have an idea to deal with that.

Sorry, had to stop testing, as these changes need to be made before continuing to use…

However, very good start :)

Don't apologize, I'm so very thankful you actually tested it. I've been itching to get some real testing based feedback from someone knowledgeable, thanks a ton!

Edit: Uploaded an edited version. Going to work on making more human like walking procedures later.

I'm using Dragon Axe, I'll try your updated version when I get a chance….

Alright, shouldn't be too many problems if you're using a dragon axe. I was actually thinking earlier since I made the script's IsCutting using a dragon axe there might be problems with using a rune one.

Also, got a 621 logs cut progress report earlier using this.

Will test when i got mem

Line 947: [Error] (22603:1): Invalid number of parameters in script

Oops, left a small thing in there that I shouldn't have. Try the one I just uploaded.

Edit: Should be releasing a new version with tons more fail safes and SmartColors sometime today. Just running through testing and it seems to be working better than ever.

Tree Finding and cutting is a bit smoother:), but no luck with the banking.:(

SRL Compiled in 16 msec
SMART Initialized.
Loaded: Server 89, Members: True, Signed: True, Super Detail: False.
Enrix E B
Creating the NickTPA.
Starting cutting procedure
Banking
Failed to find the color, no result.
Walking to bank failed
NextPlayer
Successfully executed
Successfully compiled (5497 ms)
SRL Compiled in 0 msec
SMART Initialized.
Loaded: Server 99, Members: True, Signed: True, Super Detail: False.
Enrix E B
Creating the NickTPA.
Starting cutting procedure
Banking
Failed to find the color, no result.
Walking to bank failed
NextPlayer

Just passing by to say it ran one load, and got lost on the road to bank on the second… :confused:

Damn thing works one day then fails the next. I'll try and update it sometime soon and will post when I do.

Edit: Was it trying to find the bank, Cigue? I've never ever had a problem with it getting near the bank, just finding it.

Edit2: I just completed a bank finding function that has yet to fail me even once after 500 logs cut. I'm now working on updating some other things and you guys can expect a release soon. Hopefully this one is stable :O

For me it finds the tree, but doesnt click to cut. Ahhh

Releasing an updated version. This new version seems to be working better than ever; hopefully it works for you guys.

/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/
Bbri06"s Catherby Yew Cutter
Time running: 4 Hours, 31 Minutes and 25 Seconds
Logs banked: 729
/*/*/*/*/*/*/*/*/*/*/*/*/*/*/*/

Check the first post for updated version: 1.13.

Line 615: [Hint] (22043:1): Variable 'NEWCOLOR' never used in script C:\Program Files\SCAR 3.22\includes\SRL\SRL\Misc\SmartColors.scar
Line 615: [Hint] (22043:1): Variable 'CTS' never used in script C:\Program Files\SCAR 3.22\includes\SRL\SRL\Misc\SmartColors.scar
not sure what this means but okayy help? :)

Hmm… Are you on SRL open dev ?

The checkout for it is
http://www.villavu.com/repositories/srl-opendev

indeed i do. Still not working though. :s

Well I have no idea what-so-ever where those are coming from then, but since they are just hints, they should not technically cause problems with the script running.

Pompey, make sure SRL Dev is UPDATED, and also hints, wont break script.
:)

:/ it still just finds a tree, but doesnt click it. and searches for a new one:/

Oh, I think I know! Are you on pre-release scar?

I dont know, Scar Divi 3.22 ?

Yep, that's the problem. The pre-release is 3.23 Beta. You can get it by making a new folder, name it whatever, then svn checkout that folder to

http://freddy1990.com/svn/scarprerelease

Then you'll have to get the open dev SRL and put it inside of that new scar folder.

Once you've got that stuff done, make sure you're opening the script with the Scar.exe in the pre-release folder rather than the standard one.

Hmm i've done all that. Now im getting
Failed when compiling
Line 5: [Error] (17:11): Unknown identifier 'SmartIsKeyDown' in script C:\Documents and Settings\Andy\Desktop\SRL\SRL\Misc\SMART.scar

Sorry to be a hassle. :)

You're not being a hassle, don't worry.

Try compiling this

program New;
{.include SRL/SRL/Misc/SMART.scar}
{.include SRL/SRL.scar}
{.include SRL/SRL/Skill/WoodCutting.scar}
{.include SRL/SRL/Misc/SmartColors.scar}
begin
end.

If that doesn't compile then you should make a thread in general help with your error since it is somewhere in your install, I think.

Seems its definately my setup, i'll try get it working then get you a log :)

Cool, thanks.

EDIT: Pompey, did you move your plugins from SRL to the plugins folder?

I did indeed, i may attempt to reinstall scar.

I can't get this to run, evidently some sort of update by Jagex has messed up a lot of the SRL functions.
If bbri06 doesn't mind, I'm going to hack it apart and make it run again. It won't be as efficient or nice as this one, but it will work. I'll certainly give bbri06 credit for all the stuff that I "stole".

JIM

you are also talking about it not clicking on the tree, do you have Scar 3.22 or Scar 3.23Beta, because you need 3.23Beta…

Im getting the script to run fine just the running back to tree function you have seems to be hit or miss because it uses the floating store symbol. On several occasions it has gotten stuck because the store symbol is down by the docks and it cant fix itself. If you can fix the running back to trees procedure then it will be a great script and probably the best yew cutter.

Zenith, I'll get around to working on that soon, hopefully. Thanks for the feedback.

Hi, I have only just started running this script but haven't succesfully ran back to the trees as yet, but as zenith already stated its hit and miss so im gonna keep it running while watching over it. Also while im already chopping a yew it decides to try cut another tree before the original one had been chopped down. If you could manage to fix that it would be super :)

Will post report if i can successfully run for a good period of time.
Thanks

Is anyone going to update this script because if not it seems quite dead to me?

I was thinking about updating it, but now that volleyball has started, I don't have much time.

as soon as i logg on it breaks for 8 mins??

Well then unless someone wants to take charge with his agreement I think this yew-cutter is forever outdated?