SRL Archive - MSI Suggestions

Small Update on Constants


Sir R. M8gic1an

2009-12-08 07:42:14

For those of you who don't yet know, MSI has been following SRL 5 standards.

In SRL 5, all constants will be CapLocked, as so: SRL_CONSTANT, WAIT_TIME_UPTEXT, TREE_COLOR

So, for all the contants that we use, let's make sure they look this way :)

~RM

Coh3n

2009-12-08 10:57:09

From: Rasta Magician
For those of you who don't yet know, MSI has been following SRL 5 standards.

In SRL 5, all constants will be CapLocked, as so: SRL_CONSTANT, WAIT_TIME_UPTEXT, TREE_COLOR

So, for all the contants that we use, let's make sure they look this way :)

~RM

Why capitalized? Just for them to stand out? Or…

Wizzup?

2009-12-08 13:37:36

Uhm, I'm not sure if we agree on the all caps thing. :p <3

Coh3n

2009-12-08 13:41:24

From: Wizzup?
Uhm, I'm not sure if we agree on the all caps thing. :p <3

It makes sense if you want them to stand out from other variables.

Wizzup?

2009-12-08 13:43:31

From: Coh3n
It makes sense if you want them to stand out from other variables.


<sarcasm< It had crossed my mind… :duh: </sarcasm>

Anyway, what I said is that RM said SRL 5 is going to have constants that way, and I'm not sure the dev team agrees on that.

Sir R. M8gic1an

2009-12-08 13:49:05

From: Wizzup?
<sarcasm< It had crossed my mind… :duh: </sarcasm>

Anyway, what I said is that RM said SRL 5 is going to have constants that way, and I'm not sure the dev team agrees on that.


Oh possibly my mistake, that was the impression I had from the thread.

Let's have a vote here at MSI then :p

Caps or no Caps?

~RM

Coh3n

2009-12-08 13:50:42

From: Rasta Magician
Oh possibly my mistake, that was the impression I had from the thread.

Let's have a vote here at MSI then :p

Caps or no Caps?

~RM

Lol, I say Caps. Although we'll have to convert a million of them over, I think it makes more sense.

EDIT: After all, you said you wanted MSI to be understood by everyone. Having the constants stand out, will definitely help out.

Wizzup?

2009-12-08 16:59:12

Then it will differ from SRL 5 I guess…

NCDS

2009-12-08 17:41:57

Personally, I think it look's somewhat ugly. :redface:
I wouldn't do it in my personal scripts, but as far as trying to make it as easy as possible for people to follow, it's not a bad idea.

Either way, I don't mind.


Edit:
It would, however, make sense that one of SRL's largest projects would follow SRL standard's.

marpis

2009-12-08 18:21:16

Earlier I thought it was a good idea but now I oppose it.
Lets keep them clean looking. :)

Coh3n

2009-12-08 19:44:14

From: marpis
Earlier I thought it was a good idea but now I oppose it.
Lets keep them clean looking. :)

I think at first it may look ugly, but it's an obvious distinction between constants and variables. However, if the constant's names are obvious to their purpose, it shouldn't matter either way.

NCDS

2009-12-08 21:09:35

Since all the functions are already signified with a "MSI_" why not just put a "C_" in front of constants?

Just an idea.

Coh3n

2009-12-08 21:12:29

From: NCDS
Since all the functions are already signified with a "MSI_" why not just put a "C_" in front of constants?

Just an idea.

Not a bad idea. I think that would make it look uglier, but that's just my personal preference. :o

I think either would work because it gives a good distinction.

Naike

2009-12-09 09:34:15

I'm still for the capitalized. So much better.
At least for the include, idc if people do it in their scripts.

We'll have a shitloads of consts with SRL 5, might as well make a way to spot them all.