SRL Archive - Research & Development Lounge

Help SRL! Test new OpenBankFast here!

marpis

2009-12-07 10:43:52

Hi.

I want this new OpenBankFast function to be tested before I'll commit it.
Because of the text it probably won't notice uptext or choose the option correctly, but just look if it hovers the right place (bank booth).
I don't have a member accuont so I didn't update P2P banks, only F2P.

The faster I get some results from others, the sooner OpenBank() will work again!


function OpenBankFast2(Location: String): Boolean;
var
  x, y, i, l, c, z, h: Integer;
  Info: TVariantArray;
  Booths, t: TPointArray;
  ABooths: T2DPointArray;
  B: TBox;
begin
  if (not LoggedIn) then
    Exit;
  if BankScreen or PinScreen then
  begin
    Result := True;
    Exit;
  end;
  
  case LowerCase(Location) of {            Sort X     Sort Y     Color    Tol   Hue   Sat   Count  SplitTPA?  W   H }
    'akb', 'al kharid':           Info := [MSCX - 50, MSCY,      11196157, 20,   0.20, 1.15, 100,   False,   10, 10]; // Fixed 12/7, #40
    'lb', 'lumbridge':            Info := [MSCX,      MSCY - 50, 6780805,  10,   0.19, 0.27, 100,   False,   10, 10]; // Fixed 12/7, #40
    'veb', 'varrock east':        Info := [MSCX,      MSCY + 50, 3037545,  5,    0.41, 1.32, 100,   False,   10, 10]; // Fixed 12/7, #40
    'vwb', 'varrock west':        Info := [MSCX,      MSCY,      3037545,  5,    0.41, 1.32, 500,   True,    10, 10]; // Fixed 12/7, #40
    'feb', 'falador east':        Info := [MSCY,      MSCY + 50, 5008519,  10,   0.22, 0.67, 100,   False,   10, 10]; // Fixed 12/7, #40
    'fwb', 'falador west':        Info := [MSCY,      MSCY + 50, 5074569,  10,   0.22, 0.67, 200,   True,    10, 10]; // Fixed 12/7, #40
    'db', 'draynor':              Info := [MSCX - 50, MSCY,      5527389,  7,    0.20, 0.20, 10,     False,  5,  10]; // Fixed 12/7, #40
    'eb', 'edgeville bank':       Info := [MSCX + 50, MSCY,      4347490,  15,   0.32, 0.61, 100,   False,   10, 10]; // Fixed 12/7, #40
    'ctb', 'catherby bank':       Info := [MSCX,      MSCY,      3239049,  8,    0.20, 0.20, 500,   False,   10, 10];
    'clt', 'camelot bank':        Info := [MSCX,      MSCY,      7636882,  5,    0.20, 0.20, 500,   False,   10, 10];
    'nab', 'north ardougne bank': Info := [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10];
    'sab', 'south ardougne bank': Info := [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10];
    'ynb', 'yanille bank':        Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'ngb', 'north gnome bank':    Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'sgb', 'south gnome bank':    Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'wgb', 'warrior guild bank':  Info := [MSCX,      MSCY,      2578286,  7,    0.20, 0.20, 500,   False,   10, 10];
    'fgb', 'fishing guild bank':  Info := [MSCX,      MSCY,      2908796,  10,   0.20, 0.20, 500,   False];
    else
    begin
      srl_Warn('OpenBankFast', 'Unknown bank: '+Location, warn_AllVersions);
      Exit;
    end;
  end;

  MakeCompass('n');
  z := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  SetColorSpeed2Modifiers(Info[4], Info[5]);
    
  FindColorsSpiralTolerance(Info[0], Info[1], Booths, Info[2], MSX1, MSY1, MSX2, MSY2, Info[3]);
  ColorToleranceSpeed(z);
  SetColorSpeed2Modifiers(0.2, 0.2);
  
  { Split to ATPA. }
  If Info[7] Then
    ABooths := SplitTPA(Booths, 1)
  Else
    ABooths := TPAtoATPA(Booths, 10);
  SortATPAFrom(ABooths, Point(Info[0], Info[1]));
  
  { Go through ATPA. }
  l := Min(GetArrayLength(ABooths) -1, 20);
  for i := 0 to l do
  begin
    { Too few pixels. }
    if (Length(ABooths[i]) < Info[6]) then
      Continue;

    { Too small TPA bounds. }
    B := GetTPABounds(ABooths[i]);
    If ((B.X2 - B.X1) < Info[8]) Or ((B.Y2 - B.Y1) < Info[9]) Then
      Continue;
      
    MiddleTPAEx(ABooths[i], X, Y);
    MMouse(X, Y, 3, 3);
    if WaitUpText('ooth', 300) Then
    begin
      GetMousePos(X, Y);
      Mouse(x, y, 0, 0, False);
      if WaitOption('uickly', 300) then
      begin
        FFLag(0);
        MarkTime(c);
        repeat
          Wait(100);
        until (BankScreen) or (PinScreen) or (TimeFromMark(c) > 10000);
        Wait(Random(300));
        if (Players[CurrentPlayer].Pin <> '') then
          InPin(Players[CurrentPlayer].Pin);
      end;
    end;
  end;
  Result := (BankScreen) or (PinScreen);
end;

Wizzup?

2009-12-07 10:46:48

Are you going to override the old one?

marpis

2009-12-07 10:53:07

From: Wizzup?
Are you going to override the old one?

Lol your avatar! :p

Going to replace it with this one when I hear it works.

ZephyrsFury

2009-12-07 11:05:33

Just a quick observation but you need to check if the length of the players array is greater than 0 before checking Players[CurrentPlayer].Pin. If you don't then people who don't set the players array will get a runtime error when using the function.

Good job on fixing up the function though, you've done what everyone's avoided for a while :p

Wizzup?

2009-12-07 11:08:03

From: marpis
Lol your avatar! :p

Going to replace it with this one when I hear it works.

Yeah, it should have something like "Why So Serious" next to it. :p

Ok, replace it if it works fine. :)

marpis

2009-12-07 11:19:54

From: ZephyrsFury
Just a quick observation but you need to check if the length of the players array is greater than 0 before checking Players[CurrentPlayer].Pin. If you don't then people who don't set the players array will get a runtime error when using the function.

Yea I can add that but that part is actually from the original function :rolleyes:

From: ZephyrsFury

Good job on fixing up the function though, you've done what everyone's avoided for a while :p

/s/a while/ever/

Lawl that's been broken for centuries.. Someone had to do it finally! :)

Naum

2009-12-07 12:28:27

It found the bank really fast, it right clicked and didn't click the option to open the bank 'uickly'. But, when I changed this:

if WaitOption('uickly', 300) then

To this:

if WaitOption('uickl', 300) then

..It seemed to work brilliantly :). I suspect its the 'y' character causing the problem,

GJ!

marpis

2009-12-07 13:28:31

OK I decided to commit this already :rolleyes:

JPHamlett

2009-12-07 15:51:58

what wrong with text its works for me

Nava2

2009-12-07 18:32:20

 case LowerCase(Location) of {            Sort X     Sort Y     Color    Tol   Hue   Sat   Count  SplitTPA?  W   H }
    'akb', 'al kharid':           Info := [MSCX - 50, MSCY,      11196157, 20,   0.20, 1.15, 100,   False,   10, 10]; // Fixed 12/7, #40
    'lb', 'lumbridge':            Info := [MSCX,      MSCY - 50, 6780805,  10,   0.19, 0.27, 100,   False,   10, 10]; // Fixed 12/7, #40
    'veb', 'varrock east':        Info := [MSCX,      MSCY + 50, 3037545,  5,    0.41, 1.32, 100,   False,   10, 10]; // Fixed 12/7, #40
    'vwb', 'varrock west':        Info := [MSCX,      MSCY,      3037545,  5,    0.41, 1.32, 500,   True,    10, 10]; // Fixed 12/7, #40
    'feb', 'falador east':        Info := [MSCY,      MSCY + 50, 5008519,  10,   0.22, 0.67, 100,   False,   10, 10]; // Fixed 12/7, #40
    'fwb', 'falador west':        Info := [MSCY,      MSCY + 50, 5074569,  10,   0.22, 0.67, 200,   True,    10, 10]; // Fixed 12/7, #40
    'db', 'draynor':              Info := [MSCX - 50, MSCY,      5527389,  7,    0.20, 0.20, 10,     False,  5,  10]; // Fixed 12/7, #40
    'eb', 'edgeville bank':       Info := [MSCX + 50, MSCY,      4347490,  15,   0.32, 0.61, 100,   False,   10, 10]; // Fixed 12/7, #40
    'ctb', 'catherby bank':       Info := [MSCX,      MSCY,      3239049,  8,    0.20, 0.20, 500,   False,   10, 10];
    'clt', 'camelot bank':        Info := [MSCX,      MSCY,      7636882,  5,    0.20, 0.20, 500,   False,   10, 10];
    'nab', 'north ardougne bank': Info := [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10];
    'sab', 'south ardougne bank': Info := [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10];
    'ynb', 'yanille bank':        Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'ngb', 'north gnome bank':    Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'sgb', 'south gnome bank':    Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'wgb', 'warrior guild bank':  Info := [MSCX,      MSCY,      2578286,  7,    0.20, 0.20, 500,   False,   10, 10];
    'fgb', 'fishing guild bank':  Info := [MSCX,      MSCY,      2908796,  10,   0.20, 0.20, 500,   False];
    else
    begin
      srl_Warn('OpenBankFast', 'Unknown bank: '+Location, warn_AllVersions);
      Exit;
    end;
  end;

I really dislike that. :(

noidea

2009-12-07 20:27:57

I would have doene it like

function OpenBankFast2(Location: String): Boolean;
var
  x, y, i, l, c, z, h, m, n: Integer;
  Info : array of TVariantArray;
  g: boolean;
  namez: array of array of Variant;
  Booths, t: TPointArray;
  ABooths: T2DPointArray;
  B: TBox;
begin
  if (not LoggedIn) then
    Exit;
  if BankScreen or PinScreen then
  begin
    Result := True;
    Exit;
  end;

  Info := [[MSCX - 50, MSCY,      11196157, 20,   0.20, 1.15, 100,   False,   10, 10], [MSCX,      MSCY - 50, 6780805,  10,   0.19, 0.27, 100,   False,   10, 10],
           [MSCX,      MSCY + 50, 3037545,  5,    0.41, 1.32, 100,   False,   10, 10], [MSCX,      MSCY,      3037545,  5,    0.41, 1.32, 500,   True,    10, 10],
           [MSCY,      MSCY + 50, 5008519,  10,   0.22, 0.67, 100,   False,   10, 10], [MSCY,      MSCY + 50, 5074569,  10,   0.22, 0.67, 200,   True,    10, 10],
           [MSCX - 50, MSCY,      5527389,  7,    0.20, 0.20, 10,    False,   5,  10], [MSCX + 50, MSCY,      4347490,  15,   0.32, 0.61, 100,   False,   10, 10],
           [MSCX,      MSCY,      3239049,  8,    0.20, 0.20, 500,   False,   10, 10], [MSCX,      MSCY,      7636882,  5,    0.20, 0.20, 500,   False,   10, 10],
           [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10], [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10],
           [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10], [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10],
           [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10], [MSCX,      MSCY,      2578286,  7,    0.20, 0.20, 500,   False,   10, 10],
           [MSCX,      MSCY,      2908796,  10,   0.20, 0.20, 500,   False]];

  namez := [['akb','al kharid'], ['lb', 'lumbridge'], ['veb', 'varrock east'], ['vwb', 'varrock west'], ['feb', 'falador east'],
            ['fwb', 'falador west'], ['db', 'draynor'], ['eb', 'edgville bank'], ['ctb', 'catherby bank'], ['clt', 'camelot bank'],
            ['nab', 'north ardougne bank'], ['sab', 'south ardougne bank'], ['ynv', 'yanille bank'], ['ngb', 'north gnome bank'],
            ['sgb', 'south gnome bank'], ['wgb', 'warrior guild bank'], ['fgb', 'fishing guild bank', '']];

  g := false;
  for m := 0 to high(namez) do
  begin
    for n := 0 to high(namez[m]) do
    begin
      if (lowercase(Location) = namez[m][n]) then
      begin
        g := true;
        break;
      end;
    end;
    if (g) then
      break;
  end;

  if (not(g)) then
  begin
    writeln('Invalid bank!');
    result := false;
    exit;
  end;

  MakeCompass('n');
  z := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  SetColorSpeed2Modifiers(Info[m][4], Info[m][5]);

  FindColorsSpiralTolerance(Info[m][0], Info[m][1], Booths, Info[m][2], MSX1, MSY1, MSX2, MSY2, Info[m][3]);
  ColorToleranceSpeed(z);
  SetColorSpeed2Modifiers(0.2, 0.2);

  { Split to ATPA. }
  If Info[m][7] Then
    ABooths := SplitTPA(Booths, 1)
  Else
    ABooths := TPAtoATPA(Booths, 10);
  SortATPAFrom(ABooths, Point(Info[m][0], Info[m][1]));

  { Go through ATPA. }
  l := Min(GetArrayLength(ABooths) -1, 20);
  for i := 0 to l do
  begin
    { Too few pixels. }
    if (Length(ABooths[i]) < Info[m][6]) then
      Continue;

    { Too small TPA bounds. }
    B := GetTPABounds(ABooths[i]);
    If ((B.X2 - B.X1) < Info[m][8]) Or ((B.Y2 - B.Y1) < Info[m][9]) Then
      Continue;

    MiddleTPAEx(ABooths[i], X, Y);
    MMouse(X, Y, 3, 3);
    if WaitUpText('ooth', 300) Then
    begin
      GetMousePos(X, Y);
      Mouse(x, y, 0, 0, False);
      if WaitOption('uickly', 300) then
      begin
        FFLag(0);
        MarkTime(c);
        repeat
          Wait(100);
        until (BankScreen) or (PinScreen) or (TimeFromMark(c) > 10000);
        Wait(Random(300));
        if (Players[CurrentPlayer].Pin <> '') then
          InPin(Players[CurrentPlayer].Pin);
      end;
    end;
  end;
  Result := (BankScreen) or (PinScreen);
end;

I'm PRETTY sure it work. I havent tested, I just like that more than case of's. Java has taught me to dislike them

Nava2

2009-12-07 21:44:43

From: noidea
I would have doene it like

function OpenBankFast2(Location: String): Boolean;
var
  x, y, i, l, c, z, h, m, n: Integer;
  Info : array of TVariantArray;
  g: boolean;
  namez: array of array of Variant;
  Booths, t: TPointArray;
  ABooths: T2DPointArray;
  B: TBox;
begin
  if (not LoggedIn) then
    Exit;
  if BankScreen or PinScreen then
  begin
    Result := True;
    Exit;
  end;

  Info := [[MSCX - 50, MSCY,      11196157, 20,   0.20, 1.15, 100,   False,   10, 10], [MSCX,      MSCY - 50, 6780805,  10,   0.19, 0.27, 100,   False,   10, 10],
           [MSCX,      MSCY + 50, 3037545,  5,    0.41, 1.32, 100,   False,   10, 10], [MSCX,      MSCY,      3037545,  5,    0.41, 1.32, 500,   True,    10, 10],
           [MSCY,      MSCY + 50, 5008519,  10,   0.22, 0.67, 100,   False,   10, 10], [MSCY,      MSCY + 50, 5074569,  10,   0.22, 0.67, 200,   True,    10, 10],
           [MSCX - 50, MSCY,      5527389,  7,    0.20, 0.20, 10,    False,   5,  10], [MSCX + 50, MSCY,      4347490,  15,   0.32, 0.61, 100,   False,   10, 10],
           [MSCX,      MSCY,      3239049,  8,    0.20, 0.20, 500,   False,   10, 10], [MSCX,      MSCY,      7636882,  5,    0.20, 0.20, 500,   False,   10, 10],
           [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10], [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10],
           [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10], [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10],
           [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10], [MSCX,      MSCY,      2578286,  7,    0.20, 0.20, 500,   False,   10, 10],
           [MSCX,      MSCY,      2908796,  10,   0.20, 0.20, 500,   False]];

  namez := [['akb','al kharid'], ['lb', 'lumbridge'], ['veb', 'varrock east'], ['vwb', 'varrock west'], ['feb', 'falador east'],
            ['fwb', 'falador west'], ['db', 'draynor'], ['eb', 'edgville bank'], ['ctb', 'catherby bank'], ['clt', 'camelot bank'],
            ['nab', 'north ardougne bank'], ['sab', 'south ardougne bank'], ['ynv', 'yanille bank'], ['ngb', 'north gnome bank'],
            ['sgb', 'south gnome bank'], ['wgb', 'warrior guild bank'], ['fgb', 'fishing guild bank', '']];

  g := false;
  for m := 0 to high(namez) do
  begin
    for n := 0 to high(namez[m]) do
    begin
      if (lowercase(Location) = namez[m][n]) then
      begin
        g := true;
        break;
      end;
    end;
    if (g) then
      break;
  end;

  if (not(g)) then
  begin
    writeln('Invalid bank!');
    result := false;
    exit;
  end;

  MakeCompass('n');
  z := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  SetColorSpeed2Modifiers(Info[m][4], Info[m][5]);

  FindColorsSpiralTolerance(Info[m][0], Info[m][1], Booths, Info[m][2], MSX1, MSY1, MSX2, MSY2, Info[m][3]);
  ColorToleranceSpeed(z);
  SetColorSpeed2Modifiers(0.2, 0.2);

  { Split to ATPA. }
  If Info[m][7] Then
    ABooths := SplitTPA(Booths, 1)
  Else
    ABooths := TPAtoATPA(Booths, 10);
  SortATPAFrom(ABooths, Point(Info[m][0], Info[m][1]));

  { Go through ATPA. }
  l := Min(GetArrayLength(ABooths) -1, 20);
  for i := 0 to l do
  begin
    { Too few pixels. }
    if (Length(ABooths[i]) < Info[m][6]) then
      Continue;

    { Too small TPA bounds. }
    B := GetTPABounds(ABooths[i]);
    If ((B.X2 - B.X1) < Info[m][8]) Or ((B.Y2 - B.Y1) < Info[m][9]) Then
      Continue;

    MiddleTPAEx(ABooths[i], X, Y);
    MMouse(X, Y, 3, 3);
    if WaitUpText('ooth', 300) Then
    begin
      GetMousePos(X, Y);
      Mouse(x, y, 0, 0, False);
      if WaitOption('uickly', 300) then
      begin
        FFLag(0);
        MarkTime(c);
        repeat
          Wait(100);
        until (BankScreen) or (PinScreen) or (TimeFromMark(c) > 10000);
        Wait(Random(300));
        if (Players[CurrentPlayer].Pin <> '') then
          InPin(Players[CurrentPlayer].Pin);
      end;
    end;
  end;
  Result := (BankScreen) or (PinScreen);
end;

I'm PRETTY sure it work. I havent tested, I just like that more than case of's. Java has taught me to dislike them

Ugly and hard to read though. ;)

Would be better with constants.

noidea

2009-12-07 23:14:30

From: Nava2
Ugly and hard to read though. ;)

Would be better with constants.

Meh, it was quite sexy when it was in SCAR. the SCAR tags messed it up :o

I refuse! No constants for me!

marpis

2009-12-08 03:22:18

From: Nava2

 case LowerCase(Location) of {            Sort X     Sort Y     Color    Tol   Hue   Sat   Count  SplitTPA?  W   H }
    'akb', 'al kharid':           Info := [MSCX - 50, MSCY,      11196157, 20,   0.20, 1.15, 100,   False,   10, 10]; // Fixed 12/7, #40
    'lb', 'lumbridge':            Info := [MSCX,      MSCY - 50, 6780805,  10,   0.19, 0.27, 100,   False,   10, 10]; // Fixed 12/7, #40
    'veb', 'varrock east':        Info := [MSCX,      MSCY + 50, 3037545,  5,    0.41, 1.32, 100,   False,   10, 10]; // Fixed 12/7, #40
    'vwb', 'varrock west':        Info := [MSCX,      MSCY,      3037545,  5,    0.41, 1.32, 500,   True,    10, 10]; // Fixed 12/7, #40
    'feb', 'falador east':        Info := [MSCY,      MSCY + 50, 5008519,  10,   0.22, 0.67, 100,   False,   10, 10]; // Fixed 12/7, #40
    'fwb', 'falador west':        Info := [MSCY,      MSCY + 50, 5074569,  10,   0.22, 0.67, 200,   True,    10, 10]; // Fixed 12/7, #40
    'db', 'draynor':              Info := [MSCX - 50, MSCY,      5527389,  7,    0.20, 0.20, 10,     False,  5,  10]; // Fixed 12/7, #40
    'eb', 'edgeville bank':       Info := [MSCX + 50, MSCY,      4347490,  15,   0.32, 0.61, 100,   False,   10, 10]; // Fixed 12/7, #40
    'ctb', 'catherby bank':       Info := [MSCX,      MSCY,      3239049,  8,    0.20, 0.20, 500,   False,   10, 10];
    'clt', 'camelot bank':        Info := [MSCX,      MSCY,      7636882,  5,    0.20, 0.20, 500,   False,   10, 10];
    'nab', 'north ardougne bank': Info := [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10];
    'sab', 'south ardougne bank': Info := [MSCX,      MSCY,      4084572,  5,    0.20, 0.20, 500,   False,   10, 10];
    'ynb', 'yanille bank':        Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'ngb', 'north gnome bank':    Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'sgb', 'south gnome bank':    Info := [MSCX,      MSCY,      3239049,  7,    0.20, 0.20, 500,   False,   10, 10];
    'wgb', 'warrior guild bank':  Info := [MSCX,      MSCY,      2578286,  7,    0.20, 0.20, 500,   False,   10, 10];
    'fgb', 'fishing guild bank':  Info := [MSCX,      MSCY,      2908796,  10,   0.20, 0.20, 500,   False];
    else
    begin
      srl_Warn('OpenBankFast', 'Unknown bank: '+Location, warn_AllVersions);
      Exit;
    end;
  end;

I really dislike that. :(

-.-

Copy it to your scar and see it with fixed font, it's very readable, unless you dislike all excel sheets and stuff :p

Wanted

2009-12-12 11:51:58

Marpis! man, my script failed last night after 92 loads because OpenBankFast('vwb') doesn't work! :(

Even when I test vwb for openbankfast in it's on small test script it never works at all.

Update vwb pl0x?

WT-Fakawi

2009-12-12 12:01:41

I experienced something similar with the new OpenBank. All went well until ChooseOption refused to find "Use Quickly" and thus returned False. Sounds like a Font-issue to me.

Reverted to ye oldy OpenBankQuiet. Still works at Draynor…. after one-and-a-halve year lol.

Wanted

2009-12-12 12:04:09

From: WT-Fakawi
I experienced something similar with the new OpenBank. All went well until ChooseOption refused to find "Use Quickly" and thus returned False. Sounds like a Font-issue to me.

Reverted to ye oldy OpenBankQuiet. Still works at Draynor…. after one-and-a-halve year lol.

I use this in place of text functions

      Use := [];
      if (CountColorTolerance(14342657, 7, 7, 100, 25, 70) > 150) then
        Use := ['quick', 'uick', 'uic']
      else
        if (CountColorTolerance(648165, 7, 7, 100, 25, 50) > 100) then
          Use := ['ank B', 'nk B', 'k Ba'];
      if (Length(Use) > 0) then
      begin
        GetMousePos(OB.X, OB.Y);
        Mouse(OB.X, OB.Y, 0, 0, False);
        Wait(200 + Random(50));
        if (not (ChooseOptionMulti(Use))) then
          Continue;

If it's blue it uses ['quick', 'uick', 'uic'] if its yellow ['ank B', 'nk B', 'k Ba']

So maybe change 'use quickly' to ChooseOptionMulti(['quick', 'uick', 'uic']);

Btw: I'm running SCAR 2.32 beta, maybe that's the problem why your fonts aren't working?

Also, I really don't like WaitOption, WaitText ect.. functions.. they just piss me off whenever I use em.

marpis

2009-12-13 07:40:28

Updated, tested a couple of times in different places and compass angles, seems to work great now.
E: In open-dev ofc

Wanted

2009-12-13 12:39:44

Great job man, it's the perfect bank opening failsafe. :)

marpis

2009-12-13 12:42:49

From: IceFire908
Great job man, it's the perfect bank opening failsafe. :)

You offend me by using it as a "failsafe" ;)

Cigue

2009-12-22 23:28:38

Gaise, I am a bit confused, does this work with the text update?

Wanted

2009-12-22 23:38:11

From: Cigue
Gaise, I am a bit confused, does this work with the text update?

Open your SRL folder and, open bank.scar find openbankfast and replace isuptext('bank') or whatever with (CountColorTolerance(14342657, 7, 7, 100, 25, 70) > 150)