SRL Archive - Archive

miny noob - SRL Member Application


miny noob

2009-10-30 07:22:10

How Long have You Played Runescape?
8 Year(s)


Are you affilated in anyway with Jagex LTD?
Nope

Were you Referred to SRL?
-


What is your general programming knowledge?
A lil c++
And some pascal :)


Are you a member of any other communities?
Only a cod4 community, From New Zealand.
www.Affliction.net.nz


Tell us about yourself…
From: miny noob
Well, First off, Id just like to say sorry about my previous application, I didn't read the stickies. (I know right Im a noob?)

Well, Im Miny Noob, 16 years old, Living in New Zealand. Thats pretty much me, Oh and i pay a lot of computer games.

The reason Im here, An interesting one at that. Pretty much found this place by wanting scripts for scar, I found the best scripts around in this place. That was awhile ago, About a year I think.

I kind of drifted away from runescape, And pursued other things for awhile, And now i found myself back here, Again looking for the latest and greatest scripts. That when it all changed, See I went into irc one day when i as bored in class. I made some friends, And met some great people. I just want to be one of those great people :)

Oh please excuse my English, I edited it as well as i could, But Im not great with English.



Please show us one (or multiple) of your scripts.
program CabPower eater;
{.include SRL\SRL\misc\SMART.SCAR}
{.include srl/srl.scar}

const
SmartWorld = 152;//World to load.
Members = False;//Members?
SignedClient = True;//Used signed client?
HighDetail = False;//Use high detail?
CabbageColour1 = 4099179;// Use the darkest green on the cabbage(Seems to work best)
CabbageToEat = 1;// How many loads you want to drop?

var
CabbageEaten: Integer;
CabbagePicked: Integer;


Procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;

Players[0].Name :='';//Username
Players[0].Pass :='';//Pass
Players[0].Nick :='';//Nick
Players[0].Active:=True;
end;

procedure AntiBan;
begin
if(not(LoggedIn))then
Exit;
FindNormalRandoms;
case Random(8) of
0:
begin
HoverSkill('Range', false);
wait(2453+Random(432));
end;
1: PickUpMouse;
2:
begin
MakeCompass('N');
wait(100+random(133));
MakeCompass('S');
wait(50+random(133));
MakeCompass('N');
FindNormalRandoms;
end;
end;
end;

procedure PickCab;
var x, y: integer;
begin
if not LoggedIn then Loginplayer;
wait(100);
if LoggedIn then writeln('Logged in');
repeat
FindNormalRandoms;
MakeCompass('N');
if FindObj(x, y, 'ick', CabbageColour1, 5) then
Mouse(x, y, 0, 0, false);
ChooseOption('ick');
repeat
wait(400+random(250));
AntiBan;
inc(CabbagePicked)
Until not IsUpText('abbage') or (InvFull) or (CabbagePicked = CabbageToEat);
until(InvFull) or ( CabbagePicked = CabbageToEat );
end;

procedure EatCab;
var CabbageDTM, x, y: Integer;

begin
Repeat
GameTab(tab_Inv)
CabbageDTM := DTMFromString('78DA63BCC3CCC0A0CEC4800C2AE7B932F0036' +
'94620FE0F048C0F806A8C50D54064612490BE0254A34F40CD45A0' +
'1A45026A9E1156030057720AA0');
if findDTM (CabbageDTM, x, y, MIX1, MIY1, MIX2, MIY2)then
begin
Mouse(x, y, 10, 10, true);
inc( CabbageEaten );
wait(400+random(400))
end;
until ( CabbageEaten = CabbageToEat ) or not findDTM (CabbageDTM, x, y, MIX1, MIY1, MIX2, MIY2);
end;

procedure Report;

Begin
Writeln('You ate ' +IntToSTR(CabbageEaten)+ '/' +IntToSTR(CabbageToEat)+ '.');
If ( CabbageEaten = CabbageToEat ) then Writeln ('Grats bro you ate as many as you needed.');
Writeln ('Vote yes =D');
end;

begin
DeclarePlayers;
Smart_Server := SmartWorld;
Smart_Members := Members;
Smart_Signed := SignedClient;
Smart_SuperDetail := HighDetail;
SetUpSRL;
wait(300);
if not LoggedIn then Loginplayer;
AntiBan;
repeat
if (invfull) then exit;
PickCab;
EatCab;
until ( CabbageEaten = CabbageToEat )
report;
exit;
end.


{Thanks To
Simtoon for your banking tutorial.
JunkJ for your declare players tutorial.
I Pro Leeching for your tutorial
Griff721 for an awesome tutorial. Alot was learned from here cheers dude.
Bionicle for your radial walking tutorial
ZyphrsFury you also have an awesome tutorial.

I know I didn't use half this stuff in here, Im noting the good ones though :) }

Nava2

2009-10-30 12:09:39

Nope.. doesn't even compile.

Sorry, don't have time for an indepth response on this one.

JPHamlett

2009-10-30 13:24:18

no soory to simple

Kyle Undefined

2009-10-30 15:18:24

It's a no, like Nava said it doesn't even compile. Here is what needs to be fixed…

First of all, your program name should not contain spaces. So

program CabPower eater;
Needs to be

program CabPowerEater;

Your constants are alright, but you can move CabbageToEat to the declare players.

procedure DeclarePlayers;
begin
HowManyPlayers := 1;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;

Players[0].Name :='';//Username
Players[0].Pass :='';//Pass
Players[0].Nick :='';//Nick
Players[0].Active:=True;
Players[0].Integers[0] := 1; // How many loads to do
end;

Your vars can be made into one line, be sure to use correct standards so it's easier to read.

var
CabbageEaten: Integer;
CabbagePicked: Integer;
Can be made like

var
CabbageEaten : Integer;
Since both are Integers, you can list them on one line and separate them with commas.

Your AntiBan looks pretty good.

Your PickCab procedure needs some work, just some standards work and a little code tweaking.

var x, y: integer;
Should be

var
x, y : Integer;
Although the code still runs either way, it's just easier to read when scanning through. Same for this line

if not LoggedIn then Loginplayer;
Looks better like

if(not(LoggedIn))then
Loginplayer;
Same goes for the next line

if(LoggedIn)then
WriteLn('Logged in');

After and if…then statement, if you have the code do more than two things you need a begin and an end. Also, never use exact coordinate clicking, it will get you banned eventually.

if FindObj(x, y, 'ick', CabbageColour1, 5) then
Mouse(x, y, 0, 0, false);
ChooseOption('ick');
Should be

if(FindObj(x, y, 'ick', CabbageColour1, 5))then
begin
Mouse(x, y, 4, 4, False);
Wait(100 + Random(200));
ChooseOption('ick');
end;
Notice the "4, 4" where the zeros were, that means it will click 4 pixels off from where the color was found. Also, after you do a right click, you should wait about 100 milliseconds or more since it take SCAR ~100 milliseconds to recognize Uptext/options/etc.

Your inside repeat…until loop doesn't need that many conditions.

Until not IsUpText('abbage') or (InvFull) or (CabbagePicked = CabbageToEat);
Can be written as

until(not(IsUpText('abbage')));

Your outside loop looks fine, but you don't need the CabbageToEat to

until(InvFull);
Since you want to do loads, just repeat it until the inventory is full.

Now, I see your logic in the PickCab procedure, but you're a little off. You really only need one loop in there, here is how it can be shortened.

procedure PickCab;
var
x, y : Integer;
begin
FindNormalRandoms;
MakeCompass('N');
if(not(LoggedIn))then
Loginplayer;
Wait(100);
repeat
if(FindObj(x, y, 'ick', CabbageColour1, 5))then
begin
Mouse(x, y, 4, 4, False);
Wait(100 + Random(200));
ChooseOption('ick');
Wait(400 + Random(250));
AntiBan;
end;
until(InvFull);
end;
It will repeat finding and clicking the cabbage and waiting and increasing that var until the inventory is full.

Now, onto your EatCab procedure. Again, nothing major just standards. You put them all on one line, good job :)

var
CabbageDTM, x, y: Integer;

I would take the GameTab and CabbageDTM out of the repeat loop, otherwise you will keep clicking the inventory spot and declaring a DTM which will take up space.

Refrain from putting spaces in functions and procedures, it's just hard to read.

if(findDTM (CabbageDTM, x, y, MIX1, MIY1, MIX2, MIY2)then
Like

if(FindDTM(CabbageDTM, x, y, MIX1, MIY1, MIX2, MIY2))then

I see where you're headed with the CabbageEaten variable, but take out the increment. You want to do that in the main loop so it will act as loads done.

Always free your DTM when you're done using it. This is how your procedure will look after changing it

procedure EatCab;
var
CabbageDTM, x, y: Integer;
begin
GameTab(tab_Inv)
CabbageDTM := DTMFromString('78DA63BCC3CCC0A0CEC4800C2AE7B932F0036' +
'94620FE0F048C0F806A8C50D54064612490BE0254A34F40CD45A0' +
'1A45026A9E1156030057720AA0');
repeat
if(FindDTM(CabbageDTM, x, y, MIX1, MIY1, MIX2, MIY2))then
begin
Mouse(x, y, 10, 10, true);
Wait(400 + Random(400))
end;
until(not(FindDTM(CabbageDTM, x, y, MIX1, MIY1, MIX2, MIY2)));
FreeDTM(CabbageDTM);
end;

Onto your Report procedure. Since we got rid of the variable CabbageToEat, you need to replace it with

Writeln('You ate ' +IntToSTR(CabbageEaten)+ '/' +IntToSTR(Players[CurrentPlayer].Integers[0])+ '.');
That gets the current player that is logged in and gets the value that we set it to earlier. Same thing goes with your if…then statement.

Your main loop just needs some more standards work and and minor code tweaks. The first if…then needs to be standardized, I'm not going to post it since I have examples above.

Same thing with your second if…then statement.

Inside of your repeat…until is where you want to increment your CabbageEaten variable.

repeat
if(InvFull)then
Exit;
PickCab;
EatCab;
Inc(CabbageEaten);
until(CabbageEaten = Players[CurrentPlayer].Integers[0]);
Also needed to change the CabbageToEat to the current player. The exit; at the end is not needed.

Well that's all I could see that needed to be changed, hope this helps you on future scripts. Good luck :)

~Camo

Bionicle

2009-10-30 15:34:56

I think there is nothing more to say over what camo said.
(O_o)
sorry its a no, for all those reasons. Keep reading them tutorials!

YoHoJo

2009-10-30 15:41:39

Yeah Camo pretty much explained it all, but don't worry! Not many people get in on the first try, and thank you for even trying, I see potential in you! Just keep working hard and learning more! Here is a pre-prepared message for you:

Basic Beginner Scripting Tutorials:
http://www.villavu.com/forum/showthread.php?t=23133
http://www.villavu.com/forum/showthread.php?t=49089
http://www.villavu.com/forum/showthread.php?t=4625

And Here's the Entire Beginners Scripting Tutorial Section:
http://www.villavu.com/forum/forumdisplay.php?f=95

Guides on 'raising your rank' which go along with scripting better/attitude/ect:
http://www.villavu.com/forum/showthread.php?t=3562
http://www.villavu.com/forum/showthread.php?t=50475
http://www.villavu.com/forum/showthread.php?t=40470

YoHoJo

2009-10-30 15:59:52

From: NaumanAkhlaQ
Bundh Kuro Bhai!!!


1) Fkn ROFL
2) I want to give hm a chance to reply to the responses and whatnot before I close it.

Bionicle

2009-10-30 16:15:48

gah! double posting mod!
lolz<3

Kyle Undefined

2009-10-30 16:28:55

/me drops the banzhammer :/ Grr lol

~Camo

miny noob

2009-10-30 18:10:04

Thanks for the replys guys. Ill step my game up a bit.

rogeruk

2009-11-02 06:01:46

Sorry its a no.

Lack of failsafes and all what Camo' said

cycrosism

2009-11-03 03:41:43

no multiplayer
too simple antiban
no tpa's
no walking and radialwalk
no bitmaps (Only saw 1 DTM)
script too short

And, to be honest I don't see why anyone would ever need a script to pick and eat cabbage.

Keep trying though, don't give up. You have made a really good attempt.

Quickmarch

2009-11-03 05:02:36

Offtopic: Lol, I think you were the one who sent me a few PMs telling me to stop spamming, when I was a leecher that is. xD

It's a no from me. Too simple as said in the reasons above.

YoHoJo

2009-11-03 09:34:02

Alright Miny Noob, feedback recived.
Here is my list is helpful links:
Basic Beginner Scripting Tutorials:
http://www.villavu.com/forum/showthread.php?t=23133
http://www.villavu.com/forum/showthread.php?t=49089
http://www.villavu.com/forum/showthread.php?t=4625

And Here's the Entire Beginners Scripting Tutorial Section:
http://www.villavu.com/forum/forumdisplay.php?f=95

Guides on 'raising your rank' which go along with scripting better/attitude/ect:
http://www.villavu.com/forum/showthread.php?t=3562
http://www.villavu.com/forum/showthread.php?t=50475
http://www.villavu.com/forum/showthread.php?t=40470


Check them out, they will help you. Good luck next time buddy!