First of all: THANKS for the great feedback Baked!
Just because I stopped being member I decided to publish my script. It's out of the blue, without any "publish revising" on standards, adding multiplayer etc.
From: Baked0420
You should add multiplayer, some people might say no just because it doesn't support multiplayer which is a SRL golden rule.
I could do this, but in a members script… are there people who auto more members accounts? Pretty waste of your (real life) money, i'd guess… Just let every account do it's own script.
In climbdown, you have q:= 0, then:
if (not FindObjTPA(x,y,10791596 ,4,2,25,25,25*25-150,['limb'])) then
q:=1;
if (q=1) then
begin
if FindObjEx(x,y,['down'],[10791596 ],4,50,MSX1,MSY1,MSX2,MSY2) then
q:=0;
end;
if q=0 then
well what if it never found the first obj tpa? q would = 0 by default, no? either set q = to something else, like 5, at first, or have the last find obj tpa set q to something else other than 0. It may result true when it shouldn't have.
I guess no. I put q:=0.
The first if asks: if (not FindObjTPA(…)); So, if the finding fails,
not FindObjTPA() is true. Then, q:=1 and it will search using FindObjEx. is FindObjTPA succeeds, q remains 0 and the script will click accordingly.
I must agree, this can be scripted much smoother. However, I'm not member anymore, so I'm not going to do it :P
And why do you use FindObjTPA? you made your own TPA's earlier, why you ObjTPA when yuo can make your own? It'd look better in my opinion.
Hmm, the FindObjTPA function is in SRL, so why not use it?
I try first FindObjTPA , then FindObjEx. Still, ClimbDown fails occasionally. I've been working on it serveral times, and without SMART this now works properly. It's been a real pain in the bottoms for me though.
You never use result in WalkToLowStairs, it could just be a procedure.
Oh, you're right. Is a procedure faster?
I don't really like this:
if p=30 then
writeln('We may be not in the bank. Risky!');
Result:=True;
you should check if you are in the bank by checking for the bank symbol, or checking for something you know is only in the bank or something, if you might not be in the bank I don't think it should result true :p And in that same procedure, I don't know why you would repeat making the compass north for up to 30 times lol, call it once before the repeat.
You're pretty right, this was a left-over from my programming ventures, before the state defenitions. It wasn't really planned to stay. My apologies.
About the compass: yeah who cares :P? i persume MakeCompass first checks if the angle is already taken, so it hardly does anything in computational sense.
In this:
if Bankscreen then
begin
MouseBox(382,299,411,317,1);
wait(300+random(400));
if (StartAmount=-1) then StartAmount:=GetAmount(95, 95);
CurrentAmount:=GetAmount(95, 95);
StringsDone:=CurrentAmount-StartAmount;
FlaxToGo:=GetAmount(49, 94);
if ((not FindColorTolerance(x,y,10920520 ,30,80,100,160,3)) or (FlaxToGo < 10)) then
begin
Logout;
writeln('Out of Flax! Good job!');
TerminateScript;
end;
I think you need to call CloseWindow; before trying to logout.
Oh yeah, they changed that in a last update. The LogOut X is removed when in a bankscreen. I might just do that.
I like the antiban in the end of the bank procedure though, how it randomly closes bank sometimes and sometimes doesn't.
Could do the same with climbing up and down the stairs, using the SpecialChat instead of the RightClick.
In spinwheel, you have you failsafe noted, for if it doesn't find the spin wheel, it logs out, it's noted, so if it doesn't find it, it continues on with the procedure.
Again, some left-overs from the pre-"stage definition"-time. My apologies. Now, when SpinWheel fails, the script will find GetInfo=3 and it will all work out.
I have no clue, but when you level up, if it stops spinning you need to make it start spinning again, unless it stats spinning again after clicking the pop-up box which it looks like you have it do.
It does, I checked it.
Just a few things you could fix up, after you add multiplayer, since you have TPA's there's a chance you could get members, but I would suggest learning DDTM's and using that for your walking, then it would almost definitely be a yes, if you used DDTM's to walk. Multiplayer, TPA's, and DDTM's, that's what most people like to see. Fix some standards, like in setup, there's a bunch of unneeded spaces, taking up more lines then you need to. But I like this script, I would probably vote yes.
Thank you, I'll have a look at DDTM's for my next script: Some auto-fighter/prayer trainer :) You can use pretty much every approach in pretty much every script, whatever you would like to program. Ill keep your advice in mind.
About standards: Lol, theyre very important, i know. But as i'm not applying, i dont
really care :).
About randomness: I checked them all, it shouldn't create a problem, since there is always a function after the wait which involves randomness. But eventually randomness is better indeed.
Once again: Really THANKS! :) It's good to know I'm on the right track.