SRL Archive - SRL Bugs

Potential endless loop in login function


barbarianl3t

2009-09-23 23:14:18

I think it's here


function RSReady: Boolean;
begin
Result := (LoggedIn) or (GetColor(520, 146) = 4038981);
end;


procedure LoginPlayer;
...
Line-354 repeat

Code that makes the thing login

Line-398 until (GetColor(207, 409) = 238301) or (LoggedIn);
The GetColor(207,409) = 238301 is refering to the yellow click box.
Because the new tutorial doesn't officially appear to satisfy the (LoggedIn) part it is a endless loop.



I'm not sure if it is an endless loop or not but when playing runescape without the little play button after logging in the script ignores all actions aftwerwards. I think when it doesn't find the yellow Click Here to Play button it goes into an endless loop. The only example I have of this happening is in the tutorial/ a new guy. It logins fine but the script doesn't move past the point where it logs in.

JPHamlett

2009-09-24 00:00:14

just take that paort out of it and name it loginplayer2

barbarianl3t

2009-09-24 06:50:21

That's a way to get around the bug but the problem is that there still could be a potential never ending loop in the Login Player function in SRL, something taught never to be done in the beginner tutorials.

(Edit) Doing what you said J_Pizzle would be getting rid of one of the best failsafes there is. If the character didn't log in correctly you would never know making the login; "less" precise. (/edit)

(I have looked through the Login procedure and think that i see the problem)

I think it's here


function RSReady: Boolean;
begin
Result := (LoggedIn) or (GetColor(520, 146) = 4038981);
end;


procedure LoginPlayer;
...
Line-354 repeat

... Code stuff that I don't get...

Line-398 until (GetColor(207, 409) = 238301) or (LoggedIn);
The GetColor(207,409) = 238301 is refering to the yellow click box.
Because the new tutorial doesn't officially appear to satisfy the (LoggedIn) part it is a endless loop.

barbarianl3t

2009-10-09 22:47:41

Does anybody recognize else recognize this problem? I find it kindof funny that every tutorial seems to preach DO NOT USE ENDLESS loops but we have a (semi)-endless loop. I call it semi endless because it does quit after three minutes I think but doesn't recognize it logged in.