SRL Archive - MSI Suggestions

Took a while…

Const
  { Abbreviations:
    - FS: Fishing Spot
    - GS: General Store
    - GE: Grand Exchange
    - VE: Varrock East
    - VW: Varrock West
    - FW: Falador West
    - FE: Falador East
    - V: Volcan
    - SO: Stronghold Of *
    - AK: Al Kharid
    - SW: Spinning Wheel  }
    
    
  {Cities' Index}
  City_Varrock     =   0;
  City_Falador     =   1;
  City_Karamja     =   2;
  City_Rimmington  =   3;
  City_Edgeville   =   4;
  City_BarbVillage =   5;
  City_Draynor     =   6;
  City_AlKharid    =   7;
  City_Lumbridge   =   8;
  
  {Places' Index}

  {Varrock}
  Loc_VEBank       =   0;
  Loc_VWBank       =   1;
  Loc_GEBank       =   2;
  Loc_VEMine       =   3;
  Loc_VWMine       =   4;
  Loc_GEYew        =   5;
  Loc_ChurchYew    =   6;
  Loc_VETree1      =   7;
  Loc_VETree2      =   8;
  Loc_VWTree       =   9;
  Loc_CastleGuards =   10;
  Loc_Dummy        =   11;
  Loc_Dungeon      =   12;
  Loc_DarkWizards  =   13;
  Loc_Anvil        =   14;
  Loc_WheatField   =   15;
  Loc_AuburyShop   =   16;
  Loc_EarthAltar   =   17;
  Loc_Sawmill      =   18;
  Loc_Aphotecary   =   19;
  
  {Falador}
  Loc_FWBank       =   20;
  Loc_FEBank       =   21;
  Loc_MiningGuild  =   22;
  Loc_FWWaterPump  =   23;
  Loc_Furnace      =   24;
  Loc_DwarfMine    =   25;
  Loc_WhiteKnights =   26;
  Loc_SouthYew1    =   27;
  Loc_SouthYew2    =   28;
  Loc_SouthYew3    =   29;
  Loc_Cows         =   30;
  Loc_Chickens     =   31;
  Loc_AirAltar     =   32;
  Loc_CraftGuild   =   33;

  {Karamja}
  Loc_MainDock     =   34;
  Loc_GeneralStore =   35;
  Loc_FishingDock  =   36;
  Loc_Jungle       =   37;
  Loc_VDungeon     =   38;

  {Rimmington}
  Loc_RimmyMine    =   39;
  Loc_Yew1         =   40;
  Loc_Willows1     =   41;
  Loc_Trees1       =   42;
  Loc_RimmyGS      =   43;
  Loc_Trees2       =   44;
  Loc_Willows2     =   45;
  Loc_FishingSpot  =   46;
  Loc_Cookery      =   47;
  
  {Edgeville}
  Loc_Bank         =   48;
  Loc_Yews1        =   49;
  Loc_Yews2        =   50;
  Loc_CookStove    =   51;
  Loc_Monastery    =   52;
  
  {Barbarian Village}
  Loc_BarbMine     =   53;
  Loc_SOSecurity   =   54;
  Loc_Trees        =   55;
  Loc_BarbFSpot    =   56;
  Loc_BodyAltar    =   57;
  Loc_Evergreen    =   58;
  Loc_SOSafety     =   59;
  Loc_BarbBar      =   60;
  
  {Draynor Village}
  Loc_DraynorBank  =   61;
  Loc_DraynorFS    =   62;
  Loc_DraynorOak   =   63;
  Loc_WizardTower  =   64;
  Loc_DraynorYew1  =   65;
  Loc_DraynorYew2  =   66;
  Loc_DraynorYew3  =   67;
  Loc_DraynorMine  =   68;
  Loc_LumbySwamp   =   69;
  Loc_WaterAltar   =   70;
  Loc_DraynorDung  =   71;
  
  {Al Kharid}
  Loc_AKBank       =   72;
  Loc_AlKharidFS   =   73;
  Loc_AKWarriors   =   74;
  Loc_AKFurnace    =   75;
  Loc_Tanner       =   76;
  Loc_AKCookStove  =   77;
  Loc_FireAltar    =   78;
  Loc_AlKharidMine =   79;
  Loc_LumbyCows    =   80;
  
  {Lumbridge}
  Loc_LumbyBank    =   81;
  Loc_CastleTrees  =   82;
  Loc_DukeHoracio  =   83;
  Loc_LumbySwamp2   =   84;
  Loc_LumbyMine    =   85;
  Loc_LumbyFS      =   86;
  Loc_LumbyCS      =   87;
  Loc_LumbySW      =   88;
  Loc_CombatTutors =   89;
  Loc_LumbyFurnace =   90;
  Loc_LumbyFS2     =   91;
  Loc_Goblins      =   92;
  Loc_FredFarmer   =   93;

Tell me if there is something missing before I commit.

I'd suggest a list of what each abbreviation is.

also,
Loc_LumbySwap2 = 84;

I guess you meant swamp ?

~RM

Fixed and updated. Also note that in SCAR the constants look fenced like proggies. eg:

Const
  ABC    =  123;
  DEF    =  456;
  GHI    =  789;

Loc_RimmyGS      =   43;
Loc_GeneralStore =   35;

Loc_BarbFSpot    =   56;
Loc_FishingSpot  =   46;
Loc_AlKharidFS   =   73;
Loc_LumbyFS      =   86;

Loc_LumbyCS      =   87;
Loc_AKCookStove  =   77
Loc_CookStove    =   51;
Loc_Cookery      =   47;

I think you should use the same naming scheme for all, otherwise instead of making it easier for us, it makes it harder.

Loc_AK_CS
Loc_LB_CS
Loc_EV_CS
Loc_BV_CS

ak = Al kharid
LB = Lumby
EV = EdgeVille
BV = Barbarian Village.

just leave a list of the abreviations and name the stuff that way (for all of them) as it'll make it easier in the end, so names don't get repeated.

~RM

Done. This is what I committed:

{==============================================================================\
|                         MSI Group Scripting Include                          |
|                                Walking.scar                                  |
|==============================================================================|
| For All walking and repositioning routines                                   |
|                                                                              |
 \_____________________________________________________________________________}
 
Const
  { Abbreviations:
    - FS: Fishing Spot
    - GS: General Store
    - GE: Grand Exchange
    - VE: Varrock East
    - VW: Varrock West
    - FW: Falador West
    - FE: Falador East
    - CG: Castle Guards
    - DW: Dark Wizards
    - V: Volcan
    - SO: Stronghold Of *
    - AK: Al Kharid
    - SW: Spinning Wheel
    - LB: Lumby
    - EV: EdgeVille
    - BV: Barbarian Village}
    
    
  {Cities' Index}
  City_Varrock     =   0;
  City_Falador     =   1;
  City_Karamja     =   2;
  City_Rimmington  =   3;
  City_Edgeville   =   4;
  City_BarbVillage =   5;
  City_Draynor     =   6;
  City_AlKharid    =   7;
  City_Lumbridge   =   8;
  
  {Places' Index}

  {Varrock}
  Loc_VEBank       =   0;
  Loc_VWBank       =   1;
  Loc_GEBank       =   2;
  Loc_VEMine       =   3;
  Loc_VWMine       =   4;
  Loc_GEYew        =   5;
  Loc_ChurchYew    =   6;
  Loc_VETree1      =   7;
  Loc_VETree2      =   8;
  Loc_VWTree       =   9;
  Loc_VarrockCG    =   10;
  Loc_VE_Dummy     =   11;
  Loc_VE_Dungeon   =   12;
  Loc_VarrockDW    =   13;
  Loc_VW_Anvil     =   14;
  Loc_WheatField   =   15;
  Loc_AuburyShop   =   16;
  Loc_EarthAltar   =   17;
  Loc_Sawmill      =   18;
  Loc_Aphotecary   =   19;
  
  {Falador}
  Loc_FWBank       =   20;
  Loc_FEBank       =   21;
  Loc_MiningGuild  =   22;
  Loc_FWWaterPump  =   23;
  Loc_FW_Furnace   =   24;
  Loc_DwarfMine    =   25;
  Loc_WhiteKnights =   26;
  Loc_SouthYew1    =   27;
  Loc_SouthYew2    =   28;
  Loc_SouthYew3    =   29;
  Loc_FallyCows    =   30;
  Loc_Chickens     =   31;
  Loc_AirAltar     =   32;
  Loc_CraftGuild   =   33;

  {Karamja}
  Loc_MainDock     =   34;
  Loc_KaramjaGS    =   35;
  Loc_FishingDock  =   36;
  Loc_Jungle       =   37;
  Loc_VDungeon     =   38;

  {Rimmington}
  Loc_RimmyMine    =   39;
  Loc_Yew1         =   40;
  Loc_Willows1     =   41;
  Loc_Trees1       =   42;
  Loc_RimmyGS      =   43;
  Loc_Trees2       =   44;
  Loc_Willows2     =   45;
  Loc_FishingSpot  =   46;
  Loc_Cookery      =   47;
  
  {Edgeville}
  Loc_EVBank       =   48;
  Loc_EVYews1      =   49;
  Loc_RVYews2      =   50;
  Loc_EV_CS        =   51;
  Loc_Monastery    =   52;
  
  {Barbarian Village}
  Loc_BVMine       =   53;
  Loc_SOSecurity   =   54;
  Loc_BVTrees      =   55;
  Loc_BV_FS        =   56;
  Loc_BodyAltar    =   57;
  Loc_BVEvergreen  =   58;
  Loc_SOSafety     =   59;
  Loc_BVBar        =   60;
  
  {Draynor Village}
  Loc_DraynorBank  =   61;
  Loc_DraynorFS    =   62;
  Loc_DraynorOak   =   63;
  Loc_WizardTower  =   64;
  Loc_DraynorYew1  =   65;
  Loc_DraynorYew2  =   66;
  Loc_DraynorYew3  =   67;
  Loc_DraynorMine  =   68;
  Loc_LumbySwamp   =   69;
  Loc_WaterAltar   =   70;
  Loc_DraynorDung  =   71;
  
  {Al Kharid}
  Loc_AKBank       =   72;
  Loc_AK_FS        =   73;
  Loc_AKWarriors   =   74;
  Loc_AKFurnace    =   75;
  Loc_AKTanner     =   76;
  Loc_AK_CS        =   77;
  Loc_FireAltar    =   78;
  Loc_AKMine       =   79;
  Loc_LBCows       =   80;
  
  {Lumbridge}
  Loc_LBBank       =   81;
  Loc_CastleTrees  =   82;
  Loc_DukeHoracio  =   83;
  Loc_LBSwamp2     =   84;
  Loc_LBMine       =   85;
  Loc_LB_FS        =   86;
  Loc_LB_CS        =   87;
  Loc_LB_SW        =   88;
  Loc_CombatTutors =   89;
  Loc_LBFurnace    =   90;
  Loc_LB_FS2       =   91;
  Loc_LBGoblins    =   92;
  Loc_FredFarmer   =   93;

{******************************************************************************}
{ Function SetUpWalk(City, WhereTo: integer): TWalk;                           }
{ By: Rasta Magician                                                           }
{ Rev: 1                                                                       }
{ Date: 13 Sep 09                                                              }
{ Description: Returns a TWalk, depending on City and desired destination      }
{******************************************************************************}