SRL Archive - RS3 Outdated / Broken Scripts

Smartest Karamja Fisher!

Hai everybody, I decided to learn reflection and make a script!-(i know color already :p)- So I made this karamja fisher and seller for DA leechers :P. This script is currently in the alpha stages, so it needs testing. You'll notice a lot of the script is commented out, due to changes :rolleyes:. So please everyone post progress reports and comments discussing the script.


Setup:

- Setup players at karamja dock, with their chats to how you like :P.
- Make sure each and every one of them has a harpoon or lobster pot,
- In the declareplayers, 'age' = cage fishing, 'arpoon' = harpoon fishing..
I would have made that into a simple boolean but im too lazy right now.

Version History:

{----------------------------------------------------------------------------------------------------------------------------------------------------------------}
Version History:
{{----------------------------------------------------------------------------------------------------------------------------------------------------------------}
Version History:
{----------------------------------------------------------------------------------------------------------------------------------------------------------------}
'1.0' : - First version.
        - 303 lines.
        - Walking was broken.
        - Selling was half-broken, wouldn`t sell the fish, only find the shopkeeper and open the screen.
        - Fishing was working. :D
        - Fish Counting and Load count was done.
        - No progress report.
{----------------------------------------------------------------------------------------------------------------------------------------------------------------}
'2.0' : - Second version, [PARTIAL] revamp of original.
        - YAY we surpassed 400 lines.
        - Fixed walking to pefection. (-I think :P-)...
        - Fixed Selling.
        - Small edit to fishing func.
        - Fish count and Load count was modified.
        - Added small vague proggy :P.
        - New func : RCompass : Changes compass randomly and sets its back to north.
        - New func : WhilstFishing : Assures that the player will always be fishing.
        - Used MouseSpeed change, to speed up selling.
        - Commented out DebugPath.
        - Removed DoneLoad as it wasn`t necessary.
{----------------------------------------------------------------------------------------------------------------------------------------------------------------}
'2.1' : - Fixed some nasty runtime error occuring in gametab :S
{----------------------------------------------------------------------------------------------------------------------------------------------------------------}
'2.2' : - Added Tad`s uber walking functions, script should be flawless now.
         - Proggy is broken :S.
{----------------------------------------------------------------------------------------------------------------------------------------------------------------}
'2.21': - Fixed walking and proggy, thanks to Pure1993.
{----------------------------------------------------------------------------------------------------------------------------------------------------------------}

Sample Proggy:
Note : looks wayyy neater in scar'
[php]==============================================================|
|+——————-Made By: Smarter Child—————– +|
| Script has ran for: 6 Minutes and 23 Seconds |
| Script has done: 1 loads |
| Script has caught: 25 fish |
| Script has switched: 0 times |
|————————————————————–|
| ****: Done: 1 loads, Caught: 0 Tuna, 25 Lobsters, 0 Swordies |
|————————————————————–|
| Post all proggies/comments/suggestions/bugs on script thread |
|==============================================================|
[/php]

Enjoy!!


BUGS~
-When fishing, it sometimes click the spot again, even though your currently fishing
-Omg new bug, you might get runtime error in gametab, idk why exactly though :s, please download newest version..
-Sometimes clicks spot even if your inventory is full, don't worry about this, the script will re-calibrate itself ;).

Update: New walk function, should make script flawless and able to run longer, big credits to Tad for his path walking function, download new version pl0x :D
NEW VERSION~~

Proggies, i still have to get some :p
Edit: Got 1 short proggy, cuz my computer is bitching at me.

|==============================================================|
|+-------------------Made By: Smarter Child----------------- +|
|              Script has ran for: 50 Minutes and 5 Seconds                   |
|              Script has done: 7 loads                        |
|              Script has caught: 168 fish                       |
|                        Script has switched: 0 times                      |
|--------------------------------------------------------------|
| ***: Done: 7 loads, Caught: 0 Tuna, 168 Lobsters, 0 Swordies    |
|--------------------------------------------------------------|
| Post all proggies/comments/suggestions/bugs on script thread |
|==============================================================|

Looks good, I'll save this spot for a proggie :)
EDIT: I don't know if this was an error on the script's part or maybe my computer did something too but when the time came to sell the lobbies, the program continually wanted to click the run icon when ever it had just one point and run around the store for about three minutes. It was very nice how it corrected itself eventually but the proggie:
|==============================================================|
|+——————-Made By: Smarter Child—————– +|
| Script has ran for: 22 Minutes and 37 Seconds |
| Script has done: 50 loads |
| Script has caught: 1300 fish |
| Script has switched: 0 times |
|————————————————————–|
| rues: Done: 50 loads, Caught: 0 Tuna, 1300 Lobsters, 0 Swordies |
|————————————————————–|
| Post all proggies/comments/suggestions/bugs on script thread |
|==============================================================|
can be a little misleading xD
I'll be sure to post a better one later!

Looks pretty nice, good job ;)

You left your password in the latest version, I changed it and PMed the new one to you.

|==============================================================|
|+——————-Made By: Smarter Child——————-+|
| Script has ran for: 41 Minutes and 0 Seconds |
| Script has done: 13 loads |
| Script has caught: 340 fish |
| Script has switched: 0 times |
|————————————————————–|
|sica: Done: 13 loads, Caught: 0 Tuna, 340 Lobsters, 0 Swordies|
|————————————————————–|
| Post all proggies/comments/suggestions/bugs on script thread |
|==============================================================|

Nice proggies, any suggestions? I think the walking is fail atm xD
Edit: NEW VERSION, PLEASE REDOWNLOAD 2.2.
Edi2: script is flawless, although proggy is messed up in 2.2, will have fix soon :)

Very nice ;] i might abuse this someday. good luck trying to get me to post a proggy though xP

From: lancerawks aka Lance
Very nice ;] i might abuse this someday. good luck trying to get me to post a proggy though xP

lmfao that's mean :D

testing it out now

From: xking
lmfao that's mean :D

testing it out now

Oh no, Lance means it in a friendly way ;).

its running as i'm typing this. i have noticed that its slightly buggy when it comes to finding the shop owner. it keeps waking in and out of the shop. it might be just for me though. apart ffrom that this looks like a brilliant script. its very lazy/boored human like, which is ideal as its a power fisher. brilliant anti-ban aswell. oh almost for got the progress report, as mentioned by owner it need fixing. but apart from that its really good. i'm using it on my second main, just to give you an idea how much i like it. heres the current progress report and i will post more as time goes on:

|==============================================================|
|+-------------------Made By: Smarter Child----------------- +|
|              Script has ran for: 13 Minutes and 6 Seconds                   |
|              Script has done: 45 loads                        |
|              Script has caught: 1170 fish                       |
|                        Script has switched: 0 times                      |
|--------------------------------------------------------------|
| iya: Done: 45 loads, Caught: 0 Tuna, 1170 Lobsters, 0 Swordies    |
|--------------------------------------------------------------|
| Post all proggies/comments/suggestions/bugs on script thread |
|==============================================================|

|==============================================================|
|+——————-Made By: Smarter Child—————– +|
| Script has ran for: 1 Hours, 1 Minutes and 49 Seconds |
| Script has done: 146 loads |
| Script has caught: 3796 fish |
| Script has switched: 0 times |
|————————————————————–|
| iya: Done: 146 loads, Caught: 0 Tuna, 3796 Lobsters, 0 Swordies |
|————————————————————–|

script terminated inside the shop with a full inv and no shop screen. i guess it couldnt find the sk.

|==============================================================|
|+-------------------Made By: Smarter Child----------------- +|
|              Script has ran for: 2 Hours, 53 Minutes and 24 Seconds                   |
|              Script has done: 323 loads                        |
|              Script has caught: 8398 fish                       |
|                        Script has switched: 0 times                      |
|--------------------------------------------------------------|
| iya: Done: 323 loads, Caught: 0 Tuna, 8398 Lobsters, 0 Swordies    |
|--------------------------------------------------------------|
| Post all proggies/comments/suggestions/bugs on script thread |
|==============================================================|
[Runtime Error] : Out Of Range in line 281 in script C:\Users\Ahmed\AppData\Local\Temp\Karamja Fisher & Seller 2.2.scar

the script terminated while i was out in the garden. once i logged back in he was stood ourside the shop with full inv.

Nice proggy, Ahmed, ill see wats wrong. (+Im arab(muslim)+) too :p

Yah i also have to fix counting it worked in previous version but latest has good walking and thats all i changed :confused:

Edit: Yes, i think i did good job with the antiban ;).

Lmao whats with all those proggies being f@k#d up?

13 minutes and 1k fish bs lol ill post a real -proggy for you Smarter child

Sorry for idiot question: How i can run that script ? :(

Proggy, is broken, and i might have to use a color alternative to the counting, such as ItemAmount. Martinike, download SRL include and make sure you reflection dev svn latest, check the wiki ;).

Loaded all chars. (NPCChars, TradeChars, SmallChars, StatChars, UpChars)
Include file C:\Program Files\SCAR 3.12\includes\SRL\SRL\Misc\Smart.Scar does not exist.
Include file C:\Program Files\SCAR 3.12\includes\SRL\SRL.Scar does not exist.
Include file C:\Program Files\SCAR 3.12\includes\SRL\SRL\Reflection\Reflection.Scar does not exist.
Failed when compiling

Help :(

As for your proggy problem, here is why it is happening:

function R_WalkPath(Path: TPointArray; Randomness: Integer): boolean;
var
  i, t, l, fails: integer;
  NTile, D : TPoint;
begin
  NTile := NextTile(Path, 10);
  i := TileToIndex(NTile, Path);
  fails := 0;
  l := GetSystemTime;
  while (i < High(Path)) and (fails < 20) do
  begin
   // AntiRandoms;
    if (Path[i].x = Path[i+1].x) and (Path[i].y = Path[i+1].y) then
    begin
      Inc(i);
      Continue;
    end;
    t := GetSystemTime;
    while not (NextGoodTile(Path, i, NTile)) and (GetSystemTime - t < 20000) do
      wait(200+random(100));
    if NextGoodTile(Path, i, NTile) then
      if WalkToTile(NTile, Randomness, 17+random(10)) then
        i := TileToIndex(NTile, Path)
      else
        Inc(fails)
    else
      Inc(fails);
  end;
  result := fails < 20;
  if result then
  begin
    MarkTime(t);
    if not GetFlag(D) then Exit;
    repeat
      if not GetFlag(D) then break;
      if DistanceFrom(D) < 2 then break; //REMOVE THIS
      if not CharacterMoving then break;
    until(TimeFromMark(t) > 30000);
  end;
end;

Procedure Loop;
begin
  Players[CurrentPlayer].Integers[6] := 0;
  SetPos('Both');
  WhilstFishing;
  if InvFull then
  begin
    CountFish;
    Proggy;
    R_WalkPath(ShopPath, 2);
   // WalkToTile(Point(2907, 3148), 1, 0);
    if isidle then // problem is here ;)
    begin
      SellFish;
      MouseSpeed := 15;
      Proggy;
      R_WalkPath(DockPath, 2);
      Switch;
    end;
  end;
end;

IsIdle <> GetFlag(D)
IsIdle = not CharacterMoving;

It will count the fishes quite often… and it is also the core of most walking problems which have been mentioned here. ;)

Thanks Pure1993!

########### NEW VERSION ###############
########### Version ###############
########### 2.21 ###############

Seems to work OK. Will post prog soon :)

It works? Well if you get proggy, post it, and i can fix all the bugs.

some of these proggys seem really off tbh

is this working at the moment?

From: mizuno
is this working at the moment?

D: Again, test the script. Your posts will be considered spam with punishment if you keep this up. I won't report you for now, but please try not to spam like this. :)

thanks for this!

going to try it after i try a few other scripts i got.

stocking up on scripts atm while i learn about SCAR

Actually, this script is kinda outdated atm, when reflection is completely updated. This script will be updated, I will probably make one that also banks for junior members ;)

Looks good, going to test now

Looks Good!

Thanks for this. Will definitely use it.

Great Job!

Attention Spammers and Leechers…

http://www.villavu.com/forum/showthread.php?t=18341

~RAM

From: Smarter Child
Actually, this script is kinda outdated atm, when reflection is completely updated. This script will be updated, I will probably make one that also banks for junior members ;)

From: getslotownlost
Looks good, going to test now

From: Kavz
Looks Good!

Thanks for this. Will definitely use it.

I think I'll close this now and give the leecher's one less place to post…. Smarter child, Please PM a staff member to reopen if you decide to update…

~RAM