SRL Archive - Archive

How Long have You Played Runescape?
5 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?



What is your general programming knowledge?
Just Scar


Are you a member of any other communities?
No


Tell us about yourself…

From: Goodpeople
Ive been working hard on this script, and I hope you enjoy :D

Please show us one (or multiple) of your scripts.

program Ranged_Barb_Killer;
{.include SRL\SRL.scar}

var
  Eat, Kills, KillTime,  AttType, MonsterColour1, TimeKill: Integer;
  MonsterColour2:  integer;
  PickUpArrows, GetFood, BarbarianLoop: Boolean;
  FoodType: Byte;

function FindBarbHallColor: Integer; Forward;
function Antiban: Integer; Forward;
function GetArrows: Integer; Forward;
function EatFood: Integer; Forward;

procedure SetUpVars;
begin
  TimeKill     := 5000+random(250);
  AttType      := 2     // 1= range 2= melee
  Eat          := 30;   // What Hp You want to Eat at.
  Kills        := 100;  // How many kills you want before the script ends.
  PickUpArrows := False; // Do You Wish to Pick Up Arrows?
  FoodType     := 1;    // Currently Only supports Salmon. 1 = Salmon
  GetFood      := True; //Walk Back To EdgeVille to Get Food?
  BarbarianLoop:= False; // This script features a loop where you can start in
  //barbarian hall, and then bank for food, then come back. It can also be used
  //as a normal autofighter.
  MonsterColour1:= 4285742;  // leave these blank if barbarian loop = true.
  MonsterColour2:= 2719910;
end;

const
  YourSRLID = '';
  YourSRLPass = '';
  MonsterName = '';

procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  SRLID       := YourSRLID;
  SRLPassword := YourSRLpass;

  Players[0].Name := '';
  Players[0].Pass := '';
  Players[0].Nick := '';
  Players[0].Active := True;

  SetPlayerNameTPAs;
end;

var
x, y, HP, ArrowsDTM, SalmonDTM: integer;
Total, Gained, Foodies: integer;

procedure ReportIt;
begin
  WriteLn('| Goodpeoples Pure Trainer');
  WriteLn(' --------------------------');
  WriteLn('|- Script has Ran For |' + TimeRunning + '|');
  WriteLn('|- has Killed A Total Of |' + IntToStr(Total) + '| out of |' + IntToStr(Kills) + '| Monsters');
  WriteLn('|- Has Eaten |' + IntToStr(Foodies) + '| Salmon');
  WriteLn('|- Total Levels Gained |' + IntToStr(Gained) + '| Levels');
  WriteLn(' -------------------------');
end;

procedure LoadDTMs;
begin
 ArrowsDTM := DTMFromString('78DA6354636660D8CCC8800C22CCB81994813' +
   '44C94D100A86603AA1A902C8A1A2DA09ADD04D4C800D56CC1AF06009' +
   'E6F04AF');
 SalmonDTM := DTMFromString('78DA63E4636660D8C1C8800C9E06C83128036' +
   '99828A30450CD2A543520591435C298E660A86105AAD98E5F0D00D73' +
   '2050A');
end;

Function SetDDTM(WalkNumber: Integer): integer;
var
  dtmMainPoint: TDTMPointDef;
  dtmSubPoints: Array [0..3] of TDTMPointDef;
  TempTDTM: TDTM;

begin
  case WalkNumber of
  1:
  begin
    dtmMainPoint.x := 743;
    dtmMainPoint.y := 201;
    dtmMainPoint.AreaSize := 0;
    dtmMainPoint.AreaShape := 0;
    dtmMainPoint.Color := 6118500;
    dtmMainPoint.Tolerance := 50;

    dtmSubPoints[0].x := 743;
    dtmSubPoints[0].y := 201;
    dtmSubPoints[0].AreaSize := 0;
    dtmSubPoints[0].AreaShape := 0;
    dtmSubPoints[0].Color := 6118500;
    dtmSubPoints[0].Tolerance := 50;

    dtmSubPoints[1].x := 739;
    dtmSubPoints[1].y := 195;
    dtmSubPoints[1].AreaSize := 0;
    dtmSubPoints[1].AreaShape := 0;
    dtmSubPoints[1].Color := 62965;
    dtmSubPoints[1].Tolerance := 50;

    dtmSubPoints[2].x := 746;
    dtmSubPoints[2].y := 196;
    dtmSubPoints[2].AreaSize := 0;
    dtmSubPoints[2].AreaShape := 0;
    dtmSubPoints[2].Color := 195836;
    dtmSubPoints[2].Tolerance := 50;

    dtmSubPoints[3].x := 747;
    dtmSubPoints[3].y := 205;
    dtmSubPoints[3].AreaSize := 0;
    dtmSubPoints[3].AreaShape := 0;
    dtmSubPoints[3].Color := 60909;
    dtmSubPoints[3].Tolerance := 50;

    TempTDTM.MainPoint := dtmMainPoint;
    TempTDTM.SubPoints := dtmSubPoints;
    Result := AddDTM(TempTDTM);
  end;
  2:
  begin
    dtmMainPoint.x := 735;
    dtmMainPoint.y := 257;
    dtmMainPoint.AreaSize := 0;
    dtmMainPoint.AreaShape := 0;
    dtmMainPoint.Color := 3155950;
    dtmMainPoint.Tolerance := 0;

    dtmSubPoints[0].x := 735;
    dtmSubPoints[0].y := 257;
    dtmSubPoints[0].AreaSize := 0;
    dtmSubPoints[0].AreaShape := 0;
    dtmSubPoints[0].Color := 3155950;
    dtmSubPoints[0].Tolerance := 0;

    dtmSubPoints[1].x := 741;
    dtmSubPoints[1].y := 251;
    dtmSubPoints[1].AreaSize := 0;
    dtmSubPoints[1].AreaShape := 0;
    dtmSubPoints[1].Color := 721153;
    dtmSubPoints[1].Tolerance := 0;

    dtmSubPoints[2].x := 738;
    dtmSubPoints[2].y := 260;
    dtmSubPoints[2].AreaSize := 0;
    dtmSubPoints[2].AreaShape := 0;
    dtmSubPoints[2].Color := 721153;
    dtmSubPoints[2].Tolerance := 0;

    TempTDTM.MainPoint := dtmMainPoint;
    TempTDTM.SubPoints := dtmSubPoints;
    Result := AddDTM(TempTDTM);
  end;
  3:
  begin
    dtmMainPoint.x := 760;
    dtmMainPoint.y := 282;
    dtmMainPoint.AreaSize := 0;
    dtmMainPoint.AreaShape := 0;
    dtmMainPoint.Color := 1016577;
    dtmMainPoint.Tolerance := 50;

    dtmSubPoints[0].x := 760;
    dtmSubPoints[0].y := 282;
    dtmSubPoints[0].AreaSize := 0;
    dtmSubPoints[0].AreaShape := 0;
    dtmSubPoints[0].Color := 1016577;
    dtmSubPoints[0].Tolerance := 50;

    dtmSubPoints[1].x := 756;
    dtmSubPoints[1].y := 288;
    dtmSubPoints[1].AreaSize := 0;
    dtmSubPoints[1].AreaShape := 0;
    dtmSubPoints[1].Color := 721153;
    dtmSubPoints[1].Tolerance := 50;

    dtmSubPoints[2].x := 765;
    dtmSubPoints[2].y := 287;
    dtmSubPoints[2].AreaSize := 0;
    dtmSubPoints[2].AreaShape := 0;
    dtmSubPoints[2].Color := 721153;
    dtmSubPoints[2].Tolerance := 50;

    TempTDTM.MainPoint := dtmMainPoint;
    TempTDTM.SubPoints := dtmSubPoints;
    Result := AddDTM(TempTDTM);
  end;
  4:
  begin
    dtmMainPoint.x := 779;
    dtmMainPoint.y := 202;
    dtmMainPoint.AreaSize := 0;
    dtmMainPoint.AreaShape := 0;
    dtmMainPoint.Color := 1495013;
    dtmMainPoint.Tolerance := 50;

    dtmSubPoints[0].x := 779;
    dtmSubPoints[0].y := 202;
    dtmSubPoints[0].AreaSize := 0;
    dtmSubPoints[0].AreaShape := 0;
    dtmSubPoints[0].Color := 1495013;
    dtmSubPoints[0].Tolerance := 50;

    dtmSubPoints[1].x := 774;
    dtmSubPoints[1].y := 196;
    dtmSubPoints[1].AreaSize := 0;
    dtmSubPoints[1].AreaShape := 0;
    dtmSubPoints[1].Color := 65793;
    dtmSubPoints[1].Tolerance := 50;

    dtmSubPoints[2].x := 784;
    dtmSubPoints[2].y := 196;
    dtmSubPoints[2].AreaSize := 0;
    dtmSubPoints[2].AreaShape := 0;
    dtmSubPoints[2].Color := 65793;
    dtmSubPoints[2].Tolerance := 50;

    TempTDTM.MainPoint := dtmMainPoint;
    TempTDTM.SubPoints := dtmSubPoints;
    Result := AddDTM(TempTDTM);
  end;
  5:
  begin
    dtmMainPoint.x := 885;
    dtmMainPoint.y := 437;
    dtmMainPoint.AreaSize := 3;
    dtmMainPoint.AreaShape := 0;
    dtmMainPoint.Color := 3495793;
    dtmMainPoint.Tolerance := FindBarbHallColor;

    dtmSubPoints[0].x := 885;
    dtmSubPoints[0].y := 437;
    dtmSubPoints[0].AreaSize := 3;
    dtmSubPoints[0].AreaShape := 0;
    dtmSubPoints[0].Color := 3495793;
    dtmSubPoints[0].Tolerance := FindBarbHallColor;

    dtmSubPoints[1].x := 907;
    dtmSubPoints[1].y := 439;
    dtmSubPoints[1].AreaSize := 3;
    dtmSubPoints[1].AreaShape := 0;
    dtmSubPoints[1].Color := 3495793;
    dtmSubPoints[1].Tolerance := FindBarbHallColor;

    dtmSubPoints[2].x := 882;
    dtmSubPoints[2].y := 443;
    dtmSubPoints[2].AreaSize := 3;
    dtmSubPoints[2].AreaShape := 0;
    dtmSubPoints[2].Color := 3495793;
    dtmSubPoints[2].Tolerance := FindBarbHallColor;

    TempTDTM.MainPoint := dtmMainPoint;
    TempTDTM.SubPoints := dtmSubPoints;
    Result := AddDTM(TempTDTM);
  end;
 end;
end;

Procedure DetectHits;
begin
  HP := GetSkillInfo('Hitpoints', False);
  if not HP < eat  then
  begin
  exit;
  end;
    SetRun(true);
    GameTab(4);
  EatFood;
  exit;
  {if FindObjTPA(x, y, 3957631, 20, 2, 15, 25, 10, ['tool', 'Stool', 'ool']) then
    Mouse(x, y, 0, 0, true);
  if not (FindObjTPA(x, y, 3957631, 20, 2, 15, 25, 10, ['tool', 'Stool', 'ool'])) then
  begin
    Exit;
  end;}
end;

Function Randoms: boolean;
begin
  if (not (LoggedIn)) then
    Exit;
  DetectHits;
  FindNormalRandoms;
end;

function FindGainedLevel: boolean;
begin
  if not LoggedIn then
    Exit;
  if ClickContinue(False, False) then
  begin
    if FindNPCChatText('lations', Nothing) then
    begin
      writeln('We gained a Ranged level!');
      Inc(Gained);
      ClickContinue(True, True);
      Result := True;
      Exit;
    end;
  end;
end;

function FindBarbHallColor: Integer;
var
  CTS, II, Count, PCount: Integer;
  ColourDensity: Extended;
  TPA, CPts: TPointArray;
  TIA: TIntegerArray;
  TB: TBox;
begin
  Result := 0;
  CTS := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  SetColorSpeed2Modifiers(0.44, 1.42);
  if (FindColorsTolerance(TPA, 2048853, MMX1, MMY1, MMX2, MMY2, 10)) then
  begin
    FilterPointsPie(TPA, 0.0, 360.0, 0.0, 76.0, MMCX, MMCY);
    TIA := GetColors(TPA);
    ClearSameIntegersAndTPA(TIA, TPA);
    for II := 0 to High(TIA) do
    begin
      FindColorsTolerance(CPts, TIA[II], MMX1, MMY1, MMX2, MMY2, 0);
      TB := GetTPABounds(CPts);
      Count := Length(CPts);
      try
        ColourDensity := Count / ((TB.x2 - TB.x1) * (TB.y2 - TB.y1));
      except end;
      if (Count < 300) or (ColourDensity < 0.08) or (Count <= PCount) then Continue;
      Result := TIA[II];
      PCount := Count;
    end;
  end;
  SetColorSpeed2Modifiers(0.2, 0.2);
  ColorToleranceSpeed(CTS);
end;

Procedure Setup;
begin
  SetupSRL;
  SetUpVars;
  DeclarePlayers;
  LoginPlayer;
  LoadDTMs;
  if AttType = 1 then
  begin
  Players[CurrentPlayer].Integers[3] := GetSkillInfo('Ranged', False);
  if Players[CurrentPlayer].Integers[3] < 25 then
  begin
    Writeln('Ranging is too low! Please get to at least 25 before running.');
    TerminateScript;
  end;
  if Players[CurrentPlayer].Integers[3] > 75 then
  KillTime := 4000+random(250);
  if Players[CurrentPlayer].Integers[3] > 60 then
  KillTime := 5000+random(250);
  if Players[CurrentPlayer].Integers[3] > 50 then
  KillTime := 6000+random(250);
  if Players[CurrentPlayer].Integers[3] < 49 then
  KillTime := 7000+random(250);
  GameTab(4);
  if FindDtm(ArrowsDTM, x, y, MIX1,MIY1,MIX2,MIY2) then
  begin
    Mouse(x, y, 0, 0, false);
    ChooseOption('ield');
    exit;
  end;
  if not (FindDtm(ArrowsDTM, x, y, MIX1,MIY1,MIX2,MIY2)) then
    begin
      GameTab(5);
      if FindDtm(ArrowsDTM, x, y, MIX1,MIY1,MIX2,MIY2) then
        Mouse(x, y, 0, 0, false);
      exit;
    end;
    if not(FindDtm(ArrowsDTM, x, y, MIX1,MIY1,MIX2,MIY2)) then
    begin
      Writeln('Could not find arrows! Please get arrows, and run again.');
      TerminateScript;
    end;
    if not  (Players[CurrentPlayer].Integers[3] > 25) then
    begin
      NextPlayer(False);
    end;
  end;
  if AttType = 2 then
  begin
 KillTime := TimeKill;
 end;
end;

procedure AutoFightSetup;
begin
 SetupSRL;
  SetUpVars;
  DeclarePlayers;
  LoginPlayer;
  LoadDTMs;
  repeat
   MakeCompass('N');
   if FindObjTPA(x, y, MonsterColour1, 20, 2, 15, 25, 5, [MonsterName]) or
   FindObjTPA(x, y, MonsterColour2, 20, 2, 15, 25, 5, [MonsterName])   then
   begin
     Mouse(x, y, 0, 0, false);
     ChooseOption('ttack')
     Randoms;
   end;
   Randoms;
   AntiBan;
   Wait(KillTime);
   GetArrows;
   Randoms;
   FindGainedLevel;
   Inc(Total);
   Until (Total >= Kills);
  ReportIt;
end;


function WalkToEdge: Boolean; // No FailSafes, so watch out
var
  WalkDTM, Walk2DTM, Walk3DTM, Walk4DTM: Integer;
begin
  if  not (GetFood) then Exit;
  WalkDTM := SetDDTM(1);
  if FindDTM(WalkDTM, X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 3, 3, True);
    Writeln('Going back to edge.');
    Wait(5000+random(250));
    FFlag(0);
  end;
  Walk2DTM := SetDDTM(2);
  if FindDTM(Walk2DTM, X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 3, 3, True);
    FFlag(0);
    Result := True;
  end;
  Walk3DTM := SetDDTM(3);
  if FindDTM(Walk3DTM, X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 3, 3, True);
    FFlag(0);
    Result := True;
  end;
  if FindDTM(Walk3DTM, X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 3, 3, True);
    FFlag(0);
    Result := True;
  end;
  Walk4DTM := SetDDTM(4);
  if FindDTM(Walk4DTM, X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 3, 3, True);
    FFlag(0);
    Result := True;
  end;
  If Not (result) then
  begin
    LogOut;
    NextPlayer(False);
  end;
end;

function Banking: Boolean;
begin
  OpenBankFast('eb');
  if ((Foodtype = 1)) then
  begin
    if FindDtm(SalmonDTM, x, y, MIX1,MIY1,MIX2,MIY2) then
    begin
      Mouse(x, y, 0, 0, false);
      ChooseOption('ll');
      Result := True;
    end;
  end;
  if not(result) then
  Exit;
end;

Procedure BackToBarbs;
var
  WalkDTM: array [1..5] of integer;
  I: Integer;
begin
  if  not (GetFood) then Exit;
  WalkDTM[1] := SetDDTM(4);
  if FindDTM(WalkDTM[1], X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 8, 8, True);
    FFlag(0);
  end;
  WalkDTM[2] := SetDDTM(3);
  if FindDTM(WalkDTM[2], X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 8, 8, True);
    FFlag(0);
  end;
  WalkDTM[3] := SetDDTM(2);
  if FindDTM(WalkDTM[3], X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 8, 8, True);
    FFlag(0);
  end;
  WalkDTM[4] := SetDDTM(1);
  if FindDTM(WalkDTM[4], X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y, 8, 8, True);
    Wait(5000+random(250));
    FFlag(0);
  end;
  WalkDTM[5] := SetDDTM(5);
  if FindDTM(WalkDTM[4], X, Y, MMx1,MMy1,MMx2,MMy2) then
  begin
    Mouse(x, y - 5, 4, 4, True);
    Wait(5000+random(250));
    FFlag(0);
  end;
  for I := 1 to 5 do
  begin
    FreeDtm(I);
  end;
end;

Function EatFood: integer;
begin
  if (Foodtype = 1) then
  begin
    if FindDtm(SalmonDTM, x, y, MIX1,MIY1,MIX2,MIY2) then
    begin
      Mouse(x, y, 0, 0, false);
      ChooseOption('almon');
      Inc(Foodies);
    end;
    if not (FindDtm(SalmonDTM, x, y, MIX1,MIY1,MIX2,MIY2)) then
    begin
      WalkToEdge;
      Banking;
      BackToBarbs;
    end;
  end;
end;

Function AntiBan: integer;
begin
  if(not(LoggedIn))then
  Exit;
  case Random(17) of
   0:
   begin
     HoverSkill('Ranged', false);
     wait(2453+Random(432));
   end;
   1:
   begin
     HoverSkill('Ranged',false);
     wait(2364+Random(413));
     GameTab(4);
   end;
   2: PickUpMouse;
   7:
   begin
     MakeCompass('N');
     wait(100+random(5));
     MakeCompass('S');
     wait(100+random(5));
     MakeCompass('N');
   end;
   8:
   begin
     RandomRClick;
     wait(500 + random(500));
   end;
   9:
   begin
     IdleTime(1000 + Random(750), 500, 0.5);
     Wait(300 + random(700));
   end;
 end;
end;

Function GetArrows: integer;
begin
  if not (PickUpArrows) then
  begin
  exit;
  end;
    if FindObjTPA(x, y, 857707, 20, 2, 15, 25, 10, ['rrow', 'arrow', 'rrow']) then
    begin
    Mouse(x, y, 0, 0, false);
    ChooseOption('ake');
    GameTab(4);
    end;
    if not FindObjTPA(x, y, 857707, 20, 2, 15, 25, 10, ['rrow', 'arrow', 'rrow'])  then
    begin
      exit;
      end;
    if FindDtm(ArrowsDTM, x, y, MIX1,MIY1,MIX2,MIY2) then
    begin
      Mouse(x, y, 0, 0, false);
      ChooseOption('ield');
    end;
  end;

procedure GetBarb;
begin
  repeat
   MakeCompass('N');
   if FindObjTPA(x, y, 8619150, 20, 2, 15, 25, 5, ['arbarian', 'Barbarian', 'arian']) then
   begin
     Mouse(x, y, 0, 0, false);
     ChooseOption('ttack')
     Randoms;
   end;
   Randoms;
   AntiBan;
   Wait(KillTime);
   GetArrows;
   Randoms;
   FindGainedLevel;
   Inc(Total);
   Until (Total >= Kills);
  ReportIt;
end;

procedure ScriptTerminate;
begin
  ReportIt;
  Disguise('Terminated');
  TerminateScript;
end;

Procedure WhatLoop;
begin
if (BarbarianLoop) then
  begin
  Setup;
  GetBarb;
  end;
  if not (BarbarianLoop) then
    begin
    AutoFightSetup;
    end;
end;

begin
  WhatLoop;
end.

okay let take a look at this and leave comment :)

1- why you use ddtm when the extra d mean dynamic when theyr not dynamic just just a dtm. dont worry about that lol i did same error when i aplyed :p

2-

Procedure DetectHits;
begin  
  HP := GetSkillInfo('Hitpoints', False); 
  if not HP < eat  then  
  begin  
    exit;  
  end;    
  SetRun(true);    
  GameTab(4);  
  EatFood;  
  exit
  ...

can be shortened

Procedure DetectHits;
begin  
  HP := GetSkillInfo('Hitpoints', False); 
  if not HP < eat  then  exit;    --- no need to begind end since you use only 1 line
  SetRun(true);    
  GameTab(4);  
  EatFood;  
  exit
  ...

3- function WalkToEdge: Boolean; // No FailSafes, so watch out
you told all.

4- Banking: Boolean; bank your salmon it doesnt withdraw them ? what the use of banking them ? if FindDtm(SalmonDTM, x, y, MIX1,MIY1,MIX2,MIY2) will search in inventory…
you should use MBX1, MBY1, MBX2, MBY2 (they are for bank)

5-

Function EatFood: integer;
begin  
  if (Foodtype = 1) then  
  begin    
    if FindDtm(SalmonDTM, x, y, MIX1,MIY1,MIX2,MIY2) then    
    begin      
       Mouse(x, y, 0, 0, false);      
       ChooseOption('almon');      
       Inc(Foodies);    
    end;

chooseoption almon will probably fail sometime with drop and examine, you should change it for eat.

6- Function GetArrows: integer; it have no result ??

7-
Mouse(x, y, 0, 0, false);
ChooseOption('ttack')

you shoudl add wait between or use waitoption('') ( not sure of name)


8-

Procedure MainLoop;
begin  
  WhatLoop;
end;

begin  
  Mainloop;
end.

lol just name your whatloop mainloop and delet mainloop :p


well some thing to correct,nobody is perfect :p, i can see the effort in the script and i dont care about minor detail but ill dont vote for now, i saw your autocolor function(FindBarbHallColor) and i did wow but after i saw a simple FindObjTPA :(

if Players[CurrentPlayer].Integers[3] > 75 then
  begin
  KillTime := 4000+random(250);
  end;
  if Players[CurrentPlayer].Integers[3] > 60 then
  begin
  KillTime := 5000+random(250);
  end;
  if Players[CurrentPlayer].Integers[3] > 50 then
  begin
  KillTime := 6000+random(250);
  end;
  if Players[CurrentPlayer].Integers[3] < 49 then
  begin
  KillTime := 7000+random(250);
  end;

Unnecessary begins and ends. You could also use a case.

Those 5 DDTM's that you have are not dynamic enough, the second one doesn't even have any tolerance to it. Instead of using FindObjTPA you should write your own TPA to find the thing you are looking for. You should add some failsafes to those DDTM's like a radialwalk or something, maybe even a symbol click if there is anything around to click, but you could at least add a Writeln('DDTM walk failed');

The Anti-ban could be improved a bit more. I like the way you used the "FindBarbHallColor", did you write that up youself?

  {if FindObjTPA(x, y, 3957631, 20, 2, 15, 25, 10, ['tool', 'Stool', 'ool']) then
    Mouse(x, y, 0, 0, true);
  if not (FindObjTPA(x, y, 3957631, 20, 2, 15, 25, 10, ['tool', 'Stool', 'ool'])) then
  begin
    Exit;
  end;}

Can be shortened to

  {if FindObjTPA(x, y, 3957631, 20, 2, 15, 25, 10, ['tool', 'Stool', 'ool']) then
    Mouse(x, y, 0, 0, true)
  else Exit;}

Looks pretty good though. Just looking through the arrow and the salmon DTM, these could fail quite a bit (or click another object) because you only have 1 main point of colour then the rest is the black outline with the tolerance of 35, the black outline never changes colour so you should make the tolerance 0 or 1. the DTM's are pretty small so you should add another 2-3 points to them.

Holding my vote

edit - I went to test this script out and got a runtime error.. hmm

Cycrosism, don't vote at all until a few weeks have passed..

When you are using an if..then statement and you only have 1 following line, or the following line starts another loop then you don't need a begin..end; nest around it.

Example:

function FindGainedLevel: boolean;
begin
  if not LoggedIn then
    Exit;
  if ClickContinue(False, False) then
  begin
    if FindNPCChatText('lations', Nothing) then
    begin
      writeln('We gained a Ranged level!');
      Inc(Gained);
      ClickContinue(True, True);
      Result := True;
      Exit;
    end;
  end;
end;

//That should be this:

function FindGainedLevel: boolean;
begin
  if not LoggedIn then
    Exit;
  if ClickContinue(False, False) then
    if FindNPCChatText('lations', Nothing) then
    begin
      writeln('We gained a Ranged level!');
      Inc(Gained);
      ClickContinue(True, True);
      Result := True;
      Exit; // This is some what pointless as well as that is the end of the function anyways
    end;
end;

If this is yours then Excellent job! :

function FindBarbHallColor: Integer;
var
  CTS, II, Count, PCount: Integer;
  ColourDensity: Extended;
  TPA, CPts: TPointArray;
  TIA: TIntegerArray;
  TB: TBox;
begin
  Result := 0;
  CTS := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  SetColorSpeed2Modifiers(0.44, 1.42);
  if (FindColorsTolerance(TPA, 2048853, MMX1, MMY1, MMX2, MMY2, 10)) then
  begin
    FilterPointsPie(TPA, 0.0, 360.0, 0.0, 76.0, MMCX, MMCY);
    TIA := GetColors(TPA);
    ClearSameIntegersAndTPA(TIA, TPA);
    for II := 0 to High(TIA) do
    begin
      FindColorsTolerance(CPts, TIA[II], MMX1, MMY1, MMX2, MMY2, 0);
      TB := GetTPABounds(CPts);
      Count := Length(CPts);
      try
        ColourDensity := Count / ((TB.x2 - TB.x1) * (TB.y2 - TB.y1));
      except end;
      if (Count < 300) or (ColourDensity < 0.08) or (Count <= PCount) then Continue;
      Result := TIA[II];
      PCount := Count;
    end;
  end;
  SetColorSpeed2Modifiers(0.2, 0.2);
  ColorToleranceSpeed(CTS);
end;

Otherwise, you need to credit.

function Banking: Boolean;
begin
  OpenBankFast('eb');
  if ((Foodtype = 1)) then
  begin
    if FindDtm(SalmonDTM, x, y, MIX1,MIY1,MIX2,MIY2) then
    begin
      Mouse(x, y, 0, 0, false);
      ChooseOption('ll');
      Result := True;
    end;
  end;
  if not(result) then // This too,
  Exit; // is pointless. If it's the end anyways, there is no need really for an Exit;
end;

You show some knowledge of Array's, but why no TPA's?! :p

Not too bad. You should fix the things I said as well as what previous post's suggest and re-apply with that. I think you would have a lot better response ;)

Nice attempt, but No for now.

From: Da 0wner
Cycrosism, don't vote at all until a few weeks have passed..

Oh I wasn't aware that you were the admin and that you are able to make the rules for when people are allowed to vote

From: cycrosism
Oh I wasn't aware that you were the admin and that you are able to make the rules for when people are allowed to vote

Its true, you can't vote until 2 weeks after you get membership.

EDIT: It seems that the 2 weeks have passed, so you can vote, but it is a rule, so could you not have just said, yeah, the rule is 2 weeks, and those 2 weeks are over, thanks for making sure though! Or something along those lines.

And, this was the script I applied with…
http://www.villavu.com/forum/showthread.php?t=38522

From: Griff721
Its true, you can't vote until 2 weeks after you get membership.

EDIT: It seems that the 2 weeks have passed, so you can vote, but it is a rule, so could you not have just said, yeah, the rule is 2 weeks, and those 2 weeks are over, thanks for making sure though! Or something along those lines.

And, this was the script I applied with…
http://www.villavu.com/forum/showthread.php?t=38522

The two weeks are not over. Cycroism has only been a member for 8 days. What if he applied, it took 2 weeks for him to get accepted. Would he be allowed to vote on his first day of membership then? This is why the days start at the time you are accepted.

Cycroism, I have also already told you this in another thread. Not trying to back seat mod either, but you are not allowed to vote until your 2 weeks are up.

From: JAD
The two weeks are not over. Cycroism has only been a member for 8 days. What if he applied, it took 2 weeks for him to get accepted. Would he be allowed to vote on his first day of membership then? This is why the days start at the time you are accepted.

Cycroism, I have also already told you this in another thread. Not trying to back seat mod either, but you are not allowed to vote until your 2 weeks are up.

Sorry about that, I misread the dates. But still, my main point was that it is a rule, and no one is trying to back seat mod or anything.

Sorry, this is getting off topic. Please close, stolen script. http://www.villavu.com/forum/showthread.php?t=38522

Damn it Goodpeople, don't take other people's hard work and claim it yours!

You do know you will be suspended/banned right?

From: Griff721
Sorry about that, I misread the dates. But still, my main point was that it is a rule, and no one is trying to back seat mod or anything.

Sorry, this is getting off topic. Please close, stolen script. http://www.villavu.com/forum/showthread.php?t=38522

Nice find Griff! Maybe he is not such a "GoodPeople" after all :/

He has been banned, and this thread is now unofficially closed.

Umm.. How is GoodPeople able to get this script since its in the Members Section.

closed

From: Da 0wner
Cycrosism, don't vote at all until a few weeks have passed..

From: Griff721
Its true, you can't vote until 2 weeks after you get membership.

EDIT: It seems that the 2 weeks have passed, so you can vote, but it is a rule, so could you not have just said, yeah, the rule is 2 weeks, and those 2 weeks are over, thanks for making sure though! Or something along those lines.

And, this was the script I applied with…
http://www.villavu.com/forum/showthread.php?t=38522

From: JAD
The two weeks are not over. Cycroism has only been a member for 8 days. What if he applied, it took 2 weeks for him to get accepted. Would he be allowed to vote on his first day of membership then? This is why the days start at the time you are accepted.

Cycroism, I have also already told you this in another thread. Not trying to back seat mod either, but you are not allowed to vote until your 2 weeks are up.

From: Griff721
Sorry about that, I misread the dates. But still, my main point was that it is a rule, and no one is trying to back seat mod or anything.

Sorry, this is getting off topic. Please close, stolen script. http://www.villavu.com/forum/showthread.php?t=38522

Can I just point out that is never been an official rule. More or less a suggestion so that new members can get a feel for how applications are judged. If someone feels they're able to vote fairly and without bias then you can't stop them.