SRL Archive - Archive

All that is man - SRL Member Application


All that is man

2009-07-06 04:36:14

How Long have You Played Runescape?
4 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?



What is your general programming knowledge?
SCAR, very very little java


Are you a member of any other communities?
No


Tell us about yourself…
From: All that is man
My name is Brian, i'm 14 years old. I love to play on my computer and xbox 360, i play basketball and baseball.



Please show us one (or multiple) of your scripts.
program new;
{.Include SRL\SRL\Misc\Smart.Scar}
{.include srl/srl.scar}
{.include srl/srl/reflection/reflection.scar}
var
Loads, trips, totalLoads, ms: integer;
procedure multiplayer; forward;
procedure moveFishingSpots; forward;
procedure proggy; forward;
procedure DeclarePlayers;
begin
HowManyPlayers := 2 ;
NumberOfPlayers(HowManyPlayers) ;
CurrentPlayer := 0 ;

Players[0].Name :='' ;
Players[0].Pass :='' ;
Players[0].Nick :='' ;
Players[0].Loc :='' ;//fish or bank
Players[0].integers[0] := 3 ;//Amount of loads to do
Players[0].integers[1] := 25 ;//Amount of times to do the amount of loads to do
Players[0].integers[2] := 0 ;//LEAVE 0!
Players[0].Active:=True ;

Players[1].Name :='' ;
Players[1].Pass :='' ;
Players[1].Nick :='' ;
Players[1].Loc :='' ;//fish or bank
Players[1].integers[0] := 3 ;//Amount of loads to do
Players[1].integers[1] := 25 ;//Amount of times to do the amount of loads to do
Players[1].integers[2] := 0 ;//LEAVE 0!
Players[1].Active:=True ;

{Players[0].Name :='' ;
Players[2].Pass :='' ;
Players[2].Nick :='' ;
Players[2].Loc :='' ;//fish or bank
Players[2].integers[0] := 5 ;//Amount of loads to do
Players[2].integers[1] := 5 ;//Amount of times to do the amount of loads to do
Players[2].integers[2] := 0 ;//LEAVE 0!
Players[2].Active:=True ;}
end;
procedure W(Time, RandomTime: integer);
begin
Wait(Time+random(RandomTime));
end;
procedure CM;
begin
repeat
w(10, 10);
until(not(charactermoving))
end;
function RM: integer;
begin
result := (1+random(6));
end;
procedure PreparingOpening;
begin
SetupSRL;
SetupReflection;
{$IFDEF srl_SMART}
Smart_Server:=80;
Smart_Members:=false;
Smart_Signed:=true;
Smart_SuperDetail:=False;
{$ENDIF}
w(2500, 2500);
Disguise('Barb Fisher And Banker');
ClearDeBug;
DeclarePlayers;
LoginPlayer;
w(1000, 500);
SetAngle(true);
makeCompass('n');
end;
procedure AntiBan;
begin
case random(9) of
0: begin
RandomRClick;
W(500, 500);
R_FindRandoms;
FindNormalRandoms;
end;
1: begin
BoredHuman;
W(500, 500);
R_FindRandoms;
FindNormalRandoms;
end;
2: begin
Makecompass('random');
W(1, 1000);
MakeCompass('n');
R_FindRandoms;
FindNormalRandoms;
end;
3: begin
PickUpMouse;
W(1, 1000);
end;
4: begin
hoverskill('fishing', false);
w(1000, 1000);
gametab(4);
end;
5: begin
case random(2) of
0: begin
RM;
gameTab(rm);
w(1000, 500);
gameTab(rm);
w(500, 1000);
gameTab(4);
end;
1: begin
rm;
gameTab(rm);
w(500, 500);
gameTab(4);
end;
end;
end;
end;
end;
function ToBank: Tpointarray;
begin
SetRun(true);
SetLength(result, 7);
result[0] := Point(3097, 3436);
result[1] := Point(3094, 3450);
result[2] := Point(3089, 3458);
result[3] := Point(3083, 3465);
result[4] := Point(3080, 3479);
result[5] := Point(3086, 3490);
result[6] := Point(3093, 3490);
end;
function ToFish: Tpointarray;
begin
SetRun(true);
SetLength(result, 8);
result[0] := Point(3087, 3489);
result[1] := Point(3079, 3482);
result[2] := Point(3081, 3473);
result[3] := Point(3087, 3465);
result[4] := Point(3094, 3453);
result[5] := Point(3093, 3443);
result[6] := Point(3104, 3434);
result[7] := Point(3109, 3433);
end;
procedure PathWalker(PathToWalk: TPointArray);
var
I: Integer;
Path: TPointArray;
begin
Path := PathToWalk;
for i := 0 to High(Path) do
begin
WalkToTile(Path[i], 1, 2);
w(500, 500);
CM;
FindNormalRandoms;
case Random(4) of
0: AntiBan;
end;
end;
W(500, 500);
end;
function findFishingSpot: boolean;
var
FP: tnpc;
begin
if (FindNPC('Fishing Spot', FP)) then
begin
if(TileOnMS(Fp.tile, 10))then
begin
result := true;
end else
begin
result := false;
end;
end;
end;
procedure Bank;
var
Trout, Salmon, x, y: integer;
begin
Trout := DTMFromString('78DA634C6462606066644006BB366C603002D' +
'220D1FF40C0980354F385010D302291403A19A8868D11BF9A60A0' +
'1A6E026A40EEF981DF2E00373F0A48');
Salmon := DTMFromString('78DA63EC6462606065644006476BF3198C803' +
'448F43F1030D601D5F0A0AA81C8C24820DD0D54F38301BF9AE940' +
'35DF18089BC385DF2E004B1F0AB8');
R_OpenBankBooth('eb');
repeat
wait(10);
until(BankScreen)
w(100, 500);
if FindDtm(trout, x, y, Mix1, Miy1, Mix2, Miy2) then
begin
Mouse(x, y, 5, 5, false);
w(500, 1000);
R_ChooseOption('eposit-All');
w(100, 500);
if FindDtm(salmon, x, y, Mix1, Miy1, Mix2, Miy2) then
begin
Mouse(x, y, 5, 5, false);
w(500, 1000);
R_ChooseOption('eposit-All');
w(100, 500);
end;
end;
CloseBank;
Loads := Loads + 1;
totalLoads := totalLoads + 1;
inc(players[currentplayer].integers[2]);
Multiplayer;
end;

function RodAndFeathers: boolean;
var
a: integer;
begin
if InventoryContainsMultiEx([310, 315], a) then
begin
result := true;
end else
begin
Writeln('Can''t find your rod or feathers, please get them');
Disguise('Terminated');
proggy;
TerminateScript;
end;
end;
function fishing: boolean;
var
playerstuffs : tme;
begin
playerstuffs := getme;
if (playerstuffs.Animation = 623) then
begin
result := true;
end;
end;
procedure Fish;
var
FP: TNPC;
FishPoint: Tpoint;
begin
repeat
if invfull then PathWalker(ToBank);
if not findFishingSpot then moveFishingSpots;
if (FindNPC('Fishing Spot', FP)) then
begin
R_FindRandoms;
FindNormalRandoms;
Fishpoint := TileToMS(FP.Tile, Random(0));
if not findFishingSpot then moveFishingSpots;
Mouse(FishPoint.x, FishPoint.y, 2, 2, false);
R_ChooseOption('ure');
if not (FindNPC('Fishing Spot', FP)) then moveFishingSpots;
w(3500, 2000);
if fishing then
begin
repeat
if not (FindNPC('Fishing Spot', FP)) then moveFishingSpots;
case random(3) of
0: w(2000, 2000);
1: AntiBan;
2: w(2000, 2000);
end;
R_FindRandoms;
FindNormalRandoms;
until not (fishing)
end;
end;
until((invfull)or(not(findFishingSpot)))
end;
procedure MoveFishingSpots;
var
playerposlol: integer;
PlayerPosition, FS1, FS2: Tpoint;
begin
FS1 := Point(3109, 3432);
FS2 := Point(3103, 3424);
PlayerPosition := GetMyPos;
playerposlol := 0;
if PointInBox(PlayerPosition, IntToBox(3103, 3437, 3114, 3428)) then
begin
playerposlol := 1;
end else
begin
setRun(true);
case playerposlol of
0: begin
WalkToTile(FS2, 1, 2);
w(10000, 5000);
Ms:=ms+1;
end;
1: begin
WalkToTile(FS1, 1, 2);
w(10000, 5000);
MS:=Ms+1;
end;
end;
end;
fish;
end;
procedure Multiplayer;
begin
if ((players[currentplayer].integers[0]) <= (Loads)) then
begin
Loads := 0;
inc(players[currentplayer].integers[1]);
if ((players[currentplayer].integers[1]) <= (trips)) then
begin
Nextplayer(false);
end else
begin
NextPlayer(true);
end;
end;
end;
procedure proggy;
var
i: integer;
begin
Writeln('All that is man''s Barb fisher/Banker');
Writeln('Current Player: ' + Players[currentplayer].name);
Writeln('Time Ran: ' + TimeRunning + '.');
for i := 0 to high(players) do
Writeln('Player: ' + players[i].name + ' - Fish caught: ' + intToStr(players[i].integers[2] * 26) + ' - Banked: ' + intToStr(players[i].integers[2]) + ' times.');
end;
procedure MainLoop;
var
loop: integer;
begin
preparingOpening;
if(Players[currentplayer].Loc='fish')then loop := 1;
if(Players[currentplayer].Loc='bank')then loop := 2;
case loop of
1: begin
repeat
fish;
pathWalker(toBank);
bank;
proggy;
pathWalker(toFish);
until(allplayersinactive)
end;
2: begin
repeat
if invfull then bank;
proggy;
pathWalker(toFish);
Fish;
pathWalker(toBank);
until(allPlayersInActive)
end;
end;
end;
begin
MainLoop;
end.
All that is man's Barb fisher/Banker
Time Ran: 24 Minutes and 6 Seconds.
Banked: 7 times.
Fished: 182 fish.
MovedSpots: 1 times.

All that is man's Barb fisher/Banker
Current Player: ****
Time Ran: 9 Minutes and 16 Seconds.
Player: **** - Fish caught: 78 - Banked: 3 times.
Player: **** - Fish caught: 26 - Banked: 1 times.

Rubix

2009-07-06 05:00:21

you need to space between functions etc.

ian.

2009-07-06 05:03:27

From: Rubix
you need to space between functions etc.


If you voted no for that.. >.< lol I'm not gonna vote or read right now.. I'm upset and don't wanna vote based on my real life troubles. D: Sowwy. Hope you get in ;) I like your attitude.

Good luck.

Rubix

2009-07-06 05:09:05

no, i normaly dont vote until i read what other peoplethink, then i vote whatever the majority votes : )

Harry

2009-07-06 05:19:13

You are on IRC a bit (you need to get a real client and idle more, and be active more: we want to know you more!)

Too lazy to review the script right now all the way, looks good for the most part, except for a few standards. Holding vote, but I am leaning twords yes.

Coh3n

2009-07-06 05:32:05

I'm not suppose to vote for another week or so, as I recently became a member myself, but I will make some comments to help you improve your script. :)

1: Improve your standards. I'll fix this little bit as an example.
procedure W(Time, RandomTime: integer);
begin
Wait(Time+random(RandomTime));
end;

procedure CM;
begin
repeat
w(10, 10);
until(not(charactermoving))
end;

function RM: integer;
begin
result := (1+random(6));
end;

Also here, you don't need to indent the begin after an if..then statement:
function findFishingSpot: boolean;
var
FP: tnpc;
begin
if(FindNPC('Fishing Spot', FP))then
if(TileOnMS(Fp.tile, 10))then
result := true
else
result := false;
end;

Also in that little bit, an if..then statement will do the first line following, unless you put a begin…end nest around it. Like I did there. :)

You also have a lot of useless begin..end nests throughout your script that you'll be able to eliminate with experience. :)

2: Your walk paths don't have to be written way they are, for longer paths it looks better to write them like this, IMO:
function ToBank: Tpointarray;
begin
SetRun(true);
SetLength(result, 7);
result := [Point(3097, 3436), Point(3094, 3450), Point(3089, 3458),
Point(3083, 3465), Point(3080, 3479), Point(3086, 3490),
Point(3093, 3490)];
end;


That way it saves some lines and some repetitive coding.

3: Your banking function is set to Deposit-All. When you're fishing Trout/Salmon, you are fly fishing, and have the rod/feathers in your inventory, so it would do one load, then stop because there's no rod/feathers.

4: Other than that I didn't see anything too major. I think you should clean up your code a bit, making it easier to understand.

I haven't been in member's for very long, but I know that if you apply with a Reflection script, it has to be REALLY good. I would like to see what the long-time members vote.

Overall, I don't think it's a bad script. I think it could use a lot of work, but it has potential. Good luck. :)

Thanks. :D

JAD

2009-07-06 05:37:05

From: Coh3n
I know that if you apply with a Reflection script, it has to be REALLY good.


In my opinion it doesn't have to be so amazing it's like dev worthy. It just has to be greater than or equal to the skill demonstrated in most apps that get in.



I think that this is a great app. Your code is hard to read, but that has nothing to do with your scripting ability. I don't have time to give it a thorough read through, but from what I saw it definitely looks good enough.

Yes from me. Good job :)

Coh3n

2009-07-06 06:07:10

From: JAD
In my opinion it doesn't have to be so amazing it's like dev worthy. It just has to be greater than or equal to the skill demonstrated in most apps that get in.


Yeah that's good to know. :) What I meant more or less was about the walking and things like that. It could just be me, but I find finding objects, and walking is A LOT easier with Reflection than with color.

That's just me though. ^_^

Awkwardsaw

2009-07-06 06:11:50

From: Coh3n
Yeah that's good to know. :) What I meant more or less was about the walking and things like that. It could just be me, but I find finding objects, and walking is A LOT easier with Reflection than with color.

That's just me though. ^_^


it is :p and also, im leaning more to the no, because it has no color, other than dtms.

although i cant vote :p

also,coh3n has some good points :)

cycrosism

2009-07-06 06:19:48

No, you used reflection

Coh3n

2009-07-06 06:21:46

From: akwardsaw
also,coh3n has some good points :)


Thanks. :D

From: cycrosism
No, you used reflection


You vote an instant 'no' because he used Reflection?

cycrosism

2009-07-06 06:23:19

Yes. When applying they shouldn't use reflection because it does not require that much skill, they should learn about TPA's and DDTMS and such

Coh3n

2009-07-06 06:24:50

From: cycrosism
Yes. When applying they shouldn't use reflection because it does not require that much skill, they should learn about TPA's and DDTMS and such


Oh, I see, just checking. :) And I do agree with you, learning TPAs and such is a big help.

Rubix

2009-07-06 06:50:51

Coh3n seems you are running this thread lol

P1nky

2009-07-06 06:51:20

nopppe because reflection.

Coh3n

2009-07-06 06:53:58

From: Rubix
Coh3n seems you are running this thread lol


I do what I can. :p

From: ~~Joker~~
nopppe because reflection.


I'm not even going to make an attempt at arguing with you. :p

marpis

2009-07-06 08:31:25

Im sorry, it's a No.

1) Not because of Reflection, but because you don't have any failsafes!
Your fishing procedure will be messed up if the fishing spot isn't there yet.

2) If one step of your walking fails, it just keeps on going which leads to no good.

3) You should use parameters on your functions, like this

MyFindFishingspot(var msx, msy: integer): boolean;
so you wouldn't have to call FindNPC a million times in your fishing procedures.
It's slow and inefficient.

4)

if(TileOnMS(Fp.tile, 10))then
begin
result := true;
end else
begin
result := false;
end;
can be shortened to

result := TileOnMS(Fp.tile, 10);

5)

1: begin
rm; // what is this?
gameTab(rm);
w(500, 500);
gameTab(4);
end;
Why do you call RM; there?

More more more failsafes!

JAD

2009-07-06 08:46:12

From: cycrosism
No, you used reflection


You were only accepted into members 8 days ago. Please read the stickies:
http://www.villavu.com/forum/showthread.php?t=1288
http://www.villavu.com/forum/showthread.php?t=38699
http://www.villavu.com/forum/showthread.php?t=24420

@Joker, why do you instant no a reflection? Maybe you should look at the script past the includes.

Floor66

2009-07-06 09:41:52

Sorry, no. Not because of reflection but just the lack of RRW/TPA/DDTM. You need to know these colour basics!

Daniel

2009-07-06 10:17:27

Hmm, sorry, but you're using reflection for almost all finding with no backups from colour. Your script is very dependant on reflection, your standards are a bit on the goofy side (but mostly it's good), you should also learn about using if's with just an else instead of using begin end else ;) You have procedures which are just 1 line, or only used once. Sorry, but it's a no from me :(

From: Rubix
no, i normaly dont vote until i read what other peoplethink, then i vote whatever the majority votes : )

e.g: http://www.villavu.com/forum/showthread.php?p=588626#post588626

And so you only vote on what the majority votes? Sorry, but if that's the case, then you're pathetic.. (no offence)

Quickmarch

2009-07-06 10:39:03

Havn't voted in awhile, but it's a No from me.

All the things that marpis said, no TPA object finding, no DDTM back-up walking. Overall just to simple. :)

Dynamite

2009-07-06 11:13:12

no from me.
if you had
failsafes
RRW
DTMs
DDTMs
TPAs
then i would be rethinking.
i dont mind that it is reflection but you need to add tje things above.
use color for failsafes and object finding.

T~M

Lance

2009-07-06 13:44:27

From: cycrosism
No, you used reflection


just because reflection isnt in the script dosnt mean he has no skill. Whats up with you and joker?

I vote no, because like what the others said, there isnt any TPA's (which are confuseing at first but once you learn them i think they are much funner and easyer to use than reflection, though maby not as efficiant) and the path walking dosnt have a failsafe incase one of the steps failed (which is pretty big cause you could find yourself compleatly lost and thats quite bannable)

I do think useing reflection shows skill.. skill of efficancy. Knowing when it would be more effective to use reflection over color. And it should be honored in the applications, if the applications are good. I mean what is this community baised on? were here to make powerful scripts, not to show off our skills in only one aspect of scripting, are we not? But then again what do i know? ima newbie to srl members myself :P

Edit: im sorry i almost forgot, Better luck next time (it looks as if you wont win) i hope you learn from this and if you need any help im not a great teacher but you can always PM me since it wasnt to long ago since i didnt know about TPA's and all that myself ;D i may be able to answer questions and direct you to good tutorials :]

Pure1993

2009-07-06 16:18:44

Voting "no" because of reflection is one of the most pathetic excuses for casting a certain vote which I have ever herad… -.-
Reflection takes just as much skill as color. Sure, you don't go around juggeling with rrw, autocoloring, and other neccessarry time wasters when using reflection, BUT you are working with TPAs, TIntegerArrays, Ids, failsafes of various sorts, using reflection properly, etc.
I am working on the most complicated script I have written so far, and guess what? It's a reflection script! Why would you script a color script if you are aiming for efficiency?!?! Color will not run as long, as safe, and as fast as reflection will! If you decide to stick with colors and hate reflection, then keep it to yourself! Nobody wants to hear it!
The only reason to vote no because of reflection is if the code sucks, is inefficient, or fails at the task! Oh, guess what? Those are the same reasons for voting no in a color script… who'd have guessed? -.-

Under normal circumstances I respect everyone around me, including srl form members/participants… but this is just bull ****.

Voting "yes" to equal out an "unqualified" vote.

Runescapian321

2009-07-06 16:42:05

From: Pure1993
Voting "no" because of reflection is one of the most pathetic excuses for casting a certain vote which I have ever herad… -.-
Reflection takes just as much skill as color. Sure, you don't go around juggeling with rrw, autocoloring, and other neccessarry time wasters when using reflection, BUT you are working with TPAs, TIntegerArrays, Ids, failsafes of various sorts, using reflection properly, etc.
I am working on the most complicated script I have written so far, and guess what? It's a reflection script! Why would you script a color script if you are aiming for efficiency?!?! Color will not run as long, as safe, and as fast as reflection will! If you decide to stick with colors and hate reflection, then keep it to yourself! Nobody wants to hear it!
The only reason to vote no because of reflection is if the code sucks, is inefficient, or fails at the task! Oh, guess what? Those are the same reasons for voting no in a color script… who'd have guessed? -.-

Under normal circumstances I respect everyone around me, including srl form members/participants… but this is just bull ****.

Voting "yes" to equal out an "unqualified" vote.


+1! Color is just a slightly more complicated way of spending 10x as much time. People say color is much more complicated, but in reality all it is is just copy/pasting code (for example, TPAs), maybe filling some simple numbers in (radians in RRW, and/or color(s)), and…well that's all there is to it. Of course, there's things like Autocolor functions, etc. But how often does an applicant have that? Most are accepted without something as complex. The basics of color (as far as are needed for a successful application) are hardly, if any, more complex than the normal reflection - certainly not a reason to vote no alone. Of course, showing a bit of color knowledge certainly doesn't hurt.

EDIT: I'm probably not going to vote, mainly because of all that marpis said - failsafes especially.

mixster

2009-07-06 16:43:25

In a democracy, there is no such thing as a bad vote. Freedom allows them to vote however they like. I wouldn't think it a stupid vote even if they voted yes or no simply because their name starts with a vowel or their signature is under 3 lines long.

Don't get into a debate between colour vs reflection here as well. Leave the guys app alone if you want to and go do it else where.

cycrosism

2009-07-06 16:44:45

From: JAD
You were only accepted into members 8 days ago. Please read the stickies:
http://www.villavu.com/forum/showthread.php?t=1288
http://www.villavu.com/forum/showthread.php?t=38699
http://www.villavu.com/forum/showthread.php?t=24420

@Joker, why do you instant no a reflection? Maybe you should look at the script past the includes.


I did read them, this is the first app I have ever voted on

Markus

2009-07-06 17:19:25

The script itself is okay, however, only reflection walking/object finding?
I'd like to see a bit of colour first, but it seems you understand the most important parts of scripting (procedures/loops/structures). From there on, learning some walking/object finding isn't too hard :)
I'll vote no for now, but I'm sure you'll get in if you learn a bit of colour scripting. Good luck!

Rubix

2009-07-06 18:32:35

Yes.

Naike

2009-07-06 18:36:59

No, sorry. To simple and no reflection.

Wanted

2009-07-09 05:43:37

I'm going to vote yes because you seem like you know a good portion of the stuff I'd require a beginning member to know.

I'd highly recommend my intermediate tutorial (link in sig) so you can learn about using fail safes better and UpText ect…

My guess is you're not going to get accepted this time, but read some tutorials and improve your script then you should have a good chance of getting in next time.

-IceFire

Phran6

2009-07-13 08:00:22

im going to vote no because its too simple, you use reflection for wak and findobj for finding stuff, nothing realy for prove your skill to be a srl member.

Brain

2009-07-13 08:19:27

hmmmm…he hasn't posted in this thread since the start?

I'll pm him the url in case he lost it.

I vote yes, good attitude, good name (srl name and real name :p), and decent script.

Nava2

2009-07-15 00:54:24

No, sorry bud, it shows very little skill.

Not because its reflection, but you didn't really blow my socks off with it!

Reflection scripting takes a lot more arrays etc, but in reality is easier.

Best of luck either way. Also, listen to coh3n. He has a lot of points. Especially standards.

All that is man

2009-07-21 00:56:44

Alrighty thanks guys, I understand where I stand and how I could improve, thanks Brain for the link, because yes I did lose it >.<. But thank you everyone!

Markus

2009-07-22 01:14:20

Closed, and you can apply again in a week (as it was 1 week since the last post + another week = the 2 week wait).
Good luck next time!