SRL Archive - Outdated Tutorials

Small change, two params were switched around to make it match other similar functions:

Old:

function CountItems(Identifier: Integer; ItemType: string; tol: TIntegerArray): Integer;

and

function ClickAllItems(Identifier: Integer; ItemType, option: string; waitnum: Integer; tol: TIntegerArray):Integer;

New:

function CountItems(ItemType: string; Identifier: Integer; tol: TIntegerArray): Integer;

and

function ClickAllItems(ItemType: String; Identifier: Integer; option: string; waitnum: Integer; tol: TIntegerArray):Integer;

ItemType and Identifier have been switched around. If your script complains about a type mismatch error with CountItems or ClickAllItems(Except) then switch your params around:

For example:

Change:

C := CountItems(LogDTM, 'dtm', []);

to:

C := CountItems('dtm', LogDTM, []);

Simple? Any objections btw?

"Da EssArrEll Devz"

Kwlkwl, gdgd!
But why was it changed? Confuzzled peeps?

The developers must always be active.
They are not lazy after all. ;)

From: Floor66
Kwlkwl, gdgd!
But why was it changed? Confuzzled peeps?

To match similar functions, not because people were confused, but to make it easier in general, as now the params are in the same order.

~RM

Alright thanks :)

From: Hermen
The developers must always be active.
They are not lazy after all. ;)

I'm fast becoming lazy, d/w.

I think the older one was better…

From: marpis
I think the older one was better…

Why? Any particular reason?

If I can say I am totally agree with this. When I was trying out/learning SRL I found confusing that similar functions were different in this. I like the logical way! And this is it. Hope it did not sound like a spam :/

I did it because when I originally changed all thaw functions around, those two were already setup.

I just forgot to switch them and it had been bugging me for quite awhile.

From: marpis
I think the older one was better…

i think the order of the parameters was more logical

From: marpis
i think the order of the parameters was more logical

I think this new order is more logical - 1st param: What it is, 2nd: What we're looking for, 3. info to help us look. Besides it now matches with CountItemsIn and ItemAmount.

From: ZephyrsFury
I think this new order is more logical - 1st param: What it is, 2nd: What we're looking for, 3. info to help us look. Besides it now matches with CountItemsIn and ItemAmount.

Isn't param 1 and param 2 the same? :p

Anyway: It's ok for me, but it will break alot of scripts :/

From: Zyt3x
Isn't param 1 and param 2 the same? :p

Anyway: It's ok for me, but it will break alot of scripts :/

Try this

program New;

var
pt1,pt2,pt3,TheFile:integer;
str1,str2,TheScriptString, TheScriptPath:string;
begin
  TheScriptPath := Readln('Full path of script you would like to fix (I suggest you use a copy)');
  TheFile:=OpenFile(TheScriptPath,true);
  ReadFileString(TheFile,TheScriptString,Filesize(thefile));
  CloseFile(TheFile);
  TheScriptString:=lowercase(TheScriptString);

  pt1:=1;
  repeat
    pt1 := PosEx(lowercase('CountItems('), TheScriptString, pt1+1);
    if pt1>0 then
    begin
      pt2 := PosEx(',', TheScriptString, pt1);
      str1:=  copy(TheScriptString,pt1+11,pt2-pt1-11);
      pt3 := PosEx(',', TheScriptString, pt2+1);
      str2:=  copy(TheScriptString,pt2+1,pt3-pt2-1);
      Delete(TheScriptString, pt1+11,pt3-pt1-11);
      insert(str2+','+str1,TheScriptString,pt1+11);
    end;
  until pt1<1;

  pt1:=1;
  repeat
    pt1 := PosEx(lowercase('ClickAllItems('), TheScriptString, pt1+1);
    if pt1>0 then
    begin
      pt2 := PosEx(',', TheScriptString, pt1);
      str1:=  copy(TheScriptString,pt1+14,pt2-pt1-14);
      pt3 := PosEx(',', TheScriptString, pt2+1);
      str2:=  copy(TheScriptString,pt2+1,pt3-pt2-1);
      Delete(TheScriptString, pt1+14,pt3-pt1-14);
      insert(str2+','+str1,TheScriptString,pt1+14);
    end;
  until pt1<1;

  TheFile:=ReWriteFile(TheScriptPath,true);
  WriteFileString(TheFile,TheScriptString);
  CloseFile(TheFile);
end.

Edit: Somebody wanna change this so that it automatically fixes all scripts in a directory, and also saves the original as ScriptName.scar.OLD rather than rewriting?

From: Zyt3x
Isn't param 1 and param 2 the same? :p

Anyway: It's ok for me, but it will break alot of scripts :/

The same?

And yes it might break a few scripts. But we either change this or change CountItemsIn, ItemAmount, FindItem, FindItemEx and all the other ones.

From: ZephyrsFury
The same?

And yes it might break a few scripts. But we either change this or change CountItemsIn, ItemAmount, FindItem, FindItemEx and all the other ones.

?
Are you going to change more?

From: Hermen
?
Are you going to change more?

Nope.

From: ZephyrsFury
The same?

And yes it might break a few scripts. But we either change this or change CountItemsIn, ItemAmount, FindItem, FindItemEx and all the other ones.

Yeah: 1st param: What it is, 2nd What we're looking for,
What we're looking for is the same as what it is and vice versa :P
It was meant as a joke so dw

And even if more functions are broken, the fixer script above is easy to modify.