SRL Archive - SRL Archives

In the last few months I have been getting lots of run times errors from WizzyPlugin in ChooseoptionMulti ( In different spots ).
So today I switched to 3.2d, and I got this Run time error [Runtime Error] : Exception: Access violation at address 04C0DACD in module 'WizzyPlugin.dll'. Write of address 41412F9A in line 587 in script C:\Program Files\SCAR 3.20\includes\SRL/SRL/Core/Text.scar on this line TPA := ReturnPointsNotInTPA(TPA, B);
Thats one of many.
I told Wizzup on teh IRC, and he told me to post here.

Works fine for me.. :o using 3.20d + dev rev..

I get the same error! But I get it for almost everything in WizzyPlugin… FindColorsTolerance returns me with an error too.

I've got it once now.

http://www.villavu.com/forum/showpost.php?p=572848&postcount=2001
http://www.villavu.com/forum/showpost.php?p=552300&postcount=1938
- http://www.villavu.com/forum/showpost.php?p=553784&postcount=1949 (same person)
- http://www.villavu.com/forum/showpost.php?p=554009&postcount=1950 (same person)
http://www.villavu.com/forum/showpost.php?p=553495&postcount=1944

I got it again last night. Same error. (After 4 hours with my Guild Miner)
/me checks out those links

Edit: Zytex, I'm not getting out of Memory Errors. 4/5 of those are out of memory. (I got Out Of Memory when I was using ForeFeathers as well)

Tbh, I think this is a scar problem, not an SRL one.

By looking at the code, I think you might get an error in ReturnPointsNotInTPA if there are duplicate points in your TPA or when points fall out of the box.

So maybe a ClearDoubleTPA before calling it?

From: nielsie95
By looking at the code, I think you might get an error in ReturnPointsNotInTPA if there are duplicate points in your TPA or when points fall out of the box.

I wrote the function mainly for Quiz Master, I don't think I added any error checking. Most likely ChooseOptionMulti isn't using is correctly, or forgot some failsafe / check.

i have never got any errors from wizzyplugin :)

~shut

So, Freddy, take a look at this?

From: noidea
So, Freddy, take a look at this?

As Wizzup said, it might be in the plugin. I guess I will take a look at it later.

Try adding a ClearDoubleTPA before it..

Yes i'v had same Error ( We discussed about this in IRC ) :) But itäs cool i know that you guys will handle it (;

~Home

From: nielsie95
Try adding a ClearDoubleTPA before it..

I'd rather use a different solution, that would slow it down would it not?

Slow > Run Time Error
…

From: noidea
Slow > Run Time Error
…

Seems like there should be a faster solution though.. Doesn't it?

From: Nava2
I'd rather use a different solution, that would slow it down would it not?

Lol. Probably not. But you can use it to see if it's really the problem.

From: Nava2
I'd rather use a different solution, that would slow it down would it not?

It shouldn't slow it down too much really, unless you use *huge* TPA's.
I could rewrite it this evening…

EDIT: It would be nice if you can check if this is indeed the problem.

EDIT2: I took a look at the function, and this should fix it:

8,9d7
<   SetLength(Result, ((Box.X2 - Box.X1 + 1) * (Box.Y2 - Box.Y1 + 1)) - Length(TotalTPA));
< 
11d8
< 
14a12
>   SetLength(Result, Length(TotalTPA);  
24a23
>   SetLength(Result, I);

Note that will still error if you pass an invalid (too small) TBox.

Full code…

Function ReturnPointsNotInTPA(Const TotalTPA: TPointArray; Box: TBox): TPointArray;

Var
   X, Y, I: Integer;
   B: Array Of Array Of Boolean;

Begin
  SetLength(B, Box.X2 - Box.X1 + 1, Box.Y2 - Box.Y1 + 1);
  For I := 0 To High(TotalTPA) Do
    B[TotalTPA[I].X - Box.X1][TotalTPA[I].Y - Box.Y1] := True;

  SetLength(Result, Length(TotalTPA);  
  I := 0;
  For X := 0 To Box.X2 - Box.X1 Do
    For Y := 0 To Box.Y2 - Box.Y1 Do
      If Not B[X][Y] Then
      Begin
          Result[I].X := X + Box.X1;
          Result[I].Y := Y + Box.Y1;
        I := I + 1;
      End;
  SetLength(B, 0);
  SetLength(Result, I);
End;   

So.. can you like give us the 'updated' dll or something? I don't know anything about that :S

Any gain on this?
I saw Shut's thread.

I think Nava is adding it.

Shuts problem may or may not be related, although the problem does appear to exist in the same module.

From what i can gather this issue was/is an intermittent problem.

The current issue that shuttle highlighted and I for one experience was introduced in Open Dev 44 and is repeatable every time when any parameter of any ChooseOption routine is run.

Okay, so I have been playing with the ReturnPointsNotInTPA and I cannot seem to fix it.

Anyone else have any solutions? Here is what is in there:

Function ReturnPointsNotInTPA(Const TotalTPA: TPointArray; const Box: TBox): TPointArray;
var
  x, y, w, h, i, l: integer;
  B: Array of Array of Boolean;
begin;
  w := Box.x2 - Box.x1;
  h := Box.y2 - Box.y1;
  if (w = 0) and (h = 0) then
    Exit;
  SetLength(b, w + 1, h + 1);
  l := High(TotalTPA);
  x := 0;
  for i := 0 to l do
    if ((TotalTPA[i].x >= Box.x1) and (TotalTPA[i].x <= Box.x2) and
        (TotalTPA[i].y >= Box.y1) and (TotalTPA[i].y <= Box.y2)) then
    begin;
      Inc(x);
      B[TotalTPA[i].x-Box.x1][TotalTPA[i].y-Box.y1] := True;
    end;
  if x = 0 then
    Exit;
  SetLength(result,(w + 1) * (h + 1) - x);
  i := 0;
  for x := 0 to w do
    for y := 0 to h do
      if not B[x][y] then
      begin;
        Result[i].x := x + Box.x1;
        Result[i].y := y + Box.y1;
        Inc(i);
      end;
  SetLength(b,0);
end;

What is the purpose of the function exactly…? I don't get why your making it so complicated if its just to return all the TPAs that are do not match point from the TBox..? Unless i'm not understanding what your trying to do exactly…



~NS

From: Nadeem
What is the purpose of the function exactly…? I don't get why your making it so complicated if its just to return all the TPAs that are do not match point from the TBox..? Unless i'm not understanding what your trying to do exactly…



~NS

It's the easiest and fastest way todo it.

Yes, I got it. I was thinking of something else at that time.

This is what I got, but its more less the same. I was thinking of maybe even making a pre-TPA gathering all the valid TBox points and if then for the filter at the end, but thats more time consuming :/

function ReturnPointsNotInTPA(const TotalTPA: TPointArray; Box: TBox): TPointArray;
var
  I, II, R, L, W, H: Integer;
  B: array of array of Boolean;
begin
  W := iAbs(Box.x2 - Box.x1);
  H := iAbs(Box.y2 - Box.y1);
  if (W = 0) or (H = 0) then
  begin
    SetLength(Result, 1);
    Result[0].x := -1;
    Result[0].y := -1;
    Exit;
  end;
  
  SetLength(B, W + 1, H + 1);
  SetLength(Result, (W + 1) * (H + 1));
  L := Length(TotalTPA) - 1;
  
  // This could also be, B[][] := PointInBox(TotalTPA[I], Box);
  for I := 0 to L do
    if (TotalTPA[I].x >= Box.x1) and (TotalTPA[I].x <= Box.x2) and
       (TotalTPA[I].y >= Box.y1) and (TotalTPA[I].y <= Box.y2) then
      B[TotalTPA[I].x - Box.x1][TotalTPA[I].y - Box.y1] := True;
  
  for I := 0 to W do
    for II := 0 to H do
      if not B[I][II] then
      begin
        Result[R].x := I + Box.x1;
        Result[R].y := II + Box.y1;
        R := R + 1;
      end;
      
  SetLength(B, 0, 0);
  SetLength(Result, R);
end;

~NS

From: Nava2
Okay, so I have been playing with the ReturnPointsNotInTPA and I cannot seem to fix it.

Anyone else have any solutions? Here is what is in there:

Function ReturnPointsNotInTPA(Const TotalTPA: TPointArray; const Box: TBox): TPointArray;
var
  x, y, w, h, i, l: integer;
  B: Array of Array of Boolean;
begin;
  w := Box.x2 - Box.x1;
  h := Box.y2 - Box.y1;
  if (w = 0) and (h = 0) then
    Exit;
  SetLength(b, w + 1, h + 1);
  l := High(TotalTPA);
  x := 0;
  for i := 0 to l do
    if ((TotalTPA[i].x >= Box.x1) and (TotalTPA[i].x <= Box.x2) and
        (TotalTPA[i].y >= Box.y1) and (TotalTPA[i].y <= Box.y2)) then
    begin;
      Inc(x);
      B[TotalTPA[i].x-Box.x1][TotalTPA[i].y-Box.y1] := True;
    end;
  if x = 0 then
    Exit;
  SetLength(result,(w + 1) * (h + 1) - x);
  i := 0;
  for x := 0 to w do
    for y := 0 to h do
      if not B[x][y] then
      begin;
        Result[i].x := x + Box.x1;
        Result[i].y := y + Box.y1;
        Inc(i);
      end;
  SetLength(b,0);
end;

Remove the -x or add a check if you already set the point when counting x.
Also, see this.

EDIT: Nadeem's code should work too?

Although this is a bit over the top:

  if (W = 0) or (H = 0) then
  begin
    SetLength(Result, 1);
    Result[0].x := -1;
    Result[0].y := -1;
    Exit;
  end;

I just redownloaded SRL and both my friend and I get [Runtime Error] : Exception: in line 584 in script C:\Program Files\SCAR 3.20\includes\SRL/SRL/Core/Text.scar
every time ChooseOption is called.
Thanks for working on this guys :)

Never happened to me, never. Running Win7 with SCAR 3.20d, portable and non-portable. No problems :)

From: noidea
I just redownloaded SRL and both my friend and I get [Runtime Error] : Exception: in line 584 in script C:\Program Files\SCAR 3.20\includes\SRL/SRL/Core/Text.scar
every time ChooseOption is called.
Thanks for working on this guys :)

Same thing :) Hopefully it will be fixed soon :) Thanks for your effort guys!


~Home

In a function i wrote that handles the gate for the cows south of falador, I use 2 things that in my mind set off the error i get.

error: Access violation at address 00529608 in module 'scar.exe'. Read of address 0000006C

I use "FindColorSpiralTolerance" and "ChooseOption".

heres the function:

Function HandleGate: boolean;
var
  G:TPoint;
begin
  G:=Point(3032, 3313);
  if not(loggedin) then exit;
  MyRandoms;
  if FindObjectEx(G, 7050, 5) then
  begin
    Writeln('Attempting to handle gate.');
    if (GetMyPos.x = 3031) then
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 257, 183, 281, 237, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          ChooseOption('pen');
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end else
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 208, 119, 225, 225, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          ChooseOption('pen');
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end;
  end else Writeln('Gate already open, walking in the cow pen now.');
end;

Can anyone help me? I think its a problem with scar, but i have no idea.

Try this my friend, I replaced the ChooseOption with a find text :).

Function HandleGate: boolean;
var
  G:TPoint;
begin
  G:=Point(3032, 3313);
  if not(loggedin) then exit;
  MyRandoms;
  if FindObjectEx(G, 7050, 5) then
  begin
    Writeln('Attempting to handle gate.');
    if (GetMyPos.x = 3031) then
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 257, 183, 281, 237, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          ChooseOption('pen');
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end else
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 208, 119, 225, 225, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if FindText(x, y, 'pen', UpChars, x, y, x + 100, y + 100) then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          ChooseOption('pen');
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end;
  end else Writeln('Gate already open, walking in the cow pen now.');
end;

I'll try that, although it looks like you changed absolutely nothing. =\
maybe im blind.

EDIT: NVM, lol, i see it now. =]
i hope it works =]

EDIT again >.>: Didn't work, im still getting an access violation error. Im soooo confused. =[

Fine nielsie :P

Here:

function ReturnPointsNotInTPA(const TotalTPA: TPointArray; Box: TBox): TPointArray;
var
  I, II, R, L, W, H: Integer;
  B: array of array of Boolean;
begin
  W := iAbs(Box.x2 - Box.x1);
  H := iAbs(Box.y2 - Box.y1);
  if (W = 0) or (H = 0) then Exit;
  SetLength(B, W + 1, H + 1);
  SetLength(Result, (W + 1) * (H + 1));
  L := Length(TotalTPA) - 1;

  for I := 0 to L do
    if (TotalTPA[I].x >= Box.x1) and (TotalTPA[I].x <= Box.x2) and
       (TotalTPA[I].y >= Box.y1) and (TotalTPA[I].y <= Box.y2) then
      B[TotalTPA[I].x - Box.x1][TotalTPA[I].y - Box.y1] := True;

  for I := 0 to W do
    for II := 0 to H do
      if not B[I][II] then
      begin
        Result[R].x := I + Box.x1;
        Result[R].y := II + Box.y1;
        R := R + 1;
      end;
  SetLength(B, 0, 0);
  SetLength(Result, R);
end;

Hey, Try this:

Function HandleGate: boolean;
var
  G:TPoint;
  V: TIntegerArray;
begin
  G:=Point(3032, 3313);
  if not(loggedin) then exit;
  MyRandoms;
  if FindObjectEx(G, 7050, 5) then
  begin
    Writeln('Attempting to handle gate.');
    V := [257, 183, 281, 237, 4, 208, 119, 225, 225, 4];
    if (GetMyPos.x = 3031) then F := 0 else F := 5;
    if FindColorSpiralTolerance(x, y, 5401208, V[F], V[F+1], V[F+2], V[F+3], V[F+4]) then
    begin
      MMouse(x, y, 2, 2);
      wait(100+Random(75));
      if IsUpText('pen') then
      begin
        GetMousePos(x, y);
        Mouse(x, y, 0, 0, false);
        wait(100+Random(75));
        ChooseOption('pen');
        Writeln('Successfully opened gate. =D');
        GatesOpened:=GatesOpened+1;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end else
    begin
      Writeln('Failed to find gate.');
      LogOut;
      TerminateScript;
    end;
  end else
    Writeln('Gate already open, walking in the cow pen now.');
end;

I shortened up the code, and added GetMousePos(); If that doesn't work, try increasing the characters used in ChooseOption? Ex: 'pen gat', 'Open'



~NS

get srl dev rev 32
i done it and i havent got one runtime error since :)
something was changed in wizzyplugin in dev rev 33

~shut

Rune Pro: Sorry my bad use this:

Function HandleGate: boolean;
var
  G:TPoint;
begin
  G:=Point(3032, 3313);
  if not(loggedin) then exit;
  MyRandoms;
  if FindObjectEx(G, 7050, 5) then
  begin
    Writeln('Attempting to handle gate.');
    if (GetMyPos.x = 3031) then
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 257, 183, 281, 237, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          if FindText(x, y, 'pen', UpChars, x, y, x + 100, y + 100) then
            Mouse(x, y, 0, 0, True);
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end else
    begin
      if FindColorSpiralTolerance(x, y, 5401208, 208, 119, 225, 225, 4) then
      begin
        MMouse(x, y, 2, 2);
        wait(100+Random(75));
        if IsUpText('pen') Then
        begin
          Mouse(x, y, 0, 0, false);
          wait(100+Random(75));
          if FindText(x, y, 'pen', UpChars, x, y, x + 100, y + 100) then
            Mouse(x, y, 0, 0, True);
          Writeln('Successfully opened gate. =D');
          GatesOpened:=GatesOpened+1;
        end else
        begin
          Writeln('Failed to find gate.');
          LogOut;
          TerminateScript;
        end;
      end else
      begin
        Writeln('Failed to find gate.');
        LogOut;
        TerminateScript;
      end;
    end;
  end else Writeln('Gate already open, walking in the cow pen now.');
end;

That should work :)

The first one got this: [Error]: Access violation at address 00529608 in module 'scar.exe'. Read of address 00000280

second one: [Error]: Access violation at address 00529608 in module 'scar.exe'. Read of address 0000018C

I have no idea what could be wrong…

Hmm… Maybe try this on a different version of SCAR…? Or probably just do what Shuttleu's recommending, i.e: dl dev rev 32



~NS

From: Nadeem
Hmm… Maybe try this on a different version of SCAR…? Or probably just do what Shuttleu's recommending, i.e: dl dev rev 32



~NS

I just used 3.15b, and it worked. I then updated it's SRL, and then it stopped working.

Something has changed is the latestt revs

Yes… The function ReturnPoints was changed.

Then maybe revert back to the previous one, or at least differentiate between what was changed to pin point error and come up with a better solution? :)



~NS

Here is the old plugin if any one wants.

nice post :) only one thing, its a dll…! a .dbr or .pas would've been better/easier IMO



~NS

Here. The dll was just for people that need to use. Here is the other :)

I have an idea to fix it. Give me a few.

Double posting, but does the newest one work?

From: Nava2
Double posting, but does the newest one work?

No, same error. :( Happens in ChooseOption for me.

What was there change? I'd like to see please :)



~NS

From: Nadeem
Fine nielsie :P

Here:

function ReturnPointsNotInTPA(const TotalTPA: TPointArray; Box: TBox): TPointArray;
var
  I, II, R, L, W, H: Integer;
  B: array of array of Boolean;
begin
  W := iAbs(Box.x2 - Box.x1);
  H := iAbs(Box.y2 - Box.y1);
  if (W = 0) or (H = 0) then Exit;
  SetLength(B, W + 1, H + 1);
  SetLength(Result, (W + 1) * (H + 1));
  L := Length(TotalTPA) - 1;

  for I := 0 to L do
    if (TotalTPA[I].x >= Box.x1) and (TotalTPA[I].x <= Box.x2) and
       (TotalTPA[I].y >= Box.y1) and (TotalTPA[I].y <= Box.y2) then
      B[TotalTPA[I].x - Box.x1][TotalTPA[I].y - Box.y1] := True;

  for I := 0 to W do
    for II := 0 to H do
      if not B[I][II] then
      begin
        Result[R].x := I + Box.x1;
        Result[R].y := II + Box.y1;
        R := R + 1;
      end;
  SetLength(B, 0, 0);
  SetLength(Result, R);
end;

~NS

I honestly don't see the use for all those failsafes… If you just make sure you pass a correct box everything is well… I've already submitted a patch to nava which should fix the issue.

All this checking is just too much overhead IMO. If I start passing random params to Functions in SCAR it will most likely crash too. You can't add failsafes for everything… :)

From: Wizzup?
I honestly don't see the use for all those failsafes… If you just make sure you pass a correct box everything is well… I've already submitted a patch to nava which should fix the issue.

All this checking is just too much overhead IMO. If I start passing random params to Functions in SCAR it will most likely crash too. You can't add failsafes for everything… :)

lolz kk! :)



~NS

From: Nadeem
lolz kk! :)



~NS

Well… I don't really mind either way though… If yours works better, it can just be put in as well… It would be considerably slower, so you might add it with a different name, eg: ReturnPointsNotInTPASafe… :)

As you wish bro :) It's your function.



~NS

From: Wizzup?
Well… I don't really mind either way though… If yours works better, it can just be put in as well… It would be considerably slower, so you might add it with a different name, eg: ReturnPointsNotInTPASafe… :)

Can I have this patch?

Or is it the same one.. because that didn't work.. o.O

Is it fixed. I don't quite understand.

In most cases 'No news is a good news!' but ATM I'm a bit confused. It seemed a few days ago it's getting fixed but after that no feedback at all!? So, Is it or isn't it fixed?

From: bugger0001
In most cases 'No news is a good news!' but ATM I'm a bit confused. It seemed a few days ago it's getting fixed but after that no feedback at all!? So, Is it or isn't it fixed?

I don't think it is fixed ( Note i'm not toally sure ) But if you use OpenDev version just replace that plugn with Offcicial Rev #33 version Plugin :)

I hope this helped even a little bit someone :)

~Home

Well I've tried that, but doing so makes me get Runtime Errors after solving randoms. Then the problem occurs in the text.scar line 451 where's

Result := FindTextTPAinTPA(yy,TextTPA,SearchTPA,Matches);

Don't know if this ones also in Wizzy or not…

fixed in openDev, be sure to move the pluggins.

~RM

From: Rasta Magician
fixed in openDev, be sure to move the pluggins.

~RM

I think you could even add a check for that… Take a md5 sum of each dll, and see if it matches the current one. ;)

I just got the error xD Didn't know it was fixed already :O
Anyway tysm! Just got it at a 7 hr proggy >.>