SRL Archive - Archive

cycrosism - SRL Member Application


cycrosism

2009-05-20 11:44:00

How Long have You Played Runescape?
6 Year(s)


Are you affilated in anyway with Jagex LTD?
No

Were you Referred to SRL?



What is your general programming knowledge?
Visual Basic, A little bit of Java and PHP


Are you a member of any other communities?
RSbot, Scythe, MoparScape, rs-hacking and Freddy1990.


Tell us about yourself…
From: cycrosism
My name is Mark and for a hobby I enjoy using computers and gardening. In my spare time I go on my computer or tend to my garden which has various plants in it. I also play 2 sports which is Cricket and Basketball.

I got an A in I.T and an A+ in Computer programming last year and I am doing I.T this semester and programming nest semester for this year.



Please show us one (or multiple) of your scripts.
The best progress report posted so far is

Worked for 15 Hours, 23 Minutes and 6 Seconds
Gained 665280 Exp
Chopped 9856 Willows
Gained 10 Levels


//Main Script is below


program Drain_willows; {Version 6.3}
{.include SRL/SRL/Misc/Smart.scar}
{.Include SRL\SRL.SCAR}

Var
logs, logxp, x, y:Integer;

const
member = false; //True if you are autoing in member world

procedure DeclarePlayers;
begin
HowManyPlayers := 1; //How many players?
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := 0;
Players[0].Name := ''; //username
Players[0].Pass := ''; //password
Players[0].Nick := ''; //3-4 letters of name
Players[0].Pin := ''; //bank Pin
Players[0].Booleans[1] := true; //true if using sleep
Players[0].Integers[1] := 10+random(10); //Switch players/relog after how many loads?
Players[0].BoxRewards := ['XP', 'ostume']; //Use the random event box on what?
Players[0].Active := True;
{
Players[1].Name := ''; //username
Players[1].Pass := ''; //password
Players[1].Nick := ''; //3-4 letters of name
Players[1].Pin := ''; //Bank Pin
Players[1].Booleans[1] := true; //true if using sleep
Players[1].BoxRewards := ['XP', 'ostume']; //Use the random event box on what?
Players[1].Active := True;
}{
Players[2].Name := ''; //username
Players[2].Pass := ''; //password
Players[2].Nick := ''; //3-4 letters of name
Players[2].Pin := ''; //Bank Pin
Players[2].Booleans[1] := true; //true if using sleep
Players[2].BoxRewards := ['XP', 'ostume']; //Use the random event box on what?
Players[2].Active := True;
}{
Players[3].Name := ''; //username
Players[3].Pass := ''; //password
Players[3].Nick := ''; //3-4 letters of name
Players[3].Pin := ''; //Bank Pin
Players[3].Booleans[1] := true; //true if using sleep
Players[3].BoxRewards := ['XP', 'ostume']; //Use the random event box on what?
Players[3].Active := True;
}
end;

procedure AntiBan;
begin
if not LoggedIn then Exit;
case Random(251) of
0: Begin
RandomRClick;
wait(1000+random(1000));
end;
50: HoverSkill('random', False);
100: HoverSkill('Woodcutting', False);
150: RandomMovement;
200: BoredHuman;
250: If (Players[CurrentPlayer].Booleans[1] = true) then
Begin
Writeln('Sleeping');
SleepAndMoveMouse(1000+random(6000));
Writeln('Finished sleeping');
end;
end;
end;

Procedure AntiRandom;
begin
FindNormalRandoms;
If FindFight then
begin
Disguise('Running from fight');
runaway('E',true,1,5000+random(2000));
end;
end;

function FindDirtRoadColorEx: Integer;
var
i, Red, Green, Blue, GC, TestColor: Integer;
P: TPointArray;
begin
GC := 2115926;
FindColorsSpiralTolerance(MMCX, MMCY, P, GC, MMX1, MMY1, MMX2, MMY2, 55);
for i:=0 to High(p)-1 do
begin
if rs_OnMinimap(P[i].x,P[i].y) then
begin
TestColor := GetColor(P[i].x,P[i].y);
ColorToRGB(TestColor, Red, Green, Blue);
if InRange(Red - Blue, 36, 71) then
if InRange(Red - Green, 8, 34) then
if InRange(Green - Blue, 24, 53) then
if GetColor(P[i].x + 2, P[i].y + 2) = TestColor then
if GetColor(P[i].x + 1, P[i].y + 1) = TestColor then
if GetColor(P[i].x, P[i].y + 2) = TestColor then
if GetColor(P[i].x + 2, P[i].y) = TestColor then
if GetColor(P[i].x, P[i].y + 1) = TestColor then
if GetColor(P[i].x + 1, P[i].y) = TestColor then
if GetColor(P[i].x + 2, P[i].y + 1) = TestColor then
if GetColor(P[i].x + 1, P[i].y + 2) = TestColor then
begin
Result := TestColor;
Writeln('Dirt Road Color = '+IntToStr(Result));
exit;
end;
end;
end;
WriteLn('Could not find Dirt Road Color!');
Result := 0;
end;

procedure DeathWalk;
Var
x,y,hometeleDTM,HomeTeleBIT:integer;
begin
HomeTeleDTM := DTMFromString('78DA63FCC3CCC07087910119FCFDF70F4CC34' +
'4197F01D53C4655D3D7FB1955CD4FA09AEBA86AAAAA7EA0AA6160214' +
'ECD03026AFE12E19EAF98FEC2500332E7320135AC40F7DCC6AF06003' +
'B5820DA');
HomeTeleBIT := BitmapFromString(24, 24, 'beNpzMPFwGDKIgYE' +
'RDZFtSF/vZzgi1ShME8gwDdkQUSF9NESkUZiGVFX9gCPijUI2BNkE' +
'NNPgRuF3DLJLTE3y4AjNVVidhMuQv//+QaSADGKMwvQRUBdEO9wcI' +
'IlsFFbfoZkDMQTTHLhRZJgDR2SYQ56/vFysqBXOZMc70A3USocQo5' +
'ANpCRfAM2BGOVsbQhEVMmn5JQbduSXY3Av0K1cJck6sk3AogYAZGI' +
'N/w==');
If not loggedin then exit;
if(not(FindLumbyRoadColor > 0)) then
begin
Writeln('Death walk activated');
GameTab(7);
Disguise('We are lost - Doing death walk');
if FindDTM(HomeTeleDTM, X, Y, MIX1, MIY1, MIX2, MIY2) then
begin
Mouse(X, Y, 10, 10,true);
End else
begin
If (FindBitmap(HometeleBIT,x,y)) then
Begin
Mouse(X+11, Y+10, 10, 10,true);
end;
end;
Wait(500+random(500));
If (FindBlackChatMessage('need to wait')) then
Repeat
Writeln('You need to wait another X minutes to cast this spell');
Logout;
Writeln('Waiting 5 minutes');
wait(60000*5);
Loginplayer;
Gametab(7);
if FindDTM(HomeTeleDTM, X, Y, MIX1, MIY1, MIX2, MIY2) then
Mouse(X, Y, 10, 10,true)
else begin
if(FindBitmap(HometeleBIT, X, Y)) then
Mouse(X+11, Y+10, 10, 10,true)
else
Mouse(571, 228, 12, 12, true);
end;
wait(500+random(500));
Until(not(FindBlackChatMessage('need to wait')));
If (FindBlackChatMessage('need to wait')) then
Repeat
Writeln('You need to wait another X minutes to cast this spell');
Logout;
Disguise('Waiting 5 minutes');
Writeln('Waiting 5 minutes');
wait(60000*5);
Loginplayer;
Gametab(7);
if FindDTM(HomeTeleDTM, X, Y, 557, 214, 605, 259) then
begin
Mouse(X, Y, 10, 10,true);
end else
begin
Mouse(571, 228, 12, 12,true);
end;
wait(500+random(500));
Until(not(FindBlackChatMessage('need to wait')));
FreeDTM(HomeTeleDTM);
FreeBitmap(HomeTeleBIT);
wait(17500+Random(5000));
end else
Disguise('Walking back');
Writeln('Walking Back');
Makecompass('n');
SetAngle(True);
Setrun(true);
RadialRoadWalk(FindLumbyRoadColor, 30, 80, 65, 1, 1);
RadialRoadWalk(FindLumbyRoadColor, 340, 0, 50, 1, 1);
RadialRoadWalk(FindLumbyRoadColor, 270, 345, 60, 1, 1);
RadialRoadWalk(FindLumbyRoadColor, 240, 330, 40, 1, 1);
RadialRoadWalk(FindLumbyRoadColor, 240, 330, 40, 1, 1);
If(FindDirtRoadColorEx > 0) then
begin
RadialWalk(FindDirtRoadColorEx, 200, 310, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 200, 310, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 200, 310, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 200, 310, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 180, 300, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 180, 300, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 180, 300, 65, 1, 1);
end else
begin
Writeln('Player is lost');
Players[CurrentPlayer].Active := False;
Logout;
Exit;
end;
If(FindRoadColor > 0) then
begin
RadialRoadWalk(FindRoadColor, 270, 360, 60, 1, 1);
RadialRoadWalk(FindRoadColor, 270, 360, 60, 1, 1);
end else
begin
Writeln('Player is lost');
Players[CurrentPlayer].Active := False;
Logout;
Exit;
end;
Cleardebug;
Writeln('Bank Symbol on screen: '+BoolToStr(FindSymbol(x, y, 'bank')));
SymbolAccuracy := 0.7;
If(FindSymbol(X, Y, 'bank')) then
Begin
Mouse(X, Y, 4, 4, True);
FFlag(10);
Writeln('We returned to the bank');
If (FindWaterColor > 0) then
Begin
If (FindSymbol(X, Y, 'bank')) then
begin
mouse(x-30,y+30,6,6,true);
FFlag(10);
end;
end else
begin
Writeln('No water found on screen');
Writeln('No bank symbol found on screen');
Writeln('Player is lost, Setting to false');
Players[CurrentPlayer].Active := False;
Logout;
Exit;
end;
end;
FreeDTM(HometeleDTM);
FreeBitmap(HomeTeleBIT);
end;

procedure ChopWillow;
var
CTS, x, y, i, b, xtr: Integer;
Points: TPointArray;
Pointe: TPoint;
Pointers: T2DPointArray;
begin
if not (LoggedIn) then Exit;
Repeat
CTS := GetColorToleranceSpeed;
ColorToleranceSpeed(3);
FindColorsSpiralTolerance(MSCX, MSCY, Points, 5865581, MSX1, MSY1, MSX2, MSY2, 5);
ColorToleranceSpeed(CTS);
Pointers := SplitTPA(Points, 4);
SortATPASize(Pointers, True);
b := High(Pointers);
Antirandom;
for i:=0 to b do
begin
Pointe := MiddleTPA(Pointers[i]);
Wait(50+random(50));
MMouse(Pointe.x, Pointe.y, 4, 4);
if IsUpText('illo') then
begin
GetMousePos(X, Y);
Wait(10+random(10));
Mouse(X, Y, 1, 1, True);
Disguise('Chopping');
Wait(2000+random(1000));
MarkTime(xtr);
While (IsUpText('illo')) Do
Begin
If (Not(Loggedin)) Then exit;
wait(500);
Antiban;
Antirandom;
If (FindBlackChatMessage('you are dead')) then
Begin
Writeln('You died');
Disguise('Player is dead! Deathwalk activated');
Deathwalk;
end;
If(TimeFromMark(xtr)>50000) then break;
end;
end;
end;
Until(InvFull);
If(Players[CurrentPlayer].Booleans[0]) Then
Begin
Logs:= Logs+ 28;
Logxp := Round(Logs * 67.5);
End Else
Begin
Logs:= Logs+ 27;
Logxp := Round(Logs * 67.5);
end;
end;

procedure ProgressReport;
Begin
ClearDebug;
Writeln('-------------------------------');
Writeln('Worked for '+TimeRunning);
Writeln('Gained ' + FloatToStr(Logxp) + ' Exp');
Writeln('Chopped '+IntToStr(Logs)+' Willows');
Writeln('-------------------------------');
end;

function WalkingDDTM: Integer;
var
dtmMainPoint: TDTMPointDef;
dtmSubPoints: Array [0..1] of TDTMPointDef;
TempTDTM: TDTM;
begin
AntiRandom;
dtmMainPoint.x := 582;
dtmMainPoint.y := 188;
dtmMainPoint.AreaSize := 0;
dtmMainPoint.AreaShape := 0;
dtmMainPoint.Color := FindWaterColor;
dtmMainPoint.Tolerance := 1;

dtmSubPoints[0].x := 582;
dtmSubPoints[0].y := 188;
dtmSubPoints[0].AreaSize := 0;
dtmSubPoints[0].AreaShape := 0;
dtmSubPoints[0].Color := FindWaterColor;
dtmSubPoints[0].Tolerance := 1;

dtmSubPoints[1].x := 575;
dtmSubPoints[1].y := 178;
dtmSubPoints[1].AreaSize := 0;
dtmSubPoints[1].AreaShape := 0;
dtmSubPoints[1].Color := FindRockColor;
dtmSubPoints[1].Tolerance := 1;

TempTDTM.MainPoint := dtmMainPoint;
TempTDTM.SubPoints := dtmSubPoints;
Result := AddDTM(TempTDTM);
end;

Procedure WalkToWillow;
Var
WaterRocks:Integer;
begin
If (not(loggedin)) then exit;
Disguise('Walking to the willows');
MakeCompass('N');
FindNormalRandoms;
WaterRocks:= WalkingDDTM;
if FindDTM(WaterRocks, X, Y, MMX1,MMY1,MMX2,MMY2) then
begin
Mouse(X+(33), Y+(4), 6, 6, True);
FFlag(10);
FreeDTM(WaterRocks);
end else
begin
Writeln('DDTM method failed');
FreeDTM(WaterRocks);
wait(500+random(1000));
If (FindWaterColor > 0) then
Begin
If (FindSymbol(X, Y, 'bank')) then
begin
mouse(X-30, Y+30, 6, 6, true);
FFlag(10);
Writeln('Used water and bank symbol method');
end else Writeln('Could not find bank symbol');
wait(500+Random(1000));
if (FindSymbol(x, y, 'fishing spot')) then
begin
Mouse(X, Y, 7, 7, true);
FFlag(10);
end else
DeathWalk;
end else
DeathWalk;
end;
end;

procedure Bank;
begin
if not loggedin then exit;
Setrun(true);
Disguise('Walking to bank');
if (FindSymbol(X, Y, 'bank')) then
begin
FindColor(X, Y, FindRockColor, 627, 8, 698, 161);
Mouse(X+(3), Y-(40), 10, 10, true);
FFlag(10);
OpenBank('db', true, true);
If(Players[CurrentPlayer].Booleans[0]) Then
Begin
DepositAll;
Closebank;
ProgressReport;
End Else
Begin
Deposit(2, 28, True);
CloseBank;
ProgressReport;
end;
end else
begin
Writeln('Looking for bank symbol');
begin
symbolAccuracy := 0.4;
if (FindSymbol(X, Y, 'bank')) then
Begin
Mouse(X, Y, 5, 5, True);
FFlag(7);
OpenBank('db', true, true);
Disguise('Depositing');
If(Players[CurrentPlayer].Booleans[0]) Then
Begin
DepositAll;
Closebank;
ProgressReport;
End Else
Begin
Deposit(2, 28, True);
CloseBank;
ProgressReport;
end;
end else
DeathWalk;
end;
end;
end;

Procedure CheckIfUsingAxe;
begin
Disguise('Auto-detecting axe');
Gametab(4);
MMouse(578, 229, 8, 8);
wait(500);
if(isuptext('hatchet')) then
begin
Writeln('We are not weilding an axe');
Players[CurrentPlayer].Booleans[0] := false;
end else
begin
Gametab(5);
wait(500);
MMouse(585, 305, 8 ,8);
wait(300);
if(isuptext('hatchet')) then
begin
Writeln('Axe is wielded');
Players[CurrentPlayer].Booleans[0] := true;
Gametab(4);
end else
begin
Writeln('No axe found');
Logout;
Players[CurrentPlayer].Active := False;
end;
end;
end;

Procedure SetupSmart;
Begin
Disguise('Loading SMART');
Writeln('Loading SMART');
SmartSetupEx(23, member, true, false);
wait(3000);
SetTargetDC(SmartGetDC);
repeat
wait(100);
until(SmartGetColor(253, 233)<>1118604);
Cleardebug;
Writeln('SMART loaded');
Disguise('SMART loaded');
end;

procedure MainLoop;
var
Reps:Integer;
begin
If(not(loggedin)) then loginplayer;
repeat
Reps:=Reps+ 1;
Walktowillow;
ChopWillow;
Bank;
FindLamp('woodcutting');
until(Reps>=Players[0].Integers[1]) or (AllPlayersInactive) or (not(loggedin));
if (AllPlayersInactive) then
begin
Logout;
Cleardebug;
ProgressReport;
Writeln('All players are inactive');
wait(500+random(500));
Writeln('Thank you for using Drain Willows!');
Disguise('Script ended - No players left');
TerminateScript;
end;
If (Reps>=Players[0].Integers[1]) then
begin
Disguise('Switching players');
Reps:=0;
Nextplayer(True);
end;
If(not(loggedin)) then
Begin
If (AllPlayersInactive) then
begin
ClearDebug;
ProgressReport;
Writeln('Player is logged out, failed a random?');
wait(500+random(500));
Writeln('Thank you for using Drain Willows!');
Disguise('Script ended - Not logged in');
TerminateScript;
end else
loginplayer;
end;
end;

Procedure SetupScript;
Begin
Cleardebug;
SetupSRL;
Cleardebug;
SetupSmart;
DeclarePlayers;
If (not(loggedin)) then
begin
Loginplayer;
end;
makecompass('n');
SetAngle(True);
CheckIfUsingAxe;
LampSkill:='woodcutting';
end;

begin
Setupscript;
Repeat
Mainloop;
Until(AllPlayersInactive);
end.

MasterKill

2009-05-20 11:59:26

Your progress report is a bit disappointing, but the script looks fine, yes.

Good job.

Naum

2009-05-20 12:07:15

case Random(250) of

will never pick 250, so your cases are wrong,

Also for CheckIfUsingAxe you could have used a Try, Except case :)


There are lots of things that could be shortened, but apart from that good script.

Yes :) - 70/30

Da 0wner

2009-05-20 12:16:43

random(251) :D.

Dynamite

2009-05-20 12:57:27

Learn some more about cases, but apart from that (as long as there is no hidden past)
Yes.
Good luckk

T~M

Sir R. M8gic1an

2009-05-20 13:08:33

Most definitely not, with an attitude like yours.

~RM

Daniel

2009-05-20 13:09:22

Yup.

You've improved ;)

cycrosism

2009-05-20 13:28:40

From: Rasta Magician
Most definitely not, with an attitude like yours.

~RM


What's wrong with my attitude? Sometimes I get pissed off on the IRC but I don't see what I do wrong on the forum?

Dynamite

2009-05-20 13:29:42

From: Rasta Magician
Most definitely not, with an attitude like yours.

~RM


Aww man not another hidden past? :(

T~M

Da 0wner

2009-05-20 13:38:24

From: The Man
Aww man not another hidden past? :(

T~M


Don't vote on any applications pl0x.
You should not vote on applications as soon as you get into SRL Members. Wait a couple of weeks and see how others are taking the applications and learn.

Dynamite

2009-05-20 13:55:12

From: Da 0wner
Don't vote on any applications pl0x.


Its suggested that new SRL Members look around at recent applications and stick around for a few new ones, just so you know what to look for and what our standard is in terms of new SRL member abilities/attitudes. There's no set time frame though so if you feel like you're ready go ahead and vote.


T~M

NCDS

2009-05-20 16:10:21

Hmm not too bad.

Would seem you know what your doing for the most part.

Walking looks rather weak though:

Disguise('Walking back');
Writeln('Walking Back');
Makecompass('n');
SetAngle(True);
Setrun(true);
RadialRoadWalk(FindLumbyRoadColor, 30, 80, 65, 1, 1);
RadialRoadWalk(FindLumbyRoadColor, 340, 0, 50, 1, 1);
RadialRoadWalk(FindLumbyRoadColor, 270, 345, 60, 1, 1);
RadialRoadWalk(FindLumbyRoadColor, 240, 330, 40, 1, 1);
RadialRoadWalk(FindLumbyRoadColor, 240, 330, 40, 1, 1);
If(FindDirtRoadColorEx > 0) then
begin
RadialWalk(FindDirtRoadColorEx, 200, 310, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 200, 310, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 200, 310, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 200, 310, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 180, 300, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 180, 300, 65, 1, 1);
RadialWalk(FindDirtRoadColorEx, 180, 300, 65, 1, 1);
end else
begin
Writeln('Player is lost');
Players[CurrentPlayer].Active := False;
Logout;
Exit;
end;
Which makes me have some doubt's.

I must go to work now so I'll hold my vote.

I'll check back again later.

The Claw

2009-05-20 18:13:05

You have one of the worst attitudes on the forum, extremely annoying and immature. No.

Dervish

2009-05-20 18:19:02

No.

Naum

2009-05-20 18:19:57

Change my vote to a no then.

P1nky

2009-05-20 19:07:02

due to attitude , NO. Otherwise script looks okay.

I seen couple of posts just now and didn't like it.

http://villavu.com/forum/showthread.php?t=45188… immature posting , just calm down and discuss don't need to Use F bombs and stuff like that..

Dynamite

2009-05-20 19:07:55

From: NaumanAkhlaQ
Change my vote to a no then.


Yeh same for me.

T~M

Blumblebee

2009-05-20 19:37:22

Yes I like you, good script, nice kid, you active on irc, and the forums. (My names Mark too :))

Lance

2009-05-20 19:39:38

i know im a new member so i probably dont have any right to vote, but heres one thing that i noticed that you might want to change for your next revision:
HomeTeleDTM := DTMFromString('78DA63FCC3CCC07087910119FCFDF70F4CC34' +    
'4197F01D53C4655D3D7FB1955CD4FA09AEBA86AAAAA7EA0AA6160214' +
'ECD03026AFE12E19EAF98FEC2500332E7320135AC40F7DCC6AF06003' +
'B5820DA');
HomeTeleBIT := BitmapFromString(24, 24, 'beNpzMPFwGDKIgYE' +
'RDZFtSF/vZzgi1ShME8gwDdkQUSF9NESkUZiGVFX9gCPijUI2BNkE' +
'NNPgRuF3DLJLTE3y4AjNVVidhMuQv//+QaSADGKMwvQRUBdEO9wcI' +
'IlsFFbfoZkDMQTTHLhRZJgDR2SYQ56/vFysqBXOZMc70A3USocQo5' +
'ANpCRfAM2BGOVsbQhEVMmn5JQbduSXY3Av0K1cJck6sk3AogYAZGI' +
'N/w==');
If not loggedin then exit;

if you are logged out and the script rolls over to your DeathWalk function, then it will load your DTM and Bitmap without freeing it. i would put the failsafe before you load them just to be sure there are no membory leaks.

Torrent of Flame

2009-05-20 19:40:24

No. I voted no before I even read any other posts or the script. I'm sorry but your attitude is diabolical. I don't care if you can script, to be honest you are very annoying, immature and aggressive.

Richard

2009-05-20 20:21:19

No, your attitude isn't appropriate for SRL.

Dervish

2009-05-20 20:26:26

From: ~~Joker~~
due to attitude , NO. Otherwise script looks okay.

I seen couple of posts just now and didn't like it.

http://villavu.com/forum/showthread.php?t=45188… immature posting , just calm down and discuss don't need to Use F bombs and stuff like that..


No post of his in there.

senrath

2009-05-20 20:28:57

From: Dr D. Dervish
No post of his in there.


Um, yes there are. Read from the end of page 2 onwards.

Dervish

2009-05-20 20:48:41

Didn't see multiple pages, sorry.

No anyways :p.

marpis

2009-05-20 22:09:54

F***, i had pointed out many phailures in your script and then i accidentally press 'previous page' in my mouse :@ i don't have time to check them again

NO. because of your posts in the thread: Srl Irc ROUND 2

mixster

2009-05-20 22:26:10

DeclarePlayers - You forget to have .Integers[1] for the commented out players. Based on what it is used for, most likely will cause problems for multiplayer.

FindDirtRoadColorEx - You loop through to High(p) - 1. When using High, you don't do -1 for looping unless you have a reason not to use the last index, which there doesn't seem to be in this case. Also, look into FilterPointsPie or something similar for a more advanced method of removing invalid points than just checking if they're on the minimap or not.

DeathWalk - Indenting is horrible here. Normally not a problem, but it makes it much harder to read through. In terms of relogging a player, it may be worth looking into SetTimeOut - it would allow you to set the player to false and have it recall a procedure (after a set time) that sets the player to active. When they then log in, it would be able to then teleport them home and your script wouldn't have to pause for 5 minutes just to allow the player to tele home. If you decide against this, then add some randomness at least so it's 5 minutes + Random(minute) or the like.

The point of the second loop is beyond me as well. The initial loop only breaks if it doesn't find the message, so the second loop is, in theory impossible. What's worse is that if there are no random checks done around it, then it's possible the player will be sunk in an infinite loop of logging out then logging in then failing then logging out etc.

The walking itself is horrible and the several exits show a memory leak in the bitmap and dtm loading (as was said already). After that, you then fail to use NextPlayer(False) and instead manually set the user to false then log them out. You also have a random else at some point (for the Disguise), which looks like it's in there by mistake or should be an else begin … end; - either way, due to the indenting failure, it's hard to link it up, but I think it goes with the second if in the procedure where it checks for the lumby road colour.

Moving on a bit, you later check for if you can find the bank symbol. If not, you then look for the water and then for the bank again. This is extremely illogical as you haven't moved, so the bank shouldn't have magically appeared.

After going through this far, I kind of lost hope. This is the first time I've had to do multiple corrections etc for a single procedure - usually it's only the one paragraph.
Without considering attitude around and the rest of it, it's a no from me. It made my eyes bleed.

Da 0wner

2009-05-21 02:44:11

From: marpis
F***, i had pointed out many phailures in your script and then i accidentally press 'previous page' in my mouse :@ i don't have time to check them again

NO. because of your posts in the thread: Srl Irc ROUND 2


Mm, I have that on my mouse as well. However, when you press it and then you press the forward one, it will keep all the text you had before in the text box (If you have Firefox).

cycrosism

2009-05-21 09:50:21

Well when people say offensive things to me its not very nice like The Claw u called me a scammer when I asked if I could borrow someones account to get colors in varrock, and others are always making fun of me too on the IRC calling me gay and calling me a fag its not very nice and now because i respond to them you are saying I have a bad attitude?

Da 0wner

2009-05-21 10:08:22

I'm not in the IRC much anymore, but they might be saying that in response to you having a bad attitude.

Torrent of Flame

2009-05-21 12:14:31

From: Da 0wner
I'm not in the IRC much anymore, but they might be saying that in response to you having a bad attitude.


Normally how it is. I tried to offer him advice and he still insults me.

cycrosism

2009-05-21 13:36:44

From: Torrent of Flame
Normally how it is. I tried to offer him advice and he still insults me.


If I insulted you it would of been because you insulted me first or said something about me that was offensive

Torrent of Flame

2009-05-21 13:44:50

From: cycrosism
If I insulted you it would of been because you insulted me first or said something about me that was offensive


No. I told you to stop getting frustrated because thats what they wanted and you went off on a rant then /ragequit

cycrosism

2009-05-21 13:50:43

I just want to say I am sorry for anything bad I said to people, and I would love it if people stopped calling me a fag/homo, especially the mods (The Claw).

Nava2

2009-05-21 20:11:56

No, purely on attitude.

The script isn't too bad. Some efficiency things, and maybe some failsafes.

Also, your DDTM has two points.. You should have 3-4 at least. Also, your first sub is your Main… o.O

NCDS

2009-05-21 23:11:47

From: cycrosism
I just want to say I am sorry for anything bad I said to people, and I would love it if people stopped calling me a fag/homo, especially the mods (The Claw).


My suggestion would be to just be as nice and helpful as you can, and try re-applying in a month or so.

Lance

2009-05-22 02:06:59

you know i have never noticed this guy being rude on the IRC, though im not on a whole lot. cycro you may need to be extra nice just because you now have a reputation, people may mis-interperate you for being rude when your not just because they have a preconceived notion of who you are.
The best thing you can do is just not fight, just walk away from people who are pissing you off ;]

Tniffoc

2009-05-22 03:08:21

I've never seen this attitude, but it sounds pretty bad, so I won't vote. To me, cycroism was really nice on IRC.

3Garrett3

2009-05-22 05:49:06

It doesn't matter if you are nice most of the time. If you are going to be a dick randomly, you don't deserve it.

I vote no because of the attitude. You were the one that had a ragequit of the VAIO too, right? I recall someone doing that, and it strikes me as you. I remember you and someone else having bad attitudes and I mix you up. But I know that you do have one, so don't say I'm voting because of someone else.

Anyway. No.

cycrosism

2009-05-22 09:50:59

I can't believe you guys…

Torrent of Flame

2009-05-22 11:28:53

From: cycrosism
I can't believe you guys…


It isn't down to you, I'm afraid. Fix up the script with suggestions laid out here, work on your attitude a little ;) and re-apply in a month.

cycrosism

2009-05-22 11:32:00

Sorry, a month is just too long for me. I'm not complaining or anything but I think I might move to java/rsbot

Da 0wner

2009-05-22 11:41:03

Kthxbai…
But a month is not long.

Torrent of Flame

2009-05-22 11:43:12

From: cycrosism
Sorry, a month is just too long for me. I'm not complaining or anything but I think I might move to java/rsbot


Thats the way to do it. I suppose thats like moving to people who are like you. Alot of those people over there like to flame and don't bother working on it. You have the potential to be a good scripter, but you have the attitude of a 5 year old. Try working on it?

cycrosism

2009-05-22 11:55:12

THERE IS NOTHING WRONG WITH MY ATTITUDE!!!! I am just sick of people always calling me gay and calling me a fag and the second i respond to them with something its "OMG look his being a fag again im gonna put this in sig"

Torrent of Flame

2009-05-22 12:14:04

From: cycrosism
THERE IS NOTHING WRONG WITH MY ATTITUDE!!!! I am just sick of people always calling me gay and calling me a fag and the second i respond to them with something its "OMG look his being a fag again im gonna put this in sig"


[JOKE] Shut up you fag. [/JOKE]

No, there is something wrong with your attitude. You take EVERYTHING to heart, and start rants even when people say 'it was just a joke dude chill', to which you normally go on about how it wasnt actually a joke and why they said it. You have an attitude problem, you start fights because you cant shut the fuck up and just laugh something off.

The Claw

2009-05-22 12:14:17

Wow, even after the whole of SRL tells you you have a bad attitude, you continue to deny it.

From: cycrosism
Sorry, a month is just too long for me. I'm not complaining or anything but I think I might move to java/rsbot


kbye

marpis

2009-05-22 12:26:30

guys, no need to argue about this anymore. he won't learn, just leave it

Naum

2009-05-22 12:42:52

No need to leave over a little thing like that, I'm sure if you started helping around more and stayed passive then things would improve.

Also it took me 8 applications before I became a member :)

Da 0wner

2009-05-22 12:54:22

I applied once :p, but I didn't get in :'(. I didn't take it seriously though.

cycrosism

2009-05-22 12:59:38

The Claw I didnt say I was going to leave it said i may be leaving

Sir R. M8gic1an

2009-05-22 13:04:43

You do have an attitude problem. As Torrent of Flame said, learn to laugh things off. Someone calls you gay. So what? Worst case scenario tell them you became gay after you did their mother. That ought to shut most up. But don't go raging.

Also, don't be a quitter. "A month is too long" - screw that. You've been here nearly 6 months. One more to get members won't kill you. Also, why do you want members?? The yellow name and the respect? Well, for that you'd need to have a good attitude. Many Junior Members are respected for their attitudes. So respected indeed that they sometimes don't even have to apply.

For the scripts? If the answer to that is yes, then please, go to java.

To be part of the SRL Members rank, to enjoy talking to all the othe SRL Members, to be part of a more elite group? Work on your attitude.

People at SRL tend to mostly be fair. Change your attitude and they'll respond to it.

Also, if your dedication is so little that you'd rather go to java than wait a month, no one's stopping you.

I think it is needless to say you won't make it in this time.

~RM

cycrosism

2009-05-22 13:16:27

From: Rasta Magician
tell them you became gay after you did their mother.


That wont work, they will continue to harass me and call me names even if i ask them nicely to stop

mormonman

2009-05-22 13:18:43

From: cycrosism
That wont work, they will continue to harass me and call me names even if i ask them nicely to stop


asking nicely does not work… as i said on irc, you are a noob at life. learn to actually have some self-esteem to be able to take a couple of jokes.

MasterKill

2009-05-22 13:19:15

From: cycrosism
That wont work, they will continue to harass me and call me names even if i ask them nicely to stop


Then there always is the awesome thing; "Ignore". Just don't respond to them… If you stop reacting to that kind of stuff, and you keep on helping other people with there problems, you'll earn some respect.

cycrosism

2009-05-22 13:23:51

Yeah I have already ignored 1 user, (The Claw) becuase it was constantly calling me a fag

MasterKill

2009-05-22 13:29:10

From: cycrosism
Yeah I have already ignored 1 user, (The Claw) becuase it was constantly calling me a fag


Ok and this is why your behavior is not good. You constantly whine about stuff like this. Place a dot after it.

cycrosism

2009-05-22 13:48:26

From: MasterKill
Ok and this is why your behavior is not good. You constantly whine about stuff like this. Place a dot after it.


I only ignored him on the IRC, I will be happy to unignore him if he changes too

Naum

2009-05-22 14:04:08

Maybe The Claw's fine, perhaps it's you who may have to change :).
Once you've been more helpful + (input from the last 50 posts) then he won't take that badly to you.

cycrosism

2009-05-22 14:42:34

His not fine I thought i settled this with him yesterday when I apologized to him and unignored him but he called me a fag again so I have added him to the ignore list and will remove it when I next apply for members (Which will be in about a month)

Naum

2009-05-22 14:46:48

I really don't think The Claw would have done that, maybe the Claw can shed some light on this.

Torrent of Flame

2009-05-22 15:24:55

The Claw didn't call cycorism a fag. His name wasnt even mentioned. Claw said 'fag' but at no person im paticular.

Sir R. M8gic1an

2009-05-22 17:25:35

I believe enough has been said, and I can already see a subtle change in your attitude on irc. Let's hope this comes onto the forums as well.

I expect you will apply again in a month. I'll be waiting.

~RM