SRL Archive - First Scripts

Hey well this isnt exactly my first script.. its actualy my second. but i wasnt sure where else to put this :P
Ok, first of all thanks to everyone who voted on my membership aplication, ive tried to fix everything up and this is the outcome. If there are still things that need fixing please tell me :]

Since i couldnt reply to you guys all on my membership aplication forum ill use this one, though ive only just selected a few things mostly the things that i didnt understand or didnt know how to change.

Pure1993:All of the more complex things were not created by him.

your right, I have taken out / re-wrote all of the functions that didnt belong to me. I realy didnt even realize i had so many functions by other people before lol

The DDTMs have also been created by a DDTM creator, not a single self created or majorly edited DDTM (I wouldn't hold it against him if he had at least renamed the subpoints/mainpoints in an appropriate manner).

I think i understand how you would create DDTMs without a creator(juse use your color picker to chose points right?) but i realy dont see the point. besides every tutorial ive read on DDTMs taught me to use a creator so it kinda seems like its the accepted way to make them.. but if you realy want me to re make them myself i suppose i could xP oh and what exactly do you mean by renameing them in the appropriate manner..?

Floor66: His standards are off

i thought my standards were pretty good =[ could you guys point out what things im doing wrong standard wise?

boberman: lot of the script was written by someone/something else, and no credit was given anywhere

I credited every function made by someone else in the actual script..

Your main loop is another place I cringe at. The excessive use of repeat loops makes me wonder if the script is doing what you think it is.

it dosnt look that bad to me =[ are we not saposto use loops in our mainscripts? and i do know what its doing ive run my acount through it hundreds of times both to test and make money from

Wizzup?: If your walking had been just a bit neater I would have given a yes. :)

i fixed up the walking ;D tell me if you think it should be shortened, it still is very repeditive. i tried shortening by assigning the corasponding RadialWalk to a boolean and then just calling that boolean, but it was very glichy so i didnt include it =S

3Garrett3: Okay. I have a question. Is the 17/18 point DDTM a symbol? Doesn't findsymbol still work?

yup, sorry i fixed that :P

ZephyrsFury: I'm confused. The standards are pretty much perfect. :rolleyes:

are you being sarcastic? :P lol im getting mixed messages on the standards thing.

Edit: I wanted to make a pole where you guys could vote weather you think my script would make it into srl members this time, but i couldnt figure out how to do it, so could you just rate the thread instead? 5/5 meaning it would get in, 0/5 it wouldnt. thanks :] (plz dont give half points, it will throw the rateing off :P)

Seems over the average but why did you call your main loop a procedure and call it on the OTHER mainloop?

erm… you mean that i did:

begin
  ScriptSetup;
  MainLoop;
end.

well that was just for conviniance, so that if i wanted to quickly move to my MainLoop icould just click on it in the functions list, and not have to scroll down :P

You left an account name and password in there ;)

It's only a test account, otherwise someone would have changed the pass and sent it to him. ;)

Anyway, your script looks a lot better than the last one. Afew things I have left to critize…
-When using radial walk, try to make some kind of failsafe after every walk, there is a chance you mgiht get somehwere completely different
-When a bird's nest falls out of a tree, a black text message appears in the char box. Maybe you might want to check for the text first, before searching for the color

There are a few more things which could be improved/shortened, but I'm way too tired right now to read through the entire script, maybe tomorrow. Anyway, I would vote "yes", if you were to apply with this (although, you might want to hear some other members' opionions first ;))

Good job, and keep it up :)

It looks very nice. I am still not sure about the Walking, but the Walking code looks good. I don't think it can be shortened much. (That is, if I recall what the world map looks like ;) )

Good work!

haha thanks pure and wizzup? i didnt know that about the birdsnest, does anyone know what the actual message is? The Pathwalking is very accurate on my computer now =D hmm but pure what kind of failsafes could i use? maby checking for a DDTM? i dont think a DTM would work cause the minimap colors change do they not? or is it just the path colors..

It looks better ;) You've defiantly improved it.
I'd say Yes now.

No I wasn't being sarcastic. From what I could remember your standards were perfectly correct. I had no idea what everyone else was on about.

Anyway I would vote yes.

ok zeph, well alot of people said my standards were bad. would you guys say that they are alot better now? all i realy did was make it neater and look nicer lol, still the same amount of indenting and rules regarding how wrote the code.

This should go to junior members, Because it banks.

Since i recall, this is FRIST SCRIPT section, not free-for-all even though non-members can see it me thinks.

looks good im gonna try it now thanks :P

Well done! I wish i could have seen the script, but, I have been inactive for a while. *Wow and you know what, when i posted a really simple script for members app. Wizzup? voted yes, even though yours is much more advanced*
*cough* Lance, did you credit me….*cough*

I recall you changing the array and colors only last time…

Good Luck~


EDIT: I just opened the script and it looks amazing, compared to your Lance Fighter, which is still on my desktop:p.
You have improved, if i was member, which i doubt i will ever be, [neither do i wish to be srl member] i would vote for you.

Say : Votez pour moi. or something like that means vote for me in francais.

what which function are you talking about? imm pretty sure i re wrote them all. sorry if i didnt ill correct that.

Edit: the OpenGEBank was the only function that was still yours i belive, and i rewrote it as my own in the last revision. its alittle differant, i think yours was better lol but people said i needed my membership application to be more my own so i took out everyone that anyone else had made. Remember your function was GE_OpenBank? or something like that? lol

Edit2: Shokran Smarterchild x] now how do i say it in arabic? lol

I would say Yes looks quite sweet.

1 thing not to important but makes it neater i guess.

function WalkToYews : Boolean;
var
  x, y, I : Integer;

begin
  if not LoggedIn then Exit;
  FindNormalRandoms;
  For I :=4 to 6 do
  begin
    WalkPath(I);
  end;
  if FindSymbol(x, y, 'tree') then
  begin
    Result := True;
    Exit;
  end;
end;

You don't free your DTM's correctly, the way i see you do it is you free the (D)DTM by calling it again. Also you don't free all of them

Also, I was going to auto on the account you left in there, but you only had 8wc :P

haha yeah sorry cyro the nub acount was only for path walking testing. and realy im not freeing my DDTMS?! D= but someone taught me thats how you do it with ddtms v.v i feel so betrayed. lol so erm how exactly do you do it? :P

bobohobo: haha yeah it saves a few lines

Like this:

FreeDTM(DDTM);

but none of my DDTMS are named DDTM =[ i dont understand lol. are all DDTMs recorded in that variable or something?

Well, if your DDTM is a variable then yes. just use FreeDTM(nameof the DDTM) i think.

but my problem is that the dtm is DTM(tol); the tolerance is part of the name. is that just a bad idea then..?

a lot of it isnt yours it looks like you have just copied all of it from different scripts i mean:

procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  Players[0].Name :='the daggaz';
  Players[0].Pass :='test123';
  Players[0].Nick :='agaz';
  Players[0].Active := True;
  Players[0].Integers[0] := 2; // Fight style to use

FIGHT STYLE? i thought it was a yew cutter!!!!
also just a little thing, your function: PathDTM its a DDTM just rename
have

FreeDTM(GrandExchangeDTM);

and

FreeDTM(PathDTM)

They go at the end of the function ;)

T~M

shit! your right i didnt even see that. lol in truth ive pretty much copied / pasted the declare players procedure from my previous scripts because its so redundant to type. i have a few functions like that such as the smart setup, and my RanInt function :S i use those ones in all scripts so its kinda like my starting out template :P your right though i realy should take that away and yeah i guess i did get that origionaly from a tutorial so i should credit o.O but that was like forever ago haha.

and as for freeing the DTM's, if i remember correctly i put an Exit; in there so i freed them up before it would exit out of the function. i thought that i put it both before the exit and at the end of the function.. hmm ill look at that thanks

POST IN JUNIORS, THIS THREAD IS GETTING NO RS-RELATED ATTENTION~


Sorry Lance,
I quit everything related to runescape, except for popping on the forums now and then. The only reason i stayed was because i was teaching you, but, you have surpassed me.

after every load he logs off and says reason axe was banked ??

nvm found it :) works great . thank you

didnt work the dot was skipping to all the green things trees .. players hats,, ect