SRL Archive - Outdated / Broken

[SRL] Nava2 Karamja Fisher


Nava2

2009-05-09 20:51:49

Well, I wanted a challenge, and I sure as hell got one.

This is my newest script, I have worked countless hours on it.

This script is complete, but may not fully function. I need bug reports and other helpful information. Please post these, as well as the screenshots which the script saves.

Info:

  • Full Colour
  • SMART Able
  • Advanced Fish Finding
  • Fully Autocoloured
  • Fishes anything fishable on Karamja
  • Anti-Randoms
  • Anti-Ban

This is written using the Open Dev SVN, SCAR 3.20d, and if you are using SMART you need the Newest hooks. The only piece of reflection is checking if the player is LoggedIn (When SMART is opened, image messes up so LoggedIn fails.)

Setup:

The current version has full debug enabled, if you don't want this, Comment out the {$DEFINE Debug}.

To not use SMART, comment the {$DEFINE SMART} as well as comment this:
// Comment out the following to not use SMART:
{.include SRL/SRL/Misc/Smart.scar}
{.include SRL/SRL/Reflection/Hooks.scar}
//


Start players either at the Fishing Docks or in Draynor Bank. The script will identify where it is.

Click run! :)

Best Proggies:



Special Thanks to:

  • ZephyrsFury - Helped me debug a lot.

Thanks,
Nava2

Nava2

2009-05-10 08:17:43

Fixed some bugs.. Some input would be nice.. :'(

mormonman

2009-05-10 12:35:41

I would test for you, but I don't have any guys that have this high of fishing… they are are wcing.

Quickmarch

2009-05-10 13:20:10

Looks great! Will get you a proggy when my chars fishing level is 40. :)

TheChineseMan

2009-05-10 13:39:53

u beast!!!

EvilChicken!

2009-05-10 13:55:19

I looked through the script, it really looks impressive.

A thing worth mentioning that I noticed, would be the "MakeCompass(180);" in GetFishingSpots, (GJ with that function, btw!) which always will set the compass at exactly 180 degrees. This might seem a tiny bit suspicious in the long run, as I assume this function is called alot due to the nature of the script being a fishing script.

Oh, and I also like your was of using compiler directives. :)

Nava2

2009-05-10 17:55:52

From: EvilChicken!
I looked through the script, it really looks impressive.

A thing worth mentioning that I noticed, would be the "MakeCompass(180);" in GetFishingSpots, (GJ with that function, btw!) which always will set the compass at exactly 180 degrees. This might seem a tiny bit suspicious in the long run, as I assume this function is called alot due to the nature of the script being a fishing script.

Oh, and I also like your was of using compiler directives. :)


Good point, I think I may just make it check the range of the compass angle. Then, if it doesn't find it, make it default to a different direction.

Also, the idea for that function came from Spec Ed and when I was helping Iroki with his plugin stuff. :).

Thanks a lot for reading man, I do appreciate it.

EvilChicken!

2009-05-10 18:33:24

From: Nava2
Good point, I think I may just make it check the range of the compass angle. Then, if it doesn't find it, make it default to a different direction.

Also, the idea for that function came from Spec Ed and when I was helping Iroki with his plugin stuff. :).

Thanks a lot for reading man, I do appreciate it.


No problem! :)
Your scripting technique is interesting.

Nava2

2009-05-10 18:40:32

From: EvilChicken!
No problem! :)
Your scripting technique is interesting.


What do you mean?

marpis

2009-05-10 18:42:42

why not this:


{$DEFINE SMART}

{$IFDEF SMART}
{.include SRL/SRL/Misc/Smart.scar}
{.include SRL/SRL/Reflection/Hooks.scar}
{$ENDIF}

Nava2

2009-05-10 18:48:56

From: marpis
why not this:


{$DEFINE SMART}

{$IFDEF SMART}
{.include SRL/SRL/Misc/Smart.scar}
{.include SRL/SRL/Reflection/Hooks.scar}
{$ENDIF}


SCAR isn't a fan of compiler directives used with includes..

Not really sure why.

EvilChicken!

2009-05-10 19:10:53

From: Nava2
What do you mean?


Just the way you seem to think; your logics.

Nava2

2009-05-10 19:11:57

From: EvilChicken!
Just the way you seem to think; your logics.


Hehe, is that good, or bad? :)

EvilChicken!

2009-05-10 19:25:41

That is most certainly good.
If you had a flawed technique, I'd have a lot more errors to point out in your script. Which I obviously didn't have. :)

Nava2

2009-05-10 20:10:02

From: EvilChicken!
That is most certainly good.
If you had a flawed technique, I'd have a lot more errors to point out in your script. Which I obviously didn't have. :)


Thanks a lot! :)

footballjds

2009-05-11 04:05:03

any way u could add power fishing to this?
just wondering ;)

senrath

2009-05-11 04:08:17

From: footballjds
any way u could add power fishing to this?
just wondering ;)


Why the heck would you want to power fish Karamja? That's kinda like powerchopping Yews.

footballjds

2009-05-11 04:10:43

lol, kinda, but for getting up fishing powering lobs is good for higher lvls ;)
i care about exp more then gp sometimes ;)
i just want 75 fishing FAST

senrath

2009-05-11 04:12:49

From: footballjds
lol, kinda, but for getting up fishing powering lobs is good for higher lvls ;)
i care about exp more then gp sometimes ;)
i just want 75 fishing FAST


As far as I know, power fly fishing or power baiting is still faster than power fishing lobsters.

bullzeye95

2009-05-11 04:27:38

Looks nice. I just got the urge to make a fishing spot finder.. :S

You put my IsMoving into SRL? ;P

Nava2

2009-05-11 04:29:54

From: bullzeye95
Looks nice. I just got the urge to make a fishing spot finder.. :S

You put my IsMoving into SRL? ;P


Just to beat mine? :(

Any yeah, I told you didn't I?

footballjds

2009-05-11 04:36:37

From: senrath
As far as I know, power fly fishing or power baiting is still faster than power fishing lobsters.


yes it is ;)
BUT RM's fisher is awol atm :D

bullzeye95

2009-05-11 06:27:09

From: Nava2
Just to beat mine? :(

I haven't tried yours. I'm just so bored :<

Any yeah, I told you didn't I?


I don't think so, but maybe?

Nava2

2009-05-11 06:35:49

From: bullzeye95
I haven't tried yours. I'm just so bored :<


See if you can beat mine. :). I like to think mine is pretty beastly.

I don't think so, but maybe?


Well, if not.. Suprise!

@footballjds, I will add it. Shouldn't be too hard. I'll just have to move some Booleans around.

Would anyone like me to add tuna dropping, or shrimp, etc. Not like anyone will use the other options but might as well add them haha.

Also, I'm considering adding in the selling at the store.

mormonman

2009-05-11 08:41:14

From: Nava2


Also, I'm considering adding in the selling at the store



that would make this beastly! I am just starting some fishers, so that i can use this script!

Sir R. M8gic1an

2009-05-11 09:41:43

Gratz on masters ;)

~RM

legendaryhero90

2009-05-11 10:25:10

i would test this if i had the army for it.

but in the mean time, i hope everyone gets a good run out of this script.

Nava2

2009-05-11 15:21:16

From: legendaryhero90
i would test this if i had the army for it.

but in the mean time, i hope everyone gets a good run out of this script.


Thats a shame. :(

Nava2

2009-05-11 15:42:46

Uploaded Theta, should be good from here…

Let me know bugs, I think I got most of them. :)

Phran6

2009-05-15 01:18:50

i get this error:
Line 78: [Error] (17649:63): Unknown identifier 'MSToTime' in script C:\

on this
s := '[' + Players[CurrentPlayer].Name + '] ' + Loc + ' - ' + MSToTime(GetTimeRunning, Time_Bare);

Nava2

2009-05-15 02:18:08

Get the Developers SVN.

footballjds

2009-05-15 02:57:25

Nava2, can u please get ur avatar back :p
:D
at least remove t3h red :D

Nava2

2009-05-15 08:15:48

Way to stay on topic…

Uhm, ask hobs. :)

Dynamite

2009-05-17 21:14:50

From: Nava2
Get the Developers SVN.


i have DevSvn but i get that error

T~M

footballjds

2009-05-18 05:52:33

use vers 50 atm cause thats what RM's using in his when he posted :p

Nava2

2009-05-18 09:47:35

What are you talkign about… this is a colour script.. you need reflection though if you use smart. that way you can open the window.

Avaphi

2010-05-26 12:45:39

Simba compatible? Which is the newest script version? Can't really tell.

Sir R. M8gic1an

2010-05-26 13:30:06

From: Avaphi
Simba compatible? Which is the newest script version? Can't really tell.


I suspect this might be outdated :p

~RM

Avaphi

2010-05-26 13:37:31

failll :p