SRL Archive - RS3 Outdated / Broken Scripts

COLOR="Red"]This is a new revolution guys!
This is our first partnership script
This is:


WillOw
w
n
e
r



BUGS

somtimes it wont find bank
other than that none really major

Post Proggies and feedback please!
If you do.. We will keep updating ;)

T~M/J_P

btw thats not my pass in script so dont even try

Ok i will have updates on my post, so check both posts to see which is highest version.

Please post proggies and post bugs ;)

T~M

procedure findrandoms;
begin
  findnormalrandoms;
end;

worthless code ftl… -.-
if you are going to make your own function/procedure for that, have it actually do something.
ex:

function randomcheck : boolean;
begin
  if not LoggedIn then Exit;
  for i := 0 to 1 do
  case i of
    0 : findnormalrandoms;
    1 : R_findrandoms;
  end;

then to use that do something like this

if randomcheck then 
 if not LoggedIn then
 begin
   Players[CurrentPlayer].Loc := 'Random failed';
   NextPlayer(False);
   Exit;
 end;

Did you copy things from another script?
You never even use these?

  Players[0].Strings[1] := 'FEB'; //Place where you want to cut, VEB or FEB. 
/////I THOUGHT THIS WAS A WILLOW CUTTER????????????
  MinutesTerminate = 360; //Minutes to work(It will terminate script after those minutes)
///// YOU HAVE THIS COMMENTED OUT IN MAINLOOP!

Please go learn more, and fix your script up.

From: mormonman

[scar]
function randomcheck : boolean;
begin
  if not LoggedIn then Exit;
  for i := 0 to 1 do
  case i of
    0 : findnormalrandoms;
    1 : R_findrandoms;
  end;

whats r_findrandoms;

From: mormonman

procedure findrandoms;
begin
  findnormalrandoms;
end;

worthless code ftl… -.-
if you are going to make your own function/procedure for that, have it actually do something.
ex:

function randomcheck : boolean;
begin
  if not LoggedIn then Exit;
  for i := 0 to 1 do
  case i of
    0 : findnormalrandoms;
    1 : R_findrandoms;
  end;

then to use that do something like this

if randomcheck then 
 if not LoggedIn then
 begin
   Players[CurrentPlayer].Loc := 'Random failed';
   NextPlayer(False);
   Exit;
 end;

Did you copy things from another script?
You never even use these?

  Players[0].Strings[1] := 'FEB'; //Place where you want to cut, VEB or FEB. 
/////I THOUGHT THIS WAS A WILLOW CUTTER????????????
  MinutesTerminate = 360; //Minutes to work(It will terminate script after those minutes)
///// YOU HAVE THIS COMMENTED OUT IN MAINLOOP!

Please go learn more, and fix your script up.

lol do you have a pre-release, that isnt even in mine…
I posted on my post ;)

T~M

Yes, you did remove the MinutesToTerminate from mainloop…

        {if (TimeFromMark(minutesterminate) > 1000 * 60 * MinutesTerminate) then
        begin
          logout;
          TerminateScript;
        end;}//remove brackets

And yes, I just downloaded your "newest" version and it has everything that I said in it…

1.The anti-ban made me dizzy.

2.You should try fixing your standards.

3.You don't need this:

Players[0].Strings[1] := 'FEB';

or this:

{.include SRL/SRL/Skill/Woodcutting.scar}

4.Try changing procedure Banking to this:

procedure Banking;
begin
  Disguise('banking')
  MakeCompass('N');
  Wait(300 + random(160));
  OpenBankQuiet('db');
  if (PinScreen) then
    InPin(Pin);
  if Players[currentplayer].Booleans[0] = True then
  begin
    DepositAll;
    IncEx(Loads, 28);
  end;
  if Players[currentplayer].Booleans[0] = False then
  begin
    Deposit(2, 28, True);
    IncEx(Loads, 27);
  end;
  Mouse(RandomRange(483, 495), RandomRange(29, 41), 0, 0, True);
  Wait(150 + random(278));
end;

So instead of this:

loads2:= loads2+28;

Change it to this:

IncEx(Loads2, 28);

5.Add this to your progressreport:

Writeln('|~|     Gained: ' + IntToStr(Lvlups) + ' Levels.  | ');

6. It doesn't bank.

7.Why do you have this on your script?

procedure LoadDTMs;
begin


  {AxeDTM := DTMFromString('78DA63FCCFC4C0B09F91011974670832FC07D' +
    '220D1FF40C0F80BA8E61CAA1A882C8C04D1CC0C0C5B08A8E101AA' +
    'D949400D1750CD3EFC6A0056B70BE7');

  BrokenAxeDTM := DTMFromString('78DA63B4626660B8C2C8800C3AD20419FE036' +
    '990E87F2060B405AA3981AA06220B2381B40750CD29026ACC806A' +
    '1E1150E30A547396801A37A09A4BF8D5000072D20C8B'); }


  WillowDTM := DTMFromString('78DA6364C00D1861342790E0429573B195445' +
    '5230D24D809A891071212A86A8CF58451D5F00009595435C5D94EA86' +
    'A5830CD498EB64055C30A240451D578384891EC2F00DA4D05E5');

end;

Ok thanks guys for feedback, will get right on it :)

T~M

im already got half of a new and improved update dine