SRL Archive - Archive

Bad Processor - SRL Member Application


Bad Processor

2009-04-21 22:58:04

How Long have You Played Runescape?
2 Year(s)


Are you affilated in anyway with Jagex LTD?
No.

Were you Referred to SRL?



What is your general programming knowledge?
Delphi (Kinda), ActionScript, VB, C#, Pascal, SCAR, Python (Kinda).


Are you a member of any other communities?
MoparIsTheBest.com i think, Freddy1990.com, 1Sparked.INFO (Down), RS-Hacking.com


Tell us about yourself…
From: Bad Processor
Right. This is my 3rd but never final attempt at Members. As Tickyy and DDD know, I am DETERMINED to get in to SRL-Members. I started programming at around 8, trying to edit a raw .EXE file (Fail'd). I got into C#, then VB, now finally Pascal, Delphi and ActionScript.The name's Tom, and I like programming, listening to music and *drooling over Windows 7 packaging*. I've got to know a lot of the SRL people now, most of whom via IRC.I feel, if I had the time, I could create an awsome script, but I'm not that active - this app is a leap of uber faith.



Please give show us one of your scripts.
GP Beggar:
{.Script Info:
# ScriptName = Beggar
# Author = Bad Processor
# Description = Goes around, begging for free stuff.
# Version = 1.00
# Date = 21/4/09
# Comments = I might apply membership with this; not sure though.
/Script Info}
program Beggar;
{.include SRL/SRL.scar}
{.include SRL/SRL/misc/Trade.scar}
const
// FILL IN THESE, GAAAAGAGGH!
AmountOfBegs = 100;

var Follow, AmountTraded: Integer;
var NumberOfUsers: Integer;
// CHANGE BELOW FOR PLAYERS!!!
procedure DeclarePlayers;
begin
NumberOfUsers:= 1;

HowManyPlayers:= NumberOfUsers;
NumberOfPlayers(HowManyPlayers);
CurrentPlayer := StartPlayer;

Players[0].Name :='';
Players[0].Pass :='';
Players[0].Nick :='';
Players[0].Active:=True;

Writeln('You are using '+IntToStr(NumberOfUsers) + ' players.');
Writeln('Well, I think so anyway...');
end;
procedure LoadBMP;
begin
if not LoggedIn then Exit;
Follow := BitmapFromString(38, 10, 'beNpjYPiPARhwA2QFBBUTYw' +
'hJikdtJGgIpnas4nhsJKgej114TKaETWcb4SR9bMQKaG0jpu1Epig' +
'y4ghNDQMAkyuoZg==');
end;

procedure FreeBMP;
begin
if not LoggedIn then Exit;
FreeBitmap(Follow);
end;

procedure FindFollowBeg;
var x, y :Integer;
begin
if not LoggedIn then Exit;
FindObjCustom(x, y, ['alk here', 'lk here', 'Walk her'], [6654387, 5995425, 2576493], 30);
Mouse(x, y, 2, 2, False);
FindBitmap(Follow, x, y);
Mouse(x, y, 2, 2, True);
Wait(5000);
case random(3) of
0,1:TypeSend(AddMistakes('Can I have free money?', 25));
2,3:TypeSend(AddMistakes('Free coins?#', 29));
end;
end;

procedure TradingStuff;
var TradeLoop: Integer;
var HasTraded: Boolean;
begin
if not LoggedIn then Exit;
for TradeLoop:= 1 to 10 do
begin
if not HasTraded then
begin
if SomeoneTrades = true then
begin
AcceptTrade;
repeat
Wait(100);
until(PlayerAccepted);
Accept;
HadTraded:= true;
end;
end;
end;
case random(2) of
0: TypeSend(AddMistakes('Thanks'));
1: TypeSend(AddMistakes('Thanks'));
2: TypeSend(AddMistakes('Ty'));
end;
end;

procedure MainLoop;
var MainLoopLoop, PLoop: Integer;
begin
LoginPlayer;
if not LoggedIn then Exit;
for PLoop:= 0 to NumberOfUsers do
begin
for MainLoopLoop:= 1 to AmountOfBegs do
begin
FindNormalRandoms;
FindMod;
FindFight;
FindFollowBeg;
FindNormalRandoms;
FindMod;
FindFight;
TradingStuff;
FindNormalRandoms;
FindMod;
FindFight;
AmountTraded:= AmountTraded + 1;
end;
NextPlayer(False);
end;
Logout;
end;

procedure Proggy;
begin
PrintLn('BEGGAR by BadProcessor');
PrintLn('- Begs done:'+IntToStr(AmountTraded)+' -');
PrintLn('- Rate and post proggy!');
PrintLn('-Worked for '+IntToStr(GetTimeRunning\60)+' mins.');
end;
begin
SetupSRL;
ActivateClient;
DeclarePlayers;
LoadBMP;
MainLoop;
Proggy;
FreeBMP;
end.

I've also written CrudCatcher and a few others.

JAD

2009-04-21 23:09:22

In the load bmp and free bmp procedures, I don't think that a if not loggedin then exit is necessary, or even wanted in the freebmp. If you aren't logged in, you would still want to free the bitmap.

after FindObjCustom, you don't want to click in a random location if it found the object. You will move your mouse somewhere, check the uptext, then move it a little every time before clicking. Better to just make the randoms 0,0 on the Mouse.

You DEFINITELY want if(findObjCustom)then and if(FindBitmap)then's because if it didn't find it, you are still mousing at x,y, which isn't a good thing.

Add a randomness to that wait(5000) in FindFollowBeg.

random(3) either returns 0, 1, or 2, so in your case, you can take out the possibility of it being a 3.

same with the case in tradingstuff, random(2) but you have an option 2 which will never be chosen.

In tradingstuff, I don't understand why you really used a for loop at all, and why you need all those variables. That could really be reduced to a few lines.

In the mainloop, FindNormalRandoms checks for all the randoms. For findfight you will need to do if(FindFight) then do code to run away and run back.


Sorry, it's a no from me. Too short and simple for members. Good job though, you're on your way!

Richard

2009-04-21 23:11:07

Really sorry to say this, because you're a nice guy. But I think its a bit too simple. Think about adding TPAs, DTMs/DDTMs, fix standards.

Something I noticed in the main loop, you call the randoms and everything else 3 times in the second for to do loops, you could either: 1) shorten it into one procedure then call that procedure, eg:

Procedure AntiRandoms;
Begin
FindNormalRandoms;
FindMod;
FindFight;
end;

or 2) you could only call it once (I don't see that need for all that many).

And when you call FindFight, it wont do anything, just stand there and die… FindFight is a boolean, so you would need to do something like this:

If FindFight then
RunAway('n', true, 3000);

Naum

2009-04-22 00:47:33

Okay its a no,

1)
      case random(2) of
0: TypeSend(AddMistakes('Thanks'));
1: TypeSend(AddMistakes('Thanks'));
2: TypeSend(AddMistakes('Ty'));

Random(2) will pick either 1 or 0, so it should be:

      case random(2+1) of
0: TypeSend(AddMistakes('Thanks'));
1: TypeSend(AddMistakes('Thanks'));
2: TypeSend(AddMistakes('Ty'));


2)Too many unneeded begins and ends:

  procedure TradingStuff;
var TradeLoop: Integer;
var HasTraded: Boolean;
begin
if not LoggedIn then Exit;
for TradeLoop:= 1 to 10 do
begin
if not HasTraded then
begin
if SomeoneTrades = true then
begin
AcceptTrade;
repeat
Wait(100);
until(PlayerAccepted);
Accept;
HadTraded:= true;
end;
end;
end;
Can cut it down to size.

Although keep it up. :)

jakeyboy29

2009-04-22 00:50:38

Right, No this time. your a great guy and i like seeing you around the forums.

your script isent great and this is what lets you down. i think if you add me on msn, (jake_1_@hotmail.co.uk) i will be able to help you and we can get a better script made.

iv seen the advice you give people on the forums and this script does not reflect this. please add me and listen to these other people. your sure to be a member next time if you do.

Bad Processor

2009-04-24 23:37:35

Yeah…. I'm kinda rusty at the moment, grandparents ill and stuff, fair enough. I don't come here often enough to be a member anyway. :spongebob:
This script is kinda crap, I was in a hurry. Ah well, 3rd time unlucky (Or is that the other way round??).

– Bad Processor

Harry

2009-04-24 23:44:50

No, because I am not on your l33t list :(

But also, as everyone said, it is much too short and simple. I like you, just work on maybe a different script idea and make it bigger and better, and you should get in. Best of luck to your family and I hope they get better.

Bad Processor

2009-04-25 12:07:10

Okay, and thanks harry. :)

– BP

BobboHobbo

2009-04-25 12:21:59

From: Bad Processor
Yeah…. I'm kinda rusty at the moment, grandparents ill and stuff, fair enough. I don't come here often enough to be a member anyway. :spongebob:
This script is kinda crap, I was in a hurry. Ah well, 3rd time unlucky (Or is that the other way round??).

– Bad Processor


Ouch, its not that bad, ive seen way worse :).

Keep it up!

Bad Processor

2009-04-27 20:00:02

Really thanks. And BH? I thought you left a loong time ago. Thanks any.

Also, WTF with my members apps' only tag being mudkips. Is that joke from Harry or someone?

– BP

Naum

2009-04-27 20:11:12

Yeah Im on your l33t list!!! :).

Better get someone to close this (like nava2), good luck next time.

Nava2

2009-04-28 05:11:32

Nava2 is not a mod. :(

Sorry bud, you need to make it a bit more complex for me.

Good attempt though.

Hobbit

2009-05-05 08:58:56

2 - Yes
10 - No

Sorry but you didn't make it

Please stick around and read some tutorials and take what people have suggested to improve on your script then apply in one month.