SRL Archive - First Scripts

MetalancA's Al-Kaharid dragonhide tanner!

Hi! I've been working on this script for a while, and I decided to post it after getting a proggie that was more than 5 minutes lol.

I appreciate any constructive criticism, post your bugs and I'll be updating this script frequently. I always want to better my scripting ability, so any pointers on the script would be greatly appriciated :D

Dragonhide tanning is one of the best ways to make money on Runescape. Playing manually, it's 300-400k an hour. I decided to make this script because it looked challenging, and fun and the same time. Plus the fact that it's great money!

What to do:
1. Put your GP coins in your first bank slot, and your dragonhides in your second bank slot.
2. Start with your player at the Al-Kaharid bank, about in the middle.

Post your proggies please!

if my account didn't get hacked and locked, I'd test it for you, but for now all I can do is look over your codes, which is a lot harder to find bugs with :P. Once I get my account back, if I can manage to make any quick money I'll use it to buy like 2, 3 inventories of d'hide and test this out for you. A cool thing to make this script much better would be to make it an anything tanner. It'd give you more to do and make it a little bit more challenging, well goodluck scripting, and when and if I can I'll give any tips I can on what to improve.

EDIT: For your antirandom procedure, all you need is FindNormalRandoms; it takes care of both FindNonInventoryRandoms; and FindInventoryRandoms;. For Check money, you should do if(PinScreen) then InPin because not everyone has a bank pin. For WithdrawHides; you don't do InPin in there, when you do for checking money, you should keep the script consistent, either it uses pins or not. You have good antiban, but you have for the choosing examine antiban, you have it right click if it finds uptext, then right after the right click with no wait it chooses examine, that's a little unhuman to have no wait there. I like your deposithides; though, how it tries a few times to open the bank, but there's an easier way to do that,

For I:= 0 to 3 do
  if OpenBank(Players[CurrentPlayer].Strings[0], true, true) = true then exit;
if not BankScreen then
  begin
    writeln('could not find bank');
    logout;
    exit
  end;
[\scar]

you'd have to switch it like that so it doesn't logout the first time it doesn't find the bank if you use the For I:= 0 to 3.


That's all I had time to look over, I pretty much read most of it, or scimmed it, I got to the last two procedures but didn't have time to really look them over, oh and in the main loop, try to avoid  Until(False) endless loops are bad. well i gotta go to sleep, nice script in general, and don't take my review in a bad way, I pointed out mostly bad things because I didn't have time to compliment much, sorry. Goodjob again.

Thanks for the detailed feedback :) I appriciate it.

The only reason I didn't use Inpin in the withdraw hides procedure is because Checkmoney is always the first procedure the script does, and after that comes Withdrawhides. It would be kind of pointless to use Inpin with withdraw hides, because there would never be a pin screen :p