SRL Archive - Outdated / Broken

SRL Varrock Yew Cutter / Banker


JLewis

2006-03-27 10:28:37

SRL Varrock Yew Cutter / Banker


Setup
  • Get Colors For Constants
  • Start At The Trees
  • Begin


TreeMM=





BankWorker & GrassColor1 =






  • Scar Resource Library rev 222+
  • NAME : SRL Varrock Yew Cutter / Banker
  • WRITER : JLewis
  • CATEGORY : WoodCutter
  • DESCRIPTION : Cuts and Banks Varrock Yews
  • USAGE : Start at Trees
  • AUTOCOLOR : No
  • NOTES : ENJOY!

Sdcit

2006-03-27 10:50:35

1. Good job besides..well you know :p

2. Why not use perfect north and getcolor?

3. Why not use findsymbol

masquerader

2006-03-27 18:55:13

195836 always works with bankers/npc people :)

Kernel Klink

2006-03-27 19:14:04

I didn't get a chance to actually test this script, but I did analyze and the code, for the most part, looks well-written. So good job. However, I do have a few suggestions:

  • I too think, if I interpreted what SDcit stated right, that you should really try learning proper indenting style. I find it quite tedious when trying to make my way around a script and the indenting is messy. I would indent it for you, but I have a life, as oppose to Pwnd and Bebe :p.
  • If I am not mistaken, I believe that the banker dot (yellow-colored dot) is relatively the same color every login. Therefore, I do not think you have to ask the user to set the color. Instead, just add a bit of tolerance to the findcolor.

If I see anything else, I'll notify you. But, its quite a good script without my suggestions. Once again, good job.

JLewis

2006-03-28 10:06:05

Thanks for suggestions all!