A G E N T
2009-02-02 14:26:21
I just got the newest rev (193), and it seems that TileOnMS(Point, Height) has been changed to TileOnMS(Tile, Height)… however GetMe still returns a TPoint as Result.Tile, and tries to use that point, causing lots of type mismatch errors (and probably cursing ;) ). Anyways, I guess something to fix in next rev / roll back to previous rev?
Baked0420
2009-02-02 15:49:37
I am getting the same problem. But I'm stuck with 193, sorry for sounding like a noob but can you tell me how to go back to the previous Rev?
does this help or is it just fail
{*******************************************************************************
function TileToPoint(Tile: TTile): TPoint;
By: Narcle
Description: Changes TTile to a TPoint
*******************************************************************************}
function TileToPoint(Tile: TTile): TPoint;
begin
Result.x := Round(Tile.x);
Result.y := Round(Tile.y);
end;
{*******************************************************************************
function PointToTile(Tile: TPoint): TTile;
By: Narcle
Description: Changes TPoint to a TTile
*******************************************************************************}
function PointToTile(Tile: TPoint): TTile;
begin
Result.x := Tile.x + 0.0;
Result.y := Tile.y + 0.0;
end;
A G E N T
2009-02-02 17:16:50
From: Baked0420
I am getting the same problem. But I'm stuck with 193, sorry for sounding like a noob but can you tell me how to go back to the previous Rev?
svn co -r 192
http://scarreflection.googlecode.com/svn/trunk "C:\Path\to\Reflection"
From: pur3b100d
does this help or is it just fail
{*******************************************************************************
function TileToPoint(Tile: TTile): TPoint;
By: Narcle
Description: Changes TTile to a TPoint
*******************************************************************************}
function TileToPoint(Tile: TTile): TPoint;
begin
Result.x := Round(Tile.x);
Result.y := Round(Tile.y);
end;
{*******************************************************************************
function PointToTile(Tile: TPoint): TTile;
By: Narcle
Description: Changes TPoint to a TTile
*******************************************************************************}
function PointToTile(Tile: TPoint): TTile;
begin
Result.x := Tile.x + 0.0;
Result.y := Tile.y + 0.0;
end;
Yeah, I suppose those are the right ones, just a matter of putting them in wherever they need to go (as well as in any current scripts, I would think.)
William
2009-02-02 18:17:35
i get same error no idea how 2 get back 2 192 though
Baked0420
2009-02-02 18:22:08
nevermind I figured it out, when I right click, there was a drop menu or w/e coming of off the tortoise Svn to get back a revision, so I got back to 192 and reflection works again :D.
Shady?
2009-02-02 20:37:53
Yea, i'm just stucking up with 192… Is either that or fix my whole fishing script.. meh.
Narcle
2009-02-02 22:02:14
Yes i think Nava2 did this… and i thought i mentioned a LONG time ago to NOT do this. Don't update scripts to tile system, just revert to older Reflection svn. I'll have Nava2 revert it, if he doesn't do it in time I'll do it tomorrow/wed.
Shady?
2009-02-02 22:14:04
From: Narcle
Yes i think Nava2 did this… and i thought i mentioned a LONG time ago to NOT do this. Don't update scripts to tile system, just revert to older Reflection svn. I'll have Nava2 revert it, if he doesn't do it in time I'll do it tomorrow/wed.
Oh thanks :) Plus i think you're missing Echo Fighter @ your siggy ;)
Narcle
2009-02-02 22:33:58
From: Shady?
Oh thanks :) Plus i think you're missing Echo Fighter @ your siggy ;)
oh i am… think i'm out of siggy room, ble
Baked0420
2009-02-02 22:57:36
yea if you look at changelog Nava2 did it, I looked to see who did this when I went to see what was changed to find out why it wouldn't work. He just messed up on date, he said he changed it 1/2 when it's 2/2 now. Yes Nava, it's February :p.
ZephyrsFury
2009-02-03 02:34:00
From: Baked0420
yea if you look at changelog Nava2 did it, I looked to see who did this when I went to see what was changed to find out why it wouldn't work. He just messed up on date, he said he changed it 1/2 when it's 2/2 now. Yes Nava, it's February :p.
No he changed it on the 1st of Feb hence 1/2/2009.
Baked0420
2009-02-03 12:00:06
oh I thought that was Jan/1/2009, most people do it month/day/year that I know.
A G E N T
2009-02-03 17:11:26
Alright, I only checked out to latest because I thought there might have been a hooks update. Anyway, thanks for the clarification.
@Baked, that date format makes no sense to me - it should either go in order of smallest to greatest, or greatest to smallest, not middle/smallest/greatest… Although the ISO spec is YYYY-MM-DD.
senrath
2009-02-03 17:42:04
From: A G E N T
@Baked, that date format makes no sense to me - it should either go in order of smallest to greatest, or greatest to smallest, not middle/smallest/greatest… Although the ISO spec is YYYY-MM-DD.
It's the way we do it in the United States. MM/DD/YYYY. Yet another example of how we decided to be different from the rest of the world, and how many problems it causes people who don't know.
Nava2
2009-02-03 18:46:54
Yes, I did it. I talked with method, as well as lordsaturn. We agreed it made sense. My apologies, I thought I got all the errors.
ZephyrsFury
2009-02-03 18:57:30
From: Nava2
Yes, I did it. I talked with method, as well as lordsaturn. We agreed it made sense. My apologies, I thought I got all the errors.
Nava if you're going to use TTile then use it everywhere, not just in NPC functions. Don't switch back and forth between TTiles and TPoints - you'll end up confusing people and creating errors.
lordsaturn
2009-02-04 02:06:56
Fixed, everything is now TTiles. There are NO more TPoints in any types. Walking/Objects/GroundItems and everything else now uses TTiles. Sorry if this breaks a lot of scripts, but it was for the best, and it'll only take a few seconds to fix.
Baked0420
2009-02-04 05:54:59
so I can update to latest reflection and I won't get any errors (unless script was using TPoint and not TTIle, of course)? I just don't wanna get the latest then have to go back again if something is messed up.