SRL Archive - Archive

shazam

ALOT of ACA :(.

Your standards are little off here and there…

You couldve shortened dropping by doing a for… case :(.

No walking, unefficient antiban…

Even RanWait was from mormonmann (spelled right ? :s).

No DTMs, DDTMs …

Waiting for the other's feedback but I'm leaning towards no, sorry.

Grade : 35/100.

unnecessarily long, and endless loop in mainloop

would not find gas while mining

nothing new, too simple

im not voting yes, sorry
better luck next time

you should've left the script there. it wasn't that bad.you were just unlucky to have harsh Dr.Dervish judge you first :P

besides, member apps is a place where you learn alot because everyone tells you what you should've changed.

~RM

Like RM said. You'll get lots of pointers here if you want them - or even if you don't. hehe

From: Rasta Magician
you should've left the script there. it wasn't that bad.you were just unlucky to have harsh Dr.Dervish judge you first :P

besides, member apps is a place where you learn alot because everyone tells you what you should've changed.

~RM

Was that because of my reaction against impiwimpi ? :cartman:

From: Dr D. Dervish
Was that because of my reaction against impiwimpi ? :cartman:

yes.

Everything everyone said is true, I learned the majority of my scripting from just applying then getting told what to work on.

I would say its one of the best was to learn!

If you want help with anything tho then feel free to PM me or MSN.

Yes. I like your attitude.

From: Bam Bam
Yes. I like your attitude.

from this paragraph? or from the forums? cause im not sure from this one paragraph.

There is a couple things with standards that could be fixed, but I would never say "no" because of that.

I believe LoginPlayer; already checks to see if you are logged in so that is not needed, but once again, no points off for be careful ;)

if not(LoggedIn) then LogInPlayer;

I will tell you right now, try not to use ACA atleast for your members APP. because alot of people look down upon that. That was one of my big flaws in my first APP.

I like your logic with this but:

Procedure TinProcess;
begin
repeat
  if not(LoggedIn) then LogInPlayer;
  FindNormalRandoms;
  TinMProcess;
  i:=i + 1;
until(InvFull = true);
begin
  MMouseItem(1);
  if (IsUpText('icka')) then
    begin
      DropItem(2);
      DropItem(3);
      DropItem(4);
      DropItem(5);
      RanWait(250+random(700));
      DropItem(6);
      DropItem(7);
      DropItem(8);
      DropItem(9);
      DropItem(10);
      DropItem(11);
      RanWait(250+random(700));
      DropItem(12);
      DropItem(13);
      DropItem(14);
      DropItem(15);
      DropItem(16);
      DropItem(17);
      RanWait(250+random(700));
      DropItem(18);
      DropItem(19);
      DropItem(20);
      DropItem(21);
      DropItem(22);
      DropItem(23);
      DropItem(24);
      DropItem(25);
      DropItem(26);
      DropItem(27);
      DropItem(28);
    end else
      begin
        RanWait(250+random(700));
        DropAll;
      end;
  end;
end;

Can easily be shortened into:

Procedure TinProcess;
begin
repeat
  if not(LoggedIn) then LogInPlayer;
  FindNormalRandoms;
  TinMProcess;
  i:=i + 1;
until(InvFull = true);
begin
  MMouseItem(1);
  if (IsUpText('icka')) then
    begin
      DropItem( 2, 28);
    end else
      begin
        RanWait(250+random(700));
        DropAll;
      end;
  end;
end;

If you can, try to incorporate some TPA's and maybe some DTM's as it will impress alot of people that are judging you, but yet again, they are not required and I will not say 'no' because you dont have them.

I am going to hold my vote for now, only because i want to push you to try and learn a bit more (which I know you are because ive been helping you ;)) but I definately see you becoming a member in the near future.

GoodLuck!

No sorry, and your user and pass are in there.

Watch your code, its long when unneeded at points.

Good luck, next time.

Read this.

Its not that bad. However im gonna have to say no on this one.

There are a few things that can easily be made smaller. And some things that show just slightly short of the knowledge needed.

My suggestions if you dont get in this time
Learn:

- FOR and WHILE loops
- Learn TPA (If you want. Not needed. See below)
- If you dont want to use custom TPA's just learn how to use the many findobj in SRL. Findobj is a very powerful tool that you use in many a script

Btw did you make the auto color yourself?

From: Nava2
No sorry, and your user and pass are in there.

Watch your code, its long when unneeded at points.

Good luck, next time.

Read this.

Thanks alot for that link(and mentioning my password -_-), i leaned alot from it. And i'm learning about TPA's so hopefully next go around i'll do better