SRL Archive - Archive

deleted

no, too simple imo.

maybe next time ;)

From: ~~Joker~~
no, too simple imo.

maybe next time ;)

ok, and what could I add, cause I couldn't think of anything.

P.S. thanks for whoever voted that yes =)

From: d1s3l
ok, and what could I add, cause I couldn't think of anything.

Its good enough IMO. However, you just squeaked in by my standards.

It needs more failsafes, What if you aren't at the bank? What if you get lost while walking? What if an meteor destroys all human life! :D You don't have to check for everything, but you aren't checking for enough. The more fool proof your script, the better it looks.

procedure RandomGameTab;

Is really quite ugly, It is pretty much half of your script and it could be cut down to about 6 lines.

       GameTab(Random(12));
       if(Random(10) > 5) then
          RandomRClick;
       if(Random(10) > 5) then
          PickUpMouse;
       GameTab(Random(12));
     end;

Viola, does just about the exact same thing while using far less space. Case statements are nice, however when you have lots of them that look pretty much identical you should be asking yourself "Do I really need all these cases or can I cut this down to 1-2 cases?"

Your script is simple, but like you said, there really isn't much more to add to a woodcuter/banker (other then woodcutting and banking)

No, sorry.

The logic is all over the place, especially in key parts like the walking. You have quite a few begins in the wrong places and, as a result of that and the poor logic, I really doubt that your script would work at all. I'd suggest to continue working and reading tutorials and try again in a month.

From: Method
No, sorry.

The logic is all over the place, especially in key parts like the walking. You have quite a few begins in the wrong places and, as a result, I really doubt that your script would work at all. I'd suggest to continue working and reading tutorials and try again in a month.

the first time i used it, it ran for 1hr 30mins and stopped cause of marduat
Oh and your dont gotta be a dick and say go back to tutorials, I wasted alot of hours on this script.

@Bober thanks for the help, I changed it and seem much better, thanks

Sorry. Too simple. Also, your standards are a bit off in some areas.

Like above… too simple.

From: d1s3l
the first time i used it, it ran for 1hr 30mins and stopped cause of marduat
Oh and your dont gotta be a dick and say go back to tutorials, I wasted alot of hours on this script.

@Bober thanks for the help, I changed it and seem much better, thanks

procedure WalkToTrees;
begin
  if(not(LoggedIn))then Exit;
  Wait(2000);
  SetRun(True);
  MakeCompass('w');
  Disguise('Walking To The Willows...');
  begin
    if invfull then
    MakeCompass('w');
    WalkToBank;
    Exit;
    begin

Your script will never get past that part in the function. Call me crazy, but I just don't see it. You might get lucky with the water walking in the ChopTrees function, but other than that your script shouldn't work. I'm not trying to "be a dick" and say that your hard work was for nothing, but I don't think this script is worthy of being accepted. Sorry.

Bad standards, bad nesting. Sorry, its a no.

There are other issues as well, mainly attitude. Method is trying to help, and you are being a 'dick' so frankly, gf to you and apply again some other time and try to get my vote.

Nope.

From: Nava2
Bad standards, bad nesting. Sorry, its a no.

There are other issues as well, mainly attitude. Method is trying to help, and you are being a 'dick' so frankly, gf to you and apply again some other time and try to get my vote.

Nope.

find one post where i was a dick beside the one before. And i cant see where in that thread he was trying to help me.

He was giving you suggestions, its a critique when you apply. You learn from it.

Take what he says, and try and improve. Don't cut at those who help.

Don't kick a gift horse in the mouth.

From: Nava2
He was giving you suggestions, its a critique when you apply. You learn from it.

Take what he says, and try and improve. Don't cut at those who help.

Yeah i guess, sorry about that.

there was no point taking it down, now you can't get any more feedback, which if you don't listen to will cause us to vote no next time

Nuh uh :0

no im to be guessing?

Well I took it down because I realized that I had alot more work to do in this script and I knew what I needed to do and I didnt want to waste your guys' time :)