SRL Archive - First Scripts

Hey guys a script i made dun be haten :)
I feel very speshful and i want you guys to try it please and tell me what i did wrong :) I'm still trying to learn to script i have the basics i let it run for a little bit and this is what is left me with

##############################################
lVlavericks BucketFiller Has been running for:
7 Minutes and 46 Seconds
lVlavericks BucketFiller Has Done:
5Trips which equals 140.
Please Post Proggies and any feedback you have
Thank you!!!
~lVlaverick~
##############################################

Enjoy!!!!!
Please Post Proggies and Feeback :)


~lVlaverick~

Nice script, I suppose. Few things:

Procedure OBank;
Begin
MakeCompass('n');
Setangle(false);
 If (FindColor(x, y, 9408915, 0, 0, 518, 337)) Then
  Begin
   Mouse(x, y, 5, 5, false);
    Wait(250+random(750));
     ChooseOption('uickly');
      Wait(3000+random(1500));
  End;
End;

Alot of your script had pretty bad standards, and….

FindColor????

Colors change. FagHax is just stupid like that. Use, at the least, FindObjTPA.

Look up some tutorials on TPA finding and such. It'll be a major step up from FindColor. =P

I'm tired and in school, so mah language is.. Ish.

Nice effort ~lVlaverick~

You left your account details in the script. I have changed them for you and sent you the new details by private message.

edit: It would be much faster to simply buy buckets of water from the gnome copter place, as theres a bank deposit box right next to it, you can easily get 27 buckets in less than 15 seconds, which is the fastest way in the game, :P

Thanks orange and i'll look at some scripts for the tpa thing

Here it is with decent standards:

//////////////////////////////////////////////////////////
//Start off in the small bank in Varrock with no buckets//
//  in your inventory and you can start logged off or   //
//  logged in fill out DeclarePlayers and line 11-14    //
//////////////////////////////////////////////////////////
program BucketFiller;
{.include srl/srl.scar}

const
  BankBucketColor    = 1789798;  //Get The Dark Brown Color of an empty bucket
  FilledBucketColor  = 10321533; //Get the Water Part of a filled bucket
  MinimapRoadColor   = 8357257;  //Get the gray color of the road on the minimap
  WaterFountainColor = 13933438; //Walk to the water fountain and get a color

var
  x, y, T : Integer;

procedure DeclarePlayers;
begin
  HowManyPlayers := 1;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  Players[0].Name :='corvette0456';
  Players[0].Pass :='gallardo';
  Players[0].Nick :='c456';
  Players[0].Loc  :='Bank';
  Players[0].Active:=True;
end;

procedure MyAntiBan;
begin
 case Random(7) of
  1: BoredHuman;
  2: PickupMouse;
  3: Hoverskill('Range', False);
  4: Hoverskill('random', False);
 end;
end;

procedure OBank;
begin
  MakeCompass('n');
  SetAngle(False);
  if (FindColor(x, y, 9408915, 0, 0, 518, 337)) then
    begin
      Mouse(x, y, 5, 5, false);
      Wait(250+random(750));
      ChooseOption('uickly');
      Wait(3000+random(1500));
    end;
end;

procedure DepositBuckets;
begin
  if (BankScreen) then
    begin
      if (FindColor(x, y, FilledBucketColor, 554, 214, 727, 462)) then
        begin
          Mouse(x, y, 5, 5, false);
          Wait(100+random(175));
          ChooseOption('All');
        end;
    end;
end;

procedure WithdrawlBuckets;
begin
  if (BankScreen) then
  begin
    if (FindColor(x, y, BankBucketColor, 26, 84, 495, 191)) then
      begin
        Mouse(x, y, 5, 5, false);
        Wait(100+random(75));
        ChooseOption('All');
        Wait(1000+random(750));
        Mouse(489, 34, 5, 5, true);
        Wait(500+random(750));
      end;
   end;
end;

procedure WalkToFountain;
begin
  RadialWalk(MiniMapRoadColor, 0, 10, 65, -1, 0);
  SetAngle(True);
  Wait(500+random(500));
  if (FindSymbol(x, y, 'water')) then
    begin
      Mouse(x, y, 5, 5, true);
      Wait(12000+random(3000));
    end;
end;

procedure FillBuckets;
begin
  if (FindColor(x, y, WaterFountainColor, 0, 0, 518, 338)) then
    begin
      Mouse(577, 224, 5, 5, True);
      IsUpText('se');
      Mouse(x, y, 5, 5, True);
      Wait(500+random(1000));
      MyAntiBan;
      Wait(13000+random(2500));
    end;
end;

procedure GoToBank;
begin
  RadialWalk(MiniMaproadColor, 120, 150, 65, -1, 0);
  Wait(3500+random(1500));
  SymbolAccuracy := 0.5;
  if (FindSymbol(x, y, 'bank')) then
    begin
      Mouse(x, y, 5, 5, True);
      T := T+1;
      SymbolAccuracy := 0.8;
      Wait(7500+random(1500));
    end;
end;

procedure Proggie;
begin
  Writeln('##############################################');
  Writeln('lVlavericks BucketFiller Has been running for:');
  Writeln(TimeRunning);
  Writeln('lVlavericks BucketFiller Has Done:');
  Writeln(IntToStr(T) +' Trips which equals ' + IntToStr(T*28) +' buckets.');
  Writeln('Please Post Proggies and any feedback you have');
  Writeln('Thank you!!!');
  Writeln('~lVlaverick~');
  Writeln('##############################################');
end;

begin
  Disguise('iTunes');
  SetUpSRL;
  ActivateClient;
  Declareplayers;
  LoginPlayer;
  Gametab(4);
  repeat
    OBank;
    WithdrawlBuckets;
    FindNormalRandoms;
    WalkToFountain;
    FillBuckets;
    FindNormalRandoms;
    GoToBank;
    OBank;
    DepositBuckets;
    Proggie;
  until(false)
end.

Yeah. I hope that's good enough for you. I try pretty hard to fix people's scripts with standards. Lol. Yeah. It's hard to learn them. Took me a while =/.

Wait what are standards?

Proper spacing, tabbing, alignment, etc.

oh ok

From: lVlaverick
oh ok

Uber spam.

Read some TPA tuts =]

could use a bit of work on the standards, but else quite good.
What u should do is open Scar (folder) and go to this directory: Includes/SRL/SRL/Core/
Here u can find bunch of SRL procedures & functions, which help and makes scripting alot easier.

Lets say for ur bank opener, We could just do: OpenBankFast('feb') ( feb = Falador east bank )

Or finding almost anything with

Findobjtpa

or

findobj

So just open that directory and look at the procedures and functions which u think would be cool to use.

good for first script but bad overall..

sweet script but not many people want to fill buckets O.o

For a first script this is still a neat little script, i mean you probly could buy buckets easier but this is cheaper and his hard work, good effort bro =]

nice for a first script, thumbs up.

I like the idea, its something i need very badly, and its a good job for your first script!

But still… Its pretty slow, the walking is pretty bad (takes long time, and goes to the wrong places etc.), and the script doesen't give me enough time to fill all my buckets. And it doesen't take long before it starts in and out of the bank, doing nothing else than taking out empty buckets.

Not to bad , very clever idea tho wil help many ppl out with farming and etc… good job 5 stars :f:

nice script. worked for the short time i used it.

nice script. i'm using :)