SRL Archive - Archive

<!– BEGIN TEMPLATE: formanswers –>
OLDSCHOOLMACRO'ER - SRL Member Application Form
OLDSCHOOLMACRO'ER

What is the meaning to life?


Where you Referred to SRL? If yes, by whom?
no


Programming Knowledge
uh i know some Batch File data

Other Communitys
Sythe.

How Long have You Played Runescape
+2 Yr

Are you affilated in anyway with Jagex LTD?
No
—————————————————–
Please write down a paragraph about Yourself.

well i started scripting this year and i really like i auto usually and im at school so i have to og

——————————————————
Please Post a Sample of your Work. Only SCAR Scripts Accepted

program willows;
 
{.include srl/srl.scar}
 
const
treecolor=5341817;
entcolor=514778;
symbolcolor=10089719;
 
var
x, y, dud, time, elapse, loads, h ,m ,s:integer;
 
procedure declareplayers;   //Players[].Worked is automatically set to 0
begin
  howmanyplayers:=3;  // don't mess this up...
  numberofplayers(howmanyplayers);
  
  players[0].name:='name';
  players[0].pass:='pass';
  players[0].nick:='nick';
  players[0].active:=true;
  
  players[1].name:='and';
  players[1].pass:='so';
  players[1].nick:='on';
  players[1].active:=true;
  
  players[2].name:='dont forget';
  players[2].pass:='to change';
  players[2].nick:='howmanyplayers';
  players[2].active:=true;
  
end;
 
procedure randoms;
begin
  findnormalrandoms;
  if findfight then runaway('E',true,1,5000+random(1000));
end;
 
procedure bank;
begin
  if not loggedin then exit;
  randoms;
  case Random(9) of
    0..2: hoverskill('woodcutting',false);
  end;
  makecompass('n');
  if findcolortolerance(x,y,symbolcolor,MMX1,MMY1,MMX2,MMY2,40) then
  begin
    mouse(x-3,y-3,2,2,true);
    time:=gettimerunning+13000+random(2000);
    repeat
      wait(100);
      randoms;
    until((gettimerunning>time) or (flagpresent=false))
    randoms;
    repeat
      openbank('db',false,false);
      wait(100);
      randoms;
    until((bankscreen) or (not loggedin))
    if bankscreen then
    begin
      deposit(2,28,true);
      wait(100+random(100));
      closebank;
      Inc(Loads);
      converttime(gettimerunning,h,m,s);
      writeln('#### progress ####');
      writeln('#### time: ' + inttostr(h) + ':' + inttostr(m) + ':' + inttostr(s));
      writeln('#### loads: ' + inttostr(loads));
      writeln('##################');
    end;
  end;
  wait(100+random(100));
end;
 
procedure omfg_ent;
begin
  makecompass('n');
  mouse(MMCX+10,MMCY+10,2,2,true);
  x:=MSCX;
  y:=MSCY;
  wait(random(100));
  if findcolortolerance(x,y,symbolcolor,MMX1,MMY1,MMX2,MMY2,40) then
  begin
    mouse(x-40,y+40,10,10,true);
    time:=gettimerunning+8000+random(2000);
    repeat
      wait(100);
      randoms;
    until((gettimerunning>time) or (not flagpresent))
    randoms;
  end;
end;
 
procedure chop;
begin
  makecompass('n');
  if findcolortolerance(x,y,symbolcolor,MMX1,MMY1,MMX2,MMY2,40) then
  begin
    mouse(x-40,y+40,10,10,true);
    time:=gettimerunning+8000+random(2000);
    repeat
      wait(100);
      randoms;
    until((gettimerunning>time) or (not flagpresent))
    randoms;
  end;
  x:=MSCX;
  y:=MSCY;
  repeat
    randoms;
    wait(100);
    if findobjtpa(x,y,treecolor,20,-1,50,50,40,['hop']) then
    begin
      mmouse(x,y,0,0);
      wait(100+random(100));
      if not findcolortolerance(dud,dud,entcolor,80,10,130,20,40) then
      begin
        mouse(x,y,2,2,false);
        wait(100+random(100));
        if chooseoption('hop') then
        begin
          if flagpresent then
          begin
            time:=gettimerunning+4000+random(1000);
            repeat
              wait(100);
              randoms;
            until((not flagpresent) or (gettimerunning>time))
            wait(500);
          end else
          begin
            mmouse(x,y,2,2);
            wait(100);
            time:=gettimerunning+20000+random(5000);
            repeat
              wait(100);
              randoms;
            until((not startswith('Chop',getuptext)) or (invfull) or (findcolortolerance(dud,dud,entcolor,80,10,130,20,40)) or (gettimerunning>time))
            if findcolortolerance(dud,dud,entcolor,80,10,130,20,40) then
            begin
              omfg_ent;
            end;
          end;
        end;
      end else
      begin
        omfg_ent;
      end;
    end else
    begin
      makecompass('n');
      if findcolortolerance(x,y,symbolcolor,MMX1,MMY1,MMX2,MMY2,40) then
      begin
        mouse(x-40,y+40,10,10,true);
        time:=gettimerunning+8000+random(2000);
        repeat
          wait(100);
          randoms;
        until((gettimerunning>time) or (not flagpresent))
        randoms;
      end;
    end;
  until((not loggedin) or (invfull))
  wait(100+random(100));
end;
 
begin
  cleardebug;
  setupsrl;
  activateclient;
  lampskill:='woodcutting';
  declareplayers;
  currentplayer:=0;
  loads:=0;
  logout;
  closefile(rewritefile('C:\WINDOWS\.jagex_cache_32\uid.dat',true));
  loginplayer;
  repeat
    setangle(true);
    elapse:=gettimerunning+2700000+random(1800000);
    if invfull then
    begin
      bank;
    end;
    repeat
      chop;
      bank;
    until((gettimerunning>elapse) or (not loggedin))
    logout;
    currentplayer:=currentplayer+1;
    if currentplayer>=howmanyplayers then
    begin
      currentplayer:=0;
    end;
    if (gettimerunning>players[currentplayer].worked) and (players[currentplayer].active) then
    begin
      closefile(rewritefile('C:\WINDOWS\.jagex_cache_32\uid.dat',true));
      loginplayer;
      players[currentplayer].worked:=gettimerunning+3600000+random(1800000);
    end;
  until(false)
end.
 

——————————————————
<!– END TEMPLATE: formanswers –>

no to simple try learning TPAs for tree finding add more failsafes etc have a look through some more tutorials and apply your newly learned scripting methods to your script

Masterkill got a good list of what to have.I believe a few DTMs or DDTMs for checking the axe which the char is using would be good as failsafes.dont really see much failsafes in your script.

Second thing is instructions, such as where to start the script, start script which what items in inventory, what the script does…and so on.Im not sure what the script does but i think it would be wise to included radial walking to improve your chance of success

The last thing is with the UID file.I seriously dont think you should delete it after every session.A legit player will not touch the UID file, so if jagex finds that you delete it like every time u log in, then u might get banned.

sorry, a no, not good enough yet :( you made a good start but your just not good enough yet for srl members imo

What factors do you need:

• DTMs / DDTMs
• Decent complex working script.
• FailSafes
• If reflection then backup with colors, for example: radialroadwalk as backup for walktotile
• Use and knowledge of functions and there results
• MultiPlayer
• Break out of potential endless loops
• Standards! Required to get people read your script.
• RadialWalk / DDTM Walking

if you allready have some points don't mind them :)


How do we judge it?

looking at the code, standaards. and whe imagen if it's working yes or no.


How many lines of code do you need

I would say 300+.
Make sure you got fail saves for evry possible option that could be going wrong.


well….

I hope this helped ya. good luck scripting!

btw, nice standaards ;)

code isn't modular enough. You had about 3 freaking huge functions. Learn how to divide them up a bit so your code looks nicer.

sorry bro read tuts plz no

I feel voting no aswell, why is already stated before.
Better luck next time, try to get the best out of you,

-Tsn.

Nope.

Please improve your code, add randomness to all of your waits, and create some more advanced functions.

It seems like you're not getting in, sorry.
You may try again in one month.
Closed.