SRL Archive - Discussions and Debates

Proggie Help


P1nky

2008-08-23 02:43:33

THanks Nava

prob solved :)

Method

2008-08-23 11:39:53

I'm not entirely sure what the problem may be, but you have random begins and ends thrown around in procedures. There's no if conditional before them, they're just there. Fixing standards can sometimes fix errors, so I'd suggest doing that first.

P1nky

2008-08-23 13:07:10

nava stfu didnt i say i bet someone would say that…

god dam… thanks method

Nava2

2008-08-23 14:53:45

From: ~~Joker~~
nava stfu didnt i say i bet someone would say that…

god dam… thanks method


Sorry, its just that, it is sooo annoying to read code that isn't in standards.

Found it! :)

Your standards were killing you. Here is what I think it should be.

Procedure bank;

var
logdtm : integer;

Begin
If Not (LoggedIn) Or Not (Players[CurrentPlayer].Active) Then
NextPlayer(false);
SRLStatsNeedSent;
If (Not (LoggedIn)) Then Exit;
writeln('Reached Banked');
MakeCompass('W');
OpenBankFast('db');
Repeat
wait(1000);
If (PinScreen) Then
Begin
Writeln('Bank Pin Found. Remove!!')
wait(3000 + Random(700))
TerminateScript;
End;
Until bankscreen; //you may want to failsafe that... =/
LogDtm := DTMFromString('78DA63CC65626078C480025A12CD18FE03694' +
'620FE0F048C2540353719D000231209A453806AEE1050130B54F3' +
'92801A907BDE1350530D54F31CBF1A0035170E14');
gametab(4);
Deposit(1, 28, True);
If finddtm(logdtm, x, y, 550, 203, 731, 464) Then
Begin
Mouse(x, y, 3, 3, false);
wait(random(400) + 100);
ChooseOption('ll');
end;
newwait(500, 200);
closebank;
Writeln('Done Banking');
Inc(LoadsNum);
Inc(LoadsNum2);
Inc(banked);
Inc(ReportVars[7]);
report;
//ToTrees;
end;

I fixed the standards, and because I did that I found the error. If you didn't find a DTM you weren't completing the rest of the procedure. Watch your nesting.

Hope thats it.. :)

P1nky

2008-08-23 22:51:05

hah yes tht was it i thought about that but i totally forgot i put the deposit shit

thanks nava sorry for my rude post before i thought you just wanted to taunt me or somthn but yes im working on my standards now on the script and about to release :)

thnx once again ReP+

Nava2

2008-08-24 14:06:06

My pleasure, I'm sorry as well, I kinda jumped the gun. I'm too picky at times.