SRL Archive - Archive

I understood all your comments and am learning DTMS, am now freeing my bitmaps and improving it heaps better.

Thanks for the help everyone.

I resign from my application. Try again next month maybe. I know I need to learn a lot more

Looks ok i guess, YES

Wow thanks, I'm excited

Extra to my Application:

The Script Stats in my sig are not correct, as I only added the SRL Stats part recently. My biggest proggy was 10 hours

Hmm, script is..

OK. Somemessy code.
Your activity worries me.

..



Sorry.

By the way, have a look at Bank.scar.

Yeah I use Bank.scar with some of my scripts, but updated RuneScape ruined it all for me.

I've downloads REV 19 now and it all works.

I am updated my Script to Bank.scar as we speak.
Will be released in V2

No.

Post Count and Post content are Sketchy. A lot of useless 4 word or less posts.
Not to mention the script has some VERY distinct similarities to this one.
http://www.scar-scripts.com/view/1247

Including the name you released it under..
http://www.villavu.com/forum/showthread.php?t=32165

You do not free your bmp's, low post count, half of your posts are from the "anyone know who is foss" thread, and that thread spreads doubt that you could steal p/w's, (I'm not saying it was you) and with out your double posts being deleted you would be on a far higher post count.
However the script looks ok.

Erm Hobbit.

you say it has some VERY distinct similarities i think that is because it may be his

Players[0].Name :='fosscape';
  Players[0].Pass :='leftrightupdown';
  Players[0].Nick :='foss';
  Players[0].Active := True;

For now ill hold my vote.

What the fuck? thats my username and pass but i changed ages ago =P!!!

Including the name you released it under..
http://www.srl-forums.com/forum/mult...ti-t34864.html

Thats me

function TotalCut: Integer;
var i, x: integer;
begin
 for i := 0 to HowManyPlayers - 1 do
 begin
   x := x + Players[i].Integers[1];
 end;
 result := x;
end;

Instead of doing HowManyPlayers - 1, you could just do High(HowManyPlayers) ;) (High = Length - 1; Low = Length +1; Length = Length ;))

Also, instead of doing Result:=X;, you could've replaced X with Result, and since there is only one line in the for to do loop you could've removed that begin and that end, so it would look like:

function TotalCut: Integer;
var i: integer;
begin
 for i := 0 to HowManyPlayers - 1 do
   Result:=Result+Players[i].Integers[1];
end;

procedure SRLRep;
begin
  SRLRandomsReport;
end;

What's this? There's no need for this procedure, since it only contains one line. You might as well remove it and replace SRLRep with just SRLRandomsReport;.

procedure Report;
begin
ClearReport;
if(UseSRL) then SRLRandomsReport;
//Ln('Gathering Report');
AddToReport('#########################');
AddToReport('#      Pro Fletcher     #');
AddToReport('#         v 1.5         #');
AddToReport('#  Players: ' + intToStr(HowManyPlayers));
AddToReport('#  Current: ' + Players[CurrentPlayer].Name);
AddToReport('#  Running: ' + TimeRunning);
AddToReport('#      Cut: ' + intToStr(Players[CurrentPlayer].Integers[1]));
AddToReport('#    Total: ' + intToStr(TotalCut));
AddToReport('#    Loads: ' + intToStr(Loads));
AddToReport('#    Banks: ' + intToStr(MyBanks));
AddToReport('# AntiBans: ' + intToStr(antis));
AddToReport('#   Gained: ' + intToStr(lvls));
AddToReport('#    Level: ' + intToStr(Players[CurrentPlayer].level[13]));
AddToReport('#########################');
 
if(TCut > 0) and (TotalCut >= TCut) then TerminateScript;
if(SCut > 0) and (Players[CurrentPlayer].Integers[1] >= SCut) then Logout;

What about the debug box? It has much more space, also, this wouldn't even fit the average report box.

procedure NoRandoms;
begin
  //I deleted this function because I only use it on Pest Control now,
  //Anti-Randoms slow down my PC XD
 
 
  {ln('Searching for randoms');
  FindNormalRandoms;
  FTWait(4);
  If FindFight Then
  Begin
    ln('Found fight, running');
    RunAway('N', True, 1, 5000 + Random(5000));
  End;
  If ClickToContinue Then ClickContinue(True, True);
  If FindMod Then
  Begin
    Ln('Found a Moderator... Do nothing, he wont realise!');
  End;
  FindNormalRandoms;}
 end;

If you're not going to use it, then just remove it ;) It'll save a lot of space.

procedure ScriptTerminate;
begin
  Ln('Ending script');
  WriteLn('####################################');
  WriteLn('####################################');
  Writeln('# Thankyou for using Pro Fletcher! #');
  WriteLn('####################################');
  WriteLn('####################################');
  if(UseSRL) then SRLRep;
  Report;
end;

You have this procedure that's never called. What is it good for? Best just to remove it ;) Also, i see a direct copy of the WriteLn's from that procedure in the main loop. Why?

You also have an endless loop, very little player support and a lot of bad use of standards. You also have a lot of Bitmaps, which can fail a lot, and you have hardly any fail-safes.

I am going to vote NO on this application for now, since it does not meet the quality requirements for acceptance into SRL Members.

For a list of requirements, have a look at the various tutorials around SRL and in its' tutorials forum ;)

From: Hobbit
Not to mention the script has some VERY distinct similarities to this one.
http://www.scar-scripts.com/view/1247

Including the name you released it under..
http://www.srl-forums.com/forum/mult...ti-t34864.html

Umm, that was his script and he obviously improved it and put this one into his SRL Members application.

Even look at the names:
Fosscape. ;)

But anyways, Foss, look at the above and improve on your script that way. Then next application you might make it in.

I think Waddo (about the bmps's) and dan made it clear enough. Not enough to get in IMO, learn some more and re-apply next month;)

-Tsn.

[QUOTE=Dan's The Man;433471][scar]function TotalCut: Integer;
var i, x: integer;
begin
for i := 0 to HowManyPlayers - 1 do
begin
x := x + Players[i].Integers[1];
end;
result := x;
end;[/scar]
Instead of doing [i]HowManyPlayers - 1[/i], you could just do [i]High(HowManyPlayers)[/i] ;) (High = Length - 1; Low = Length +1; Length = Length ;))

*cut*[/QUOTE]

Maybe Howmanyplayers-1 is faster? :p

Im holding my vote.

Edit: im 51% on no.. sry..

Most part of the script is for debugging, and why do you keep the pest control-procedure in there?

and too little random on mouse();

@ Dan's The Man,
Scriptterminate doesn't have to be called.
When you stop the script/it gets an error, it will automatically do that procedure;)
I use it in my fightcaver too:)

Iew, no randomness:o

      wait(700);

Thats bannable.. Use

      wait(700+random(500));

Or something like that;)

Your standards also, not cool:p

I fixed them in this function so you can see what I mean.
They are usefull when you are searching for errors/bugs;)
It makes it view better:)

function TakeLogs: Boolean;
var Z: Integer;
begin
  GameTab(4);
  ln('Opening Bank..');
  if not(OpenMyBank) then
  begin
    ln('Bank not found.. Relocating to nearest bank symbol');
    ReLocate;
    GetBankPos;
    wait(1000);
    OpenMyBank;
  end;
  MarkTime(Z);
  repeat
    wait(500);
  until(TimeFromMark(Z) > 10000) or (Bankscreen);
  ln('Bank took ' + IntToStr(TimeFromMark(Z)) + ' ms');
  FixBank;

  wait(800);
  if(ExistsItem(2)) then
  begin
    Mouse(620, 231, 3, 3, false);
    wait(400);
    if(FindBitmap(StoreAll, x, y))then //finds the bitmap
    begin
      ln('Storing from slot 2');
      Mouse(x + random(100), y, 1, 1, True); //left clicks the bitmap
    end else Ln('"Store All" not found!');
    wait(500);
  end else Ln('Nothing to store');
  MMouse(91, 78, 1, 1);
  wait(500);
  if(IsUpText('ogs')) then
  begin
    ln('Detecting log');
    log := GetLog(rs_GetUpText);
    Mouse(91, 78, 1, 1, False);
    Wait(800);
    ln('Withdrawing logs');
    if(FindBitmap(WithdrawAll, x, y))then //finds the bitmap
    begin
      Mouse(x + random(100), y, 1, 1, True); //left clicks the bitmap
    end else Ln('"Withdraw All" not found!');
    wait(600);
    ln('Closing bank');
    CloseBank;
    result := true;
  end else
  begin
    Ln(rs_getUptext + ' is not a log');
    ln('Closing Bank');
    CloseBank;
    result := false;
  end;
  CloseBank;
end;

Also, you don't need a begin here, because you only give 1 command:
You use this:

    if(FindBitmap(WithdrawAll, x, y))then //finds the bitmap
    begin
      Mouse(x + random(100), y, 1, 1, True); //left clicks the bitmap

I use this:

    if(FindBitmap(WithdrawAll, x, y))then Mouse(x + random(100), y, 1, 1, True); //left clicks the bitmap

See? Thats a lot of smaller.
Also, when it fails to find the log or so, you don't exit the procedure.
Which means it will move on and keep on moving the mouse.
Don't do that!
It will look very unhuman.

Sorry man, It's a no from me.
It is a good attempt, but you need to improve some things.
Good luck;)

PvH

From: Zytex!
Maybe Howmanyplayers-1 is faster? :p

Teaching the pupils of SRL more advanced methods :p ;) :p

[QUOTE=Dan's The Man;433471][scar]function TotalCut: Integer;
[scar]procedure ScriptTerminate;
begin
Ln('Ending script');
WriteLn('####################################');
WriteLn('####################################');
Writeln('# Thankyou for using Pro Fletcher! #');
WriteLn('####################################');
WriteLn('####################################');
if(UseSRL) then SRLRep;
Report;
end;
You have this procedure that's never called. What is it good for? Best just to remove it ;) Also, i see a direct copy of the WriteLn's from that procedure in the main loop. Why?


Ohhh looks like you just got taught something Dan's The Man.
ScriptTerminate automaticly gets called just before the script terminates.
Try this in scar for example

Procedure scriptterminate;
Begin
writeln('s');
end;

Begin
terminatescript;
end.

Im not going to vote though foz, just thought I would point that out :)

Edit : Just saw someone elses mentioned it :(

@ss23 you should wait 2 weeks after becoming member anyway ;)

ontopic
im going to vote no for some stated things in this thread like post count/spam etc longivity and i think dan summed most of it up script is alright maybe next time

sorry no

I am sure I have seen this script elsewhere….

Dang, can't find it. Oh well :p

It is a no, but here's how you can fix your anti-randoms:

procedure NoRandoms;
begin
  If FindFight Then
  Begin
    ln('Found fight, running');
    RunAway('N', True, 1, 5000 + Random(5000));
  End;
  ClickContinue(True, True);
  FindNormalRandoms
end;

Just call it every second or so and you will be fine :D

Good luck next time, if you need more help hit me up on MSN.

I think I'll vote yes, artly cos I got in with a fletcher of about the same quality, except I think I got in with my form (use forms, we love them ;)).

GL!

PS: Anyone noticed I'm back yet?

nah gl next time

alot of reasons been already discussed ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Sketchy standards, I know the whole bank.scar thing has been discussed, low post and low activity already been discussed as well. Need to free bitmaps… ummm.. I am also going to say no because a fletcher really is not a very complex script when you get right down to it. No walking, no TPAs, no DDTMs, you did not use any DTMs. Good luck, keep working, and try again in a month :D.

From: pvh
@ Dan's The Man,
Scriptterminate doesn't have to be called.
When you stop the script/it gets an error, it will automatically do that procedure;)

PvH

Cool :D Never knew that :D

lol I tought you all something XD@!!!

It seems like you're not getting in, sorry.
You may apply again in one month, good luck.
Closed.