SRL Archive - RS3 Outdated / Broken Scripts

Hi ! I'm releasing my new script : "The Dervish Soft Clay Maker".

It will make you soft clay if you have jugs of water (easier to buy in G.E than buckets of water), and clay in the TOP ROW OF BANK.

Instructions

1)Setup Lines : - 8 to 10
- 18 to 21

2)Go To a bank booth in the chosen bank

3)Empty all your items in inventory

4)Check that the clay and the jugs of water are in top row of bank

5)Drag The Crosshair from SCAR to RuneScape window

6)Hit "Run"

7)Post proggies , feedback, comments, and constructive critiscism

Here it is folks :

[ATTACH]13075[/ATTACH] - V0.1
[ATTACH]13076[/ATTACH] - V0.2 (fixed tons of bugs)


Have fun making profit :D

Ok first thing I notice when I look at the script is that you're indents are only 1 space. SRL Standard is 2 spaces which IMO looks a lot better. :)

With your anti randoms proc:

procedure DoAntiRandoms;
begin
 FindLamp(Skill);
 FindTalk;
 FindInventoryRandoms;
 FindNonInventoryRandoms;
 FindNormalRandoms;
end;

FindNormaRandoms covers all of the things in the above procedure. There is no need to call them twice.

You also need to improve your antiban procedure by adding more antiban procs to it. Simple random right clicking and skill hovering won't make the script seem much more human-like thus making you look very suspicious.

Can I ask you want this is supposed to do (out of curiousity):

procedure SetupThePlayer;
begin
 If not (LoggedIn) then
 begin
  TerminateScript;
 end else
 MouseBox(662,472,690,497,1);
 If not FindColorTolerance(x,y,1579628,625,420,660,445,5) then
 begin
  Wait(200+random(100));
  MouseBox(625,420,660,445,1);
  MouseBox(630,175,652,200,1);
 end else
 begin
  MouseBox(630,175,652,200,1);
 end;
end;

You also need to put in a lot of failsafes into the script. I see in a couple of places that you have endless loops which are quite dangerous in terms of bans. For example:

 repeat
  OpenBankQuiet(Bank);
 until(BankScreen);

This script will continuously call OpenBankQuiet until it finds the BankScreen. What happens though if the character isn't in the bank and the bank booth is not in view? The script will endlessly move the mouse around the screen (which means the char won't log out) trying to find the booth. Thus after a couple of hours of doing that a ban will result.

You also need failsafes as a backup for when things don't happen as planned. I noticed that you haven't checked to see if the character has run out of clay/water yet. According to your code the character will continuously open the bank and close the bank until 'MadeSoftClay = SoftClayToMake' which will not happen if there is no clay left to soften.

I also suggest that you learn how to use DTMs or Bitmaps to find your Clay and your Jugs of Water while withdrawing, softening and depositing rather than assume that the items exists in certain spots.

Oh multiplayer is not setup properly in your main loop:

procedure MainLoop;
begin
 SetupSRL;
 ClearDebug;
 ActivateClient;
 DeclarePlayers;
 MadeSoftClay := 0;
 LoginPlayer;
 SetupThePlayer;
 repeat
  Banking;
  MakeSoftClay;
  StoreTheLeftItems;
  Proggy;
 until(MadeSoftClay = SoftClayToMake);
end;

You don't call NextPlayer anywhere and you don't have a loop for each of the players.

So yea thats my feedback.

Zeph

Thanks for the GR8 feedback :)

I made a new version but all stuff you saw will be included in V0.3 :)

Thanks ALOT

Edit 1 : The thing you asked for in SetupThePlayer, was for setting Run Mode ON in case there's a big space between the booths and you take another one than the one you're already at.

I tried to tinker with it a ilttle but my coding isn't what it used to be, I removed your Almostlogout case because it gave me an error idk why. Everything worked until it came to withdraw the clay and jugs, ill try another form of banking but it wouldn't withdraw either thus resulting in a loop.


EDIT: I Fixed it up a tad bit for my needs, I looked though the srl include and saw withdraw, Your findcolortolorance wasn't found so it would skip the next step and close bank, I removed it. I would love to talk over aim or MSN to discuss the changes made, but here is my banking system.
Motokid985 AIM
[email]Johnjohn@charter.net[/email] MSN

procedure Banking;
begin
 If not (LoggedIn) then
 begin
  Writeln('Somethings wrong you arent logged in...');
  TerminateScript;
 end else
 repeat
  OpenBankQuiet(Bank);
 until(BankScreen);
 Wait(300+random(100));
 begin
  Withdraw(1,1,10)
 end;
 wait(2000+random(500));
 begin
  Withdraw(2,1,10)
 end;
CloseBank;
end;

I also had a small problem with bankquiet, it couldn't find the bank all the time, I was using vwb so that might be it but idk, Ill look later. But replacing that into your banking procedure makes it work for me.