SRL Archive - First Scripts

This is my first script, a Steel Smither.
You need to start it in Falador West Bank with Compass facing north, or logged off at the bank. Use lowest detail and highest Brightness. Put Crosshairs on runescape, Press Play and fill out the form.

Make sure you Put iron in your first bank slot and coal in your second. Ill probably revise this later by searching for DTMs


There are no Antirandoms or AntiBan in this script.

However, while smithing there are almost no Antirandoms anyway.

This Script Includes SRLPlayerForums. And uses SRL #16

This is just my first script I will probably update fixing bugs and adding other bars you can make. Please Submit Critizism.

______________________

revised version thanks to tips by FreakyMonkey.
Script is a little faster, has less bugs, and is probably more laggy friendly :)
Also fixed the bug with finding the bank symbol and doesn't confuse the beer symbol with bank symbol anymore.

KK, I have a couple things to say about the script.

1:
LOVE THE STANDARDS! Glad you put the time and effort to make them look great.

2:

SRLPlayerForm(true,[],[],[],[]);//Wth?

You didn't put anything in the playerform haha. You should probably put the bronze constant into there. Remember that the things you put into the player form are in array form. This is how you would call the first string that you put in the player form….

if Players[CurrentPlayer].Strings[0] then
  //blah

Notice how I used "CurrentPlayer" if its a multiplayer script. Also when defining it (the "strings[0]" part) I make the variable name (eg: String, Integer,etc.) plural.

Anyway, you may have added the playerform, but you didn't use it. :p

3:
For this function you are using Mouse then Flag to walk, but this would be the perfect opportunity to use MouseFlag, MFNF(Mouse Find NO Flag), or MFF(Mouse Find Flag). This is what you did…

    
    Mouse(x,y,1,1,true);
    Flag;
  

You can just do this….

  MouseFlag(x,y,1,1);
  //Or
  MFNF(x,y,1,1);
 //Or
  MFF(x,y,1,1);

Much easier right?

4:
I don't know about you, but I really like using OpenBankFast over OpenBankQuiet. I noticed that you used it in your script. If you have noticed some lag when it opens the bank I think you should use OpenBankFast.

OpenBankFast('fwb');//Same way of defining as OpenBankQuiet

5:
I don't like how you didn't put any failsafes into this part here. There are many SCAR users out there who have crappy 500 mB RAM computers that lag every other second…*cough* ME :rolleyes:

Change this…

Mouse(258,403,1,1,false);
    wait(1000+random(1000));
    ChooseOption('X');
    wait(1000+random(1000));
    TypeSend('9');

To….

repeat
  Mouse(258,403,1,1,false);
  Wait(1000+random(200));
  if ChooseOption('X')then
    Break;
until(false);
Wait(1000+random(200));
TypeSend('9');

6:
Lastly, I noticed this…Probably just a foolish mistake, but you don't have to do this….

    MMouse(x,y,1,1);
    Mouse(x,y,1,1,true);

Just do this…

Mouse(x,y,1,1,true);//Both moves and clicks

Probably just a careless error :duh:

7:
Ok what's missing here….Guess…..

NO DECLARE PLAYERS OMFG. Lol. Script in work i see :p .


Those are my comments for now. Keep up the good scripting man lovin' it :f: You really impressed me with your standards.

PS: YOu probably might want to think of getting a Script ID and put some SRL Stats into that stuff.

BTW: If you want my help PM me for my MSN or leave your MSN here.

~Rep me if I helped.

Hey thanks for the tips, but i have a few questions. I know that you can declare players in the script but i thought the SRLPlayerForm declared the players for you, such as you can call on declare player arrays in the script when you include it. If not then ill have to put it in for later.
Also i don't exactly know what you mean by put the Constant in SRLPlayerForm. I thought it supported variables only. I was going to use it for asking which bars to make such as

SRLPLayerForm(true,[],['BarType'],[],[])

And wouldn't this

repeat
  Mouse(258,403,1,1,false);
  Wait(1000+random(200));
  if ChooseOption('X')then
    Break;
until(false);
Wait(1000+random(200));
TypeSend('9');

work better without the mouse in the repeat loop because you would just keep right clicking the Steel bar probably making your computer lag more. And i didn't know you could have a function that doesn't return a boolean after an if statement or i would have done something like that.

I didn't know about the MouseFlag so thank you about that.
I started scripting long ago, Stopped, and started again just recently and back then i had the Functions Movemousesmooth and clickmouse in my head so i just incorporated that to MMouse and Mouse which would explain the few lines with that.
Ill try the OpenBankFast.
And Lastly im still having trouble with the Symbol thing. I tried changing symbolaccuracy but doesn't seem to be working 100% of the time.

so this script takes out coal and iron?

From: wand2658
so this script takes out coal and iron?

Put Iron in your first bank slot and Coal in your second, it'll smith the steel walk back to the bank and bank it withdraw iron and coal and go back to smith.

Ok, for the SRL playersform, it takes the player's username and password OUT of the declareplayers. And thats what I mean when you put this

SRLPLayerForm(true,[],['BarType'],[],[]);

That is the correct way of formatting the procedure. Then since 'BarType' is a string you would call on it later in the script like this…

SRLPLayerForm(true,[],['BarType'],[],[])
//blah
if Players[CurrentPlayer].Strings[0]='bronze' then
   //rest of script

Do you understand that? Since 'BarType' is the first string in the array you call on it starting from 0. I suggest you read Sumilion's TUT on SRLPlayerForm here.

And for this part…

repeat
  Mouse(258,403,1,1,false);
  Wait(1000+random(200));
  if ChooseOption('X')then
    Break;
until(false);
Wait(1000+random(200));
TypeSend('9');

I don't think you fully understand what 'Break' does. 'Break' breaks out of an endless loop regardless of the 'Until(false)' function. So in essense this would right click, wait, chooseoption (if it exists), and continues. If this fails it would repeat until it DOESN'T fail.

BTW: What I meant by lag is that sometimes the option boxes in RS don't show up because of lag. This method makes sure that it actually CLICKS the right option before continuing.

Also for the symbol accuracy, I noticed that you merely changed the accuracy from .9 (which is a VERY high accuracy rate) to .8 ( which is still pretty high). I suggest that you lower the accuracy to maybe .5. If that doesn't work I think you should use this function before you use your first symbol function….

LoadSymbolBitmapColor(Name: String): Integer;
//Or
GetSymbolColor(var  rx, ry: Integer; Name: string): Integer;
 

Then, since they returns as an integer, use these in a FindColor procedure then MouseFlag the area where it finds the bitmapcolor.

A bit complex, yes, but I'm positive either one will work well.

~Rep me if I helped.

In the SRLPlayerForm i know that it draws from the Declare players, but for me i find it easier to just input your information when the form comes up then to have someone right in all their information in the script.
I know how to add variables into the Form like bartype, i just got confused in your wording.
For the repeat loop i know what break does, but what i was saying that the mouse in the loop destroys the point of the failsafe. Because if for some reason and it lagged, you wouldn't be able to choose the option ('x') and right click it again, which i think would cause more lag.

I also fixed the FindSymbol problem by use FindSymbols and making a T2DPointArray and seperate the bar symbol from the bank symbol.

Well ChooseOption actually checks to find the text to click A LOT of times before resulting true so I doubt that event would occur. The only possible way it couldn't really work if the option box didn't pop up in the first place (the right-click didn't work). I don't think that a loop like that would cause much lag, it would only cause lag if its repeating it A LOT of times. If you want you can just put a "Inc©" or something and then replace "until(false)" to until(c=5) or something like that.

Glad your symbol finding worked though.

good job on the first script. heres what happened to me. i had iron and coal in the first and second bank slots, respectively. I had a hammer in my first inventory slot. ran the script, logged in, went into the bank (had to delete my PIN number because there is no where to enter it in the form), the script then put the hammer into the bank and withdrew the 9 iron and 18 coal. exited bank booth then never did anything else. scar left a message:

** Warning in GameTab: 4 does not exist**

i think it would work bettter with a little more work. and can you tell us where to put the hammer? i don't think you mentioned it. good luck.

From: neo247
good job on the first script. heres what happened to me. i had iron and coal in the first and second bank slots, respectively. I had a hammer in my first inventory slot. ran the script, logged in, went into the bank (had to delete my PIN number because there is no where to enter it in the form), the script then put the hammer into the bank and withdrew the 9 iron and 18 coal. exited bank booth then never did anything else. scar left a message:

** Warning in GameTab: 4 does not exist**

i think it would work bettter with a little more work. and can you tell us where to put the hammer? i don't think you mentioned it. good luck.

That's a bold and cavalier message to post as a first time poster my friend, maybe you should be a bit humber…:rolleyes:

lmao!! im sorry. i haven't played runescape in forever and im just gettin back into it. disregard everything i just said. ill give your script another go =p

edit: ok i tried it again. everything starts off fine. it walks half way to the furnace. then turns the screen so that east is facing up, then it wont go any further.

Awesomeness