SRL Archive - First Scripts

Hey, hows it going? This is my frechly new very first script. I am looking for some awesome constructive critisism. Please read all instructions and set up lines 19-36. This supports as many players as you would like.

Instructions in the script, but heres some anyways.

Place your MEMBERS runescape account(s) in any area in RS.
Make sure to have nature runes and a fire staff (or fire runes)
Fill out how many loads to do per player. Make sure you have enough
nature runes!
PLACE THE ITEM YOU WANT TO ALCH INV SLOT NUMBER 20!!!
Drag the crosshair over the runescape window and hit play.
Make sure to give me lot's of feedback, this is my very first script!}

Vers 1.3!!
I made some huge updates with the unnbanable stuff

It repeats until false not goood

Ok thanks Whackey, How would I change thtat so I can have a better player swich?

Why did you make 2 threads? http://www.srl-forums.com/forum/showthread.php?t=34135

[QUOTE=i pro leechin';417265]Should be at least 3-3 randomness IMHO.
[/QUOTE]

What's wrong with 1-1 randomness? I use it all the time and my scripts have never gotten me banned…

For this procedure

procedure MagicBook;
begin
Mouse(740, 186,1,1,true);
wait(1000);
end;

I think you're trying to switch the GameTabs right? You could just use the "gametab" function. I saw you use it in your script in there somewhere. Or were you even trying to change the gametabs with this procedure?

 Gametab({TabNumber}) //Where I put "TabNumber" put the gametab you want to switch to. For example 4 is the Inventory.

For this..

if Players[CurrentPlayer].Banked mod Loads = 0 then
begin
nextplayer(false);
end;

You only need to do this.

if Players[CurrentPlayer].Banked mod Loads = 0 then
  Nexplayer(false);

Needa put a wait time between this.

Mouse(578, 186,1,1,true);
   Mouse(576, 402,1,1,false);

Like this…

Mouse(578, 186,1,1,true);
  Wait(1000+random(200));
   Mouse(576, 402,1,1,false);

Probably just a careless error or something.

Needa work on standards too. For Example change this function…

procedure highalch;
begin
repeat;
cast(spell);
Mouse(574, 362,1,1,true);
wait(3800);
Inc(Players[CurrentPlayer].Banked);
if Players[CurrentPlayer].Banked mod Loads = 0 then
begin
nextplayer(false);
end;

To….

procedure highalch;
begin
  repeat
    cast(spell); 
    Mouse(574, 362,1,1,true);
    wait(3800);
    Inc(Players[CurrentPlayer].Banked);
    if Players[CurrentPlayer].Banked mod Loads = 0 then
    begin
      nextplayer(false);
    end;
   //Rest of script.

Also I liked how you used "Inc" instead of just adding the variable by 1. It kinda shows that you know your SCAR Core functions, IMO. Evidently, it also is faster than defining the variable by 1.

Neway just a few of my comments. You should probably apply some color finding to your procedures. I recommend that you use the Help guide in SCAR (Press F1) and the SRL Manual (Under Help=>SRL Manual) to get some more handy functions to add to your arsenel :p. Have fun scripting man.:f:

From: freakymonkey
What's wrong with 1-1 randomness? I use it all the time and my scripts have never gotten me banned…

i'll tell you what's wrong with 1, 1 randomness.

Mouse / MMouse use Random(x) for the randomness, and Random(1) is always 0.

~RM

some asshole took my account… Please give it back

This Is Griff721 Here!!!
Why Can I Not Access My Account??