SRL Archive - Archive

<!– BEGIN TEMPLATE: formanswers –>
waddo - SRL Member Application Form
waddo

What is the meaning to life?


Where you Referred to SRL? If yes, by whom?
no


Programming Knowledge
Pascal, Scar and small amounts of Html and Java

Other Communitys
Sythe, Runespot and a Bebo

How Long have You Played Runescape
14 months

Are you affilated in anyway with Jagex LTD?
No
—————————————————–
Please write down a paragraph about Yourself.

I have been on Srl forums now for almost 2 months.
Many of you will have had some form of interaction with me,
I'm a fast learner and will continue to improve, but I am a bit to ambitious and sometimes attempt things that are way above my level.
I'm an active contibutor and have created a few scripts,
the last time I applyed it was with this same script, but since my application I have improved it greatly and have vastly improved my knowledge.

This does not contain everything i can do i can also

Use Bmp's , DTM's , Forms and a few other stuff, which alot of you may have already seen.

——————————————————
Please Post a Sample of your Work. Only SCAR Scripts Accepted

{.Script Info:
# ScriptName   = Waddos Varrock East Miner
# Author       = Waddo
# Version      = 4.05
# Comments     = Mines and banks or drops Iron or Copper.
# Features     = Working Pickaxe replacer.
# Known bugs   = Sometimes gets lost at bank, Sometimes walks past mine
# Instructions = Setup chars in mine or varrock east bank with
                 a pick equiped or in inventory, set up spare picks in
                 bank the best pick (that you want to use) first.
                 Run Script and fill out Srl Player Form.

# Credits
          NaumanAkhlaQ
          Hermpie
          Nielsie95
          Mixster
          Jukka
          N3ss3s
          Lots of other people to
/Script Info}


program automin3r;
{.include SRL/SRL/Misc/Smart.scar}
{.include srl/srl.scar}
{.include SRL/SRL/skill/mining.scar}
{.include srl/srl/misc/users.scar}

var
  tinvents, troc, activen:integer;
  invents,brokepick,pick,paws:integer;
  roc, i, abt, atm:integer;
  x, y, ran, vroadcolor, orec:integer;
  oredtm, crdtmtol, crdtmarea, Pw1DtmArea:integer;//dtm's

const
//ore colours
  copper=3692667;
  iron=2832990;
  
procedure mainloop; forward;
procedure tobank; forward;
procedure tomine; forward;

procedure DeclarePlayers;
begin
  SRLPlayerForm(True, ['bank','multiplayer'], ['Loads', 'Time Between Clicks','minutes to sleep'], ['Ore Type', 'srl ID', 'srl pass'], []);
end;

procedure srlstuff;
begin
  ReportVars[0] := ReportVars[0]+ CountItemsDtm('inv', oredtm);;
  ReportVars[1] := reportvars[1]+ 1;
  srlrandomsreport;
end;

function Setpw1DDTM: Integer;
var
  dtmMainPoint: TDTMPointDef;
  dtmSubPoints: Array [0..3] of TDTMPointDef;
  TempTDTM: TDTM;
begin
  Pw1DtmArea:=1;
  begin
    dtmMainPoint.x := 861;
    dtmMainPoint.y := 255;
    dtmMainPoint.AreaSize := 1;
    dtmMainPoint.AreaShape := 0;
    dtmMainPoint.Color := vroadcolor;
    dtmMainPoint.Tolerance := 0;

    dtmSubPoints[0].x := 861;
    dtmSubPoints[0].y := 255;
    dtmSubPoints[0].AreaSize := Pw1DtmArea;
    dtmSubPoints[0].AreaShape := 0;
    dtmSubPoints[0].Color := vroadcolor;
    dtmSubPoints[0].Tolerance := 0;

    dtmSubPoints[1].x := 871;
    dtmSubPoints[1].y := 242;
    dtmSubPoints[1].AreaSize := Pw1DtmArea;
    dtmSubPoints[1].AreaShape := 0;
    dtmSubPoints[1].Color := vroadcolor;
    dtmSubPoints[1].Tolerance := 0;

    dtmSubPoints[2].x := 869;
    dtmSubPoints[2].y := 267;
    dtmSubPoints[2].AreaSize := Pw1DtmArea;
    dtmSubPoints[2].AreaShape := 0;
    dtmSubPoints[2].Color := vroadcolor;
    dtmSubPoints[2].Tolerance := 0;

    dtmSubPoints[3].x := 883;
    dtmSubPoints[3].y := 280;
    dtmSubPoints[3].AreaSize := Pw1DtmArea;
    dtmSubPoints[3].AreaShape := 0;
    dtmSubPoints[3].Color := vroadcolor;
    dtmSubPoints[3].Tolerance := 0;

    TempTDTM.MainPoint := dtmMainPoint;
    TempTDTM.SubPoints := dtmSubPoints;
    Result := AddDTM(TempTDTM);
  end;
end;

function SetcrDDTM: Integer;
var
  dtmMainPoint: TDTMPointDef;
  dtmSubPoints: Array [0..4] of TDTMPointDef;
  TempTDTM: TDTM;
begin
  CrDtmArea:=1;
  CrDtmTol:=30;
  
  dtmMainPoint.x := 932;
  dtmMainPoint.y := 163;
  dtmMainPoint.AreaSize := 1;
  dtmMainPoint.AreaShape := 0;
  dtmMainPoint.Color := vroadcolor;
  dtmMainPoint.Tolerance := 0;

  dtmSubPoints[0].x := 932;
  dtmSubPoints[0].y := 163;
  dtmSubPoints[0].AreaSize := CrDtmArea;
  dtmSubPoints[0].AreaShape := 0;
  dtmSubPoints[0].Color := vroadcolor;
  dtmSubPoints[0].Tolerance := 0;

  dtmSubPoints[1].x := 947;
  dtmSubPoints[1].y := 169;
  dtmSubPoints[1].AreaSize := CrDtmArea;
  dtmSubPoints[1].AreaShape := 0;
  dtmSubPoints[1].Color := 6390414;
  dtmSubPoints[1].Tolerance := CrDtmTol;

  dtmSubPoints[2].x := 938;
  dtmSubPoints[2].y := 183;
  dtmSubPoints[2].AreaSize := CrDtmArea;
  dtmSubPoints[2].AreaShape := 0;
  dtmSubPoints[2].Color := vroadcolor;
  dtmSubPoints[2].Tolerance := 0;

  dtmSubPoints[3].x := 916;
  dtmSubPoints[3].y := 165;
  dtmSubPoints[3].AreaSize := CrDtmArea;
  dtmSubPoints[3].AreaShape := 0;
  dtmSubPoints[3].Color := vroadcolor;
  dtmSubPoints[3].Tolerance := 0;

  dtmSubPoints[4].x := 937;
  dtmSubPoints[4].y := 148;
  dtmSubPoints[4].AreaSize := CrDtmArea;
  dtmSubPoints[4].AreaShape := 0;
  dtmSubPoints[4].Color := vroadcolor;
  dtmSubPoints[4].Tolerance := 0;

  TempTDTM.MainPoint := dtmMainPoint;
  TempTDTM.SubPoints := dtmSubPoints;
  Result := AddDTM(TempTDTM);
end;

procedure loaddtms;
begin
  oredtm := DTMFromString('78DA63CC636260D065644006F7EACC19FE036' +
       '990E87F20602C01AA5142550391859140BA02A8C698809A78A01A' +
       '53026AE2806AB408A8C904AAB1C2AF06009ACB0A4D');
       
  brokepick := DTMFromString('78DA630C60646078C680020C95D8187480C24' +
       '0C4F01F08188381ACC70C6880118904D23140D64B026AE280AC57' +
       '04D4440059AF09A8F103B2DE1150E30664FD25A0C607C87A41408' +
       'D2B90F504BF1A00E7310FBE');
       
  pick := DTMFromString('78DA635464646078C980022CD4D8197480C24' +
       '0C4F01F08181580ACA70C6880118904D2EA40D62B026A7481AC8F' +
       '04D4C801595F08A81103398E11BF1A2920EB3301732481ACD704D' +
       '4480059CFF1AB0100450F0D2A');
end;

procedure getorecolour;
begin
  case lowercase(Players[CurrentPlayer].Strings[0]) of
    'copper'  : orec:= copper;

    'iron'    : orec:= iron;
    end;
end;

procedure report;
begin
  cleardebug;
  writeln ('script has worked for ' + timerunning);
  writeln ('you have mined '+inttostr(roc)+' ores');
  if (Players[CurrentPlayer].booleans[0])then
  begin
    writeln ('you have banked ' +inttostr(invents)+ ' loads');
  end else
  writeln ('you have dropped ' +inttostr(invents)+ ' loads');
end;

procedure freport;
begin
  cleardebug;
  writeln ('script has worked for ' + timerunning);
  writeln ('you have mined '+inttostr(troc)+' ores');
  if (Players[CurrentPlayer].booleans[0])then
  begin
    writeln ('you have banked ' +inttostr(tinvents)+ ' loads');
  end else
  writeln ('you have dropped ' +inttostr(tinvents)+ ' loads');
end;

function ispickbroke:boolean;
begin
  gametab(4);
  if finddtm(brokepick,x,y,MIX1,MIY1,MIX2,MIY2) then
  begin
    result:=true;
  end else
  gametab(5);
  if finddtm(brokepick,x,y,MIX1,MIY1,MIX2,MIY2) then
    result:=true;
end;

procedure replacepick;
var
  attempts:integer;
begin
  tobank;
  begin                                                                                                                                       //
    repeat
      if FindBank('veb') then
      begin
        wait(1000+random(100));
        srlstuff;
        Deposit(3, 28, true);
        closebank;
      end;
      attempts:=attempts+1;
    until ((CountItemsDtm('inv', oredtm)=0)or(attempts>=5))
    if attempts<5 then
      exit;
    if (not(invfull)) then
    begin
      gametab(5);
      if finddtm(brokepick,x,y,MIX1,MIY1,MIX2,MIY2) then
        mouse(x,y,2,2,true);
    end;
    if FindBank('veb') then
    begin
      wait(1000+random(100));
      Deposit(1, 28, true);
      if finddtm(pick,x,y,MSX1,MSY1,MSX2,MSY2) then
      begin
        mmouse(x, y, 3, 3);
        wait(1000+random(500));
        if isuptext('ick') then
        begin
          getmousepos(x, y);
          mouse(x, y, 0, 0, false);
          if ChooseOption('1') then
          closebank;
        end;
      end;
    end;
  end;
  tomine;
end;

Function findrock (var TempX, TempY:Integer):Boolean;
Var
  TempTpa: TpointArray;
  Temp: T2DPointArray;
  H, CTS, I:Integer;
Begin
  If Not LoggedIn Then Exit;
  CTS := GetColorToleranceSpeed;
  ColorToleranceSpeed(2);
  FindColorsSpiralTolerance(TempX, TempY, TempTPA, orec,MSX1, MSY1, MSX2-100, MSY2-100, 10);
  Temp:= TPAtoATPAEx(TempTPA, 25, 25);
  SortATPASize(Temp, True);
  H:=High(Temp);
  For I := 0 To H Do
  Begin
    MiddleTPAEx(Temp[i], TempX, TempY);
    MMouse(TempX, TempY, 3, 3);
    wait(50);
    Result:=IsUpText('ine');
    If Result Then Break;
  End;
  ColorToleranceSpeed(CTS);
End;

procedure playerinfo;
begin
  if not loggedin then exit;
  invents:=0;
  getorecolour;
  paws:=(players[currentplayer].Integers[1]*1000);
  roc:=roc+CountItemsDtm('inv', oredtm);
  troc:=roc;
  vroadcolor:=findvarrockroadcolor;
end;

procedure nextp;
var
  activep:integer;
begin
  nextPlayer(false);
  for activep:= 0 to howmanyplayers-1 do
    if players[activep].active then
    begin
      activen:=activen-1;
    end;
  if activen<=0 then
  begin
    freport;
    terminatescript;
  end;
  playerinfo;
  report;
  mainloop;
end;

procedure lost;
begin
  if findsymbol(x,y,'training dummy') then
  begin
    mouse(x,y+50,3,3,true);
    wait(1000);
    fflag(0);
    makecompass('5');
    tomine;
  end;
  if findsymbol(x,y,'clothes shop') then
  begin
    mouse(x+40,y,3,3,true);
    wait(1000);
    fflag(0);
    mouse(655, 150,6,6,true);
    wait(1000+random(100));
    fflag(1);
    if dtmrotated(setpw1ddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
    begin
      atm:=0;
      mouse(x, y, 3, 3, true);
      wait(100);
      fflag(0);
    end else
    repeat
      radialwalk(vroadcolor, 180, 200, 30, 2, 2);
      wait(1000+random(100));
      fflag(0);
      Pw1DtmArea:=Pw1DtmArea+1;
      if dtmrotated(setpw1ddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
      begin
        atm:=0;
        mouse(x, y, 3, 3, true);
        wait(1000+random(100));
        fflag(0);
        exit;
      end;
      atm:=atm+1;
    until atm>=10;
    atm:=0;
    if findsymbol(x, y, 'mining spot') then
    begin
      mouse(x, y-15, 2, 2, true);
      writeln('we got lost but we are ok now =]');
      exit;
    end else
    begin
      writeln('we facked up nextplayer');
      nextp;
    end;
  end;
end;

procedure setup;
begin
  declareplayers;
  smartSetup('mn3', False, True);
  While Not (SmartReady) Do
  Wait(100);
  SetTargetDC(SmartGetDC);
  If Not (LoggedIn) Then
  While Not (SmartGetColor(386, 249) = 65535) Do
  Wait(100);
  setupsrl;
  SetupMining;
  loaddtms;
  activen:=howmanyplayers-1
  writeln(inttostr(activen));
end;

procedure startup;
begin
  if (not(loggedin))then
  begin
    loginplayer;
  end;
  cleardebug;
  wait(10)
  writeln('varrock miner created by waddo')
  ActivateClient;
  makecompass('N');
  roc:=0;
  report;
end;

Procedure FindFightEx;
Begin
 If(FindFight) then
   Begin
     Writeln('Our player is being attacked!')
     Writeln('Lets run away!')
   Begin
     WriteLn('Running....')
     RunAway('E', False, 1, 8000+Random(3000))
     WriteLn('Successfully ran away from fight!')
   end;
 end;
end;

Procedure AntiRandoms;
var
  i : Integer;
Begin
if (not(loggedin)) then exit;
 for i := 0 to 2 do
 begin
   FindNormalRandoms;
   FindFightEx;
   wait(1);
 end;
end;

procedure mine2;
var
  mark:integer;
begin
  if not findrock(450, 350) then
  begin
    if findsymbol(x, y, 'mining spot') then
    mouse(x, y-5-random(5), 2, 2, true);
  end else
  begin
    mmouse(x, y, 3, 3);
    if gascheck(x,y) then mine2;
    if isuptext('ine') then
    begin
      getmousepos(x, y);
      mouse(x, y, 0, 0, false);
      if ChooseOption('ine') then
      begin
        fflag(0);
        marktime(mark);
        repeat
          antirandoms;
          wait(100);
        until ((FindBlackChatMessage('to mine some') or (TimeFromMark(mark) >= paws+random(2000))));
        if FindBlackChatMessage('to mine some') then
        begin
          roc:=roc+1;
          troc:=troc+1;
        end;
      end;
    end;
  end;
end;

procedure runwait;
begin
  RunTo('E', false);
  Wait(10000 + random(2840));
  RunTo('W', false);
end;

procedure drop;
begin
  srlstuff;
  gametab(4);
  for i := 3 to 28 do
  begin
    DropItem(i);
    wait(100+random(10))
  end;
  ran:= Random(3);
  case ran of
    0:typesend('iron dropped here');

    1:typesend('droping iron here');

    2:typesend('droped ore');
  end;
  invents:=invents+1
  tinvents:=tinvents+1
end;

procedure usebank;
var
  attempts:integer;
begin
  repeat
    if FindBank('veb') then
    begin
      wait(1000+random(100));
      srlstuff;
      Deposit(3, 28, true);
      closebank;
    end;
    attempts:=attempts+1;
  until ((CountItemsDtm('inv', oredtm)=0)or(attempts>=5))
  if attempts<5 then
  begin
    invents:=invents+1;
    tinvents:=tinvents+1;
    report;
  end;
  attempts:=0;
end;

procedure tobank2;
begin
  if (not(radialwalk(vroadcolor, 260, 280, 72, 2, 2))) then
    mouse(564, 86, 7,7, true);
  wait(2000);
  fflag(0);
  if (not(radialwalk(vroadcolor, 265, 275, 50, 2, 2))) then
    radialwalk(vroadcolor, 260, 280, 50, 2, 2);
  wait(1000+random(100));
  fflag(0);
  if findsymbol(x, y, 'bank') then
  begin
    mouse(x, y, 2, 2, true);
    wait(2000);
    fflag(0);
  end else
  if findsymbol(x,y,'training dummy') then
  begin
    mouse(x,y+50,3,3,true);
    wait(1000);
    fflag(0);
  end;
end;                                                                                                                                             //
procedure tobank;
begin
    if dtmrotated(setpw1ddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
    begin
      mouse(x, y-55, 3, 3, true);
      wait(1000+random(100));
      fflag(0);
    end else
    repeat
      Pw1DtmArea:=Pw1DtmArea+1;
      if dtmrotated(setpw1ddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
      begin
        atm:=0;
        mouse(x, y-55, 3, 3, true);
        wait(1000+random(100));
        fflag(0);
        exit;
      end;
      atm:=atm+1;
    until atm=10;
    atm:=0;
    if(not(radialwalk(vroadcolor, 355, 370, 72, 2, 2)))then
      mouse(626, 13,10,10,true);
    wait(1000);
    fflag(0);
    if(not(radialwalk(vroadcolor, 355, 400, 72, 2, 2)))then
      radialwalk(vroadcolor, 350, 410, 72, 2, 2);
    wait(1000+random(100));
    fflag(0);
    if(not(radialwalk(vroadcolor, 350, 390, 72, 2, 2)))then
      radialwalk(vroadcolor, 330, 400, 72, 2, 2);
    wait(1000+random(100));
    fflag(0);
    if dtmrotated(setcrddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
    begin
      mouse(x, y, 3, 3, true);
      wait(1000+random(100));
      fflag(0);
      atm:=0;
    end else
    repeat
      radialwalk(vroadcolor,280,410,40,5,5);
      wait(1000+random(100));
      fflag(0);
      crDtmArea:=crDtmArea+1;
      crDtmtol:=crDtmtol+5;
      if dtmrotated(setcrddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
      begin
        atm:=0;
        mouse(x, y, 3, 3, true);
        wait(1000+random(100));
        fflag(0);
        exit;
      end;
      atm:=atm+1;
      wait(100);
    until atm>=15;
    atm:=0;
    tobank2;
end;

procedure tomine;
var
x, y:integer;
begin
    if (not(radialwalk(vroadcolor, 60, 110, 72, 2, 2))) then
    begin
      mouse(692, 64, 3, 3, true);
    end;
    wait(5000);
    fflag(1);
    if dtmrotated(setcrddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
    begin
      wait(2000);
      mouse(x, y, 3, 3, true);
      wait(2000+random(100));
      fflag(0);
      atm:=0;
    end else
    repeat
      radialwalk(vroadcolor, 80, 100, 30, 2, 2);
      wait(100);
      fflag(1);
      crDtmArea:=crDtmArea+1;
      crDtmtol:=crDtmtol+3;
      if dtmrotated(setcrddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
      begin                                                                                                                                                                      //
        atm:=0;
        mouse(x, y, 3, 3, true);
        wait(2000+random(100));
        fflag(0);
        exit;
      end;
      atm:=atm+1;
    until atm=10;
    atm:=0;
    lost;
    if (not(radialwalk(vroadcolor, 140, 210, 70, 2, 2)))then
    radialwalk(vroadcolor, 130, 220, 70, 2, 2);
    wait(1000);
    fflag(1);
    if (not(radialwalk(vroadcolor, 155, 192, 70, 2, 2))) then
      radialwalk(vroadcolor, 150, 200, 70, 2, 2);
    wait(1000);
    fflag(1);
    if (not(radialwalk(vroadcolor, 170, 192, 60, 2, 2))) then
    begin
      mouse(686, 384,5,5,true);
    end;
    wait(600+random(100));
    fflag(0);
    radialwalk(vroadcolor, 170, 192, 60, 2, 2);
    wait(1000);
    fflag(0);
    if dtmrotated(setpw1ddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
    begin
      atm:=0;
      mouse(x, y, 3, 3, true);
      wait(100);
      fflag(0);
    end else
    repeat
      radialwalk(vroadcolor, 170, 210, 20, 2, 2);
      wait(100);
      fflag(0);
      Pw1DtmArea:=Pw1DtmArea+1;
      if dtmrotated(setpw1ddtm, x, y, mmx1, mmy1, mmx2, mmy2) then
      begin
        atm:=0;
        mouse(x, y, 3, 3, true);
        wait(1000+random(100));
        fflag(0);
        exit;
      end;
      atm:=atm+1;
    until atm>=10;
    atm:=0;
    if findsymbol(x, y, 'mining spot') then
    begin
      mouse(x, y-15, 2, 2, true);
      wait(1000+random(100));
      fflag(0);
      writeln('ores banked back at mining spot');
    end else
    writeln('we facked up on the way to mining spot');
end;

procedure droporbank;
begin
if invfull then
  if Players[currentplayer].Booleans[0] then
  Begin
    tobank;
    usebank;
    tomine;
  end else
  drop;
end;

procedure antiban;
var
noban: Integer;
Begin
  If Not (LoggedIn) Then Exit;
  noban := Random(25);
  Case noban Of
    0, 9, 17, 23: PickUpMouse;
    1, 13, 16: RandomRclick;
    2, 10, 18, 22, 24: randomMovement;
    4, 12, 19: AlmostLogout;
    5, 11, 8:  ChooseOption('cancel');
    6, 15, 21: MMouse(Random(MSX2), Random(MSY2), 0, 0);
    7, 14, 3: HoverSkill('woodcutting', false);
  end;
  abt:=0;
end;

procedure checks;//checks you are not under attack and performs antibans
var
a:integer;
begin
  if not loggedin then exit;
  wait(100);
  for a:=0 to 10 do
    case a of
      1:lost;

      2:findfightex;

      3:antirandoms;

      4:if abt>=8 then antiban;
      
      5:if abt=4+random(2) then if (ispickbroke) then replacepick;
      
      6:findpick;
      
      7:makecompass('N');

      8:setangle(true);
      
      9:mousespeed:=7+random(8);
      
      10:droporbank;
    end;
    abt:=abt+1;
end;

procedure srlstats;
begin
  ScriptID := '800';
      if ((players[currentplayer].strings[1] = '')or (players[currentplayer].strings[1] = ''))then
    begin
      writeln('DONT leech!');
      writeln('go to [url]http://stats.srl-forums.com[/url] and create an account');
    end else
    begin
      SRLID := players[currentplayer].strings[1];
      SRLPassword := players[currentplayer].strings[2];
    end;
end;

procedure mainloop;
begin
  playerinfo;
  Repeat
    if not loggedin then loginplayer;
    If (Not (LoggedIn)) then
    Begin
      writeln('Not logged in, next player!');
      NextP;
      mainloop;
    end;
    if (invents = Players[CurrentPlayer].Integers[0]) then
    if (players[currentplayer].Booleans[1]=false) then
    begin
    sleep((players[currentplayer].integers[2]*60000)+random(120000));
    end;
    if (players[currentplayer].Booleans[1]=true) then
    begin
      invents:=0;
      nextplayer(true);
      report;
      mainloop;
    end;
    checks;
    mine2;
    report;
  Until(Not LoggedIn);
end;
      
begin
  setup;
  startup;
  srlstats;
  mainloop;
  freport;
  freedtm(oredtm);
  freedtm(brokepick);
  freedtm(pick);
end.

——————————————————
<!– END TEMPLATE: formanswers –>

Yes.

You seem to understand the basics.

No. Why? Spam. I won't give you a yes until I see you consistently acting mature.

The script looks pretty sound, though. One recommendation. Take the FreeDTMs and progress report at the end and put them into a procedure called ScriptTerminate. SCAR automatically calls this procedure when a script stops, so even if the user ends the script, you won't end up with memory leaks.

Good luck!

Yes, DDTMs are a big plus too.

no, it's all messy and your logic is far off at many places.

  for activep:= 0 to howmanyplayers do
    if players[activep].active then
    begin
      activen:=activen;
    end;

no begin and end; needed there.
activen := activen …. what is the point of that?! 1:=1 … >.>

if (not(radialwalk(vroadcolor, 140, 210, 70, 2, 2)))then
    radialwalk(vroadcolor, 130, 220, 70, 2, 2);
    wait(1000);
    fflag(1);
    if (not(radialwalk(vroadcolor, 155, 192, 70, 2, 2))) then
      radialwalk(vroadcolor, 150, 200, 70, 2, 2);
    wait(1000);
    fflag(1);
    if (not(radialwalk(vroadcolor, 170, 192, 60, 2, 2))) then
    begin
      mouse(686, 384,5,5,true);
    end;
    wait(600+random(100));
    fflag(0);
    radialwalk(vroadcolor, 170, 192, 60, 2, 2);
    wait(1000);
    fflag(0);

if the 1st, 2nd and 4th radial walks mess up your still gonna be waiting around

    if FindBank('veb') then
    begin
      wait(1000+random(100));
      srlstuff;
      Deposit(3, 28, true);
      closebank;
    end;
    attempts:=attempts+1;
  until ((CountItemsDtm('inv', oredtm)=0)or(attempts>=5))
  if attempts<5 then

it deposits slots 3-28, whichleaves is with slot 1 and 2. ok, slot one is usually pickaxe but slot 2 will usually have an ore.

so CountItemsDTM will mostly always be > 0 and therefore attempts = 5 which means it'll think it was never able to bank a single load.

why did you make a whole procedure just to call SrlPlayerForm? just call it in the mainloop.

  if (not(loggedin))then
  begin
    loginplayer;
  end;

LoginPlayer already checks If Logged in

and try using most Descriptive variables. and spacing things.

also

  invents:=invents+1
  tinvents:=tinvents+1

so everytime you do one more loads with any player you increment invents

if (invents = Players[CurrentPlayer].Integers[0]) then

how on earth would that ever be true then? i didn't really like the script, i'm not voting right now, cus i might be biased.

edit: voted no after confirming what Smartzkid said

~RM

I think it is rather unfair that you vote against me because of the odd spam as the main piont to srl member is scripting ability also achieving Srl member status would make me more respected and i would therefore would have more opertunities to help newer scripters and thus improve my grammar and give me more purpose to put into my posts.

Also i think you are wrong a bout this

From: RM
it deposits slots 3-28, whichleaves is with slot 1 and 2. ok, slot one is usually pickaxe but slot 2 will usually have an ore.

so CountItemsDTM will mostly always be > 0 and therefore attempts = 5 which means it'll think it was never able to bank a single load.

deposit 3-28 incase the user has spare pickaxes

count items dtm it is a failsafe to make sure that it has actually banked the ores
I had a problem sometimes where it wouldnt find the bank or where it opened the bank but didnt actually deposit anything its rare but it happened.

From: waddo
I think it is rather unfair that you vote against me because of the odd spam as the main piont to srl member is scripting ability also achieving Srl member status would make me more respected and i would therefore would have more opertunities to help newer scripters and thus improve my grammar and give me more purpose to put into my posts.

Not really true. Maturity, helpfulness, useful posting, activeness, all come into account when applying. Sure, the MAIN point may be to script, but that's only the half of it (In fact, some people who have little/none scripting ability have a chance to make it in). And why would you wait until you're an SRL member to use better grammar? As some applying for Members guide mentioned, you must learn BEFORE you become a member (saying you'll use better grammar when you're an SRL Member is almost the same as someone saying they'll learn to script when they become an SRL Member).

I'm holding my vote - Pretty good script, but your posts aren't as good.

Yes i know this and i am learning better grammar but i have dyslxia and ADHD which is the main reason for my grammar (my english teacher had to put my punctuation in my coursework) i do post usefull stuff i do help out and i am active the fact that i cant typewrite/speak properly is something i can not be responsible for it took me about half an hour checking my application post thing for errors and im bet that there still will be loads. i do not expect you to change your vote just to have a more open look upon things that people might not be able to controll.

Also you mention that eithen people who have little/none scripting abiity have a chance to get in.
in the application form it states no script no acceptance to exeption so how is this possible?

From: waddo
Yes i know this and i am learning better grammar but i have dyslxia and ADHD which is the main reason for my grammar (my english teacher had to put my punctuation in my coursework) i do post usefull stuff i do help out and i am active the fact that i cant typewrite/speak properly is something i can not be responsible for it took me about half an hour checking my application post thing for errors and im bet that there still will be loads. i do not expect you to change your vote just to have a more open look upon things that people might not be able to controll.

Ah, ok that explains a bit :)

Also you mention that eithen people who have little/none scripting abiity have a chance to get in.
in the application form it states no script no acceptance to exeption so how is this possible?

In the case of auto-memberization (you get members without an application, note that that's extremely rare, I don't know for sure, but I'm guessing no more than five people have gotten in that way), such as me.

I'm still holding my vote, but leaning on the yes side now.


EDIT: I think I'll vote yes. The script has all of the requirements, and I looked through some of your posts and they don't seem all that bad, tbh a lot of them are helpful.

From: waddo
Yes i know this and i am learning better grammar but i have dyslxia and ADHD which is the main reason for my grammar (my english teacher had to put my punctuation in my coursework) i do post usefull stuff i do help out and i am active the fact that i cant typewrite/speak properly is something i can not be responsible for it took me about half an hour checking my application post thing for errors and im bet that there still will be loads. i do not expect you to change your vote just to have a more open look upon things that people might not be able to controll.

Also you mention that eithen people who have little/none scripting abiity have a chance to get in.
in the application form it states no script no acceptance to exeption so how is this possible?

No offense or anything but wouldn't dyslexia kinda bar you from even properly making a script? Idk, I'm not convinced…(forgive me if I'm wrong). Even still there are a lotta excess work in your procedure like Rasta said…BUT i do suppose you have added a lot of the things required to get into members…idk ..ill hold my vote

From: freakymonkey
No offense or anything but wouldn't dyslexia kinda bar you from even properly making a script? Idk, I'm not convinced…(forgive me if I'm wrong). Even still there are a lotta excess work in your procedure like Rasta said…BUT i do suppose you have added a lot of the things required to get into members…idk ..ill hold my vote

Masterkill and Rikje have dyslexia I believe, and they're ub3r at scripting ;)

oh really? I'm sorry for my stereotype. VERY SORRY.

runescapian, there are different levels of dyslexia.

but wado, saying you'll be more helpful when you become srl member is not necessary. mixster and runescapian got in without a script. they were invited in because they were constantly making good posts.

now let's take a look at one of your posts…

From: wado

[offtopic]hmm lets think posting offtopic stuff and labeling it offtopic is far less hated and noobish than :fiery: flaming :fiery: oh yer and whats yopur post got to do with the original thread topic yer so not just are you :fiery: flaming :fiery: your also posting unlabeled offtopic stuff [/offtopic]

also you didn't understand what i said about the script

There will ALWAYS be an ore on spot 2, SO DTMCount will always be > 0
Since DTMCount > 0 then Tries >= 5
if Tries >= 5 you DON'T increment Loads.

Which means your script will think it NEVER did a single load.

~RM

Even though he has dislexia (spelling?), He is constantly improving even under pressure. He is also keen to ask me for any help he may have. And I hope he will carry on in the future to be a successful learner.

I Vote Yes!

From: freakymonkey
No offense or anything but wouldn't dyslexia kinda bar you from even properly making a script?

I have dyslexia.

// back on topic

And waddo, I don't know what to vote, your code is kinda messy, but you have some good things to…. hmmmmmmmm…

EDIT:

From: Runescapian
Masterkill and Rikje have dyslexia I believe, and they're ub3r at scripting ;)

wow I didn't saw your post! (now i did) thanks! and yes rikje has dislexia to, and we aren't the worst scripters I guess.

EDIT 2:

I voted no, sorry but some times it looks like you don't know what your doing.

procedure mainloop;
begin
  playerinfo;
  Repeat
    if not loggedin then loginplayer;
    If (Not (LoggedIn)) then
    Begin
      writeln('Not logged in, next player!');
      NextP;
      mainloop;
    end;
    if (invents = Players[CurrentPlayer].Integers[0]) then
    if (players[currentplayer].Booleans[1]=false) then
    begin
    sleep((players[currentplayer].integers[2]*60000)+random(120000));
    end;
    if (players[currentplayer].Booleans[1]=true) then
    begin
      invents:=0;
      nextplayer(true);
      report;
      mainloop;
    end;
    checks;
    mine2;
    report;
  Until(Not LoggedIn); // This can make your script stop way before it should stop
end;

RM you are still wrong i use deposit(3,28,true); the tru means that if there is an item between the slot 3 and 28 it will right click and choos store all wich will automattically store the one in the second slot.

(I am recognised by the examination boards for my level of dyslexia in my exams i get a laptop or a scribe (i choose which) or i get to write it my self and have some one copy it out, i also get 25% extra time, a seperate room from everyone else, and i get rest breaks through my exam at request)

and i had a feeling there might be a good few dyslexic scripters dyslexic people seem good at scripting

me your list of people my techer one of my mates =]

the commens i get here will helpimprove my scripting however not getting accepted will mean that it will be another month till i can try again
and as many of you have said im a compentant scripter and getting anle to see the members sripts will improve me eithen more (this is not to say ill get good enough if you acept me as you have already said im good enough but i will learn new teqniques)

please take this into consideration

another thing that could help was if the spell check was working

Edit: Master Kill what do you suggest I do to end my script instead of until not loggedin
this is the kind of thing that having acces to the members scripts will help me with
these will give me ideas on how i can do things independenly.

Edit2: also RM invents:=invents+1 tinvents:=tinvents+1, invents is invents done by that char tinvents is the total invents done by all the chars.

Edit3: just for you RM lets take a look at some of my other threads


Random Event PrintScreens

I am currently taking driving lessons and will soon be taking my theory.

I have noticed from the DVLA mock test CD that to answer the questions correctly just follow these principals.

1. If the question is about actual driving then chose the answer that will mean your actions will not make other drivers slow down or change direction.

2. If it is about speed braking or other aspects like that then choose answers that are good for the enviroment and will not damage your car.


Will add more soon.

Notice improvement in grammar.

All of my threads. (I also like posting in the scripting help section if you want to veiw my posts aswell).

yes there maybe the odd spam but i label offtopic and the part you quoted was because I was aggravated as he had had a go at me for posting in random threads (my thread). I also thought it was aloud as long as it was labeled off topic. Also when i first joined i thought Double posting ment posting the same thing twice i did not relise it was just simply posting twice.

wado; i don't care about dyslexia. my girlfriend has lvl4 dyslexia. my vote has nothing to do with your grammar.

edit:
but i do own you an apology. both about the banking and the invents thing you are right.

And now, completely offtopic, i'm really glad you found a school which gives you extra time and access to a computer during exams. my gf had a real trouble finding one.

Master Kill what do you suggest I do to end my script instead of until not loggedin
this is the kind of thing that having acces to the members scripts will help me with
these will give me ideas on how i can do things independenly.

make a procedure that counts how many active players there are.

and then do
until(HowManyActive <= 0)


~RM

i know most of my last post was to show that i do contribute with usefull posts

and also that oneof you pionts was wrong

RM you are still wrong i use deposit(3,28,true); the tru means that if there is an item between the slot 3 and 28 it will right click and choos store all wich will automattically store the one in the second slot.

From: Rasta Magician

edit:
but i do own you an apology. both about the banking and the invents thing you are right.

~RM

yes i know. and i've said it before.

~RM

and Rasta i already have a procedure that count how many players are active

procedure nextp;
var
  activep:integer;
begin
  nextPlayer(false);
  for activep:= 0 to howmanyplayers-1 do
    if players[activep].active then
    begin
      activen:=activen-1;
    end;
  if activen<=0 then
  begin
    freport;
    terminatescript;
  end;
  playerinfo;
  report;
  mainloop;
end;

i posted before you posted your edit and appology accepted =]

Nope.

From: Ashur2Good
Nope.

if you read the rules of app voting you must clearly state why you voted no.

From: waddo
and Rasta i already have a procedure that count how many players are active

procedure nextp;
var
  activep:integer;
begin
  nextPlayer(false);
  for activep:= 0 to howmanyplayers-1 do
    if players[activep].active then
    begin
      activen:=activen-1;
    end;
  if activen<=0 then
  begin
    freport;
    terminatescript;
  end;
  playerinfo;
  report;
  mainloop;
end;

i posted before you posted your edit and appology accepted =]

Do you know what functions are?! If yes than use them! This would be a propper player count Function:

Function NumberOfActive(WriteLin: boolean): Integer; // By MasterKill
var
  R: Integer;
begin
  Result := 0;
  for R := 0 To HowManyPlayers - 1 do
  if (Players[R].active = True) then
  Result := Result + 1;
  If WriteLin Then
  If (Result = 0) Then WriteLn('No More Players Active.')
  Else WriteLn('Still ' + IntToStr(Result) + ' players of the ' + IntToStr(howManyPlayers) + ' players are active.');
end;

procedure mainloop;
begin
  If Not LoggedIn Then Players[CurrentPlayer].Active := False;
  If (NumberOfActive(True) = 0) Then Exit;
  NextPlayer(LoggedIn);

  // your stuffs

end;

oh yer i missread bit slow like that

From: MasterKill
Do you know what functions are?! If yes than use them! This would be a propper player count Function:

Function NumberOfActive(WriteLin: boolean): Integer; // By MasterKill
var
  R: Integer;
begin
  Result := 0;
  for R := 0 To HowManyPlayers - 1 do
  if (Players[R].active = True) then
  Result := Result + 1;
  If WriteLin Then
  If (Result = 0) Then WriteLn('No More Players Active.')
  Else WriteLn('Still ' + IntToStr(Result) + ' players of the ' + IntToStr(howManyPlayers) + ' players are active.');
end;

procedure mainloop;
begin
  If Not LoggedIn Then Players[CurrentPlayer].Active := False;
  If (NumberOfActive(True) = 0) Then Exit;
  NextPlayer(LoggedIn);

  // your stuffs

end;

or just:

function AllPlayersFalse: Boolean;
var
  I : Integer;
begin
  Result := True;
  for I := 0 to HowManyPlayers - 1 do
    if (Players[CurrentPlayer].Active) then
      Result := False;
end;

procedure MainLoop;
begin
  repeat
    //Stuff
  until(AllPlayersFalse)
end;

About Application: Im not really sure… Im 65% on No and 35% on Yes.. :s

From: nicbaz
if you read the rules of app voting you must clearly state why you voted no.

Ah Nicabz, [ITALIAN ACCENT]waz da matter wit u? [/ITALIAN ACCENT]

Sp0rk-eh, we had good times :spot: Why be a dog and pos tthat? :mad:

i don't have to explain. BUt if you want me to, i will? :S

Wadso or w/e your name is, you fail at scripting.

Sorry pal, that's just how life is.


-Ashur

zytex what could i do to push ur vote into the yes side does this help atall

http://www.villavu.com/forum/showthread.php?t=31131?p=411849#post411849

I checked, this doesn't seem to compile. I like a lot of the logic, but…

Line 442: [Error] (15631:17): Variable Expected in script

o_O
I found and fixed the error, which was on like 270. Changed

Function findrock (var TempX, TempY:Integer):Boolean;

to this.

Function findrock (TempX, TempY:Integer):Boolean;

and past that it compiles.

From: Smartzkid
No. Why? Spam. I won't give you a yes until I see you consistently acting mature.
Good luck!

Since I respect Smartzkid pretty much, and I haven't been around lately I trust him and my vote is based on his post.

Script would be yes.

And becoming member is not based only on scripting skills, activness, attidude, spammage %, and so on…

From: Negaal
Since I respect Smartzkid pretty much, and I haven't been around lately I trust him and my vote is based on his post.

Script would be yes.

And becoming member is not based only on scripting skills, activness, attidude, spammage %, and so on…

Yanni couldn't have become a member no matter how well he could script. That guy just didn't get it.

I think I'm leaning towards a yes, you took care of all the global variables pretty well. I don't think you should wait another month.

From: Ashur2Good
Ah Nicabz, [ITALIAN ACCENT]waz da matter wit u? [/ITALIAN ACCENT]

Sp0rk-eh, we had good times :spot: Why be a dog and pos tthat? :mad:

i don't have to explain. BUt if you want me to, i will? :S

Wadso or w/e your name is, you fail at scripting.

Sorry pal, that's just how life is.


-Ashur

sorry i jest felt like doing a random post…

anyway waddo.. im not sure what to vote yet still thinking…..

I'll give you a yes. Script isn't flawless, but everyone makes mistakes. You have the knowledge of scripting, just a few minor details to iron out.

Hmm thank you for the posotive feedback and also thankyou for the constructive critisism.

@JAckLKrawl first i say oops and secondly ill say hmm it compiles for me
and everyone else strange but oh well.

@Nicbaz i'm not just a one trick pony =]
I have imagination and ingenuity.
http://www.villavu.com/forum/showthread.php?t=31131

has everyone who is going to vote voted ?

From: nicbaz
if you read the rules of app voting you must clearly state why you voted no.

If you'd read properly you would have realised that you don't even have to post that you voted…

No from me.

wado, your script is very messy, and although i have already said this i didn't explain what i meant.

(In my opinion) for a script to be good it has to be possible for any scripter to pick it up, read it, and be able to edit out/in what they need.

That's why we have scripting standards. And so you know, those standards include giving descriptive names to variables and procedures.
I think that is also the reason that when you go through various scripts here you will always find some procedures with the same name but probably a bit different.

srlstuff -> SRLReportVars
Setpw1DDTM -> SetupWalkDDTM (i think it's the walking one?)
loaddtms -> LoadDTMs (just standards.. first letter of the word capitalized, DTM is completly capitalized)
getorecolour; -> GetOreColour
var orec:integer -> var OreColour:integer

btw what's the difference between report and freport ?

and so on :)

btw, waddo has shown a lot of maturity and willingness to help (even when i didn't ask for it) through pms.

waddo, my vote is still no, but if you don't get in now, for your next app, once yoou fix up your script, you definitely have my yes vote ;)

~RM

Ty for that. the difference between Reportand FReport is f stands for final and will give the total number of ores mined by all the chars.

50/50 dont look to good. another month of waiting.:(

I guess, Some admins are more stricter than others so it could swing either way ;)

From: Santa_Clause
If you'd read properly you would have realised that you don't even have to post that you voted…

No from me.

I think he meant that if you say "No" in a post with no explanation, it's considered spam.

I think there are only 26 active members?

really well i hope its going to be 27 =].

From: waddo
really well i hope its going to be 27 =].

I don't know, it'd be pretty cool to get accepted with 13/13. 13 is Fawki's lucky number for some weird reason, so maybe maybe =D

No beacuase of post 1 and 2. Keep up the good work though. Helpfull posts mean a ton to me. You've gotten some good ones here. Make some good ones of your own too :)

also, personal rant. Gramer and spelling and dyslexia have absoulttly nothing to do with scvripting ability. Sure, if you are inconsistant you may have some more fun at compile time, but thats nothing but simple fixs.

This is a close call.. The script isnt really the best!, BUT if i had to choose i would make you wait a month. Make the script better come back and get in with 14 - 0.. Becuase if you get in and your not a good scripter you wont have any idea about stuffs.. Trust me, WAIT A MONTH..

but i do know stuff it may not be the best of stuff but i still know enough

if i used my knowledge to improve that script without larning anything knew just using what ive already learned could i make it good eough for a yes

there fre i already know enough and shouldnt have to wait a month all that becoming member will do is improve my scripting

From: waddo
but i do know stuff it may not be the best of stuff but i still know enough

if i used my knowledge to improve that script without larning anything knew just using what ive already learned could i make it good eough for a yes

there fre i already know enough and shouldnt have to wait a month all that becoming member will do is improve my scripting

maybe you know enough, but you don't know how to make good use of it yet. SRL member status is more then having the will to learn more, it also is about being a propper scripter wich can help out other people with there scripts. If you are so sure that it will be a yes soon then why r u acting like this. If you are sure it will be a "yes" or "in." worthly then you'll get in next time isn't it? Just a month. 30 days to prove yourself and show us you got skills and maybe more. Make us look like fools and make a kick ass script.

Good luck.

From: MasterKill
maybe you know enough, but you don't know how to make good use of it yet. SRL member status is more then having the will to learn more, it also is about being a propper scripter wich can help out other people with there scripts. If you are so sure that it will be a yes soon then why r u acting like this. If you are sure it will be a "yes" or "in." worthly then you'll get in next time isn't it? Just a month. 30 days to prove yourself and show us you got skills and maybe more. Make us look like fools and make a kick ass script.

Good luck.

In other words, if you hurry, and Hyper has already voted, make a script and put it into your next post. xD

No.

You show your work, not work other have helped you with.

wtf timer this is my own work yes when i first started i hadhelp but almost if not all parts i had help with are tookout and most that are left i still did myself when i get help i like to be taught how not showed how
then i learnand use raher than copy therefore that is 99%my own work

Once you've fixed up your script with all suggestions to a point where you're confident you can get in, you can PM an admin, and request permission to apply early. I'd recommend you wait at least a week or two, but it's still a lot better than waiting a month.

Yes.

EDIT: The poll will close in about 40 minutes.. I bet you don't get in with 16/17… :|
EDIT2: Try again in a month and try to make some more helpful posts (@ Those who said No because of spam) and you will get in ;)

hmm i thought i had already made a good few helpful posts if you look through them

eg SrlPF tut
Random event Printscreens
general help

On an 8 hour roadtrip, we turned the radio to a Sunday assembly. The minister was talking about how to convince people of Christ. Not word for word, cornering someone who is faithless at a dinner party and arguing with them will only make them a new Christian for the moment.

Why does it matter? Telling a spammer to stop spamming for a week is selling your vote.
Not accusing you, Waddo, there just isn't much sense in a certain few peoples' reasoning.

I think Waddo is a good guy, I've looked through his posts and don't really see much that would make you feel otherwise.

16 yes 17 no's ..
yeah wait till next month.

hopefully you'll make it

thank you jack
yer pinky i know =[ argh well

You may try again in two weeks, good luck.
Closed.