SRL Archive - First Scripts

smelter and banker at Falador


markmccain

2008-05-26 00:25:37

this is my first script so any help would be great. so far it only smelts mith bars. put mith in first bank slot and coal in the second. face north and look strait down. and start with your bank open. this script is still pretty bata other then that have fun and good luck.

fuchu130

2008-05-28 19:46:26

good beta version…though it did get lost after it smelted 40 bars and i ended up in west fally…not sure what happened

iroki_

2008-05-29 09:02:17

Remember!! Never use coordinate clicking!!

xbowman6

2008-05-29 09:26:16

is it smart to use this script or can i use better a other smelt script;)

musicalmacrocosm

2008-05-31 04:18:08

This script works beautifully for me :)

I can do about 300 bars before something happens like a random that messes it up, but other than that if you start in the right spot it won't mess up. Does this have anti-random?

Dead_Photos

2008-06-03 02:51:35

nice script, I used it for a while.

FreakyMonkey

2008-06-03 18:55:17

It's an ok script. There are a couple things that you could do to improve it.

1:
procedure clear;
begin
a:=0;
end;

Is there any need of doing this? You can just define "a" as 0 when you want to revert it back to 0 INSIDE another procedure. You don't have to make another one for that purpose only. The only time you would make a procedure for defining variables as 0 would be if you have MANY variables to revert.

2:
z:=0;

ALL integer values for undefined variables are automatically defined as 0 for its next use. So you didnt need to put z:=0 at all.

3:
Procedure walksmelter;
begin
Mouse(570, 50, 2, 2, True);
wait(4000);//Why did you put a wait function?
fflag(8);
mouse(556,50,2,2,true);
wait(6000);//Why did you put a wait function?
fflag(8);
end;

There was no purpose in putting a wait function for that procedure. What the function FFlag does (in essence) is it waits for the Flag to be in range before continuing onto the next procedure. There would be no point in putting a Wait function in there.

4:
mouse(556,50,2,2,true);

You probably shouldn't use exact coordinates to make a flag present. Why don't you use radialwalk? There are plenty of Tutorials around: 1,2,3.
This script called the Radial Walk Aid- by YakMan can help you Radial Walk Later (I have attached it below.)

5:
fflag(1);

You probably didn't have to do this. Fflag(1) is almost the same as Flag or FFlag(0);

6:

*Gasp* I just looked at the script and it neither has "consts" or a "DeclarePlayer"! Those are so important for random events, antibans, and logins. You should probably add them in…

7:
end else Writeln('Could not open bank');
mouse(195,236,2,2,true)
OpenBankQuiet('feb');
wait(1000);
deposit(1,1,true);

Make sure that every time you use an "end else" followed up with a number of functions over 1 you use a begin and end. Like so….


end else
begin
Writeln('Could not open bank');
mouse(195,236,2,2,true)
OpenBankQuiet('feb');
wait(1000);
deposit(1,1,true);
end;
//continue script;

8:

I can honestly say that you have very poor standards. This is what you did.


procedure clear;
begin
a:=0;
end;
Procedure startbank;
begin
z:=0;
z:=z+1;
Withdraw(1,1,5);
wait(1000)
withdraw(2,1,20);
closebank;
end;
Procedure walksmelter;
begin
Mouse(570, 50, 2, 2, True);
wait(4000);
fflag(8);
mouse(556,50,2,2,true);
wait(6000);
fflag(8);
end;

This is what a perfectly standarded script should look like…


procedure clear;
begin
a:=0;
end;

procedure startbank;

begin
z:=0;
z:=z+1;
Withdraw(1,1,5);
wait(1000)
withdraw(2,1,20);
closebank;
end;

procedure walksmelter;

begin
Mouse(570, 50, 2, 2, True);
wait(4000);
fflag(8);
mouse(556,50,2,2,true);
wait(6000);
fflag(8);
end;
//rest of script with these standards.



Anyway those were some of my comments. However, I do wish to address that you don't have that many backup failsafes to better your script. What happens in case of antirandoms, legit players, and if the character gets stuck. Good luck with your script.

~Rep me if I helped.

sk8boyrider55

2008-06-04 18:19:37

It Dosnt run that long for me it dose like 114 bars and then stops????

AUT

2008-06-04 18:52:20

markmccain has stopped working on this script and has since left this forum. He gave is bata to me and asked me to work on it since then i have spent some time on this script and the new and improved version is at http://www.villavu.com/forum/showthread.php?t=31429?t=34078&highlight=smelter

Run Straight

2008-08-21 21:08:03

looks pretty good downloading it now

mr.peer

2008-08-24 13:01:59

i'll probably use it bit too