Ok, a couple of things i saw here.
First off, why make your own login procedure when SRL does it for you?
procedure DeclarePlayers;
begin
HowManyPlayers := 1 //Number of players
NumberOfPlayers( HowManyPlayers ); // Same an How Many Players
CurrentPlayer:= 0;
Players[0].Name :='';//Name Goes Here
Players[0].Pass :='';//PassWord Goes Here
Players[0].Nick :='';//3-4 LowerCase Letters Of Your Name
Players[0].Active:=True;//True if this acc is gonna be autoing, False if it isn't
End;
Then put this in your main loop to log in :
DeclarePlayers; //Declares the player, to use in the next procedure
LogInPlayer; // Logs in the next avalaible player from "DeclarePlayers"
And if you want to add multiplayer, look at this guide:
http://www.villavu.com/forum/showthread.php?t=12858And with the banking, it's not walking to the bank :confused:
Look at this guide on Radial Walking :
http://www.villavu.com/forum/showthread.php?t=24303And you need to check for Ents, This is a procedure made by Frozon Soul, so credit him or learn from it and make your own ;)
Function EntFinder(RunAway : Boolean) : Boolean;
Begin
if Not(LoggedIn) then Exit;
Counter := 0;
While Counter < 15 do
Begin
i := GetColor(82 + Counter, 17);
Counter := Counter + 2;
if SimilarColors(i, 119764, 20) then
Begin
Fixes := 0;
EntsFound := 1;
Result := True;
if (Lowercase(Players[CurrentPlayer].Strings[0]) = 'yew') then
if (LowerCase(Players[CurrentPlayer].Strings[1]) = 'bank') then
Begin
YewSwitch := YewSwitch - 90000;
SwitchYews;
Exit;
end;
if RunAway then
Begin
case Lowercase(Players[CurrentPlayer].Strings[3]) of
'n', 'north' : Mouse(MMCX, MMCY - 5, 3, 3, true);
'ne', 'north east' : Mouse(MMCX + 5, MMCY - 5, 3, 3, true);
'e', 'east' : Mouse(MMCX + 5, MMCY, 3, 3, true);
'se', 'south east' : Mouse(MMCX + 5, MMCY + 5, 3, 3, true);
's', 'south' : Mouse(MMCX, MMCY + 5, 3, 3, true);
'sw', 'south west' : Mouse(MMCX - 5, MMCY + 5, 3, 3, true);
'w', 'west' : Mouse(MMCX - 5, MMCY, 3, 3, true);
'nw', 'north west' : Mouse(MMCX - 5, MMCY - 5, 3, 3, true);
else
Mouse(MMCX, MMCY + 5, 3, 3, true);
end;
end;
end;
end;
end;
You would use that like this :
EntFinder(True);
Remember, it is made by Frozon Soul, so credit properly :) Or he might not let :eek:
Another main thing i saw was there we no fail safes, not a good idea :p
A nice tuorial on fail safes
HEREAnd with your anti ban, idk if you did this intentionaly but you made it a case out of 30, and only had 1-6, it would skip out on the 0 case, and cases 7-30. So it would do nothing :spot:
Other then that, it's your first script so good work :)
Nice to see there are still people out there striving to learn :)
-Ashur :stirthepot: