mspimp
2008-05-19 22:29:51
okay you have to be logged in sorry about the non auto login ill fix it 5-10minutes.
Start inside draynor bank and press run enjoy =]
benjaa
2008-05-22 09:02:37
your cutdown function needs to be refined abit, but besides that, its a good script to start off with.
are you coming from another forum? or is this your first time?
im a bit confused. did you really make this? :P
Players[0].Name :='';
Players[0].Pass :='';
Players[0].Nick :=''; //3-4 letters from name
Players[0].Active:= True;
Players[0].Booleans[1]:= True; // True if new rocks. False if old.
Players[0].Booleans[2]:= False; // Pick equipped?
Players[0].Strings[1]:= 'Tin'; // type of ore
Players[0].Integers[1]:= 3; // # of loads
WTF? i thought it was a tree chopper. oh wait, it is.
sk8terbitu
2008-05-24 11:51:57
lol nice stolen login procedure lol but that makes me think about the rest i know i have seen that chop procedure somewhere….
jakeytheninja
2008-05-24 17:56:25
its a good script but i think u need 2 work on it a bit. its kinda funny with the cutting
Starblaster100
2008-05-24 18:15:46
Hey, welcome to the forums, and congratulations on your first script!
Here are some pointers to help you along:
[php]
YourPin = '';
[/php]
This can be replaced by something which already exists in the DeclarePlayers procedure. It also means that each player can have their own individual pin number. The code is:
[php]
Players[0].Pin := '';
[/php]
In your cut down procedure, you have:
[php]
1: Mouse(x, y, 1 + Random(6), 5 - Random(4), true);
2: Mouse(x, y, 1 + Random(6), 5 - Random(4), true);
3: Mouse(x, y, 1 + Random(6), 5 - Random(4), true);
4: Mouse(x, y, 1 + Random(6), 5 - Random(4), true);
[/php]
you could change this to:
[php]
1, 2, 3, 4: Mouse(x, y, 1 + Random(6), 5 - Random(4), true);
[/php]
since they are all the same.
In procedure WalkToBank; you do not change the symbol accuracy back to its default.
To deposit your items into the back, I recommend you use bitmaps or DTMs instead of FindColorSpiral.
You should try and aviod using global variables such as x and y. Try using local variables and parameters instead.
If you need help with anything I have mentioned, I recommend you checking out my SCAR tutorial. You can find the link in my sig.
Lastly, in your declare players procedure, you use a lot of variables which you don't use anywhere else in the script, as you have copied and pasted the procedure from another script (which is alright!). However i recomend you remove them to aviod confusing eople when they are setting up their players. Try removing:
[php]
Players[0].Booleans[1]:= True; // True if new rocks. False if old.
Players[0].Booleans[2]:= False; // Pick equipped?
Players[0].Strings[1]:= 'Tin'; // type of ore
Players[0].Integers[1]:= 3; // # of loads
[/php]
as you don't seem to be using them
Nice one! Keep on scripting!
Starblaster100
hamish909
2008-05-24 18:21:47
Your first script and Starblaster replies to it your lucky.
Sounds like a good script and as Starblaster said keep on scripting!