SRL Archive - RS3 Outdated / Broken Scripts

Hello,This script cuts willows in draynor.Start in the draynor bank most south slot:)

Dude i see this in every script by yo

ur

if findcolorspiral(x,y,4219998,MSX1,MSY1,MSX2,MSY2)Then

you need to start using new things that are more reliable like

FindObjTPA and stuff like that heaps better for tree finding/cutting ect…..

also in your banking procedure you used

if findcolorspiraltolerance(x,y,2051671,MIX1,MIY1,MIX2,MIY2,1)Then

Dude Use the srl functions! i dont think yours will work well at all ( no offence)

the srl function for dranor bank is

OpenBankQuiet('db');

also you dont use anti ban in your wc procedure you use it in your main loop theres not really point to use it after you bank….. you use it like this..

repeat
      writeln( 'Killing Willows For:' + TimeRunning );
      Randoms;
      AntiBan;
      CheckEnt;
      Loginplayer;
      Killwill;
      BankWill;
      Norandoms;
     Until(false)
    End.
End;
End.

you need to use it in your procedures like..

Procedure KillWill;
var
x,y:integer;
Begin
Makecompass('N');
Setangle(True);
if findcolorspiraltolerance(x,y,1989456,MSX1,MSY1,MSX2,MSY2,1)Then
begin
isuptext('willow')
Writeln('Found willow')
Mouse(x,y,0,0,true)
[B]AntiBan;[/B]
Wait(7500+500)
End else
if findcolorspiraltolerance(x,y,2651752,MSX1,MSY1,MSX2,MSY2,1)Then
begin
isuptext('willow')
Writeln('Found willow')
Mouse(x,y,0,0,true)
Wait(7500+333)
End else
if findcolorspiral(x,y,3367513,MSX1,MSY1,MSX2,MSY2)Then
begin
isuptext('willow')
Writeln('Found willow')
Mouse(x,y,0,0,true)
Wait(7500+750)
[B] AntiBan;[/B]
end else
if findcolorspiral(x,y,4219998,MSX1,MSY1,MSX2,MSY2)Then
begin
isuptext('willow')
Writeln('Found willow')
Mouse(x,y,0,0,true)
Wait(7500+750)
if findcolorspiral(x,y,4614242,MSX1,MSY1,MSX2,MSY2)Then
begin
isuptext('willow')
Writeln('Found willow')
Mouse(x,y,0,0,true)
Wait(7500+750)
End;
End;
End;

ect……

same with the randoms the way useing them is just a waste of space…

Procedure WalkToWill;
var
x,y:integer;
begin
  if (FindSymbol(x, y, 'fish')) then
  begin
  wait(7500+300)
    Mouse(x, y, 2, 2, true);
    FFlag(0);
    Writeln('Got to Willows');
  end;
end;

your walking…. no failsafes mabee back it up on a radial walk or a dtm…??

begin
  SetUpSmart;
  SetupSRL;
  DeclarePlayers;
  ActivateClient;
    if not loggedin then loginplayer;
  Writeln('Logged your ass in')
  Writeln('1 account logged in')
  Wait(1000)
    repeat
      writeln( 'Killing Willows For:' + TimeRunning );
      Randoms;
      AntiBan;
      CheckEnt;
      Loginplayer;
      Killwill;
      BankWill;
      Norandoms;
     Until(false)
    End.
End;
End.

your mainloop…. can you please read on your other threads what i said if you have multi play you have to make it multiplayer in the mainloop…. or there is no point to have the 3 players in declare players…..

also i tested this script and no offence or anything it was very ban able, wcing procedure was horrible, but your getting better with each script you put out , mabe you should read this tut on how to make a cutter it shows you have to use

FindObjTPA so you always dont have to use spiral…

http://www.villavu.com/forum/showthread.php?t=27875

il add more if i need to…. you should test your scripts before you release

EDIT: also learn spacing…

EDIT: i tryed to fix them for you so you can learn……

//Start at the Bank in Draynor
//This script will cut Willows and Bank them!!
//Start at the most south bank slot thats easiest way...
//START!!!!!!!!!!
Program KillWill;
{.include SRL/SRL/Misc/Smart.scar}
{.include SRL/SRL.scar}

const
  SmartWorld = 155;//What world to load smart in
  Signed = True;  //False = unsigned, slower and for multiplayer
                 //True = signed, faster and for 1 player only

procedure DeclarePlayers;
begin
  HowManyPlayers := 5;
  NumberOfPlayers(HowManyPlayers);
  CurrentPlayer := 0;

  Players[0].Name := '';
  Players[0].Pass := '';
  Players[0].Nick := '';
  Players[0].Active := True;//Player active or not??
  
  Players[1].Name := 'Username';
  Players[1].Pass := 'Password';
  Players[1].Nick := 'Nickname';
  Players[1].Active := True;//Player active or not??
  
  Players[2].Name := 'Username';
  Players[2].Pass := 'Password';
  Players[2].Nick := 'Nickname';
  Players[2].Active := True;//Player active or not??
  
  Players[3].Name := 'Username';
  Players[3].Pass := 'Password';
  Players[3].Nick := 'Nickname';
  Players[3].Active := True;//Player active or not??
  
  Players[4].Name := 'Username';
  Players[4].Pass := 'Password';
  Players[4].Nick := 'Nickname';
  Players[4].Active := True;//Player active or not??
  
//add more players if u need them...
end;

Procedure SetUpSMART;
Begin
   WriteLn('Making S.M.A.R.T Ready');
   SmartSetupEx(108, false, true);
     Repeat
       wait(100);
       Until(SmartReady);
        If (SmartReady) then
          wait(1000+Random(2000));
          WriteLn('Loaded S.M.A.R.T');
          SetTargetDC(SmartGetDC);
          Exit;
       end;

Procedure WalkToWill;
var
x,y:integer;
begin
  if (FindSymbol(x, y, 'fish')) then
  begin
    wait(7500+300)
    Mouse(x, y, 2, 2, true);
    FFlag(0);
    Writeln('Got to Willows');
  end;
end;

Procedure ProgressReport;
Begin
Writeln('Timerunning'+timerunning)
End;

Procedure KillWill;
var
x,y:integer;

Begin
  Makecompass('N');
  Setangle(True);
  if findcolorspiraltolerance(x,y,1989456,MSX1,MSY1,MSX2,MSY2,1)Then
  begin
    isuptext('willow')
    Writeln('Found willow')
    Mouse(x,y,0,0,true)
    Wait(7500+500)
    end else
  if findcolorspiraltolerance(x,y,2651752,MSX1,MSY1,MSX2,MSY2,1)Then
  begin
    isuptext('willow')
    Writeln('Found willow')
    Mouse(x,y,0,0,true)
    Wait(7500+333)
  End else
  if findcolorspiral(x,y,3367513,MSX1,MSY1,MSX2,MSY2)Then
  begin
    isuptext('willow')
    Writeln('Found willow')
    Mouse(x,y,0,0,true)
    Wait(7500+750)
  end else
  if findcolorspiral(x,y,4219998,MSX1,MSY1,MSX2,MSY2)Then
  begin
    isuptext('willow')
    Writeln('Found willow')
    Mouse(x,y,0,0,true)
    Wait(7500+750)
    if findcolorspiral(x,y,4614242,MSX1,MSY1,MSX2,MSY2)Then
    begin
      isuptext('willow')
      Writeln('Found willow')
      Mouse(x,y,0,0,true)
      Wait(7500+750)
   End;
 End;
End;

Procedure Randoms;
Begin
  if not LoggedIn then exit;
  FindTalk;
  FindNormalRandoms;
  solveChatRandom;
  FindLamp ('Mining') //Uses lamp on that skill
  DwarfItem;
  If (FindFight)Then
  Begin
    MakeCompass ('N')
    RunTo('E', True)
    Wait(7000 +Random(3000));
    RunTo('W', True);
  End;
End;

procedure AntiBan;
begin
  if not LoggedIn then exit;
  case random(100) of //do a random number so it won't always perform the antiban
  0: RandomRClick;
  1: BoredHuman;
  2: HoverSkill('Mining', False);
  3: AlmostLogout;
 end;
end;

Procedure BankWill;
var
x,y:integer;
Begin
  if invfull
  then
  begin
    if (FindSymbol(x, y, 'Bank')) then
    begin
      Mouse(x, y, 2, 2, true);
      FFlag(0);
      Writeln('In BANK');
      if findcolorspiraltolerance(x,y,5664637,MSX1,MSY1,MSX2,MSY2,1)Then
      begin
        Writeln('We Found a Banker')
        Mouse(x,y,0,0,false)
        Chooseoption('quickly')
        wait(2000+566)
        if findcolorspiraltolerance(x,y,2051671,MIX1,MIY1,MIX2,MIY2,1)Then
        begin
          Mouse(x,y,0,0,false)
          Wait(1000+444)
          Chooseoption('All')
          Closebank;
      end else
      if findcolor(x,y,1786699,MIX1,MIY1,MIX2,MIY2)Then
      begin
        Mouse(x,y,0,0,false)
        Wait(1500+444)
        Chooseoption('All')
        Closebank;
        if (FindSymbol(x, y, 'fish')) then
        begin
          wait(7500+300)
          Mouse(x, y, 2, 2, true);
          FFlag(0);
          Writeln('Walked Back To Willows');
          End;
        End;
      End;
    End;
  End;
End;
    
procedure CheckEnt;
var
  eex, eey : integer;
begin
  if not LoggedIn then exit;
  if FindColorTolerance(eex, eey, 388075, 85, 15, 115, 15, 30) then
  begin
    WriteLn('Ent Found! ~Advoiding~');
    DoEmote(4);
    wait(2500+Random(7000));
    Inc(EntsAvoided);
    Entsavoided:=entsavoided+1
    SrlRandomsReport;
  end;
end;

Procedure Talking;
Begin
  if not LoggedIn then
  exit;
  if inchat('hello') then
  begin typesend('hello 2 u 2')
    if inchat('Wc lvl')then
    begin typesend('90:P')
      if inchat('woodcutting')then
      begin typesend('90:P')
        if inchat('woodcutting lvl')then
        begin typesend('99 lolz')
          if inchat('n00b')then
          begin typesend('im not a noob..')
            if inchat('ch00b')then
            begin typesend('you are a ch00bie')
              if inchat('wanna fight me n00bie?')then
              begin typesend('no tnx not fighting a n00b:)')
             end;
           end;
         end;
       end;
      end;
    end;
  end;
end;


procedure NoRandoms;
begin
  if not LoggedIn then exit;
  FindNormalRandoms;
  if FindFight then
  begin
    RunAway('s', True, 1, (22000+Random(5000)));
    NoRandoms;
  end;
end;

begin
  SetUpSmart;
  SetupSRL;
  DeclarePlayers;
  ActivateClient;
  if not loggedin then
    loginplayer;
    Writeln('Logged your ass in')
    Writeln('1 account logged in')
    Wait(1000)
    repeat
      writeln( 'Killing Willows For:' + TimeRunning );
      Randoms;
      AntiBan;
      CheckEnt;
      Loginplayer;
      Killwill;
      BankWill;
      Norandoms;
     Until(false)
    end.
  end;
end.

its not 100% right but much better

Ok nic,Im changing some things right now probably done tommorow but now i have Findobjcustom instead of findcolors so much better:)

and please for you it is amazing make such scripts and releasing tons of them but for us its annoying because they aren't that good(no offence)

Procedure Talking;
Begin
  if not LoggedIn then exit;
  if inchat('hello') then
   typesend('hello 2 u 2');
  if inchat('Wc lvl')then
   typesend('90:P');
  if inchat('woodcutting')then
   typesend('90:P');
  if inchat('woodcutting lvl')then
   typesend('99 lolz');
  if inchat('n00b')then
   typesend('im not a noob..');
  if inchat('ch00b')then
   typesend('you are a ch00bie');
  if inchat('wanna fight me n00bie?')then
   typesend('no tnx not fighting a n00b:)');
end;

could be that or even this

Procedure Talking;
Begin
  if not LoggedIn then exit;
  if inchat('hello') then typesend('hello 2 u 2');
  if inchat('Wc lvl')then typesend('90:P');
  if inchat('woodcutting')then typesend('90:P');
  if inchat('woodcutting lvl')then typesend('99 lolz');
  if inchat('n00b')then typesend('im not a noob..');
  if inchat('ch00b')then typesend('you are a ch00bie');
  if inchat('wanna fight me n00bie?')then typesend('no tnx not fighting a n00b:)');
end;

dont need those begin and end when only having 1 thing be done after a if then statement…also for the woodcutting lvl you could actually have it tell your woodcutting level by saving it to a variable then having it type that variable…

also the way you have your procedure right now it will only go onto check the next if then statement if it finds the one before it…which is very very unlikely to ever search past the 1st one…one of my ways will check for each one everytime

EDIT: you need a better usage of semi-colons ( ; )

Almost Done!!!

2pacfan make that talking into an case or else it will say at said woodcutting 90 :p and then 99 :p lolz after each other

kk will change:)