SRL Archive - First Scripts

my first script!!!!!
i owe a lot of thanks to baked0420 and NaumanAkhlAQ
for helping me with the smart setup and declare players!
well here it is

Use some SRL Standards, easier to read. Smart is useless for an AutoTalker. You need to be able to control the functions while it works if I'm not mistaken.

Here are some Critiques:

Original:

{
++++++++++++++++++++++++++++++++++++++++++++++++++ +
+                 6 Stair Auto Talker              +
+                 By:sk8terbitu                    +
+                                                  +
+ This script uses S.M.A.R.T!                      +
+ Please post proggies and Errors                  +
++++++++++++++++++++++++++++++++++++++++++++++++++ +
}
// setup
// setup what you want to say
// give me some pointers on how to improve
//Credits NaumanAkhlAQ and baked baked0420!

program StairTalker;

{.include SRL/SRL/misc/Smart.scar}
{.include SRL/SRL.scar}

const

talk1='type what you want to say here';


procedure declareplayers;
begin

HowManyPlayers := 1; //don't change unless you know what you're doing
CurrentPlayer := 0;
NumberOfPlayers(HowManyPlayers);

Players[0].Name := ''; //Runescape acc. name
Players[0].Pass := ''; //Runescape acc. pass
Players[0].Nick := ''; //Nickname - 3 or 4 letters from the middle of your R.S. name
Players[0].Active := True; // Set to false if you don't want to use this player
end;

procedure AntiRandom;
begin
FindNormalRandoms;
end;

procedure Talk;
begin
wait(1000)
SendKeys(talk1);
end;

Procedure Talkz1;
begin
repeat
Talk;
until(false)
end;

begin
SmartSetupEx(141, False, True); //substitute 141 with the world you want
While Not SmartReady Do Wait(100);
SetTargetDC(SmartGetDC);
SetupSRL;
ActivateClient;
DeclarePlayers;
Talkz1;
end.

Edited:

{
++++++++++++++++++++++++++++++++++++++++++++++++++ +
+                 6 Stair Auto Talker              +
+                 By:sk8terbitu                    +
+                                                  +
+ This script uses S.M.A.R.T!                      +
+ Please post proggies and Errors                  +
++++++++++++++++++++++++++++++++++++++++++++++++++ +
}
// setup
// setup what you want to say
// give me some pointers on how to improve
//Credits NaumanAkhlAQ and baked baked0420!

program StairTalker;

{.include SRL/SRL/misc/Smart.scar}
{.include SRL/SRL.scar}

const

  talk1='type what you want to say here';
  
 {Smart Constants} // I don't think SMART is useful for an auto talker :)
  SmartWorld = 43;
  Signed = true;

procedure declareplayers;
begin

  HowManyPlayers := 1; //don't change unless you know what you're doing
  CurrentPlayer := 0;
  NumberOfPlayers(HowManyPlayers);

  Players[0].Name := ''; //Runescape acc. name
  Players[0].Pass := ''; //Runescape acc. pass
  Players[0].Nick := ''; //Nickname - 3 or 4 letters from the middle of your R.S. name
  Players[0].Active := True; // Set to false if you don't want to use this player

end;

procedure AntiRandom; {I don't think you need this in an auto talker}
begin
  FindNormalRandoms;
  if FindFight then
  begin
    Runto('N');
    Wait(20000+random(5000));
    RunTo('S');
  end;
end;

procedure Talk;
begin
  wait(1000+random(500)); // Make sure you ALWAYS include random in waits. Also you missed the ;
  SendKeys(talk1);
end;

Procedure Talkz1; {Why do you have two procedures? It could be done as one.}
begin
  repeat
    Talk;
  until not LoggedIn; // NEVER use an infinite loop.
end;

begin
  SmartSetupEx(SmartWorld, False, Signed); // Use Constants so you don't have people searching through code to find this.
  While Not SmartReady Do Wait(100);
  SetTargetDC(SmartGetDC);
  SetupSRL;
  ActivateClient;
  DeclarePlayers;
  Talkz1;
end.

I outlined the errors I fixed and I also added standards. Learn from these, don't just use them.

Good first try though! :)

Nava2

~SendKeys is detectable insted it use TypeSend('');
~You never use your antirandom
~You don't must make procedure tou your antirandom. You need to put in your script FindNormalRandoms;
~

Procedure Talk;

Var
  I: Integer;

Begin
  If Not LoggedIn Then Exit;
  Repeat
    I := Random(7);
    Case I Of
      0: TypeSend('nie chce');
      1: TypeSend('odwal sie odemnie glombie');
      2: TypeSend('Smith lvl??');
      3: TypeSend('jupi jej jestem gej :0 ;p');
      4: TypeSend('?? co do kurwy');
      5: TypeSend('o sole mio maj...');
      6: TypeSend('krowa, kon, ketchup.');
    End;
    FindNormalRandoms;
    Wait(RandomRange(4000, 7000));
  Until (False);
End;

o ok thanks

From: iroki
~SendKeys is detectable insted it use TypeSend('');
~You never use your antirandom
~You don't must make procedure tou your antirandom. You need to put in your script FindNormalRandoms;
~

Procedure Talk;

Var
  I: Integer;

Begin
  If Not LoggedIn Then Exit;
  Repeat
    I := Random(7);
    Case I Of
      0: TypeSend('nie chce');
      1: TypeSend('odwal sie odemnie glombie');
      2: TypeSend('Smith lvl??');
      3: TypeSend('jupi jej jestem gej :0 ;p');
      4: TypeSend('?? co do kurwy');
      5: TypeSend('o sole mio maj...');
      6: TypeSend('krowa, kon, ketchup.');
    End;
    FindNormalRandoms;
    Wait(RandomRange(4000, 7000));
  Until (False);
End;

As if I missed that :duh:

As I said though, good first attempt bud :)

Nava2

prety nice thanks!

Apologies for the possiably "stupid question"

Whats a six stair talker?

Ok Very nice, My Edit of the script :):

{
++++++++++++++++++++++++++++++++++++++++++++++++++ +
+                 6 Stair Auto Talker              +
+                 By:sk8terbitu                    +
+                                                  +
+ This script uses S.M.A.R.T!                      +
+ Please post proggies and Errors                  +
++++++++++++++++++++++++++++++++++++++++++++++++++ +
}
// setup
// setup what you want to say
// give me some pointers on how to improve
//Credits NaumanAkhlAQ and baked baked0420!

program StairTalker;

{.include SRL/SRL/misc/Smart.scar}
{.include SRL/SRL.scar}

const

Talk1='type what you want to say here';
TimeToWait= 4; //Time In seconds to wait after each message.

procedure declareplayers;
begin

HowManyPlayers := 1; //don't change unless you know what you're doing
CurrentPlayer := 0;
NumberOfPlayers(HowManyPlayers);

Players[0].Name := ''; //Runescape acc. name
Players[0].Pass := ''; //Runescape acc. pass
Players[0].Nick := ''; //Nickname - 3 or 4 letters from the middle of your R.S. name
Players[0].Active := True; // Set to false if you don't want to use this player
end;

procedure AntiRandom;
begin
 FindNormalRandoms;
end;

procedure Talk;
begin
 wait(TimeToWait*1000);
 wAIT(RANDOM(1000));
 TypeSend(talk1);
end;

Procedure Talkz1;
begin
 repeat
  Talk;
 until(false)
end;

begin
  SmartSetupEx(141, False, True); //substitute 141 with the world you want
    While Not SmartReady Do Wait(100);
     Begin
      SetTargetDC(SmartGetDC);
       SetupSRL;
      ActivateClient;
       DeclarePlayers;
      Talkz1;
    end;
end.

Hope I Helped :)

Now at first i got an error while compiling the script, but after a while i figured the kink out, and it was of course my fault, not the scripts, but for some odd reason i do not believe it contains antiban, i tested the script and jagex put my account off, for 10 days…