SRL Archive - Archive

faster789 - SRL Member Application Form


faster789

2008-04-06 21:48:00

<!– BEGIN TEMPLATE: formanswers –>
faster789 - SRL Member Application Form
faster789

What is the meaning to life?


Where you Referred to SRL? If yes, by whom?
no


Programming Knowledge
Very basic of Pascal

Other Communitys


How Long have You Played Runescape
About 3 years

Are you affilated in anyway with Jagex LTD?
No
—————————————————–
Please write down a paragraph about Yourself.

I have attempted to write scripts many times, but failed. This is my third try to actually make a script that works good. IMO I have accomplished my goal and have added many features I never thought I could make before. I am/was "Very" active in SRL for the past 2 months. I continue to make my script better and will release more new scripts that aren't released yet. I am glad we have a "Scripting Help" thread, because it really helped me in learning how to script. I would also like to thank everyone for the encouragement and support for helping me to learn to script.

Thanks.
~BoBo/faster789

——————————————————
Please Post a Sample of your Work. Only SCAR Scripts Accepted

// -----------------------------------------------------------------------------------------------------//

// ------------------------------------- WELCOME TO BOH'S MINER PICK!!! -------------------------------//

// =============================Please Post BUGS AND PROGESS REPORTS!!! ===============================//

// ==================================== Version 1.1!!! =====================================//

//===========================RECOMMENDED TO USE RUNE PICKAXE FOR BEST RESULTS!======================//

//==========================================VERSION 1.1!!=============================================//

//-----------------NOTE!!!!!! DO NOT WIELD PICKAXE------------------------//

//==============TRY TO HAVE EXTRA PICKAXES FIRST BANK SLOT!!============///

//====== VERSION 1.0 =======//
// ========== FEATURES THE FOLLOWING!!!======//

// ===== ----> ---Banking!--- <---- ======//
// ===== ----> --Power Mining!-- <--- ======//
// ===== ----> ----AntiBan!---- <--- ======//
// ===== ----> -Random Finding!- <--- ======//
// ===== ----> - Gas Finding!- <--- ======//
// ===== ----> Progress Reports! <--- ======//
// ===== ---> SRL STATS <--- ======//
// ==== ---> Broken PickHead Finder <-- =====//

//===================================================================//
//===================================================================//

//====== VERSION 1.1 =======//
// ========== FEATURES THE FOLLOWING!!!======//

// ===== ----> ---Banking!--- <---- ======//
// ===== ----> --Power Mining!-- <--- ======//
// ===== ----> ----AntiBan!---- <--- ======//
// ===== ----> -Random Finding!- <--- ======//
// ===== ----> - Gas Finding!- <--- ======//
// ===== ----> Progress Reports! <--- ======//
// ===== ---> SRL STATS <--- ======//
// ==== ---> Broken PickHead Finder <-- =====//


// =========== **** Fixes**** ============//
// ==== ---> Many Small Bugs <--- =======//
// ==== ---> Flawless Finding Mine<--- =======//

//===================================================================//
//===================================================================//

// ========== CREDITS =========//
// --> Thanks to Torrent Of Flame for his awesome TUTS! <--//
// --> Thanks to MasterKill for his FindGas and some of his PickAxe DTMS Procedure :)!! <--//
// --> Thanks to the following people for helping me fix very small bugs <--//
// --> Cazax, NaumanAkhlaQ(helped a lot with bugs), PriSoner,KoKouKo//
// --> (all of my bugs were post in scripting help :) <--//
// PS: If you helped me and I did not mention you at all or properly PLEASE notify ME!!//

// ===================HAPPY AUTOING!!=================================//



program Miner;
{.include SRL/SRL/misc/SMART.scar}
{.include SRL/SRL.scar}

var LoadsNum, Level : integer;

//-----------------NOTE!!!!!! DO NOT WIELD PICKAXE------------------------//
//==============TRY TO HAVE EXTRA PICKAXES FIRST BANK SLOT!!============///

// ============FILL OUT BELOW===============//
const
//YOU NEED TO HAVE SRL STATS!!!//
SRLStatsID = ''; //your srl stats id example : '0000'
SRLStatsPass = ''; // your srl stats password example : 'password'

//Smart Setup//
SmartWorld = 105; // what world do you want to login to??
Signed = True; // leave alone..

Bank = 'True'; // True or False? if True it will bank ore, if False it will drop ore
LoadsPerPlayer = 100; // how many loads per player?
MorePickaxe = 'True'; // True means you have more pickaxes in first bankslot and false if you have no extra pickaxes
WaitPerRock = 3000 ; //if using rune pick write 3000, if addy pick write 4000, if steel pick write 8000, if iron or bronze pick GO BUY A BETER PICKAXE~!

var Gasnum : integer; // DO NOT TOUCH

//-----------------NOTE!!!!!! DO NOT WIELD PICKAXE------------------------//

procedure DeclarePlayers;
begin
HowManyPlayers :=1; // how many players do you want
NumberOfPlayers(HowManyPlayers);
CurrentPlayer:=0
Players[0].Name := 'username'; //Character Name
Players[0].Pass := 'pasword'; //Character Pass
Players[0].Nick := 'sern'; //Nickname 3 - 4 Letter's of char name
Players[0].Active := True; //true if you want this player to be ran in the script false if you dont want it to run

end;

// ===========DO NOT TOUCH BELOW UNLESS YOU KNOW WHAT YOUR DOING!!!================//

procedure Signature;
begin
ClearDebug;
writeln(' BoBo presents mine picker:');
wait(250);
writeln(' __________ _________ ___ ___ ');
wait(250);
writeln('| ____ | | | | | | |');
wait(250);
writeln('| | | | | _____ | | | | |');
wait(250);
writeln('| |____| | | | | | | |___| |');
wait(250);
writeln('| _______| | | | | | ___ |');
wait(250);
writeln('| ____ | | |_____| | | | | |');
wait(250);
writeln('| | | | | | | | | |');
wait(250);
writeln('| |____| | |_________| |___| |___|');
wait(250);
writeln('|__________| Made To Succeed! ');
wait(3000 + random(750));
end;


procedure Proggy;

begin
ClearDebug;

Writeln('-------------------------------------');
Writeln('Please post proggies to the place');
Writeln(' you got this script from! ');
Writeln('-------------------------------------');
Writeln('|| Worked For: ' +TimeRunning+ '||');
if Bank = 'False' then
Writeln('|| Dropped '+ IntToStr(LoadsNum)+ ' Ores||');
if Bank = 'True' then
Writeln('|| Banked ' + IntToStr(LoadsNum)+ ' Load(s)||');
Writeln('|| Gasses Found ' + IntToStr(GasNum)+ ' ||');
Writeln('Current Mining Level Is ' +IntToStr(Level));
Writeln('-------------------------------------');
SRLRandomsReport;
end;

procedure SetupSmart;
begin
SmartSetupEx(SmartWorld, false, Signed);
ClearDebug;
WriteLn('Setting up Smart... Please Hold...');
Wait(10000 + random(5000));
SetTargetDC(SmartGetDC);
While not(SmartReady) do Wait(100);
end;

Procedure CheckLevel;
Begin
if (not(LoggedIn)) then Exit;
Level := GetSkillInfo('mining', false);
End;


Procedure Myrandom;
begin
if(FindFight)then
RunAway('N', True,1,15000);
FindNormalRandoms;
end;

procedure Antiban;
begin
if(not(LoggedIn)) then Exit;
case Random(30) of
1: RandomRClick;
2: HoverSkill('Mining', False);
3: RandomMovement;
4: BoredHuman;
5: AlmostLogout;
6: DoEmote(400 + Random(90));
end;
begin
ReportVars[1] := ReportVars[1] + 1;
end;
end;

function InChatMulti(text: TStringArray): boolean;
var
i : integer;
s: string;
begin
for i:=0 to high(text) do
begin
if (not (GetLastChatText(s))) then
LastChatter(s);
Result := (Pos(Text[i], s) > 0);
end;
end;

function Leveled:boolean;
var x,y : integer;
begin
if(not(LoggedIn)) then Exit;
Result:=FindColor(x, y, 8388608, 14, 372, 495, 389)
if (result) then
begin
WriteLn(' ===Advanced A Mining Level==');
clicktocontinue;
wait(2000)
clicktocontinue;
end;
end;

procedure FixHead;
var x, y, PickAxeHead, PickStick : integer;
begin
if(not(LoggedIn)) then Exit;
PickaxeHead := DTMFromString('78DA6314666060106040038C482490960112B' +
'C04D470020951026A0481841801355244980352C3895F0D0073E1' +
'00F6');
PickStick := DTMFromString('78DA6314666060906140038C4824901601124' +
'204D44801095E026A40F2CA04D408000929026A048184220135E2' +
'404214BF1A00B23A014A');
GameTab(4);
Wait(550 + random(450));
if FindDTM(PickaxeHead, x, y, 525, 182, 745, 473) then
Mouse(x, y, 0, 0, True);
If FindDTM(PickStick, x, y, 525, 182, 745, 473) then
Mouse(x, y, 0, 0, True);
ReportVars[4] := ReportVars[4] + 1;
end;


function SearchHead:boolean;
var x, y, TryTofind, PickaxeHead, Pickaxe : integer;
begin
if(not(LoggedIn)) then Exit;
SetAngle(false);
Trytofind := 0;
repeat
Case Players[CurrentPlayer].strings[0] of
'Rune': begin
If FindObjCustom(x, y, ['ead', 'ick'], [8944476], 10) then
Mouse(x, y, 0, 0, True);
end;
'Addy': begin
If FindObjCustom(x, y, ['ead', 'ick'], [5070925], 10) then
Mouse(x, y, 0, 0, True);
end;
'Mith': begin
If FindObjCustom(x, y, ['ead', 'ick'], [4205098], 10) then
Mouse(x, y, 0, 0, True);
end;
'Steel': begin
If FindObjCustom(x, y, ['ead', 'ick'], [9079701], 10) then
Mouse(x, y, 0, 0, True);
end;
'Iron': begin
If FindObjCustom(x, y, ['ead', 'ick'], [7039858], 10) then
Mouse(x, y, 0, 0, True);
end;
'Bronze': begin
If FindObjCustom(x, y, ['ead', 'ick'], [2704730], 10) then
Mouse(x, y, 0, 0, True);
end;
end;
PickaxeHead := DTMFromString('78DA6314666060106040038C482490960112B' +
'C04D470020951026A0481841801355244980352C3895F0D0073E1' +
'00F6');
if (not (FindDTM(PickaxeHead, x, y, 525, 182, 745, 473))) then
begin
WriteLn(' Uh-oh attempted ' + IntToStr(Trytofind) + 'to find pickaxe head');
Trytofind := Trytofind + 1;
Wait(4000);
end else
begin
Writeln(' WOOOT!! FOUND PICKAXE HEAD!! ');
Result := true;
FixHead;
end;
Pickaxe := DTMFromString('78DA6314606060E06540038C4824909605125' +
'C04D470020976026A40662810502302245808A801B9590CBF1A00' +
'612000CF');
if FindDTM(Pickaxe,x, y, 525, 182, 745, 473) then
begin
WriteLn(' ' + Players[CurrentPlayer].Name + ': "yay found pickaxehead!!"');
if Players[CurrentPlayer].Booleans[0] then
Mouse(x, y, 0, 0, True);
Trytofind := 5;
PickAxeAttached := PickAxeAttached + 1;
end;
if (Trytofind = 2) then MakeCompass('W');
if (Trytofind = 3) then MakeCompass('E');
if (Trytofind = 4) then MakeCompass('S');
if (Trytofind = 1) then MakeCompass('N');
until (Trytofind = 5)
if (not (FindDTM(Pickaxe,x, y, 525, 182, 745, 473))) then
begin
if Morepickaxe = 'True'then
begin
Writeln(' Dang Sorry, Could not find the pickaxe head, going to bank to get new one ');
if Morepickaxe = 'False'then
begin
Writeln(' Sorry, but we could not find the pickaxe head, logging out! ');
Proggy;
Exit;
Logout;
end;
end;
end;
end;

function Loadiron: Integer;
var
ironMP: TDTMPointDef;
ironSP: array of TDTMPointDef;
ironDDTM: TDTM;

begin
SetArrayLength(ironSP, 5);

ironMP.x := 20;
ironMP.y := 17;
ironMP.areasize := 1;
ironMP.areashape := 0;
ironMP.color := 2305870;
ironMP.tolerance := 9;

ironSP[0].x := 6;
ironSP[0].y := 23;
ironSP[0].areasize := 1;
ironSP[0].areashape := 0;
ironSP[0].color := 65536;
ironSP[0].tolerance := 0;

ironSP[1].x := 13;
ironSP[1].y := 7;
ironSP[1].areasize := 1;
ironSP[1].areashape := 0;
ironSP[1].color := 65536;
ironSP[1].tolerance := 0;

ironSP[2].x := 24;
ironSP[2].y := 8;
ironSP[2].areasize := 1;
ironSP[2].areashape := 0;
ironSP[2].color := 65536;
ironSP[2].tolerance := 0;

ironSP[3].x := 30;
ironSP[3].y := 15;
ironSP[3].areasize := 1;
ironSP[3].areashape := 0;
ironSP[3].color := 65536;
ironSP[3].tolerance := 0;

ironSP[4].x := 18;
ironSP[4].y := 26;
ironSP[4].areasize := 1;
ironSP[4].areashape := 0;
ironSP[4].color := 65536;
ironSP[4].tolerance := 0;

ironDDTM.MainPoint := ironMP;
ironDDTM.SubPoints := ironSP;
result := AddDTM(ironDDTM);
end;

procedure GasFound;
var WaitForGasTime: Integer;
begin
if Not (LoggedIn) then exit;

Writeln (' ** Gas Detected ** ');
Mouse(630, 90, 8, 8, true);
FFlag(0);
case random (15) of
0: TypeSend('stupd gasses');
1: TypeSend('.....gas again :(');
2: TypeSend('...waits an hour..');
3: TypeSend('and there it comes..');
4: TypeSend('again??...gass...');
5: TypeSend('Gasess');
6: TypeSend('KABOOM :)');
7: TypeSend('another gass..');
8: TypeSend('sooo bored...');
9: TypeSend('waz expecting a gas..');
10:TypeSend('dumb gas..');
11:TypeSend('oh great..');
12:TypeSend('..so boredd...');
13:TypeSend('stop minin ppl gass here..');
14:TypeSend('thats rite stop mining..:(');
end;
Flag;
WaitForGasTime := 0;
Wait(500 + random(500));
repeat
Wait(1000);
WaitForGasTime := WaitForGasTime + 1;
until(WaitForGasTime > 29)
WriteLn(' yay its gone....');
GasNum := GasNum + 1;
ReportVars[3] := ReportVars[3] + 1;
end;

procedure FindGas; // BY MASTERKILL!
var x, y : integer;
begin
If Not LoggedIn then exit;
if (FindColorTolerance (x, y, 10596274, 0, 0, 500, 500, 1))
or (FindColorTolerance (x, y, 8950933, 0, 0, 500, 500, 1))
or (FindColorTolerance (x, y, 9017755, 0, 0, 500, 500, 1))
or (FindColorTolerance (x, y, 7900302, 0, 0, 500, 500, 1)) then
GasFound;
end;

procedure Walktobank;
var x, y: integer;
begin
if Not(LoggedIn) then exit;
SetAngle(True);
MakeCompass('N');
SetRun(False);
RadialRoadWalk(FindVarrockRoadColor,0,90,65,-2,0);
Wait (1000+ random(200));
repeat
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,270,390,65,-2,0);
Wait (1000+ random(200));
FFlag(0);
until FindBank('veb');
WriteLn(' Entering Bank ');
if FindDTM(Loadiron, x, y, mix1, miy1, mix2, miy2) then
begin
mouse (x,y,2,2,false);
Wait(200+random(1000));
ChooseOption('All');
Wait (1000 +random(300));
CloseBank;
LoadsNum := LoadsNum + 1;
Inc(Players[CurrentPlayer].Banked);
if Players[CurrentPlayer].Banked mod LoadsPerPlayer = 0 then
begin
CheckLevel;
Proggy;
NextPlayer(True);
end;
end;
end;

procedure WalktoMine;
var x,y : integer;
begin
if Not(LoggedIn) then exit;
ClearDebug;
Proggy;
SetAngle(True);
Myrandom;
MakeCompass('N');
SetRun(True);
RadialRoadWalk(FindVarrockRoadColor,0,90,65,-2,0);
FFlag(5);
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,45,110,65,-2,0);
Myrandom;
repeat
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,90,230,65,-2,0);
Wait(700+ random(250));
FFlag(5);
until FindSymbol(x,y,'mining spot');
If FindSymbol(x,y,'mining spot') then
begin
WriteLn('Found Mining Spot');
ClearDebug;
Proggy;
Mouse(x,y,7,7,true);
FFlag(0);
end;
end;

procedure Makesurepick;
var Stick, BrokenPick, x, y, n, m : Integer;
begin
if(not(LoggedIn)) then Exit;
BrokenPick := DTMFromString('78DA6334676660A8656440058C4824907603A' +
'A2926A0C61BA8A688801A3BA09A4C026A8C806A728950D34A408D' +
'13504D3E7E3500C8FC050A');
Stick := DTMFromString('78DA6314666060906140038C4824901601124' +
'204D44801095E026A40F2CA04D408000929026A048184220135E2' +
'404214BF1A00B23A014A');
if FindDTM(Stick, x, y, 532, 183, 751, 485) then
begin
writeln('uhoh lost pickhead...guna look for it..');
SearchHead;
end;
begin
if FindDTM(BrokenPick, n, m, 532, 183, 751, 485) then
begin
writeln(' dang, gasfound did not work I guess...please report this bug if you got it. ');
if MorePickAxe = 'True' then
WalktoBank;
Proggy;
Logout;
NextPlayer(true);
if MorePickAxe = 'False' then
WalktoBank;
Proggy;
Logout;
NextPlayer(false);
end;
end;
end;


procedure MakeSureRock;
var x, y, n, m : integer;

begin
if(not(LoggedIn))then
Exit;
MakeCompass('N');
SetAngle(True);
begin
if not FindObjCustom(x, y, ['ock', 'Mine'], [2832993], 6)then
SetAngle(false);
writeln('couldnt find the rock so lowering');
if FindObjCustom(n, m, ['ock', 'Mine'], [2832993], 6)then
Makesurepick;
FindGas;
Leveled;
Myrandom;
Mouse(n, m, 1, 1, True);
Myrandom;
exit;
end;
end;

procedure MinedaRock;
var x, y : integer;
begin
MakeCompass('N');
SetAngle(True);
repeat
if Not(LoggedIn) then exit;
if not FindObjCustom(x, y, ['ock', 'ine'], [2832993], 3) then
Wait(900 +random(250));
if FindObjCustom(x, y, ['ock', 'ine'], [2832993], 3) then
Makesurepick;
FindGas;
Leveled;
Myrandom;
Mouse(x, y, 1, 1, True);
Myrandom;
Wait(WaitPerRock +random(500));
until InvFull;
if InvFull then
begin
writeln( 'Inventory Full walking to bank.' );
ReportVars[0] := ReportVars[0] + 1;
end;
end;

procedure Tobank;
begin
if(not(LoggedIn)) then Exit;
MakeCompass('N')
SetAngle(True);
WalktoMine;
Antiban;
Myrandom;
MakeSureRock;
MinedaRock;
Antiban;
Myrandom;
Walktobank;
end;

procedure Drop;
Var x : integer;
begin
if Not(LoggedIn) then exit;
Antiban;
GameTab(4);
for x := 2 to 28 do
Begin
if Random(101) < 3 then
Begin
MouseItem(x, true);
MouseItem(x + 1, true);
end;
MouseItem(x, false);
ChooseOption('rop');
Myrandom;
LoadsNum := LoadsNum + 1;
ReportVars[2] := ReportVars[2] + 1;
Proggy;
end;
end;

procedure ToDrop;
begin
if(not(LoggedIn)) then Exit;
MakeCompass('N');
SetAngle(True);
WalktoMine;
Antiban;
Myrandom;
MakeSureRock;
repeat
Minedarock;
Drop;
Antiban;
Myrandom;
Inc(Players[CurrentPlayer].Banked);
until Players[CurrentPlayer].Banked mod LoadsPerPlayer = 0;
begin
CheckLevel;
Proggy;
NextPlayer(True);
end;
end;

begin
SetUpSmart;
Signature;
SetupSRL;
ScriptID :='766';
SRLID := SRLStatsID;
SRLPassword := SRLStatsPass;
if (SRLID = '') or (SRLPassword = '') then
begin
ClearDebug;
if (SRLStatsID = '') and not(SRLStatsPass = '') then writeln('Nice try, trying to trick it with just a ID :P');
writeln('You dont have SRL stats, To set up a SRL stats ID go here: http://www.stats.srl-forums.com');
TerminateScript;
end;
begin
DeclarePlayers;
if LoggedIn then Logout;
LoginPlayer;
CheckLevel;
Writeln('Current Mining Level Is ' +IntToStr(Level));
if Bank = 'False' then
begin
repeat
ToDrop;
if not Loggedin then NextPlayer(False);
until False;
end;
if Bank = 'True' then
begin
repeat
Tobank;
if not Loggedin then NextPlayer(False);
until False;
end;
end;
end.



——————————————————
<!– END TEMPLATE: formanswers –>

Harry

2008-04-06 21:51:27

Basic, but Member worthy IMO.. I think it will be a yes.

JW- a DDTM for Iron Ore?! :p

faster789

2008-04-06 22:03:24

From: Hy71194
Basic, but Member worthy IMO.. I think it will be a yes.

JW- a DDTM for Iron Ore?! :p

Thanks.;) :D

P1nky

2008-04-06 22:15:09

its quite BASIC though ill hold my vote to see other comments

Metagen

2008-04-06 23:14:56

Pinky is a noob! xD

i vote yes because i love you… yeaaa

Edit: i actually voted yes for a very good reason. it's too long for me to look though Therefore it must be a good script :)

faster789

2008-04-06 23:16:56

From: metagen
Pinky is a noob! xD

i vote yes because i love you… yeaaa

Edit: i actually voted yes for a very good reason. it's too long for me to look though Therefore it must be a good script :)


Haha, thanks buddy..
btw nope its p1nky's choice ;)

Edit: LOL, yes a very good reason:p

Metagen

2008-04-06 23:17:40

DAMN YOU! *read my siggy*

and ish fancy lookin :D all indented and yayzors

faster789

2008-04-06 23:21:27

From: metagen
DAMN YOU! *read my siggy*

and ish fancy lookin :D all indented and yayzors


LOL, sorryy…
btw wats yayzors:rolleyes:

Psychor

2008-04-07 00:18:33

Nice one, but maybe in the future you could tell for what location it's used at the beginning of the script also, lol

Negaal

2008-04-07 00:53:09

Sure yes, though I don't like when you reload dtm's at beginning of every procedure and never free them.

faster789

2008-04-07 01:08:55

@Psychor
LOL, yep i actually forgot…hmmm in my next version im going to make a procedure so it finds if your in the mines or bank..so you dont need to worry, btw thanks for voting and pointing that out ;)

@Negaal
yes, you're right but when I make a "DTM setup" where I put all my DTMS it says unknown DTM so I had to call it at each of the procedure..btw thanks for vote and advice:)

Iron Man

2008-04-07 01:58:18

I'm not going to vote because I'm new but I have a couple of suggestions:

I'll take this one for example:

procedure MakeSureRock;
var x, y, n, m : integer;

begin
if(not(LoggedIn))then
Exit;
MakeCompass('N');
SetAngle(True);
begin
if not FindObjCustom(x, y, ['ock', 'Mine'], [2832993], 6)then
SetAngle(false);
writeln('couldnt find the rock so lowering');
if FindObjCustom(n, m, ['ock', 'Mine'], [2832993], 6)then
Makesurepick;
FindGas;
Leveled;
Myrandom;
Mouse(n, m, 1, 1, True);
Myrandom;
exit;
end;
end;

That will lower the screen if it doesn't find it, and it will ALWAYS do the WriteLn. And use x, y for both of the FindObjCustoms, it just overwrights it.

Just use a static DTM instead of a DDTM for inventory items.


For your Antiban; proc, usually people make it 1/10 chances. And since when is there a 400th emote :confused:

For this procedure:

function Leveled:boolean;
var x,y : integer;
begin
if(not(LoggedIn)) then Exit;
Result:=FindColor(x, y, 8388608, 14, 372, 495, 389)
if (result) then
begin
WriteLn(' ===Advanced A Mining Level==');
clicktocontinue;
wait(2000)
clicktocontinue;
end;
end;

Shouldn't you use a random in that wait? Do you have to click to continue 2 times?

For this:

procedure MinedaRock;
var x, y : integer;
begin
MakeCompass('N');
SetAngle(True);
repeat
if Not(LoggedIn) then exit;
if not FindObjCustom(x, y, ['ock', 'ine'], [2832993], 3) then
Wait(900 +random(250));
if FindObjCustom(x, y, ['ock', 'ine'], [2832993], 3) then
Makesurepick;
FindGas;
Leveled;
Myrandom;
Mouse(x, y, 1, 1, True);
Myrandom;
Wait(WaitPerRock +random(500));
until InvFull;
if InvFull then
begin
writeln( 'Inventory Full walking to bank.' );
ReportVars[0] := ReportVars[0] + 1;
end;
end;

Shouldn't you use more than 3 tol… ? And what if it doesn't get a full inventory… won't that repeatedly look over the screen, so you should use a failsafe.


In this procedure:

procedure FixHead;
var x, y, PickAxeHead, PickStick : integer;
begin
if(not(LoggedIn)) then Exit;
PickaxeHead := DTMFromString('78DA6314666060106040038C482490960112B' +
'C04D470020951026A0481841801355244980352C3895F0D0073E1' +
'00F6');
PickStick := DTMFromString('78DA6314666060906140038C4824901601124' +
'204D44801095E026A40F2CA04D408000929026A048184220135E2' +
'404214BF1A00B23A014A');
GameTab(4);
Wait(550 + random(450));
if FindDTM(PickaxeHead, x, y, 525, 182, 745, 473) then
Mouse(x, y, 0, 0, True);
If FindDTM(PickStick, x, y, 525, 182, 745, 473) then
Mouse(x, y, 0, 0, True);
ReportVars[4] := ReportVars[4] + 1;
end;

Shouldn't you use more randomness in the Mouse? And why not use MIX1, MIY1 etc? (Inventory)


Theres a couple spots where you used a begin where it wasn't needed I think.


Declare x, y a global var to save some space.

Also, declare your dtm name as a global var that will fix your DTM problem.


For your walking, you should make it more failsafe, like
 if not radialwalk(etc...) then 
then make like a ddtm or walkpath or another radialwalk as a failsafe.
And this is also a possible infinite loop:

procedure Walktobank;
var x, y: integer;
begin
if Not(LoggedIn) then exit;
SetAngle(True);
MakeCompass('N');
SetRun(False);
RadialRoadWalk(FindVarrockRoadColor,0,90,65,-2,0);
Wait (1000+ random(200));
repeat
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,270,390,65,-2,0);
Wait (1000+ random(200));
FFlag(0);
until FindBank('veb');
WriteLn(' Entering Bank ');
if FindDTM(Loadiron, x, y, mix1, miy1, mix2, miy2) then
begin
mouse (x,y,2,2,false);
Wait(200+random(1000));
ChooseOption('All');
Wait (1000 +random(300));
CloseBank;
LoadsNum := LoadsNum + 1;
Inc(Players[CurrentPlayer].Banked);
if Players[CurrentPlayer].Banked mod LoadsPerPlayer = 0 then
begin
CheckLevel;
Proggy;
NextPlayer(True);
end;
end;
end;
What happens if it doesn't do the radialwalk, it'll keep retrying that until it finds the bank.

The most of the script is good though.


Sorry if I missed anything/messed up anything, it's late and I'm tired.

Richard

2008-04-07 03:47:30

YES! I've seen you have the right atitude, I've seen you helping others, and its nice to see that you are also a great scripts :)

skilld u

2008-04-07 10:29:54

yes. it's good.

Naum

2008-04-07 14:45:16

Yep I ''helped alot with errors'' :)

Hope you get in!

Wizzup?

2008-04-07 15:08:42

Yep. In. (as in, you get my vote :p )

richk1693

2008-04-07 16:50:18

I say yes.

faster789

2008-04-07 17:45:24

@ Iron Man, wow? You were tired and your wrote that much? Thanks a Lot. And about the tol 3 for finding the rock, if it went anymore it would not click the rock but the ground, btw do you know how I can make it ONLY click the rock because even with a tol of 3 it sometimes clicks the ground. Thanks again for the advice!:D

@ Dude Richard
Thanks and I'll continue to script while helping;)

@Skilld U
Thanks.:)

@NaumanAkhlaQ
Lol, yep you sure did and thanks.;)

@Wizzup?
Lol almost got fooled when you said "yep, your in":p
Btw Thanks a bunch!:)

@RichK1693
Thanks.(h)

Iron Man

2008-04-07 17:57:26

To solve your problem, maybe make it right click then
if not ChooseOption('ine') then exit;
?

Special Ed

2008-04-07 18:20:33

Personally this deserves a No.

This script is generally very basic, and demonstrates little knowledge of SRL or SCAR.

There are a lot of completely pointless procedures in this script and I don't recall seeing a function anywhere. There are places where cases could have been used much more efficiently and there are places where he doesn't uses cases at all, which leads me to believe he copied some of the script.

This scripts needs some failsafes added to it in a lot of different places, because this script as is is almost guaranteed a false positive or an infinite loop.

The DDTM he used was pretty pointless, although it did show he knew how to use DDTMs he didn't use them to their fullest possibility, it would have been better suited for his walking procedure.

Overall its just too simple. I think he needs to learn a lot more before becoming and SRL - Member.

Double Post?

Also if you search his recent posts, I don't think I found more than 2 useful or helpful posts in the first 3 pages.

I'm sorry if I sound harsh faster but I'm tired of people voting yes without a good basis.

Cazax

2008-04-07 19:33:25

hmmm…

- Use FindObjTPA, better than FindObjCustom, try to learn how to use it :p

- As iron man said, use if RadialWalk then…

- You didnt credit my function :p InChatMulti

- You dont need that function for finding the Gas, go to SRL/SRL/Skill/mining.scar and use those gas finders


Yes

faster789

2008-04-07 19:37:10

From: Special Ed
Personally this deserves a No.

This script is generally very basic, and demonstrates little knowledge of SRL or SCAR.

There are a lot of completely pointless procedures in this script and I don't recall seeing a function anywhere. There are places where cases could have been used much more efficiently and there are places where he doesn't uses cases at all, which leads me to believe he copied some of the script.

This scripts needs some failsafes added to it in a lot of different places, because this script as is is almost guaranteed a false positive or an infinite loop.

The DDTM he used was pretty pointless, although it did show he knew how to use DDTMs he didn't use them to their fullest possibility, it would have been better suited for his walking procedure.

Overall its just too simple. I think he needs to learn a lot more before becoming and SRL - Member.

Double Post?

Also if you search his recent posts, I don't think I found more than 2 useful or helpful posts in the first 3 pages.

I'm sorry if I sound harsh faster but I'm tired of people voting yes without a good basis.


:( Ah well, thanks for the advice. Btw, nope did not copy the script except for MasterKills find gass procedure and yes sorry I was in kind of rush and excited to post this in SRL member application, so I forgot to add many things which I am currently working on like a : if lost home tele, and walk back to mines …or if somehow end up in lumby to walk back to mines.
Anyways thanks.
P.S. lol I tried to learn TPA but sooo hard lol I get confused so fast, but I'm still working on it, so for next version most likely would add.

EDIT: I've post this problem in scripting sections about 100000 million times, but no one seems to answer as I think it's hard. As many people know, there is a varrock museum and my scripts 20% gets stuck there. Does anybody have a solution?

faster789

2008-04-07 19:39:18

From: Cazax
hmmm…

- Use FindObjTPA, better than FindObjCustom, try to learn how to use it :p

- As iron man said, use if RadialWalk then…

- You didnt credit my function :p InChatMulti

- You dont need that function for finding the Gas, go to SRL/SRL/Skill/mining.scar and use those gas finders


Yes


Lol thanks buddy. Oh yea sorry forgot to credit and I really didn't completely finish that part, many other things are to add. And Thanks for advice.;)


EDIT!!:: OMG SORRY EVERYONE FOR DOUBLE POST!! REALLY DIDNT MEAN IT! I seriiously can't find the delete option!

HyperSecret

2008-04-07 19:47:10

From: Special Ed
Personally this deserves a No.

This script is generally very basic, and demonstrates little knowledge of SRL or SCAR.

There are a lot of completely pointless procedures in this script and I don't recall seeing a function anywhere. There are places where cases could have been used much more efficiently and there are places where he doesn't uses cases at all, which leads me to believe he copied some of the script.

This scripts needs some failsafes added to it in a lot of different places, because this script as is is almost guaranteed a false positive or an infinite loop.

The DDTM he used was pretty pointless, although it did show he knew how to use DDTMs he didn't use them to their fullest possibility, it would have been better suited for his walking procedure.

Overall its just too simple. I think he needs to learn a lot more before becoming and SRL - Member.

Double Post?

Also if you search his recent posts, I don't think I found more than 2 useful or helpful posts in the first 3 pages.

I'm sorry if I sound harsh faster but I'm tired of people voting yes without a good basis.


Amen.

very good points IMO, finally someone sees the same as me…that is why i stopped voting on application.

longer does not mean its good or even worthy for that matter.

faster789

2008-04-07 20:36:37

From: HyperSecret
Amen.

very good points IMO, finally someone sees the same as me…that is why i stopped voting on application.

longer does not mean its good or even worthy for that matter.

Yes, I don't blame you, I was astonished to see him write that, and also surprised to find that he is right. And about the posts, I was just excited with my first script thread so I wanted it to get shown, sorry about that. And also yes you guys are right found infinite loop. I am currently working on newer version which will amaze your eyes!:D
BTW does that mean its a no?

Special Ed

2008-04-07 20:51:42

From my understanding approving an SRL-Member is supposed to work like this…

[1] - People review the script and the person and post comments and suggestions, yes / no, and why.

[2] - Administrators evaluate the votes and whether or not people have a substantial basis for voting yes or no and don't count the ones that don't.

[3] - An Administrator weighs the votes and may ask some moderators whether or not they agree and either "In" the person or tell them to try again.

SRL-Members has changed quite drastically since I joined over a year ago… and people don't seem to treat it quite the same anymore so I don't know if what I think is correct.

P.S. - Don't take this personally faster, I'm just appalled by how the SRL-Members base their votes nowadays. Please don't think I'm saying this to bash you, the only reason I'm being to critical and harsh is because I'm trying to prove a point. Your script is Ok, but not to what I'd consider an SRL-Members Script. I'll be looking forward to your new version of this script :)

faster789

2008-04-07 23:21:12

From: Special Ed
From my understanding approving an SRL-Member is supposed to work like this…

[1] - People review the script and the person and post comments and suggestions, yes / no, and why.

[2] - Administrators evaluate the votes and whether or not people have a substantial basis for voting yes or no and don't count the ones that don't.

[3] - An Administrator weighs the votes and may ask some moderators whether or not they agree and either "In" the person or tell them to try again.

SRL-Members has changed quite drastically since I joined over a year ago… and people don't seem to treat it quite the same anymore so I don't know if what I think is correct.

P.S. - Don't take this personally faster, I'm just appalled by how the SRL-Members base their votes nowadays. Please don't think I'm saying this to bash you, the only reason I'm being to critical and harsh is because I'm trying to prove a point. Your script is Ok, but not to what I'd consider an SRL-Members Script. I'll be looking forward to your new version of this script :)


Hell yea! You better watch out for my new version!!! to be honest, I dont wana be srl member "rite now" cuz i wana show u my new version(when released) and OWN ALL OF YOu!;) I have so many ideas cant way to implement them…if you really dont want me to be a member, just ignore this application, i dont mind cuz in another 1 or 2 weeks ill be back to make your mouth open and say " i mis judged him" LOL thanks for the advice, I didnt your comments offensive (well at least not that much:( )

king vash

2008-04-08 01:50:12

I agree with Special Ed, The script isn't that great and their are many serious flaws for example " 6: DoEmote(400 + Random(90));" (DoEmotion takes 1 to 37) I would spend a little more time making it work, and utilizing SRL functions.

something I found to help a lot is to print it out and really look at what you did, top to bottom, no matter with what script or how many times I've do this I ALWAYS find 5+ errors a page on every page, I've done this 10+ times with my script and it really will help no matter what your programming level is.

or the other hand I like to see new members, so if you can make some improvements I'll vote yes. Things I would suggest, 1. SRL functions 2. organization 3. Readablity and Flow.

I'm holding my vote

faster789

2008-04-08 01:53:53

From: king vash
I agree with Special Ed, The script isn't that great and their are many serious flaws for example " 6: DoEmote(400 + Random(90));" (DoEmotion takes 1 to 37) I would spend a little more time making it work, and utilizing SRL functions.

something I found to help a lot is to print it out and really look at what you did, top to bottom, no matter with what script or how many times I've do this I ALWAYS find 5+ errors a page on every page, I've done this 10+ times with my script and it really will help no matter what your programming level is.

or the other hand I like to see new members, so if you can make some improvements I'll vote yes. Things I would suggest, 1. SRL functions 2. organization 3. Readablity and Flow.

I'm holding my vote

Ok, thanks. I'll elaborate on your idea. Expect a huge update on this…but the problem is that I ask if this thread can be extended, even if I have more yes's then no's I would like to have everyone satisfied. So, for when I release my next version I'll post it here…and you'll hopefully be shocked;)

CheetahNub

2008-04-08 08:16:14

DONT USE AUTOTALKERS ON GASFINDERS!

Because maybe 99% of the gasfinders give false positives, so it would be weird if someone was talking about gases all the time without even getting them :P

I'm holding my vote, cos I haven't tested it. It looks good though, so if I had to vote, I'd say yes.

faster789

2008-04-08 16:31:53

NOTE : TO EVERYONE, PLEASE HOLD YOUR VOTES! AFTER THIS POST! THERE IS GOING TO BE A NEW VERSION RELEASED as fast as possible(maximum a week). :D

faster789

2008-04-09 02:37:45

Edit: is it possible if anyone can close this poll, and reset it to 0,0. Even though apparently I might make it to SRL-members, I will make it but not with everyone's satisfaction. So I am currently updating my script( I think its soooo good so far). Thanks.

Richard

2008-04-09 04:05:54

From: faster789
Edit: is it possible if anyone can close this poll, and reset it to 0,0. Even though apparently I might make it to SRL-members, I will make it but not with everyone's satisfaction. So I am currently updating my script( I think its soooo good so far). Thanks.


Why do you want everyone to say yes? The chances of that happenning is about 1/1000000. Theres nearly always someone who votes no.

And can you please stop double posting!

Naum

2008-04-09 05:20:04

True if you cancel this, I doubt you'll get in.
Some people just too heroic….

Offtopic: @Faster do you , like rape the help section to death. :)

Special Ed

2008-04-09 15:51:33

Hey, but if everyone votes yes, he definitely knows he's on the right track! Also… I swear I'll vote no next time if you keep double posting… ;)

faster789

2008-04-09 16:37:44

@ DudeRichard and Special Ed
I know!! LIKE wat the heck!! Its not letting me delete OR edit posts! If i try to make a edit it creates a new post!…sorry.

@NaumanAkhlaQ
LOL hel yea!:p

Richard

2008-04-09 16:43:24

Hmm, I sometimes have problems where it takes ages to post new posts or whatever, just leave it while its doing whatever it is and go and grab a packet of crisps or somethings… thats what I do.

But remember never to click stop, then click the post buttong again, or it will just post 2 of the name thing.

Camaro'

2008-04-09 17:15:03

From: Special Ed
Personally this deserves a No.

This script is generally very basic, and demonstrates little knowledge of SRL or SCAR.

There are a lot of completely pointless procedures in this script and I don't recall seeing a function anywhere. There are places where cases could have been used much more efficiently and there are places where he doesn't uses cases at all, which leads me to believe he copied some of the script.

This scripts needs some failsafes added to it in a lot of different places, because this script as is is almost guaranteed a false positive or an infinite loop.

The DDTM he used was pretty pointless, although it did show he knew how to use DDTMs he didn't use them to their fullest possibility, it would have been better suited for his walking procedure.

Overall its just too simple. I think he needs to learn a lot more before becoming and SRL - Member.

Double Post?

Also if you search his recent posts, I don't think I found more than 2 useful or helpful posts in the first 3 pages.

I'm sorry if I sound harsh faster but I'm tired of people voting yes without a good basis.

I so.
Agree, Your walking procedures arent good..

RadialRoadWalk(FindVarrockRoadColor,0,90,65,-2,0);
wont work cause u need if not


if not RadialRoadWalk(FindVarrockRoadColor,0,90,65,-2,0) then
FindDDTM;


im not going to vote. If you do lose, and you do comeback again next month.. Then here are some improvements needed..

-Walking procs.. if it were to fail, it would ruin the script the.
-FailSafes
-Use some ddtms for walking.

faster789

2008-04-09 23:31:09

@ cnr sport
yep…I just implemented a DDTM but its not actualy for the "walking" its like to assist the walking…to make sure its going the right way..ill try implementing more..

nielsie95

2008-04-10 02:54:52

So you are sure you want to apply again?
If you do, I'll close this and you can make a new appliance whenever you're ready.

Torrent of Flame

2008-04-10 13:13:39

Im not voting, I just noticed I was mentioned in the credits :D

faster789

2008-04-10 19:33:16

From: nielsie95
So you are sure you want to apply again?
If you do, I'll close this and you can make a new appliance whenever you're ready.


Yes please and thanks.:)

P1nky

2008-04-10 20:34:34

From: faster789
Yes please and thanks.:)


NOW THATS A REAL SCRIPTER!


dude im so impressed, gl next time!

nielsie95

2008-04-12 05:35:15

Good luck next time.
Closed.