SRL Archive - First Scripts

All Members Please Check!


faster789

2008-04-06 00:42:43

Hello Everyone,

This is my first script ever made. So please be nice and post proggies and report ALL bugs. I am planning sometime of applying for membership with this script, but before I do that I need everyone's feedback. This script is a Varrock East Miner and can powermine or bank.
Enjoy and please REP Me if you like the script!;)

Version 1:
-Fixed Minor Bugs
-Added More Failsafes

Future -Version 2:
-AutoResponder
-SRL Stats
-and other bugs and ideas you guys post!

Cheers!
~BoBo:)

P.S. Sorry, the title for this script is wrong, EVERYBODY is allowed and is encouraged to use this script for now! So enjoy!

faster789

2008-04-06 00:59:10

Saved For Proggies!

kingarabian

2008-04-06 01:12:57

the link dont work bro.

faster789

2008-04-06 01:14:10

From: kingarabian
the link dont work bro.

Thanks for Coming:D
Try Again I re-uploaded it!

EDIT: Dang, forgot something, re-upload if upload script before this time of post!

KoKouKo

2008-04-06 01:27:48

I'm not a member, but here's some thing I noticed;

You randomly declare globals on line 152 :confused:

You have a "FindLamp" under "FindNormalRandoms", lamp solving is included in "FindNormalRandoms" so this is unnecessary. What you need to do is declare the lamp skill, but conveniently for you the default is mining so it's completely unnecessary.

That's all I really noticed because I'm tired and really need to start my English project, good luck on getting accepted, you scored a 103 on BH's marker so you probably will get in as long as it compiles and works, I didn't actually try it.

faster789

2008-04-06 01:30:16

From: KoKouKo
I'm not a member, but here's some thing I noticed;

You randomly declare globals on line 152 :confused:

You have a "FindLamp" under "FindNormalRandoms", lamp solving is included in "FindNormalRandoms" so this is unnecessary. What you need to do is declare the lamp skill, but conveniently for you the default is mining so it's completely unnecessary.

That's all I really noticed because I'm tired and really need to start my English project, good luck on getting accepted, you scored a 103 on BH's marker so you probably will get in as long as it compiles and works, I didn't actually try it.


Thanks a lot! I'll fix that and BH's Marker? Where is that? and BTW goodluck on your project;)

Runescapian321

2008-04-06 01:33:04

I'm not that great of a scripter but here's my opinion…

Lacks a few more failsafes
Wait times for knowing when a rock has been mined aren't very effective
Not a good idea to talk if you find a gas, just incase it was a false positive

Pretty good script overall :)

EDIT: @Koko I think he declares his globals only in procedures where he needed them, instead of once for the whole script at the top

BH's marker is a tool BobboHobbo made for finding out if your script is SRL Memberworthy

faster789

2008-04-06 01:35:50

From: Runescapian321
I'm not that great of a scripter but here's my opinion…

Lacks a few more failsafes
Wait times for knowing when a rock has been mined aren't very effective
Not a good idea to talk if you find a gas, just incase it was a false positive

Pretty good script overall :)


Cool , Thanks a bunch! I'll fix the listed errors and bugs!:D

KoKouKo

2008-04-06 01:40:40



procedure Antiban;
begin
if(not(LoggedIn)) then Exit;
case Random(30) of
1: RandomRClick;
2: HoverSkill('Mining', False);
3: RandomMovement;
4: BoredHuman;
5: AlmostLogout;
6: DoEmote(400 + Random(90));
end;
end;

var x,y : integer; // That's a global (line 152)
Function Leveled:boolean; // also dont capitalize words that are bolded
begin
Result:=FindColor(x, y, 8388608, 14, 372, 495, 389)
if (result) then
begin
WriteLn(' ===Advanced A Mining Level==');
clicktocontinue;
wait(2000)
clicktocontinue;
end;
end;
Don't double post use the edit button.

faster789

2008-04-06 01:43:52

From: KoKouKo


procedure Antiban;
begin
if(not(LoggedIn)) then Exit;
case Random(30) of
1: RandomRClick;
2: HoverSkill('Mining', False);
3: RandomMovement;
4: BoredHuman;
5: AlmostLogout;
6: DoEmote(400 + Random(90));
end;
end;

var x,y : integer; // That's a global (line 152)
Function Leveled:boolean; // also dont capitalize words that are bolded
begin
Result:=FindColor(x, y, 8388608, 14, 372, 495, 389)
if (result) then
begin
WriteLn(' ===Advanced A Mining Level==');
clicktocontinue;
wait(2000)
clicktocontinue;
end;
end;
Don't double post use the edit button.


Ohhh I see …Thanks a lot! and sorry for double post.

EDIT!!: NEW VERSION RELEASE –VERSION 1–

EvilChicken!

2008-04-06 03:39:19

@KoKouKo: Wizz capitalizes his. (I don't understand why?)
But, yes, obviously bold words aren't meant to be capitalized in SCAR. Anyway.

1:
 Bank = 'True'; // True or False? if True it will bank ore, if False it will drop ore
Why a string? Use booleans for True/False's. (If you don't know what a boolean is, search.)
2: Omg, never mind. I saw a DDTM in there.
Apply for memers, you've got my vote.

faster789

2008-04-06 03:48:46

From: EvilChicken!
@KoKouKo: Wizz capitalizes his. (I don't understand why?)
But, yes, obviously bold words aren't meant to be capitalized in SCAR. Anyway.

1:
 Bank = 'True'; // True or False? if True it will bank ore, if False it will drop ore
Why a string? Use booleans for True/False's. (If you don't know what a boolean is, search.)
2: Omg, never mind. I saw a DDTM in there.
Apply for memers, you've got my vote.


thanks I will be applying right after my next update…Its a huge update..many more failsafes, and better detection of where it actually is and best of all SRL stats;)

kingarabian

2008-04-06 04:45:10

From: faster789
thanks I will be applying right after my next update…Its a huge update..many more failsafes, and better detection of where it actually is and best of all SRL stats;)



procedure WalktoMine;
var x,y : integer;
begin
if Not(LoggedIn) then exit;
SetAngle(True);
Myrandom;
MakeCompass('N');
SetRun(True);
RadialRoadWalk(FindVarrockRoadColor,0,90,65,-2,0);
FFlag(5);
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,45,110,65,-2,0);
Myrandom;
repeat
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,90,230,65,-2,0);
Wait(700+ random(250));
FFlag(5);
until FindSymbol(x,y,'mining spot');
If FindSymbol(x,y,'mining spot') then
begin
WriteLn('Found Mining Spot');
Mouse(x,y,7,7,true);
FFlag(0);
end;
end;

Add more failsafes like this:
procedure WalktoMine;
var x,y : integer;
begin
if Not(LoggedIn) then exit;
SetAngle(True);
Myrandom;
MakeCompass('N');
SetRun(True);
RadialRoadWalk(FindVarrockRoadColor,0,90,65,-2,0);
FFlag(5);
Myrandom;
if not RadialRoadWalk(FindVarrockRoadColor,0,90,65,-2,0); then
RadialRoadWalk(FindVarrockRoadColor,some other radials);//use some other radials just incase
RadialRoadWalk(FindVarrockRoadColor,45,110,65,-2,0);
Myrandom;
if not RadialRoadWalk(FindVarrockRoadColor,45,110,65,-2,0) then
FindPath(0); // its best if you use more then one walking procedure.
repeat
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,90,230,65,-2,0);
Wait(700+ random(250));
FFlag(5);
until FindSymbol(x,y,'mining spot');
If FindSymbol(x,y,'mining spot') then
begin
WriteLn('Found Mining Spot');
Mouse(x,y,7,7,true);
FFlag(0);
end;
end;

Naum

2008-04-06 05:17:59

Very nicely done :).

Just some fixes for making the script run a bit better.

procedure FixHead;
var x, y, PickAxeHead, PickStick : integer;
begin
if(not(LoggedIn)) then Exit;
PickaxeHead := DTMFromString('78DA6314666060106040038C482490960112B' +
'C04D470020951026A0481841801355244980352C3895F0D0073E1' +
'00F6');
PickStick := DTMFromString('78DA6314666060906140038C4824901601124' +
'204D44801095E026A40F2CA04D408000929026A048184220135E2' +
'404214BF1A00B23A014A');
GameTab(4);
Wait(550 + random(450));
if DTMRotated(PickaxeHead, x, y, 525, 182, 745, 473) then
Mouse(x, y, 2, 1, True);
If DTMRotated(PickStick, x, y, 525, 182, 745, 473) then
Mouse(x, y, 2, 3, True);
end;

FindDTM is mainly used for finding items in the inventory, I prefer using 'DTMRoated', why?

Because It looks for the object on the ground with an angle bisector of 30 degrees. Which means it looks on the ground, if it doesn't find it it tries a different tack.

And i've added randomness in the pickup thing becuase no randomness in co-ords := InstaBan; (Unless your clicking symbols).

Another thing i noticed was that you have infinate loops e.g

  repeat
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,270,390,65,-2,0);
Wait (1000+ random(200));
FFlag(0);
until FindBank('veb');

True if it will find the bank it will click it, but what if it doesn't and radialwalk can click anywhere in its radiants. So a better tack would be:

  repeat
Tries:= Tries+1;
Myrandom;
RadialRoadWalk(FindVarrockRoadColor,270,390,65,-2,0);
Wait (1000+ random(200));
FFlag(0);
until FindBank('veb') or Tries >5
If Tries > 5 then
Begin
WriteLn('Bank NOT Found!')
Exit;
end;
Adding a failsafe really helps :), also if you want to use it you must declare the variable 'Tries' in your script.


I've got to go, but i'll go through it later :).

Nice attempt looks nice :)

Richard

2008-04-06 05:36:30

If you apply for members, you'll get my vote.

Couple of things though.

With the pickaxe finder, you don't have any randomness, when SCAR finds a DTM the x and y are the middle pixel always, so that would get you banned. Change it to something like:

'Rune': begin
If FindObjCustom(x, y, ['ead', 'ick'], [8944476], 10) then
Mouse(x, y, 3, 3, True);
end;

Just makes the script look less botty when run.


And IMO I find FindObjTPA is much better than FindObjCustom, because I think that FindObjCustom doesn't really take much skill TBH.


Apply for members, I'm 80% sure they'll accept you.

TheMagicCookie

2008-04-07 16:59:06

ehm…it runs to mining spot. than just stands there and i couldnt find option to pick what rock to mine.

faster789

2008-04-07 19:56:53

Thanks for the advice guys,
@TheMagicCookie
go to junior member scripts for mining, new version there..