SRL Archive - SRL Archives

Find Color's Are still broken


king vash

2008-04-05 21:36:31

Some one changed the ranges on find colors and it their still wrong

Water
if Green - Red <= 33 then if Green - Red >= 18 then
if Blue - Red >= 55 then if Blue - Red <= 72 then
if Blue - Green >= 33 then if Blue - Green <= 52 then
FallyRoad
if Red - Blue >= 18 then if Red - Blue <= 33 then
if Red - Green <= 15 then if Red - Green >= 0 then
if Green - Blue >= 8 then if Green - Blue <= 30 then

if you want to use these they go in includes\srl\srl\coreAutoColor.scar and under FindWaterColor and FindFallyRoadColor

MylesMadness

2008-04-06 08:43:49

Did you test or did you copy your own work. Maybe tara found that was useless.

tarajunky

2008-04-06 14:11:15

I updated it to whatever was posted. I haven't had time to do any testing at all. In the past what I have done is find the max range, and then add 5 more each direction. So if it needs to be 18-33, make it 13-38 and then just test to see if it's still specific for the water color. As long as you don't start picking up lots of wrong colors, widening the range isn't a problem.

I won't be able to do this myself, so I'm hoping someone will show some initiative.

king vash

2008-04-06 16:58:19

The ranges I have above were tested! I would go to a random world using smart log in and look for FallyRoad and Water if it would them then repeat, if it didn't the it saved a sceneshot and i constructed the ranges using the sceneshots, what i have works really well, but is in rev 15 isn't great

and tarajunky I added 2 beyond what i found but i tested i think 100 times so i'm pretty confident in my ranges and i updated them once is probable why you had the wrong ones

EvilChicken!

2008-04-06 17:04:33

So, just post the new FindWater/RoadColor for leechers, vash. Would you do that? Eh? Post the full functions? The complete functiuons? Eh?

king vash

2008-04-22 02:08:31

Color := [12096892,12228735,11504240,12096892,12162941,7372685];
this week meaning findwatercolor needs to be changed again

king vash

2008-04-22 19:52:10

rev 16 fixed almost all the issue,

FindWater still needs to be tweaked a little

if Green - Red <= 28 then if Green - Red >= 14 then

FindFallyRoad

if Red - Green <= 14 then if Red - Green >= 0 then



also can some one change it to be uniform so that the lower side is listed first
if x-y >= z then if x-y <= w then
versus switching back and forth the order their listed (Green - Red is high then low, Blue - Red is low then high)

tarajunky

2008-04-23 03:18:18

Looks like they tweaked the RockColors too.

New value after comparison should be - 723980.

I'm guessing they're planning to do this kind of stuff weekly for the forseeable future. It really shows that they literally have nothing capable of detecting or stopping the vast majority of SCAR scripts, so they resort to this amatuerish stuff.

HyperSecret

2008-04-23 03:34:15

same with the bridgecolor ;) they have been changing values in updates, i was using your values tara to compare to and i found a 3rd difference between the light and dark bridge colors, if you want to add to LAME like i did the 3rd is

TestColor + 68877

it may just now be wiser to create your own autocoloring functions and put in scripts so if they fail you can easily fix it, that is what i am doing with my woodcutter im working on and plan to release soon,

i have my own BridgeColor, WallColor (even though they arent in SRL) also my own WaterColor

tarajunky

2008-04-23 11:51:40

My guess is that the "old" autocolor functions that don't compare colors would still work with the new colors they're shifting around.

So yeah, make your own autocolor functions and they should be fine, despite the futile updates.

the scar noob

2008-04-23 15:32:24

Tested the new values, and it works fine now:)

Using LAME now atm;)

-Tsn.

HellBoyz

2008-04-24 03:15:51

Does anyone know the FindStoneColor tweak?

tarajunky

2008-04-24 10:11:16

Let me explain how FindRockColor and FindStoneColor work. Each Rock/Stone has one big chunk of uniform color in it. That chunk of color is the one it's searching for, and when you use the function, that's the number it returns. In the function, that's the "TestColor".

Immediately to the left of that chunk of color is a second, darker color. By comparing the two colors, it confirms that the color is correct. So, if the function ever breaks due to a color update, all you have to do is pick the Rock/Stone color, and the color immediately to the left of it and compare them. If the number changed, then you need to tweak the function for it to work correctly.

Note that depending on the RGB values chosen by Jagex, sometimes the colors can have two different relationships. I believe this is caused by the non-linearity between SCAR colors and RGB colors. Most color pairs have 1 fixed value between them. Some have 2. And some may even have 3.

Don't forget that once you load a world, all these colors should remain stable. So one low tech solution is to simply reload the world until your script autocolors itself correctly. As long as you have one valid comparison, it should work sooner or later.

faster789

2008-04-24 23:45:05

:confused: umm I just wana get the eye of newter working so can someone explain how to change the autocolor.scar to work so the script will work?
thanks

Ashur2Good

2008-04-27 01:59:16

hey som1 care 2 expan on rock color fix im i just changing GC := 6444639 to this GC := 723980. and whats the stone colour fix if there is 1 bit confused

EDIT: sorry guys lol my bad all fixed :)