This is a very good script for your first one. I only saw a few problems.
your attack mode procedures can be condensed in to a case:
procedure SetAttackMode;
begin
Case Players[CurrentPlayer].Skill Of
'Strength' :
SetFightMode(2);
'Attack' :
SetFightMode(1);
'Defence' :
SetFightMode(4);
end;
end;
Your main loops standards are a bit odd. I fixed them up a bit:
begin
SetupSRL;
SmartSetupEx(World, false, false);
wait(10000+random(5000));
SetTargetDC(SmartGetDC);
repeat
wait(100);
until(SmartGetColor(253, 233)<>1118604);
DisguiseIt;
DeclarePlayers;
MarkTime(NextPlayerTime);
SetUpPlayers;
repeat
KillChicken;
SetAttackMode;
Wait(200 + Random(32));
ClearDebug;
Proggie;
AntiBan;
If (TimeFromMark(NextPlayerTime) > 14 * 10000) then
begin
Wait(7000 + Random(5000));
Logout;
NextPlayer(True);
end;
Until(False);
end.
You should make a separate procedure for your antiban instead of just having it in your main loop:
procedure AntiBan;
begin
case random(250) of
0: OutOfScreen(4000 + Random(2000));
1: RandomRClick;
2: BoredHuman;
end;
end;
Another thing is that the functions that you made should be made into procedures since you never use the result.
Also cases start at 0:, not 1:.
One more thing, I noticed that some of your standards were off in a few of your other procedures. I fixed them for you:
Procedure KillChicken;
begin
If not LoggedIn then exit;
If (InFight = False) then
begin
If FindObjCustom(x, y, ['ttack', 'hicken'], [3628151, 6521491], 5) then
begin
Mouse(x,y,2,2,true);
PickupFeathers;
Chickens:= Chickens + 1;
FindNormalRandoms;
end;
end;
end;
Procedure SetUpPlayers;
begin
If not LoggedIn then LoginPlayer;
GameTab(4);
SetAngle(true);
case random(3) of
0: HoverSkill('strength',false);
1: HoverSkill('attack',false);
2: HoverSkill('defence',false);
end;
end;