SRL Archive - RS3 Outdated / Broken Scripts

AutoTyper


KoKouKo

2008-02-13 21:58:48

Drag the crosshair onto the screen
Wait for the form
Fill in the form and run

Tell me if anythings wrong with the script, all I've fully tested is the form and a previous version

Cazax

2008-02-14 06:56:43

good work. Keep on coding

KoKouKo

2008-02-14 20:01:45

thanks

i dont know if its just me but theres a procedure that checks your setup that doesnt work properly

malotthouse

2008-02-14 20:29:49

Looks like a nice bit of code,

on the leecher point, i wouldn't consider you a leecher because of your postcount and activity.

unless they were all spam. then id kill you.

my only suggestion would be maybe instead of terminating the script, you should make it pause until the person hits a key again. like so:

procedure AcceptATrade;
begin
if(AcceptTrade1=True)then AcceptTrade;
if(TradeScreen)then
begin
Report;
repeat
wait(5000);
until(IsFKeyDown(9))//this waits until f9 is pushed to continue
end;
end;

idk if thats completely right, but if you did that then you wouldn't have to restart the script after trading.

KoKouKo

2008-02-14 22:34:03

thanks for the idea

footballjds

2008-02-23 09:28:19

on line 141 you have "if(KeepTyping=False)then", why not "if not(KeepTyping)then"?

EDIT1: you have:
if(not(Color=''))or(not(Color='white'))or(not(Color='cyan'))or
(not(Color='yellow'))or(not(Color='red'))or(not(Color='purple'))or
(not(Color='green'))or(not(Color='flash1'))or(not(Color='flash2'))or
(not(Color='flash3'))or(not(Color='glow1'))or(not(Color='glow2'))or
(not(Color='glow3'))then
when using not you need to have AND instead of OR ;), just think throught the logic youl realize it;).
EDIT2: bad standards ;):
this\/
const
Color = 'Color'; // Leave blank for no color, don't add a colon
Effect = 'Effect'; // Leave blank for no effect, don't add a colon
ToType = 'Message'; // Message to type
TimesToType = 0; // How many TimesToType 0 to not use this
AcceptTrade1 = True; // Accept trade when a trade is offered
KeepTyping = True; // Will typing when trade screen is closed
// leave both 'TimesToTrade' to 0 and 'AcceptTrade1' to False
// if you want the script to go forever and ever and ever and never stop
ThisVersion = '1.5';
should be\/
const
Color = 'Color'; // Leave blank for no color, don't add a colon
Effect = 'Effect'; // Leave blank for no effect, don't add a colon
ToType = 'Message'; // Message to type
TimesToType = 0; // How many TimesToType 0 to not use this
AcceptTrade1 = True; // Accept trade when a trade is offered
KeepTyping = True; // Will typing when trade screen is closed
// leave both 'TimesToTrade' to 0 and 'AcceptTrade1' to False
// if you want the script to go forever and ever and ever and never stop
ThisVersion = '1.5';

EDIT3: the same goes for your effect check, you need,
if not(blah) and not(blah)
ect…. or
 if not((blah) or (blah) or (blah)) 
;)

EDIT4: i see you realized you got it wrong so you never called it ;), maybe fix bugs instead of avoiding them :D, anyhow, these were just a few of the things i noticed :)

KoKouKo

2008-02-24 20:07:01

thanks, i realy only made it to sell yew longs i amde with your script (xD) then i just quickly added that stuff to make it r-tard proof and put it up here, then it slowly evolved to what it is now

footballjds

2008-02-24 22:15:25

From: KoKouKo
thanks, i realy only made it to sell yew longs i amde with your script (xD) then i just quickly added that stuff to make it r-tard proof and put it up here, then it slowly evolved to what it is now


YAY! *gets a big head from the compliments* :D. glad you like it, and you also got 99 fletching :D. il have to add your name ;), thats 3 people so far WOOT!

KoKouKo

2008-03-30 19:11:33

Yea I know its a bit of a Grave Dig, but hey it's my own thread;

v3 uploaded
changes:
theres a form