SRL Archive - RS3 Outdated / Broken Scripts

Al-Kharid Fish Cooker!


Cazax

2008-01-23 14:12:17

Al-Kharid Fish Cooker!
——————————————————————-
Current Version: 0.3-


Features:
Multiplayer;
Anti-Randoms;
Anti-Ban;
SymbolWalk;
And more..
—————————————————————————–
Instuctions for V 0.1:
This Version Works with: Shrimps,Anchovies,Trouts,Salmons,Tunas,Lobbies and Swories
Start in Al kharid bank, raw fish in first bank slot, START LOGGED IN, post proggies and bugs(i know that there are bugs post here)
———————————————————————–
Changes between V 0.1 and V 0.2 : V 0.2 have more failsafes, Better Antiban and the script now have standars.
———————————————————————–
Instructions for V 0.2:
This Version Works with:
Shrimps,Anchovies,Trouts,Salmons,Tunas,Lobbies and Swories
Start in Al kharid bank, raw fish in first bank slot, START LOGGED IN OR LOGGED OUT(new) , post proggies and bugs(i know that there are bugs post here)
————————————————————————–
Changes between V 0.2 and V 0.3 : V 0.3 have better failsafes and now work quite good.
————————————————————————-
Instructions for V 0.3:
The same as V 0.2


Credits to:
JuKKa
EvilChicken
gerauchert
ummmmm0k
Gumleren
Kold( special thank to him for the idea )


—————————————————————-

gerauchert

2008-01-23 14:46:08

hey you credited me! for what lol? :D

Not bad for your second script man. Taking a look at it though I will give you some strong suggestions.

You dont need FindFastRandoms anymore. FindNormalRandoms covers all that now. You should make a running away thing just in case you are in a fight though.


Your antiban procedure:

procedure AntiBannage;
begin
if(not(LoggedIn))then
Exit;
case Random(13) of

0: TypeSend('lol');

1: begin
GetSkillInfo('Fishing', false);
wait(2000+random(1000));
GameTab(4);
end;

2: begin
GetSkillInfo('Cooking', false);
wait(2000+random(1000));
GameTab(4);
end;

3: SleepAndMoveMouse(1250+random(458));

4: TypeSend('ty');

5: BoredHuman;

6: PickUpMouse;

7: TypeSend('i want lvl up now!')

8: begin
GameTab(1 + Random(12));
wait(1000+random(1000));
GameTab(4);
end;

9: begin
case random(4) of
0: TypeSend('Fishing lvls?');

1: TypeSend('Fishing levels');

2: TypeSend('Cooking lvls');

3: TypeSend('Cooking levels');
end;
end;

10: TypeSend('i love rap');

11: TypeSend('Why?')

12: TypeSend('sell law rune 5k ea lol');

end;
end;

You will be reported and banned if you use this. This is because every time this is called it will do at least one of the case statements. What happens when nobody is in there with you and it types "Fishing lvls?" … or what happens when nobody is talking and it types "Why". Talking is very repetitive
even though it is randomized. To fix this, just take out all of the talking procedures and if you are concerned with talking maybe add in an auto responder from someone. Also change the:

case random(13) of

to something alot higher so it wont antiban EVERY time…

so something like this:

procedure AntiBannage;
begin
if(not(LoggedIn))then
Exit;
case Random(40) of
1: begin
GetSkillInfo('Fishing', false);
wait(2000+random(1000));
GameTab(4);
end;
2: begin
GetSkillInfo('Cooking', false);
wait(2000+random(1000));
GameTab(4);
end;
3: SleepAndMoveMouse(1250+random(458));
5: BoredHuman;
6: PickUpMouse;
8: begin
GameTab(1 + Random(12));
wait(1000+random(1000));
GameTab(4);
end;
end;
end;

Also I would say that you need failsafes. It is a must have in order for your script to run smoothly. Pretty much make a failsafe for every DTM search or any search/click for that matter…so if something goes wrong it will auto-correct or logout.

Other than those things, I think you are on a good path to scripting so keep up the good work! :D

Cazax

2008-01-23 15:01:22

From: gerauchert
hey you credited me! for what lol? :D

Not bad for your second script man. Taking a look at it though I will give you some strong suggestions.

You dont need FindFastRandoms anymore. FindNormalRandoms covers all that now. You should make a running away thing just in case you are in a fight though.


Your antiban procedure:

procedure AntiBannage;
begin
if(not(LoggedIn))then
Exit;
case Random(13) of

0: TypeSend('lol');

1: begin
GetSkillInfo('Fishing', false);
wait(2000+random(1000));
GameTab(4);
end;

2: begin
GetSkillInfo('Cooking', false);
wait(2000+random(1000));
GameTab(4);
end;

3: SleepAndMoveMouse(1250+random(458));

4: TypeSend('ty');

5: BoredHuman;

6: PickUpMouse;

7: TypeSend('i want lvl up now!')

8: begin
GameTab(1 + Random(12));
wait(1000+random(1000));
GameTab(4);
end;

9: begin
case random(4) of
0: TypeSend('Fishing lvls?');

1: TypeSend('Fishing levels');

2: TypeSend('Cooking lvls');

3: TypeSend('Cooking levels');
end;
end;

10: TypeSend('i love rap');

11: TypeSend('Why?')

12: TypeSend('sell law rune 5k ea lol');

end;
end;

You will be reported and banned if you use this. This is because every time this is called it will do at least one of the case statements. What happens when nobody is in there with you and it types "Fishing lvls?" … or what happens when nobody is talking and it types "Why". Talking is very repetitive
even though it is randomized. To fix this, just take out all of the talking procedures and if you are concerned with talking maybe add in an auto responder from someone. Also change the:

case random(13) of

to something alot higher so it wont antiban EVERY time…

so something like this:

procedure AntiBannage;
begin
if(not(LoggedIn))then
Exit;
case Random(40) of
1: begin
GetSkillInfo('Fishing', false);
wait(2000+random(1000));
GameTab(4);
end;
2: begin
GetSkillInfo('Cooking', false);
wait(2000+random(1000));
GameTab(4);
end;
3: SleepAndMoveMouse(1250+random(458));
5: BoredHuman;
6: PickUpMouse;
8: begin
GameTab(1 + Random(12));
wait(1000+random(1000));
GameTab(4);
end;
end;
end;

Also I would say that you need failsafes. It is a must have in order for your script to run smoothly. Pretty much make a failsafe for every DTM search or any search/click for that matter…so if something goes wrong it will auto-correct or logout.

Other than those things, I think you are on a good path to scripting so keep up the good work! :D


Thnks. those 'Strong Suggestions' will be in the next version of the script. now i can credit you :P :)

Gumleren

2008-01-23 16:53:27

Oh, by the way, in line 302 you've misspelled SetupSRL. It looks good though. With gerauchert suggestions it would be pretty neat, I'd say.

In order to make the code easier to read (and thereby making it easier to repair and such) do some more carriage returns. For example between the end; in line 300 and the begin in the line right after. Also the space between line 298 and 300 doesn't make it easier to read. There's many more of those kind of visual "errors" all over the script, I just picked out a random one.

Cazax

2008-01-23 19:03:21

From: Gumleren
Oh, by the way, in line 302 you've misspelled SetupSRL. It looks good though. With gerauchert suggestions it would be pretty neat, I'd say.

In order to make the code easier to read (and thereby making it easier to repair and such) do some more carriage returns. For example between the end; in line 300 and the begin in the line right after. Also the space between line 298 and 300 doesn't make it easier to read. There's many more of those kind of visual "errors" all over the script, I just picked out a random one.


kk ill fix the whole script in the next version

Kold

2008-01-23 19:12:31

Thanks for making this but I agree with the others that it needs a bit more work.

Cazax

2008-01-24 11:13:46

V 0.2 RELEASED!

More Failsafes, Better anti ban, and the script have standars.

Kold

2008-01-24 11:15:04

Ok, I'll check it out when I get home from school.

Oh, teehee you credited me. ^_^

gerauchert

2008-01-24 14:46:12

your new version is lookin a lil better :p

I suggest that you run heavy testing on it and whenever it messes up, add in a failsafe to counter it… until it is able to run for long periods of time with no errors.

Remember when you are putting in a NextPlayer(False) failsafe, make sure you put an "Exit" after it otherwise the new logged in player will start where the old one left off…seriously messes up the rotation ;)

Keep up the good work dude :)

Cazax

2008-01-24 15:04:28

From: gerauchert
your new version is lookin a lil better :p

I suggest that you run heavy testing on it and whenever it messes up, add in a failsafe to counter it… until it is able to run for long periods of time with no errors.

Remember when you are putting in a NextPlayer(False) failsafe, make sure you put an "Exit" after it otherwise the new logged in player will start where the old one left off…seriously messes up the rotation ;)

Keep up the good work dude :)


ok, next version should have those recomendations :rolleyes:

Kold

2008-01-24 18:41:02

It was good for a while. I started logged in, (starting logged out gave me errors).

It checked some gametabs, went to the lowest angle, moved around a bit and then opened the bank. It pulled out some trout and then I got a runtime error.

[Runtime Error] : Out Of Range in line 1443 in script C:\SCAR 3.12\includes\SRL/SRL/Core/AntiRandoms/AntiRandoms.scar

Cazax

2008-01-24 18:54:11

From: Kold
It was good for a while. I started logged in, (starting logged out gave me errors).

It checked some gametabs, went to the lowest angle, moved around a bit and then opened the bank. It pulled out some trout and then I got a runtime error.

[Runtime Error] : Out Of Range in line 1443 in script C:\SCAR 3.12\includes\SRL/SRL/Core/AntiRandoms/AntiRandoms.scar

i know that. the next version will work fine ;)

Kold

2008-01-24 19:14:58

Well cough it out then!

I need 65,000 trout cooked… V_V

Cazax

2008-01-25 12:01:29

im working hard on it

EDIT: tomorrow ill post the V 0.3 cuz i am working hard on the script

Cazax

2008-01-27 11:25:14

Finally V 0.3 Released!

kingarabian

2008-02-06 16:48:11

Nickname BMP is not used anymore in srl i suppose? So edit that out. Ill run it and test it and ill post the flaws and bugs.

On my private version same thing alkharid cooker, i have radialroadwalk. Want it? You can add it as another failsafe.

EDIT: The dtms need updating.

Cazax

2008-02-06 20:33:27

From: kingarabian
Nickname BMP is not used anymore in srl i suppose? So edit that out. Ill run it and test it and ill post the flaws and bugs.

On my private version same thing alkharid cooker, i have radialroadwalk. Want it? You can add it as another failsafe.

EDIT: The dtms need updating.


kingarabian, im not going to update the script anymore. thx anyways. Please, a mod or admin close this thread.

kingarabian

2008-02-07 02:24:31

From: cazax
kingarabian, im not going to update the script anymore. thx anyways. Please, a mod or admin close this thread.


May i update btw?

Cazax

2008-02-07 10:22:59

if you want… you can

NightBlade

2008-08-14 19:33:13

Line 39: [Error] (15581:1): Unknown identifier 'NickNameBMP' in script C:\Documents and Settings\Administrator\Desktop\Al-Kharid fishpwner V 0.3.scar

WithoutFear

2008-08-15 19:51:07

02-07-2008, 09:22 AM


this script is very outdated…won't work, stop gravedigging

NightBlade

2008-08-15 22:33:12

Then lock it

jkmaster

2008-08-17 23:18:33

Nightblade spam much? He's not a mod how is he supposed to lock… It can be avoided if everyone starting now stops posting and LET THIS THREAD DIE!!

Smarter Child

2008-08-21 00:57:47

From: WithoutFear
this script is very outdated…won't work, stop gravedigging


yeah seriously pplz don;t gravedig and wow this was at top of cooking thread so i don't blame them that nbdy has made a cooker in a while lol….P,s i am not gravedigging