SRL Archive - Archive

<!– BEGIN TEMPLATE: formanswers –>
Elkins121 - SRL Member Application Form
Elkins121

What is the meaning to life?


Where you Referred to SRL? If yes, by whom?
yes
Sythe from Sythe.org (I found them first…)

Programming Knowledge
Scar, Basic HTML, Some VB6

Other Communitys
Sythe, Sp0rk-Eh, Freddy1990

How Long have You Played Runescape
1.7 years

Are you affilated in anyway with Jagex LTD?
No
—————————————————–
Please write down a paragraph about Yourself.

I am trustworthy! Please accept me!

——————————————————
Please Post a Sample of your Work. Only SCAR Scripts Accepted

{.Script Info:
# ScriptName  = Al Kharid Smelter
# Author      = Elkins121
# Description = Smelts Steel Bars in Al Kharid
# Version     = 1
# Date        = 12/01/07
# Comments    = Start In Al Kharid,
                Most Northern Usable Bank Slot...
                Have Iron In First Bank Slot,
                and Coal In Second Bank Slot...
                Use ScarScape! Visit Forum Thread For Link To ScarScape Download...
/Script Info}
program New;
{.include SRL\SRL.scar}
Const StartPlayer   = 0;    // Determines who will play first
      LoadsToDo     = 5;

var DTM, Done, BarsMade, Banked: integer;
    MySRLID, MySRLPassword : string;
Procedure DeclarePlayers;
begin
  MySRLID       := '';   // Must be a string!
  MySRLPassword := '';   // Must be a string!
  HowManyPlayers:= 1; // Set Number of Players here.
  NumberOfPlayers(HowManyPlayers); // Sets the Players Array Length;
  CurrentPlayer:= StartPlayer; // CurrentPlayer = Array Index

  Players[0].Name    :='';    //username
  Players[0].Pass    :='';    //password
  Players[0].Nick    :='';       //3-4 consecutive letters of your user name(NOT First letter)
  Players[0].Pin     :=0;           //Pin number(not a string!!)
  Players[0].Active  :=True;         //are you going to use this player
end;

Function InPin2(pin:integer):Boolean;   //Thanks Xcan!!
var pinstr:string;
    star,i,x,y:integer;
    tpt1,tpt2:array[0..3] of tpoint;
begin
  if (PinScreen) then
   begin
     star := BitmapFromString2(False, 'a81C2B78DA4D8B3912C0200C0' +
         '3BF247C01A5C984FF3F29166970B1A359C90090A3007F0A61493A' +
         '8DDBCBACF4328CE66C7C07BDF0A9A7928B6DF4C63C4FA15E684B6' +
         'C1AD47EEE3AE036373F9CC');
     tpt1[0].x:=428; tpt1[0].y:=31;
     tpt2[0].x:=442; tpt2[0].y:=48;
     tpt1[1].x:=444; tpt1[1].y:=31;
     tpt2[1].x:=458; tpt2[1].y:=48;
     tpt1[2].x:=460; tpt1[2].y:=31;
     tpt2[2].x:=474; tpt2[2].y:=48;
     tpt1[3].x:=476; tpt1[3].y:=31;
     tpt2[3].x:=490; tpt2[3].y:=48;
     PinStr:=(inttostr(pin))
     mmouse(322,203,20,20);
     for i:=1 to 4 do
     begin
      wait(100+random(100));
      ClickText(pinstr[i], upchars, 1, 1, 512, 336, True);
      wait(100+random(100))
      mmouse(322,203,20,20);
      repeat
       wait(20)
       if i=4 then
        begin
         repeat
          wait(20)
         until bankscreen
         break;
        end;
       until FindBitmaptoleranceIn(star,x,y,tpt1[i-1].x,tpt1[i-1].y,tpt2[i-1].x,tpt2[i-1].y,20)
     end;
   end;
  if (bankscreen) then
   result:=true;
   freebitmap(star)
end;

procedure Smith;
begin
 FindNormalRandoms;
 Wait(2000);
 if FindObjCustom(x,y,['melt','urnace'],[3618619,4013378,3158068,4210757],1) then
  Mouse(x,y,0,0,true);
  Wait(2000);
  Mouse(265,410,0,0,false);
  ChooseOption('X');
  Wait(1000);
  TypeSend('9');
   repeat
   Wait(1000);
   ClickToContinue;
   FindNormalRandoms;
   HoverSkill('random',false);
   InvCount;
   ClearDebug;
   until(InvCount=9)
 BarsMade:=BarsMade+9;
 ReportVars[0] := ReportVars[0] + 9;
end;

procedure One;
begin
 OpenBankFast('akb');
 Wait(2000);
 if not (players[currentplayer].pin = 0) then
  begin
  InPin2(Players[CurrentPlayer].Pin);
  end;
 FixBank;
 DepositAll;
 Withdraw(1,1,9);
 Withdraw(2,1,18);
 CloseBank;
 FindNormalRandoms;
end;

procedure Two;
begin
 if FindSymbol(x,y,'cook') then
  Mouse(x+2,y+2,0,0,true);
  Flag;
  if FindDTM(DTM,x,y,mmx1,mmy1,mmx2,mmy2) then
   Mouse(x+6,y,0,0,true);
   Flag;
   if FindSymbol(x,y,'bank') then
    Mouse(x,y,0,0,true);
    Flag;
    OpenBankFast('akb');
    if not (players[currentplayer].pin = 0) then
     begin
     InPin2(Players[CurrentPlayer].Pin);
     end;
 Wait(2000);
 FixBank;
 DepositAll;
 Banked:=Banked+1;
 CloseBank;
 FindNormalRandoms;
 Done:=Done+1;
end;

procedure Randomness;
begin
 if FindSymbol(x,y,'cook') then
  Mouse(x+2,y+2,0,0,true);
  Flag;
  Mouse(660,55,0,0,true);
  Flag;
  Flag;
  FindNormalRandoms;
 Smith;
end;

procedure ProggyReport;
begin
 ChangeReportWidth(280);
 ClearReport;
 AddToReport('--Bars Made  ' + IntToStr(BarsMade) + ' --');
 AddToReport('-Loads Done  ' + IntToStr(Done) + ' -');
 AddToReport('-----Banked  ' + IntToStr(Banked) + ' time(s).-----');
end;

procedure RunIt;
begin
  DTM := DTMFromString('78DA632C676260F0644001FFFEF1816946289' +
      'FB10EA8C61255CD9327EF50D510634E0195CC2903AA094255F3E7' +
      '0F138A1A00D62F1205');
 repeat
 One;
 Randomness;
 Two;
 ProggyReport;
 ReportVars[1] := ReportVars[1] + 1;
 SendSRLReport;
 until(Done=LoadsToDo);
end;

begin
 SetupSRL;
 if (MySRLID='') then
  begin
  MySRLID:='3506';
  MySRLPassword:='Smeltation';
  end;
 SRLID:=MySRLID;
 SRLPassword:=MYSRLPASSWORD;
 ScriptID:='501';
 DeclarePlayers;
  if not loggedin then
  LoginPlayer;
  ReportVars[2] := ReportVars[2] + 1;
 RunIt;
end.

——————————————————
<!– END TEMPLATE: formanswers –>

It is too simple, sorry, but its a no from me.

However, you are getting close, it just needs to be a bit longer, more advanced and complex.

Also your standards need fixing.

Maybe this is early to say, but wait a month, use it to read tutorials and make a kickass script, remember to use multiplayer.

Same as n3ss3s.

Something I forgot to say, and if I'd edit it there it wouldn't propably be read, so, also you may think why do we care about did you then have standards or not, always maybe isn't about how bad it looks, ofcourse it decreases readability if you don't have them, but in my case, I think more of that did you do something you knew you were supposed to, to accomplish something?

:)

too short/small =P

repeating like n3ss hehe

You're realy close to member! but where just looking for a little bit more…
cya in one moth,, with a kick ass script pl0x :)

You're realy close to member! but where just looking for a little bit more…
cya in one moth,, with a kick ass script pl0x

So you can't just admit I pwn?

Anyway, pseudoclosed.

*NOTE: Pseudoclose can be bypassed if you have something real to say, otherwise it doesn't let you go :) *

But I tried to add standards…And also, thanks to all comments…
If any of you can help me (give extra comments or help) to make this script 'more' advanced, please feel free :-p

And to p1nky, I don't feel anything is short, as long as it gets the job done…Lol…that sounded awkward…

Uh sorry, but you don't seem to know, we look here more at the code than does it get the job done/ runtime…

You should be looking at how effective the script is to the world of runescape and SRL, not just how it was made…

From: Elkins121
You should be looking at how effective the script is to the world of runescape and SRL, not just how it was made…

if we looked that way than everyone could have made a autotalker?
……
so just listen to us we telling you for the good of you =X
;)

and its true its hardly 130-160 lines =p so that what short means:duh:

AND THATS WHAT SRL IS ALL ABOUT…… coding =P and learn if you think like that than this community wouldnt been all so great =)

thanks

But the effectiveness is more important than neatness and extravagance imho.

From: Elkins121
You should be looking at how effective the script is to the world of runescape and SRL, not just how it was made…

From: Elkins121
But the effectiveness is more important than neatness and extravagance imho.

Um, but how effective is your script, when it is about to smith the bars, you get a strange box, the random handler fails, and it clicks on the first inventory spot because you use coordinates…then it gets stuck in the loop, because you don't have a failsafe in that procedure?

We are just trying to give you constructive criticism here, whether you can be humble and learn to make positive changes is up to you…

~RAM

edit:not a perfect example in theory, but you get the idea…hopefully

Ok, understood.

2 Yes
4 No
Poll Expired .
TONS of feedback given.
Good luck on making another/ fixing up this script.
Keep working at it, take all the feedback, and you'll get in next time.