John Smith.
by munkThis script will smith at the anvils below Varrock West Bank. It will smelt any bar, and any item. Instructions are included in the script.
Updates:v8 - Idk why but I opened this script up and just started rewriting. I tested and now it works alot better. Finding anvil is now a TPA, wont find iron/steel armor anymore. The smithing screen is all fixed up, it wont click the wrong item ever. Super Symbol finding for faster walking! If there was ever a time to smith some bars, this is it:D
v7 - rev#14 fixes
v6 - Fixed for rev#12, along with a little spruce up.
v5 - Fixed mith and addy smithing. Fixed Chainbody. Added 'full' setting to make full sets of armor(plate,legs,kite,fullhelm).
v4 - All fixed up to work beautifully. Please tell me how it works and dont just leech.
v3 - Quick fixes of the new smithing screen. Fixed false bar counting(logging out).
v2 - I wrote a custom bank finding function that will find the bank slot the player is standing in. Got rid of 'random' setting and added 'auto' which will smith the highest item you can with the players level. Simple touch-ups.
John Smith
ran for 16 Hours, 3 Minutes and 42 Seconds
smithed 5371 steel bars
^coollukehand, I wrote him a quick arrowtip fix:D
Sp0rky
2007-10-24 23:42:54
Looks sex-eh.
I'll be sure to test. =)
NiCbaZ
2007-10-25 01:56:26
looks nice testing now btw please fix your cooker the bank procedure that all that need fixing
tested did 1 load before it banked it just logged off
Successfully compiled
File access error
SRL Compiled in 47 msec
John Smith
ran for 18 Seconds\
please help!
John Smith
ran for 1 Minutes and 6 Seconds
smithed 25 steel bars
NextPlayer
lolpie
2007-10-25 02:04:57
YES, SOMEONE FINALLY MADE A SMITHER!
I will post proggies after leaving it on overnight :)
kushal
2007-10-25 05:07:07
i think u meant smith not smelt?
coollukehand
2007-10-25 10:31:46
you have been reading my mind, only took a second huh, anyway I was working on agent smith thanks and i will post a proggy soon
:) :) :)
I added arrowheads added it in line up as 17 and added it in case area. Will that work? also can you add bank pin I hav etried in past on other scripts and screwed it up, or point me in the right direction. I use this for making arrows to sell
Thanks so much
n3ss3s
2007-10-25 10:43:41
YES, SOMEONE FINALLY MADE A SMITHER!
Fakawis Agent Smith :confused:
Good job munk, I've been thinking of making a varrock smither too, they seem to "attract orange cats" :rolleyes:
0mg 7h1s pwn5. 7h4nk5 Mu()k.
->{N4()m4n}<-
pl0x¬!
lolpie
2007-10-25 11:36:39
John Smith
ran for 50 Minutes and 9 Seconds
smithed 450 steel bars
You should add an option where it logs out after x number of trips. You would get less randoms that way.
John Smith
ran for 2 Hours, 48 Minutes and 25 Seconds
smithed 1520 steel bars
/~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\
| SRL 4 Randoms Report |
| www.srl-forums.com |
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
| SRL Logs : 26 |
| Boxes Solved : 35 |
\~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~/
For some reason it logs out in front of the bank, logs back in, goes to the center of the bank, logs out, logs back in, then banks repeatedly :(
deathie
2007-10-25 14:48:43
OMG … wonderful!
John Smith
ran for 9 Minutes and 49 Seconds
smithed 108 iron bars
had to stop it (I'm at school lol) and I modified it to do iron knives, I'll post a longer proggy later.
Harry
2007-10-25 15:22:11
Very good! :) And now you got a scripting cup! I look foward to more good finctions and scripts from you :D Maybe make an Al-Kyraid Smelter to go along with it? :D
thanks everyone. I really appreciate all feedback cause this script still needs alot of work, and id like to make things according to how people want it. So lemme know anything you think is valid.
@kushal - :o thx, i fixed it.
@coollukehand - actually I think I wrote for bankpins in the bank procedure. all you gotta do is add:
players[#].pin = 9999;
to each player. i just forgot to add that because ive never had a character with a bank pin before.
@naumanakhlaq - j00 |2 \/\/31c0|\/|3
@lolpie - it will log out every 20 minutes, and if there is only 1 player it will wait a minute before it logs back in. I dont have any idea why it would logout, log in, logout, then bank repeatedly or whatever. Im still doing alot of work on this script.
@hy - (h) i was going to make a smelter/smither hybrid, but Xcans smelter works so good, I decided to just use that for my smelting and work harder on this script.
post feedback/proggys!!:D
XcanadamanX
2007-10-25 16:21:13
From: munk
@hy - (h) i was going to make a smelter/smither hybrid, but Xcans smelter works so good, I decided to just use that for my smelting and work harder on this script.
sweet…now i dont have to make one for my 3k bronze bars im going to smith.
i'll post some feedback once i get to using it.
NiCbaZ
2007-10-25 17:23:16
From: nicbaz
looks nice testing now btw please fix your cooker the bank procedure that all that need fixing
tested did 1 load before it banked it just logged off
Successfully compiled
File access error
SRL Compiled in 47 msec
John Smith
ran for 18 Seconds\
please help!
John Smith
ran for 1 Minutes and 6 Seconds
smithed 25 steel bars
NextPlayer
people help?
omfg help people please dose 1 load gets to bank and logs off befor banking help!!!!!!!!!!!
XcanadamanX
2007-10-25 17:28:58
you got a file access error… close scar and try again.
deathie
2007-10-25 22:58:50
Proggies:
John Smith
ran for 29 Minutes and 38 Seconds
smithed 324 iron bars
John Smith
ran for 25 Minutes and 5 Seconds
smithed 290 iron bars
From the test runs I am so impressed. Its walking to the anvils and getting to the bank is flawless. One part that could be made more efficient is the part of the script that finds the bank teller. It often finds the bank teller that is a lil further than the character. Oh and I added the ability to smith all members stuff into the script and antiban.
NiCbaZ
2007-10-26 02:28:07
it already had anti ban….
lolpie
2007-10-26 13:00:47
John Smith
ran for 2 Hours, 41 Minutes and 12 Seconds
smithed 2230 steel bars
/~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\
| SRL 4 Randoms Report |
| www.srl-forums.com |
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
| SRL Logs : 97 |
\~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~/
Nice
Nose Smasher
2007-10-26 15:29:27
Looks good, I'll dl it and test later (when I'm on my other comp later)
Thanks =)
coollukehand
2007-10-26 17:24:48
Alright I maybe stupid but i added this Arrowtips in both places but pulls mith bars goes to anvil and seems not to be able to find arrowtips
Any suggestions????
case random(18) of
0: item:='dagger';
1: item:='axe';
2: item:='mace';
3: item:='medhelm';
4: item:='sword';
5: item:='arrowtips';
6: item:='scimitar';
7: item:='longsword';
8: item:='fullhelm';
9: item:='sqshield';
10: item:='warhammer';
11: item:='battleaxe';
12: item:='chainbody';
13: item:='kiteshield';
14: item:='twohander';
15: item:='platelegs';
16: item:='plateskirt';
17: item:='platebody';
end;
'arrowtips': begin
smithText:='arro';
barsNeeded:=1;
end;
'scimitar': begin
smithText:='cim';
barsNeeded:=2;
end;
'longsword': begin
smithText:='ong';
barsNeeded:=2;
end;
'fullhelm': begin
smithText:='ull';
barsNeeded:=2;
end;
NiCbaZ
2007-10-26 18:54:54
From: nicbaz
people help?
omfg help people please dose 1 load gets to bank and logs off befor banking help!!!!!!!!!!!
Munk please help me
lolpie
2007-10-26 20:06:44
That happens…just wait for a while and it'll log back in and continue
Victim14
2007-10-27 00:24:18
I will probably use this to smith some arrowheads and I LOVE the name! :D
NiCbaZ
2007-10-27 05:23:21
From: lolpie
That happens…just wait for a while and it'll log back in and continue
no it executes
ShowerThoughts
2007-10-27 06:25:35
nice, lol your first is almost copied from wt-fawaki's agent smith :p but nice you updated it to srl 4 i thought about it to but i forgot it :(
lolpie
2007-10-27 20:11:05
This script got me to 60 smithing…gj :)
Lacky
2007-10-27 21:18:07
From: n3ss3s
Fakawis Agent Smith :confused:
Good job munk, I've been thinking of making a varrock smither too, they seem to "attract orange cats" :rolleyes:
Orange cats? You wouldn't be talking about
him now would you?
anonymity
2007-10-27 21:24:26
/////////////////////////////////
Originally Posted by n3ss3s
Fakawis Agent Smith
Good job munk, I've been thinking of making a varrock smither too, they seem to "attract orange cats"
////////////////////////////////
Orange cats? You wouldn't be talking about him now would you?
/////////////////////////////////
Ok ….. who is him and what orange cats ¿
maybe I just don't know,
anonymity
From: lolpie
This script got me to 60 smithing…gj :)
me 58 (so far). Gotta mine more ore:D
EDIT: okay,
I dont have to mine any ores, but about 25 little pixel characters do:D
From: hermpie
nice, lol your first is almost copied from wt-fawaki's agent smith :p but nice you updated it to srl 4 i thought about it to but i forgot it :(
my first what? I actually didnt copy anything from Agent Smith, I had planned to:p but ended up not even openin it the night I wrote this script.
I will post the update when I get some more ore, and smelt it, so I have bars to test(strictly for testing;)).
NiCbaZ
2007-10-29 00:58:17
does 1 load logs off dose another load loggs off?????
coollukehand
2007-10-30 10:07:22
Thanks man for the arrowtips worked great
It does log on and off a lot almost every load
don't know why but it continues
John Smith
ran for 4 Hours, 26 Minutes and 56 Seconds
smithed 1891 mith bars
/~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\
| SRL 4 Randoms Report |
|
www.srl-forums.com |
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
| SRL Logs : 62 |
\~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~/
From: coollukehand
Thanks man for the arrowtips worked great
It does log on and off a lot almost every load
don't know why but it continues
John Smith
ran for 4 Hours, 26 Minutes and 56 Seconds
smithed 1891 mith bars
/~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\
| SRL 4 Randoms Report |
| www.srl-forums.com |
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
| SRL Logs : 62 |
\~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~/
coollukehand takes the lead with 4 hours! I was gonna ask you how that worked out for ya. Ill be adding members items soon, i just need someone to test em out. Lemme know if anyone wants to help out.
I will be posting a newer version tonight when I get home from this class. Im still figuring out why it would logout after every trip. It's never done that for me. But theres alot of good stuff in the new version.
EDIT: v2 is posted! Didn't get to everything I wanted to, but its very worth it to update.
lolpie
2007-10-31 02:17:38
Nice, can't wait to try it. Right now I need to get 80k coal and 40k iron
Harry
2007-11-01 17:50:31
I can helpy with member items :) You know my AIM.
coollukehand
2007-11-01 18:01:51
Munk I ll help with members stuff
Just let me know
coollukehand
2007-11-02 10:25:40
Still a lot of logs but it was getting the job done
I used ver 1 as I was havin a problem with arrowtips on ver 2
John Smith
ran for 16 Hours, 3 Minutes and 42 Seconds
smithed 5371 steel bars
/~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\
| SRL 4 Randoms Report |
|
www.srl-forums.com |
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~|
| SRL Logs : 245 |
| Talks : 1 |
| Old Men : 1 |
| Boxes Solved : 35 |
\~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~/
deathie
2007-11-03 02:06:21
In the login procedure you need to keep the if loggedin then begin end; part so that scar does not try to set the compass angle before done logging in. (changed in version 2.0)
procedure login;
begin
loginplayer;
wait(800);
if loggedin then
begin
findnormalrandoms;
marktime(s);
writeln('time marked as' + inttostr(s));
highestangle;
makecompass('n');
SetRun(true);
end;
end;
The bank procedurefantastic job with the find closest bank function, it does its job well
Problems:
In the for loop inside bank procedure a wait time helps lag.
wait(100+random(250)); should be enough
Oh and what is countbars<barsneeded doing in the bank procedure of the script? I think you got confused, this is why its doing a load and logging out. Just revert that part to what v1 had and works perfectly
Userkill
2007-11-06 02:05:09
Well done mate for a great script.
NiCbaZ
2007-11-06 04:20:39
still doesnt work atm
the new smithing screen stopped this script dead in its tracks. I didnt even know there was a new smith screen until I smelted 3k steel bars with a certain smelter script i may have written;) and then i went to smith them with this script, and BOOM, new smith screen. I am working on it right now, its not too much of a fix. The hardest thing will be having it scroll to find the right item. The "make All" will help though :D and i dont know why, but on the smith screen, the item names are all in statchars like before the update, but now chainbody is in chatchars? is that their big plan to stop auto smithers?
EDIT: v3 fixes up the new smithing screen. also to Nicbaz, i figured out what was wrong, do you have a slow computer? it was counting the bars before they appeared in your inventory. I put an over one second wait there so it should work fine now. lemme know. This is a quick fix, i am still working on making it perfect, and i also still want to add members items.
Rompsu
2007-11-06 18:29:45
I downloaded version 3 and start off in the bank with a hammer and bars. It goes to the anvils and makes what I requested, but then it goes back to the bank and instead of clicking the window to bank and get more bars it logs out…
Would be great for some help :)
mark9510
2007-11-06 18:53:19
i reccomend u add a setting that will have it make full of any armor
marksteele
2007-11-09 20:28:47
John Smith
ran for 15 Minutes and 41 Seconds
smithed 400 iron bars
it runs well I had no problems with it with the exeption of a few randoms it couldnt solve.
mschlott
2007-11-20 16:13:09
This seems to be the most popular current smithing tool here, but I can't get it to run.
Most of the time, it will bank, withdraw my mith bars, go to the anvil, use the mith on the anvil, then hang. My CPU goes to 100% usage then nothing.
I have tried selecting auto and mace for the item. No difference.
I am using SCAR 3.12, SRL 6 runing johnSmith_v3.scar.
Any tips?
the scar noob
2007-11-20 16:37:05
From: mschlott
This seems to be the most popular current smithing tool here, but I can't get it to run.
Most of the time, it will bank, withdraw my mith bars, go to the anvil, use the mith on the anvil, then hang. My CPU goes to 100% usage then nothing.
I have tried selecting auto and mace for the item. No difference.
I am using SCAR 3.12, SRL 6 runing johnSmith_v3.scar.
Any tips?
This scripts haven't been updated/tweaked for a while, maybe that's the problem;)
-Tsn.
From: mschlott
This seems to be the most popular current smithing tool here, but I can't get it to run.
Most of the time, it will bank, withdraw my mith bars, go to the anvil, use the mith on the anvil, then hang. My CPU goes to 100% usage then nothing.
I have tried selecting auto and mace for the item. No difference.
I am using SCAR 3.12, SRL 6 runing johnSmith_v3.scar.
Any tips?
basically what tsn said. When the smithing screen was updated not to long ago, I did a quick fix, but I really need to go over it. I will soon after I smelt 50k coal into steel :D
EDIT: ok, i got a nice update comin.
EDIT EDIT: v4 posted. Works much better. Someone wanna give me a bump:rolleyes:
jkmaster
2007-11-25 20:09:26
ran perfectly for smithing iron and steel bars into platebodies but when i tried to smith mith shortswords it didnt do anything. it would walk to the anvil, open the smith box and stop. help? nice script though =P
From: jkmaster
ran perfectly for smithing iron and steel bars into platebodies but when i tried to smith mith shortswords it didnt do anything. it would walk to the anvil, open the smith box and stop. help? nice script though =P
who would want mith shorts anyways:p
ill look into it. They use different fonts for different items on the smith screen now. Its wierd.
awesom
2007-11-26 23:20:17
Munk your scripts always own and I have 2.5k steels to smith so I will test this out :D
awesom
2007-11-27 00:45:16
Aww was running sweet on my VM then I got bob the cat.. balloon random :(
Didn't solve maze and pinball also.
Here is my evaluation:
1. Fix Randoms.
2. Make it so it doesn't try go to next player when it is only set to 1 player. (probably easy to do I don't know how though) because I could run it like endlessly if it didn't logout from trying to go to next player.
3. Sometimes banking stuffs up a little and takes ages to find and sometimes doesn't find.
Thats about it really otherwise it is sweet with steel I am going to see how it goes with mith once I use up my now 1.5k bars was 2.5 so I've already done 1k with this script so nice.
I would post proggy but the biggest was like 20mins because of the next player thing. ;)
XcanadamanX
2007-11-27 18:05:25
maze has not been solved by the devs or anyone else.
mschlott
2007-11-27 20:01:24
From: munk
basically what tsn said. When the smithing screen was updated not to long ago, I did a quick fix, but I really need to go over it. I will soon after I smelt 50k coal into steel :D
EDIT: ok, i got a nice update comin.
EDIT EDIT: v4 posted. Works much better. Someone wanna give me a bump:rolleyes:
OK I tried V4 last night, it is still stopping when it gets to the anvil trying to smith any Mith. If I pause the script, smith what I want, then resume the script, it will take what I smithed to the bank, deposit it and start over. It seems to be having a problem picking from the smith menu.
If you want me to throw in some debug messages and try again, just let me know what you want to get out of it. I have lots of mith that need to be turned into armor.
Thanks for all your effort. A very nice script over all.
awesom
2007-11-27 21:23:46
Mith doesn't work at all steel works perfectly but would be awesome if you can fix mith
mschlott
2007-11-29 13:40:01
This will be my first actuall contribution to this forum. I'm so proud.
It appears that inside the smithing window, the text "Smithing Mithiril" is wider than the other texts and falls outside the diminsions of the findtext parameters.
I changed
result:=findText(ex,wy,'mithing',Upchars,243,29,304,54);
to
result:=findText(ex,wy,'mithing',Upchars,200,29,350,54);
and successfully smithed a load of mith battleaxes.
I may not be able to code worth a darn, but I can debug with the best of em.
Edit
After leveling up to 11, the script would not find Chainbody. It looks like the font size for Chainbody is larger than all the rest of the items. I just commented the Chainbody line and move 11 to the Kiteshield line.
//11: item:='chainbody';
12,13: item:='kiteshield';
\Edit
From: mschlott
This will be my first actuall contribution to this forum. I'm so proud.
It appears that inside the smithing window, the text "Smithing Mithiril" is wider than the other texts and falls outside the diminsions of the findtext parameters.
I changed
result:=findText(ex,wy,'mithing',Upchars,243,29,304,54);
to
result:=findText(ex,wy,'mithing',Upchars,200,29,350,54);
and successfully smithed a load of mith battleaxes.
I may not be able to code worth a darn, but I can debug with the best of em.
Edit
After leveling up to 11, the script would not find Chainbody. It looks like the font size for Chainbody is larger than all the rest of the items. I just commented the Chainbody line and move 11 to the Kiteshield line.
//11: item:='chainbody';
12,13: item:='kiteshield';
\Edit
youre the man, mschlott!!! i could not figure out why mith wasnt working. I never even though about it being the smith screen text. god damit. As for the chainbody, yes, it is in chatChars and not statChars. Dont ask me why, but it is. Im trying to figure out the most efficient way to fix that. but thank you for figuring out the mith thing!!!!
Ill do an update soon. And I am also work on mark9510's idea to make full sets. Next version should have some cool stuff in it.
EDIT: there, v5 posted with some nice fixes. enjoy.
lolpie
2007-11-30 01:04:54
For me the script always died after smithing ~500 steel bars, always saying the bank could not be found…
Running v4.
mschlott
2007-11-30 23:17:08
From: lolpie
For me the script always died after smithing ~500 steel bars, always saying the bank could not be found…
Running v4.
I haven't tried V5 yet, but last night, I smithed about 1000 bars. A few time my character got lost. I watched and saw that sometimes it was clicking to the west of the bank and smith shop instead of inside. I't recovered almost every time though. I think I induced most of the failures by interfiering with the script.
I'll try V5 tommorow.
noahthepoo
2007-12-01 04:45:20
oooooh . very nice ran 4 11hours i like it
flipsk8r1106
2007-12-01 22:14:08
can you not smith cannonballs?
mschlott
2007-12-04 16:58:59
I ran V5 over the weekend. It handled Mith much better and autoed through the levels correctly. If you are planning on selling at the grand exchange, I would modify the the auto section to skip over the less sellable items. I have a bunch of mith square shields that will not sell at the grand exchange.
I did still notice that sometimes the character does not seem to go directly to the bank or smith. He sometimes goes way out of the way. It looks like the display on the client gets twisted sometimes. North is still to the top, but the walls that used to run east and west, nologer look east and west. Has anyone else noticed this?
mschlott
2007-12-04 17:01:30
I ran V5 over the weekend. It handled Mith much better and autoed through the levels correctly. If you are planning on selling at the grand exchange, I would modify the the auto section to skip over the less sellable items. I have a bunch of mith square shields that will not sell at the grand exchange.
I did still notice that sometimes the character does not seem to go directly to the bank or smith. He sometimes goes way out of the way. It looks like the display on the client gets twisted sometimes. North is still to the top, but the walls that used to run east and west, nologer look east and west. Has anyone else noticed this?
lolpie
2007-12-09 03:06:41
0: ***** | T | -6 bars | not enough bars |
John Smith
ran for 3 Minutes and 39 Seconds
smithed -6 steel bars
NextPlayer
I got this while smithing steel :(
From: lolpie
I got this while smithing steel :(
what in the hell? did you lag real bad or something?
lolpie
2007-12-10 01:29:50
Nope, it happens every time I run the script.
And no lag btw
Lee Lok Hin
2007-12-12 04:06:40
For mine, it did'nt open the door. It just walked on the –> side to the bottom of the bank,
clicked on the anvil symbol
(*s* = anvil symbol)
/—–\
| |
| |
|_*s*|
And becuz the door was closed, it just walked to the south of the room with the anvils
/—–\
| |
| |
|_*s*|
^
|
HERE
It found the anvils, and used the iron bar with them, but as the door was closed……
you kinda get my point?
EDIT: Im such a moron… I used it at the WRONG bank.
Ignore me and my cries of ignorance XD
Thanks
EDIT AGAIN:
okay… Your prggie is strange…
0: | T | -8 bars | Bank |
John Smith
ran for 4 Minutes and 16 Seconds
smithed -8 iron bars
i didnt lag
Runeman
2008-01-23 15:58:05
Could you optimize this awesome script to Rev 10?
q3ick
2008-01-23 21:26:46
Wow looks nice I must replenish my ore's before i use this bad-baby
Malevolent33
2008-01-23 22:13:02
im not sure if this script has been updated to Rev10 but i keep getting this when i run it
Line 74: [Error] (12701:1): Unknown identifier 'highestangle' in script C:\Documents and Settings\Owner.EMIR\Desktop\johnSmith_v5.scar
yeah idk what happened with the progress report, idk why it started showing negatives. Oh well, this script will get fixed up eventually, Ive just got alot on my plate as of now, but I am going to need to use this script soon so it'll get updated:)
Malevolent33
2008-01-23 22:58:33
Alright thanks munk
Runeman
2008-01-24 09:19:42
From: munk
yeah idk what happened with the progress report, idk why it started showing negatives. Oh well, this script will get fixed up eventually, Ive just got alot on my plate as of now, but I am going to need to use this script soon so it'll get updated:)
That's good.:) :bart:
eurostylz
2008-01-31 12:05:26
Yea it runs amazing but for some odd reason once in a while it smiths b-axes :confused:
From: eurostylz
Yea it runs amazing but for some odd reason once in a while it smiths b-axes :confused:
it does that for you too? i thought it was just me. I cannot figure it out god damit. There is no reason it should do that. Ill get it one day!
eurostylz
2008-02-02 23:38:58
From: munk
it does that for you too? i thought it was just me. I cannot figure it out god damit. There is no reason it should do that. Ill get it one day!
Yea it did do that i just finished smithing 1k it was good, no b-axes, i think i might have modified the script im gunna try other load of 1k tonight before i sleep, ill let you know how it goes:D
Well, i was watching "Modern Marvels: Metal" on the History Channel, and it reminded me that I gotta fix this script. So I walked my smither's to varrock, and made the fixes in the script, and began testing. I think that they made smithing more of a random trigger or something, because It was running for about an hour and 4 out of 5 were in a random(mime, crane game, quiz, and mordaut). It was never like that when I used to run it. Anyways, I posted the update so please test and tell me if you notice alot of randoms too.
also, if anyone can figure out why it smithes b-axes instead of plates sometimes, it would be greatly appreciated. It's in the "scrollSmithWindow" procedure but i cannot figure out where and why.
JuKKa
2008-02-07 04:29:01
Jukka is impressed.
Jukka luvs munks scripts.
0: auls | T | 275 bars | not enough bars |
John Smith
ran for 17 Minutes and 15 Seconds
smithed 275 steel bars
—-
although i had 1000 steel bars in bank O_o
and full inv with bars.. Must have been lag or something.
look what uncle jukka has created for john smith!
Program Test;
{.Include SRL/SRL.Scar}
Function FindVarrokBuildingFloorColor: Integer;
Var
L, A, GC, TestColor, Red, Green, Blue : integer;
P: TPointArray;
Begin
{
3427931
3559519
}
GC := 3427931;
FindColorsSpiralTolerance(MSCX, MSCY, P, GC, MMX1, MMY1, MMX2, MMY2, 50);
L := High(P);
For a := 0 To L Do
Begin
If(Not rs_OnMinimap(p[a].x, p[a].y))Then Continue;
TestColor := GetColor(P[a].X, P[a].Y);
Red := (TestColor mod 256);
Green := ((TestColor / 256) mod 256);
Blue := ((TestColor / 256) / 256);
If(Red >= 85)And(Red <= 110)Then
If(Green >= 75)And(Green <= 85)Then
If(Blue >= 50)And(Blue <= 60)Then
If(GetColor(P[a].X + 1, P[a].Y) = TestColor)Then
If(GetColor(P[a].X, P[a].Y + 1) = TestColor)Then
If(GetColor(P[a].X + 1, P[a].Y + 1) = TestColor)Then
If(GetColor(P[a].X + 2, P[a].Y + 1) = TestColor)Then
If(GetColor(P[a].X + 2, P[a].Y + 2) = TestColor)Then
Begin
Result := TestColor;
WriteLn('Varrok building floor color = ' +
IntToStr(Result));
Exit;
End;
End;
WriteLn('Could not find Varrok building floor color!');
Result := 0;
End;
Procedure WalkToAnvil;
Var
T, X, Y: Integer;
FloorTPA: TPointArray;
Tp: TPoint;
Begin
If(Not Loggedin)Then Exit;
X := MMCX;
Y := MMCY+165;
If(FindColorSpiralTolerance(X, Y, 195836, MMCX - 20, MMY1, MMCX + 20, MMY2, 20))Then
Begin
T := FindVarrokBuildingFloorColor;
FindColorsTolerance(FloorTPA, T, X-30, Y-30, X+30, Y+30, 0);
TP := MiddleTPA(FloorTPA);
Mouse(Tp.X-5, Tp.Y-5, 5, 5, True);
Flag;
End;
End;
Begin
SetupSRL;
WalkToAnvil;
End.
i barely tested the auto color so hopefully it will work. Most of the autocolor goes to tarajunky.
From: JuKKa
Jukka is impressed.
Jukka luvs munks scripts.
0: auls | T | 275 bars | not enough bars |
John Smith
ran for 17 Minutes and 15 Seconds
smithed 275 steel bars
—-
although i had 1000 steel bars in bank O_o
and full inv with bars.. Must have been lag or something.
look what uncle jukka has created for john smith!
Program Test;
{.Include SRL/SRL.Scar}
Function FindVarrokBuildingFloorColor: Integer;
Var
L, A, GC, TestColor, Red, Green, Blue : integer;
P: TPointArray;
Begin
{
3427931
3559519
}
GC := 3427931;
FindColorsSpiralTolerance(MSCX, MSCY, P, GC, MMX1, MMY1, MMX2, MMY2, 50);
L := High(P);
For a := 0 To L Do
Begin
If(Not rs_OnMinimap(p[a].x, p[a].y))Then Continue;
TestColor := GetColor(P[a].X, P[a].Y);
Red := (TestColor mod 256);
Green := ((TestColor / 256) mod 256);
Blue := ((TestColor / 256) / 256);
If(Red >= 85)And(Red <= 110)Then
If(Green >= 75)And(Green <= 85)Then
If(Blue >= 50)And(Blue <= 60)Then
If(GetColor(P[a].X + 1, P[a].Y) = TestColor)Then
If(GetColor(P[a].X, P[a].Y + 1) = TestColor)Then
If(GetColor(P[a].X + 1, P[a].Y + 1) = TestColor)Then
If(GetColor(P[a].X + 2, P[a].Y + 1) = TestColor)Then
If(GetColor(P[a].X + 2, P[a].Y + 2) = TestColor)Then
Begin
Result := TestColor;
WriteLn('Varrok building floor color = ' +
IntToStr(Result));
Exit;
End;
End;
WriteLn('Could not find Varrok building floor color!');
Result := 0;
End;
Procedure WalkToAnvil;
Var
T, X, Y: Integer;
FloorTPA: TPointArray;
Tp: TPoint;
Begin
If(Not Loggedin)Then Exit;
X := MMCX;
Y := MMCY+165;
If(FindColorSpiralTolerance(X, Y, 195836, MMCX - 20, MMY1, MMCX + 20, MMY2, 20))Then
Begin
T := FindVarrokBuildingFloorColor;
FindColorsTolerance(FloorTPA, T, X-30, Y-30, X+30, Y+30, 0);
TP := MiddleTPA(FloorTPA);
Mouse(Tp.X-5, Tp.Y-5, 5, 5, True);
Flag;
End;
End;
Begin
SetupSRL;
WalkToAnvil;
End.
i barely tested the auto color so hopefully it will work. Most of the autocolor goes to tarajunky.
why thank you:)
I like that idea alot because i used symbols(anvil/smith tutor), and it works but they can be covered in populated worlds. Ill have to test that/make my own:D (i love autocoloring!) and if you wanna look over the "scrollSmithWindow" procedure and figure out why the hell it makes b-axes on accident, itd really help me out cause I am stumped.
oh yeah, and there is the "continue" command in SCAR?!? For some reason I always thought there wasnt, or you had to use labels and goto. God damit, I couldve saved myself alot of time, haha.
Brain
2008-02-07 18:02:36
John Smith
ran for 1 Hours, 3 Minutes and 9 Seconds
smithed 1600 steel bars
Well thats my longest runner, that was almost half of all my bars, the other runs were cut short due to randoms and what not :( seems to work great, all I used what steel plate bodies
Thanks for the great script!
nobody u kno
2008-02-09 21:02:35
What would i get more money out of selling? Full steel or just steel plate bodies?
Malevolent33
2008-02-10 18:44:24
i'd suggest to make full steel because full steel will sell way faster than just plate bodies, it would probably take a while to sell plate bodies by themselves
XRaye
2008-02-14 21:45:19
0: *** | T | 30 bars | no bars |
John Smith
ran for 4 Minutes and 5 Seconds
smithed 30 bronze bars
NextPlayer
Worked perfect. I'll try it over night when i get the chance.
Brain
2008-02-17 19:44:05
0: in | F | 247 bars | no bars |
1: nz | F | 140 bars | no bars |
2: ns | T | 272 bars | no bars |
John Smith
ran for 35 Minutes and 56 Seconds
smithed 659 bronze bars
Ran great, I'll bring you another one later, with steel and mith, :D
EDIT:
If i could just throw in the suggestion of maybe having a load limit for multiple chars? so that it switched chars after so many loads, I think that might be pretty good, but this runs great anyway, but when i have 5k bars to go through, it'd be nice to have it switch between chars….i think? lol, isnt that less noticeable? well thats what all the other scripts do :P
XRaye
2008-02-18 17:53:57
I tried it again, and this time not so good. I started it out with a hammer and full inventory of bronze bars. It went to the anvil, checked my smithing level, then went to the bank and tried to get more bronze bars out of the bank. It kept doing this so i just decided to stop it. How can i fix this?
From: Brain
0: in | F | 247 bars | no bars |
1: nz | F | 140 bars | no bars |
2: ns | T | 272 bars | no bars |
John Smith
ran for 35 Minutes and 56 Seconds
smithed 659 bronze bars
Ran great, I'll bring you another one later, with steel and mith, :D
EDIT:
If i could just throw in the suggestion of maybe having a load limit for multiple chars? so that it switched chars after so many loads, I think that might be pretty good, but this runs great anyway, but when i have 5k bars to go through, it'd be nice to have it switch between chars….i think? lol, isnt that less noticeable? well thats what all the other scripts do :P
it switches after about 20 minutes :D probably didnt have enough bars to switch because each trip is like 1-2 min.
From: xraye
I tried it again, and this time not so good. I started it out with a hammer and full inventory of bronze bars. It went to the anvil, checked my smithing level, then went to the bank and tried to get more bronze bars out of the bank. It kept doing this so i just decided to stop it. How can i fix this?
It didnt find the anvil. Was it a populated world cause it can get stuck on peoples armor, and miss the anvil.
Brain
2008-02-19 18:19:53
From: munk
it switches after about 20 minutes :D probably didnt have enough bars to switch because each trip is like 1-2 min.
Oh! :duh: lol, well now im ashamed :p anyway….I'll try to post as long of proggie as i can soon….as soon as my main smither's ban is over….
gl3nni
2008-02-21 04:20:13
I think u should upgrade to make it to iron lanterns :D good money
XRaye
2008-02-21 21:56:21
From: munk
it switches after about 20 minutes :D probably didnt have enough bars to switch because each trip is like 1-2 min.
It didnt find the anvil. Was it a populated world cause it can get stuck on peoples armor, and miss the anvil.
OK I'll try it again in a less populated world.
EDIT:
I tried it when there was only the tutor and another person. And it still couldn't find i guess.
Pixelate
2008-02-26 09:34:34
Can you add arrow tips? :/
Just tested. It did well opening bank and getting bars. And going to anvils. Then when it got to anvils….It went back to bank……
Jethr0x
2008-02-26 16:04:01
Coolio… 30-49 smithing at the moment… ill post all my proggies when im done with all my bars… I am making lantern frames :D (please if you know why dont say… dont want it being leaked)… close to 4k made :-P
Pixelate
2008-02-26 18:17:41
From: Jethr0x
Coolio… 30-49 smithing at the moment… ill post all my proggies when im done with all my bars… I am making lantern frames :D (please if you know why dont say… dont want it being leaked)… close to 4k made :-P
How do you make it choose lanterns?! Cause well…ye i know what you doing I been doing but takes too long.
HOW DO YOU MAKE IT CHOOSE LANTERN?
Harry
2008-02-26 18:19:49
I don't think munk is members, therefore it won't do lanterns probably…
Pixelate
2008-02-26 21:06:01
Well ^ Guys said he is making lanterns…
HellBoyz
2008-03-14 02:32:48
Proggy using ver 6
ran for 20 Minutes and 9 Seconds
smithed 525 steel bars
Proggy using ver 7
ran for 20 Minutes and 41 Seconds
smithed 575 steel bars
ran for 1 Hours, 1 Minutes and 53 Seconds
smithed 850 steel bars
The Mayor
2008-03-15 03:09:02
v7 doesnt seem to work. Smart opens up but then it doesnt log in…?
EDIT but version 6 is sweet
John Smith
ran for 40 Minutes and 45 Seconds
smithed 258 iron bars
NextPlayer
John Smith
ran for 48 Minutes and 1 Seconds
smithed 475 iron bars
NextPlayer
EDIT: now ver 7 is working great :D
works freaking great for me!
Good Job, I love such scripts!
:D ;)
poopers
2008-03-31 01:10:37
WoW this scrip[t is awesome!!! ty soo much for it!
John Smith
ran for 4 Hours, 28 Minutes and 44 Seconds
smithed 6035 mith bars
XRaye
2008-04-04 18:20:31
0: *** | F | 148 bars | no bars |
Is working great again =)
EDIT:
ran for 32 Minutes and 36 Seconds
smithed 497 iron bars
With this script i'm going to need way more bars than i thought…
EDIT AGAIN:
ran for 13 Minutes and 58 Seconds
smithed 206 steel bars
This time the progress report was very inaccurate. It did 500 bars and ran for about half an hour. But the best part is the script is flawless =D.
John Smith
ran for 4 Hours, 55 Minutes and 50 Seconds
smithed 2982 steel bars
I think they mightve reduced randoms for smithing because i used to get atlest 1, but this run all 3 characters smithed everybar they had in there banks without getting any randoms :D
sir tien
2008-04-07 02:08:56
From: munk
I think they mightve reduced randoms for smithing because i used to get atlest 1, but this run all 3 characters smithed everybar they had in there banks without getting any randoms :D
I think you are right munk, i haven't had a random during smelting as well been doing it for over a week now 1000 bars at a time. Login time does affect it, but hey thx RS :)
codx1
2008-04-13 07:26:02
John Smith
ran for 39 Minutes and 16 Seconds
smithed 743 iron bars
John Smith
ran for 1 Hours, 43 Minutes and 19 Seconds
smithed 1993 steel bars
Successfully executed
thx worked well
zertunami
2008-04-13 11:09:41
John Smith
ran for 48 Minutes and 7 Seconds
smithed 1000 bronze bars
Works great.
codx1
2008-04-13 13:36:13
John Smith
ran for 3 Hours, 13 Minutes and 47 Seconds
smithed 2797 mith bars
John Smith
ran for 1 Hours, 51 Minutes and 11 Seconds
smithed 1075 addy bars
John Smith
ran for 3 Hours, 24 Minutes and 3 Seconds
smithed 2134 addy bars
John Smith
ran for 3 Hours, 10 Minutes and 45 Seconds
smithed 1996 addy bars
John Smith
ran for 1 Hours, 48 Minutes and 8 Seconds
smithed 2105 addy bars
John Smith
ran for 3 Hours, 57 Minutes and 37 Seconds
smithed 3978 addy bars
Ive went in 3 days from 1 to 80 smithing with this script :p
nobody u kno
2008-04-27 14:10:24
Does anyone have one of the previous version? With version 8, i find that it clicks to smith the next bar too soon before it finishes making the previous thing, which messes up making a full set.
Alco13
2008-05-10 19:51:25
kool i just tested it but shame it does not do arrow heads :( what i need to smelt, but it works so GJ
Dr Feelgood
2008-05-16 20:37:54
Works pretty well, but i would really want to see member items in it as well.
Dr Feelgood
2008-05-16 21:01:38
Okay, i made a quickfix myself to make the script do knives as i wanted it to do.
made these changes in the smith procedure around line 800-850 or so.
replaced
if findText(x,y,smithText,chars,msx1,msy1,msx2,msy2) then
with
if finddtm(KniveDTM,x,y,5,5,315,330) then
KniveDTM could be any dtm of an item that you want to smith.
replaced
mouse(x-35,y+8,10,10,false);
with
mouse(x,y,5,5,false);
added KniveDTM as a global var at the top of the script and loaded the dtm in the SetupScrip procedure.
Should work with any item as long as you make a correct dtm for it, hope it helps someone.
EDIT: Sorry for doubleposting.
codx1
2008-05-17 12:01:30
John Smith
ran for 2 Hours, 4 Minutes and 33 Seconds
smithed 2700 addy bars
Thx for using John Smith. Post Progress Report!
Successfully executed
worked well until it got stuck
Infidel00
2008-05-19 13:39:14
So would this be useable for making Iron daggers? Or would I have to tweak this script or use the above 'KniveDTM' and replace it with DaggerDTM?
Either way I think I want to check it out tonight and see if it is functional with iron daggers and if not, maybe something I can try and adjust.
Dr Feelgood
2008-05-19 20:38:15
I belive iron daggers are working, without making any modifications. if they are not working all you would have to do is replace the DTM with a DTM for the item of your choice.
Infidel00
2008-05-20 07:25:13
John Smith
ran for 10 Minutes and 20 Seconds
smithed 275 iron bars
Awesome. Seems to work fine :D
From: codx1
John Smith
ran for 3 Hours, 13 Minutes and 47 Seconds
smithed 2797 mith bars
John Smith
ran for 1 Hours, 51 Minutes and 11 Seconds
smithed 1075 addy bars
John Smith
ran for 3 Hours, 24 Minutes and 3 Seconds
smithed 2134 addy bars
John Smith
ran for 3 Hours, 10 Minutes and 45 Seconds
smithed 1996 addy bars
John Smith
ran for 1 Hours, 48 Minutes and 8 Seconds
smithed 2105 addy bars
John Smith
ran for 3 Hours, 57 Minutes and 37 Seconds
smithed 3978 addy bars
Ive went in 3 days from 1 to 80 smithing with this script :p
WOW YOUR SERIOUS o.o?
I only got 1-31 smithing pretty quick from it ^^
gothguydante
2008-05-30 13:31:27
man i use to use this all the time back in the day… is there any reason that you didn't put arrow heads? just got 1k mith bars and wanted to make them into arrow heads…
mager guy
2008-06-11 14:35:20
I'm getting this error
Line 412: [Hint] (13066:1): Variable 'AX' never used in script C:\Documents and Settings\Ryan\Desktop\johnSmith_v8(2).scar
Line 412: [Hint] (13066:1): Variable 'AY' never used in script C:\Documents and Settings\Ryan\Desktop\johnSmith_v8(2).scar
File access error
eddie
2008-06-11 14:43:17
Lol, Nice script name:D
There's a mod Called Johnsmith84 :p
Sir R. M8gic1an
2008-06-11 14:43:19
From: mager guy
I'm getting this error
Line 412: [Hint] (13066:1): Variable 'AX' never used in script C:\Documents and Settings\Ryan\Desktop\johnSmith_v8(2).scar
Line 412: [Hint] (13066:1): Variable 'AY' never used in script C:\Documents and Settings\Ryan\Desktop\johnSmith_v8(2).scar
File access error
that's not an error.
script should run fine.
~RM
mager guy
2008-07-04 17:44:35
Munk have you stopped updating this? I love this script I didn't get the proggy because scar closed but 2500 iron plates. Some suggestions would be less detectable. Possibly more randomness and sleep functions. The walk from the anvils to the bank is slow sometimes.
NightBlade
2008-08-02 14:04:41
0: oog | F | 227 bars | toAnvil |
John Smith
ran for 12 Minutes and 33 Seconds
smithed 227 bronze bars
Thx for using John Smith. Post Progress Report!
Successfully executed
Zuassi
2008-08-06 04:43:38
Working great =) Process report later
mager guy
2008-08-16 23:02:27
It works great for gettin some plates for alching but I did get a character a black mark using this script so probably needs more randoms but otherwise great script
aka1represent
2008-08-23 07:09:47
Does it still works ?
niceman9
2008-08-24 17:32:25
Is it out dated cuz i keep getting an error in scar dvi 3.15b that just says error and it gets a hammer and just loggs out.
jkmaster
2008-08-31 12:29:37
Does it say "Error starting SMART check you world prefixes."? If it does. Search the forum for a tut of how to update ur world.ini.
kensaurus
2008-09-12 01:23:45
doesnt work for me lolz.
1 year old script -.-
rockman
2009-01-24 18:14:13
still is running well for me
0: x | F | 75 bars | no bars |
1: x | F | 250 bars | no bars |
2: x | F | 450 bars | no bars |
3: x | F | 260 bars | no bars |
John Smith
ran for 1 Hours, 14 Minutes and 29 Seconds
smithed 260 bronze bars
smithed 775 iron bars
Gavril
2009-03-05 01:14:18
Running this right now. Considering how old it is, it runs surprisingly smooth!
Of course, I added smart along with a few other options to smith the bars into (as all the ones in the script are costly ^^).
Gavril
2009-03-12 02:28:39
John Smith
ran for 5 Hours, 30 Minutes and 13 Seconds
smithed 3694 iron bars
Alligaattor
2009-08-30 15:57:55
is this outdated?
bugger0001
2009-08-30 17:35:25
Alligaattor, pleas stop gravedigging. Try to look at the dates when someone last posted into the threads you are digging. Usually scripts older than 3 months are outdated ;)
Alligaattor
2009-08-30 18:18:22
:duh:
k, now i now that too :D
thebob142
2009-08-30 19:18:49
Don't grave dig freaking noob look at the last post march 21st ffs!
Markus
2009-09-01 18:16:12
Closed.