SRL Archive - Archive

<!– BEGIN TEMPLATE: formanswers –>
ammo2006 - SRL Member Application Form
ammo2006

What is the meaning to life?
Scripting :)

Where you Referred to SRL? If yes, by whom?
no


Programming Knowledge
No, I'm totally new, but I'm finding it fun and addicting.

Other Communitys
No

How Long have You Played Runescape
3 to 4 years, not shure.

Are you affilated in anyway with Jagex LTD?
No
—————————————————–
Please write down a paragraph about Yourself.

Not sure what you meen by affiliated, but I play the game, but if you meen like working for them, no.

I'm totally new to scripting, started about a month ago. Read a bunch of TUTS, didn't really understand them at first but I kept going at it, and eventually understood them. My first ever script was a power cutter, which I Made about 3 weeks ago, and released about 1 week ago. I want to be a positive part of the community (which I think i already am). The reason my post count is so low is because, MOST of the threads I see are spammed, and I HATE replying to spammed topics. So, sorry about that.

——————————————————
Please Post a Sample of your Work. Only SCAR Scripts Accepted

Theres somthing wrong with my Anti-randoms, I had a friend test it and he said it worked for him, but with me the anti randoms make the chopping procedure take longer than it should. I cant seem to fix that.

I find that it works about 9/10 runs.
Find any errors please Post(Don't know if i can see post on my app)
or contact me on msn, it's [email]potmonkey16@hotmail.com[/email]

The instructions said to put the script like this, or I would have it in an attachment…

//////////////////////////////////////////////////////////////////////////////////////////
////                                      V1.0                                        ////
////                 Cuts Logs North East of Varrock And Banks Them                   ////
////-Start in Varrock east Bank                                                       ////
////-Fill in lines 20-39                                                              ////
//////////////////////////////////////////////////////////////////////////////////////////
////                                    Credits                                       ////
////~WT-Fakawi- For FindFastRandoms~                                                  ////
////~JAD-For His TUT and the Basic Design For Banking(Changed a Bit)~                 ////
////~Srl-Forums in general for being so cool~                                         ////
//////////////////////////////////////////////////////////////////////////////////////////

program Walker;
{.include srl/srl.scar}
{.include SRL/SRL/skill/Woodcutting.scar}

Var
  LoadsDone: Integer;

///FILL THESE IN OR IT WILL NOT WORK PROPERLY!\\\
Const
  LoadsToDo = 5;          //How many loads to do
  WaitTime = 3000;         //Wait time per tree (Milliseconds)
  Treecolor = 4028267;     //The Tree Color on mainscreen
  {MINIMAP COLORS}
  MMLadderColor = 146013;     //Ladder Color in bank, on minimap.
  MMTreeColor = 1007148;     //Brown Color of Tree ON MINIMAP!

Procedure DeclarePlayers;
begin
  HowManyPlayers := 2;
  CurrentPlayer  := 0;

     Players[0].Name :='';              //Username
     Players[0].Pass :='';             //Password
     Players[0].Nick :='';            //3-4 letters of nickname
     Players[0].Active := True;      //Do you want to use this player?

     Players[1].Name :='sga';
     Players[1].Pass :='asgf';
     Players[1].Nick :='asdg';
     Players[1].Active := True;
End;
//////////////////////////////////////////////////////////////////////////////////////////
{Don't--Touch--Unless--You--Know--Wat--Your--Doing------------------------------------}///
//////////////////////////////////////////////////////////////////////////////////////////
Procedure LoggingIn;
Begin;
  DeclarePlayers;
  SetupPlayers;
  LoginPlayer;
End;
//////////////////////////////////////////////////////////////////////////////////////////
{Start---Randoms--And--Antiban--------------------------------------------------------}///
//////////////////////////////////////////////////////////////////////////////////////////
Procedure AntiBan;
Begin
  Case random(5) of
    1:HoverSkill('Woodcutting', False);
    3:PickupMouse;
    4:AlmostLogout;
  End;
End;
//////////////////////////////////////////////////////////////////////////////////////////
function FindFastRandoms: Boolean; //WT-Fakawi
var
  i: Integer;
begin
  for i := 1 to 8 do
  begin
    case I of
      1: if FindDead then
          Result := True;
      2: if FindMod then
          Result := True;
      3: if FindMime then
          Result := True;
      4: if FindMaze then
          Result := True;
      5: if FindQuiz then
          Result := True;
      6: if FindDemon then
          Result := True;
      7: begin
          if NoGameTab then
          begin
            Result := True;
            Players[CurrentPlayer].loc := 'No GameTab';
            Logout;
            Exit;
          end;
        end;
      7: begin
          if InBlack then
          begin
            Result := True;
            Players[CurrentPlayer].loc := 'InBlack';
            Logout;
            Exit;
          end;
        end;
      8: RC;
    end;
    wait(1);
  end;
end;
//////////////////////////////////////////////////////////////////////////////////////////
Procedure Randoms;
Begin
  HighestAngle;
  FindNormalRandoms;
  FindLamp ('WoodCutting');
  if (FindFight=True) then
  begin
    MakeCompass('N');
    Wait(200 + random(300))
    RunAwayDirection('N');
    Wait(5000 + Random(1000));
    MakeCompass('S');
    RunBack;
    SetRun(False);
  end;
end;
//////////////////////////////////////////////////////////////////////////////////////////
procedure WalkThere;
begin
  SetRun(False);
  Makecompass('N');
  RadialRoadWalk(FindVarrockRoadColor, 31, 58, 60, 2, 2);
  RadialRoadWalk(FindVarrockRoadColor, 86, 108, 60, 2, 2);
  RadialRoadWalk(FindVarrockRoadColor, 68, 100, 25, -2, 2);
  RadialRoadWalk(FindVarrockRoadColor, 0, 55, 48, 2, -2);
  RadialRoadWalk(FindVarrockRoadColor, 0, 15, 32, 2, -2);
  RadialWalk( MMTreeColor , 281, 307, 59, -1, 1);
  Randoms;
  Flag;
end;
//////////////////////////////////////////////////////////////////////////////////////////
{Chop--Tree---------------------------------------------------------------------------}///
//////////////////////////////////////////////////////////////////////////////////////////
Procedure ChoppingTree;
var x, y, Tries, I: Integer;

begin;
For I := 10 to 20 do
Begin;
  If FindObj(x, y, 'Tree', TreeColor, I) then
  Else
  Begin
    Wait(50);
    Tries:= Tries + 1;
    If (Tries = 20) Then
      Writeln('Could not find color, NextPlayer.')
      NextPlayer(False);
    End;
    begin;
      Mouse(x, y, 1, 1, False);
      if ChooseOption('hop') then
      begin;
        Makecompass('N');
        HighestAngle;
        Randoms;
        AntiBan;
        FindEnt(x, y, True);
        FindBirdsNest;
        Wait(WaitTime + Random (2000));
        Exit;
      End;
    End;
  End;
End;
//////////////////////////////////////////////////////////////////////////////////////////
Procedure BankIt;
var Log, x, y: Integer;
    M: Boolean;
Begin
Log := DTMFromString('78DA63BCC7C4C0709091011530229140FA115' +
     '0CD2E026A5E02D56C23A0E62350CD16026ABE03D56C25A0E62750' +
     'CD5E026AFE00D51C26A0E63350CD71026A9E02D59C24A0E60D613' +
     '500CB5B10FA');
  If (InvFull) Then
  Begin
    MakeCompass('N');
    If OpenBankGlass('veb',False,False) Then
    Begin
      FFlag(0);
      wait(500 + random(500));
      FixBank;
      If (FindDTM(Log, x, y, 568, 209, 742, 460)) Then
      Begin
        Mouse(x, y, 3, 3, false);
        ChooseOption('All')
        M := True;
      End;
      CloseBank;
      MakeCompass('N');
      if(M)then
      Begin
        LoadsDone := LoadsDone + 1;
      End;
    End;
    Else
    Begin
      WriteLn(Players[CurrentPlayer].Name + ' Could not find bank and is lost');
      Nextplayer(False);
    End;
  End;
End;
//////////////////////////////////////////////////////////////////////////////////////////
Procedure WalkBack;
Begin
  SetRun(False);
  MakeCompass('N');
  RadialRoadWalk(FindVarrockRoadColor, 84, 105, 65, -2, -2);
  RadialRoadWalk(FindVarrockRoadColor, 210, 175, 65, -2, -2);
  RadialRoadWalk(FindVarrockRoadColor, 235, 267, 60, -2, -2);
  RadialRoadWalk(FindVarrockRoadColor, 282, 260, 60, 1, -1);
  RadialRoadWalk(MMLadderColor, 258, 135, 47, 1, -1);
  Randoms;
  Flag;
  Bankit
End;

//////////////////////////////////////////////////////////////////////////////////////////
Procedure Prog;
begin;
  ClearDebug;
  WriteLn('CURRENT PLAYER: ' +Players[CurrentPlayer].Name+ '.');
  WriteLn('Running for ' +TimeRunning);
  WriteLn('Cut: ' +IntToStr(LoadsDone)+ ' Loads!.');
end;
//////////////////////////////////////////////////////////////////////////////////////////
Begin
  SetupSrl;
  SetupWoodcutting;
  ActivateClient;
  If LoggedIn then Logout;
  LoggingIn;
  Repeat
    Begin
      WalkThere;
      Repeat
        ChoppingTree;
      Until (InvFull);
      WalkBack;
      If not LoggedIn Then NextPlayer(False);
      If (Loadsdone = LoadsToDo) Then
      Begin
        NextPlayer(True);
        Prog;
        SRLRandomsReport;
      End;
    End;
  until ((CurrentPlayer) >= HowManyPlayers)
  If((CurrentPlayer) >= HowManyPlayers) Then
  Begin
    TerminateScript;
  End;
End.

——————————————————
<!– END TEMPLATE: formanswers –>

Very short script, but from what i can see, a very well written one.
im voting yes.

    MakeCompass('N');
    Wait(200 + random(300))
    RunAwayDirection('N');

semi colons. use them. all the time.

also, i would really have loved to see some DDTMS in here to help variefy the walking, to make sure you are where you think you are.

I would have also really like to see some autocoloring.

I vote yes.

you got my yes dude, keep up your work ;)

good job.

The walking isn't reliable. If it had auto-colour I might have voted yes. Your activity isn't good enough and your excuse isn't what I'd consider valid.

Sorry, but it's a no from me.

First of all the script doesn't compile:

Line 202: [Error] (12649:1): Identifier expected in script

Secondly, in your ChoppingTree procedure you have this:

Begin;
  If FindObj(x, y, 'Tree', TreeColor, I) then
  Else
  Begin
    Wait(50);
    Tries:= Tries + 1;
    If (Tries = 20) Then
      Writeln('Could not find color, NextPlayer.')
      NextPlayer(False);
    End;

Since you don't have a begin after the if (Tries = 20) then… line, the script will switch players everytime you call the procedure. :rolleyes:

Thirdly, you haven't incorporated multiplayer well. For example in the above part of the script (and in many other procedures as well), you've told the script to switch players but haven't exited the procedure so when the next player logs in, the script continues from where the last player stopped.

Also, with your Randoms procedure, you have this:

  if (FindFight=True) then
  begin
    MakeCompass('N');
    Wait(200 + random(300))
    RunAwayDirection('N');
    Wait(5000 + Random(1000));
    MakeCompass('S');
    RunBack;
    SetRun(False);
  end;

If the script finds a fight then it will run away, wait then set the angle to south and run back. You shouldn't make the script change the minimap angle as the RunBack procedure is designed to work in the same direction as RunAwayDirection… ie keep it facing north or change the direction to south before running away.

And I really think you should make your anti ban procedure longer. ;)

I'm sorry but I'll have to vote no.

I agree with Zephy, sorry no.

Zeph said it, but it looks pretty good, so after you put some failsafes to your walking, remove all the nextplayering from the procedures so it doesnt log in with next acc in middle of cutting trees.

But, remember to reapply in a month, you definetly get in.

Your walking has no failsafes etc… so its a no from me

note to self: look through script more before voting :/

Thanks everyone for all the hints/tips O.O. I wasn't shure how to use failsafes in my walking, except for if it can't find the bank after walking back, itll log out. So walking failsafes are DDtm's?

No, can be, but not necassary, for example I do

"if(not(RadialRoadWal….)))then
begin
Logout;
Exit;
end;
"

he made a very good start, and when i look at this scrip i can see he's still learning. I think he'll be a good srl member but he got some work to do :)

the thing already have been said, I have to agree with Zeph, but it's a nice start pall, there are worse apply's very worse then yource;)
Try again next month?

until ((CurrentPlayer) >= HowManyPlayers)
  If((CurrentPlayer) >= HowManyPlayers) Then
  Begin
    TerminateScript;
  End;
End.

also Currentplayer will never equal howmanyplayers, unless your using it as a sort of until(false)…cuz currentplayer starts at 0 and howmanyplayers starts with 1 so it will never be >=, but also failsafes are needed

no

  if (FindFight=True) then
  begin

isn't FindFIght a function? so if it Finds a fight the result is true so wouldn't If (FindFIght) Then
begin?

work?
I don't know what to vote so I will hold mine for now.

What the hell? So I vote no and then Zephyr votes no, and everyone says they agree with Zeph?

From: SantaClause
What the hell? So I vote no and then Zephyr votes no, and everyone says they agree with Zeph?

Yea thats beecause Zeph is more sexy…




*Jokes**

From: Santa_Clause
The walking isn't reliable. If it had auto-colour I might have voted yes. Your activity isn't good enough and your excuse isn't what I'd consider valid.

Sorry, but it's a no from me.

Thats it… No

From: Santa_Clause
What the hell? So I vote no and then Zephyr votes no, and everyone says they agree with Zeph?

It's because Zephyr explained why he voed no, it were good arguements to say no.
That's why everybody say that they agree with Zeph because he was more detailed ;)

Fine then Santy, I agree with you so that anyone that agrees with me would also agree would you. Hows that? ;)

its a good try but what zeph says is true uhm why some1 ever voted yes with a script like that just asking not wanna be mean just asking


hermpie

uuh, thanks hermpie :) your a real confidence boost -.-

From: ZephyrsFury
Fine then Santy, I agree with you so that anyone that agrees with me would also agree would you. Hows that? ;)

I was joking :p

From: Santa_Clause
I was joking :p

So was I. :p