SRL Archive - Senior Scripts and Snippets

Powerfisher v1.7


Special Ed

2007-09-14 22:03:12

Hey I was wondering whether or not to release this to SRL Members / SSRL / or just Free SRL, Its almost finished, but I think it has a lot of advanced stuff in it so I don't know if it would be such a good idea to release it to Free Scripts since I don't really want 30,000 people running this script all the time (I don't think). Also if anyone noticed anything I could / should do differently please let me know.

P.S. The Checking to make sure your fishing isn't finished yet since I'm updating it from Net / Bait Fishing to everything. Also my BigFish Procedure isn't completely finished yet I'm just testing this one at the moment.

Also I'm reworking FindFish to get a better "picture" of where the fishing spot is, and if anyone could make a procedure that would return a BMP of the screen or a debug image of the RS Screen with the edges of the fishing spot marked in red that would be awesome.

EDIT: This version does not have the reworked FindFish v2 this only has the slightly updated color averaging system.

Bam Bam

2007-09-14 22:19:28

It looks fairly decent (though I haven't looked at it in detail yet).

Could you have combined all the GTNet, GTBait, …, into one function?

And an SSRL member of all people needing this: :p
http://www.villavu.com/forum/showthread.php?t=3293

Special Ed

2007-09-14 23:35:58

What wrong with my standards? I used the ones from Kaitneiks, I tried to replicate them as closely as I could for the scripting competition. Could you point out some mistakes I made? Please… :D

EDIT: Well there are some mistakes that I know of just from editing it quickly but could you show me what I'm doing wrong?

As for combining all the "GT" functions into one, it actually would be a lot messier and un-organized (at least the way I did it) to have them all combined into one, because thats how I had it before but people said that this way would be more efficient, and personally I think it looks better, and works better. But if you have an example of how to combine them correctly I'd be more than happy to change it if its a good idea.

Also that really didn't help me at all… lol :p

Dark_Sniper

2007-09-15 01:44:53

lol … standards. Who Needs 'em?

i mean pyro does not follow standards…


when you become SSRL+ status YOU make your own set of standards no one else can follow this is what makes you elite. :spot: (look at pyros guild miner to check his standards)

and im bein to harsh on pyro here :p

-
im still the better scripter pyro… and when is this "contest" of yours. XD

Pyro

2007-09-15 06:26:59

From: Dark_Sniper
lol … standards. Who Needs 'em?

i mean pyro does not follow standards…


when you become SSRL+ status YOU make your own set of standards no one else can follow this is what makes you elite. :spot: (look at pyros guild miner to check his standards)

and im bein to harsh on pyro here :p

-
im still the better scripter pyro… and when is this "contest" of yours. XD


Yeah actaully wtf how did i get dragged in :p. Actually ed has perfect standards? Whats wrong with them. I have good standards also. Except semicolons cause im lazy. Everything you see of mine that is out of line is because i probably copied and pasted it in. Thus the spaces are un even. But i dont care.

@ Ed wow long….Actually. Tomo (Right now being 10:26 pm) i will give this a run on my miners… Just to give them a bit of a break. I shall post feedback tomo.

Bam Bam

2007-09-15 08:57:58

From: Dark_Sniper
lol … standards. Who Needs 'em?

i mean pyro does not follow standards…


when you become SSRL+ status YOU make your own set of standards no one else can follow this is what makes you elite. :spot: (look at pyros guild miner to check his standards)

and im bein to harsh on pyro here :p

-
im still the better scripter pyro… and when is this "contest" of yours. XD


I guess I was nitpicking, sorry Special Ed :p

Basicly your main loop, one procedure, and a couple for loops is all I was talking about.

Special Ed

2007-09-15 12:42:02

@ BamBam - Oh ok, those are probably just sections where I've been editing, but thanks for noticing.

@ Pyro - Heh, the reason Its so long is because I'm trying to make is "Smart" so right now it knows where the fishing spot it always, what and how many of each piece of fishing equipment you have and where they are, as well as the colors that go along with them. Its going to fish all fish and hopefully anywhere. The only problem I'm having is how to make it check to see that your still fishing. Before I just had it check to see if it found your equipment color around the fishing spot, but if you can fish anywhere what if there is a fishing spot above (top of the screen) your character. Thanks for testing it though, but beware it doesn't have anything to check if they're fishing all the time, only to check if the fishing spot has moved.

@ Dark - Are you talking about my contest or is Pyro having a contest too? Also I think if we use proper standards more people will use them and in turn there will be a more standard way to read coding (which is the original point of standards).

Hey I'm still working on it though, but no one has answered my original question. Where should I release it? (Please don't say "Special its your script you can post it wherever"). I want to post it in SRL Members because it would give a bigger incentive for non - members to try and get into SRL Members but on the other hand I think releasing a Free Script would be nice, but only depending on what we do… Look here
I don't know where to release it I'm just trying to find the best possible spot to do it though for SRL. I honestly kind of want to release it to SSRL because it would be one of the few SSRL only scripts, :p

P.S. My progress report is *meh* but it gives a lot of info, anyone have an idea on how to spruce it up?

Dark_Sniper

2007-09-15 13:26:19

lol pyro its just been so long we never talk… i miss you XD


@ ed i guess if pyro wants to get a partner we could do that dual contest…


smartz and i vs any = us winners :p

pyro join SE contest with a partner and try smartz and i :p

Special Ed

2007-09-15 13:56:13

[offtopic]Hey I think I'm going to post that Today so Yea… But I gotta talk to SB First. [/offtopic]

Anyways… any feedback Dark?

nielsie95

2007-09-15 14:46:03

From: Dark_Sniper
lol pyro its just been so long we never talk… i miss you XD


@ ed i guess if pyro wants to get a partner we could do that dual contest…


smartz and i vs any = us winners :p

pyro join SE contest with a partner and try smartz and i :p


Don't forget that Pyro has a team of developers behind him :stirthepot:

Special Ed

2007-09-15 15:00:05

[offtopic]Uhhh… nielsie95 + Pyro for a group? Also how long do you think people will need to make groups, I think the competition is going to start on the 10th of October, seeing as how SB Competition goes until the 7th. [/offtopic]

Hey any advice with the script? *Stop hijacking threads :p* God I guess I'll just make the damn post now… :D

Pyro

2007-09-16 16:17:08

*pays nielsie to do all the work then owns everyone :P *

Special Ed

2007-09-16 23:08:51

From: Pyro
*pays nielsie to do all the work then owns everyone :P *


Lol… that works… I guess… but have you gotten a chance to test my script at all? And CAN anyone please answer me original question?

Pyro

2007-09-17 17:58:41

From: Special Ed
Lol… that works… I guess… but have you gotten a chance to test my script at all? And CAN anyone please answer me original question?


No quite yet. Soon i promise. Im just having fun mining. But soon i swear ill be netting for a bit. First question? Whether to release free? I dunno. Since its powerfishing whihc can be done everywhere. There wont be one spot that gets raped. So should be fine to release to free. Unless you dont want to share your leet code. :p

Special Ed

2007-09-17 22:43:08

IDK, but I see your point, since it can fish anywhere your right no one spot will get raped, but I don't know if the coding is really worth releasing to Free Members. I'll work on it some more and think about it, maybe if we do that whole 3 script limit thing… Who knows, I need to work on it though.